From: Patrick Roy <roypat@amazon.co.uk>
To: Fuad Tabba <tabba@google.com>, <kvm@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <linux-mm@kvack.org>
Cc: <pbonzini@redhat.com>, <chenhuacai@kernel.org>,
<mpe@ellerman.id.au>, <anup@brainfault.org>,
<paul.walmsley@sifive.com>, <palmer@dabbelt.com>,
<aou@eecs.berkeley.edu>, <seanjc@google.com>,
<viro@zeniv.linux.org.uk>, <brauner@kernel.org>,
<willy@infradead.org>, <akpm@linux-foundation.org>,
<xiaoyao.li@intel.com>, <yilun.xu@intel.com>,
<chao.p.peng@linux.intel.com>, <jarkko@kernel.org>,
<amoorthy@google.com>, <dmatlack@google.com>,
<yu.c.zhang@linux.intel.com>, <isaku.yamahata@intel.com>,
<mic@digikod.net>, <vbabka@suse.cz>, <vannapurve@google.com>,
<ackerleytng@google.com>, <mail@maciej.szmigiero.name>,
<david@redhat.com>, <michael.roth@amd.com>,
<wei.w.wang@intel.com>, <liam.merwick@oracle.com>,
<isaku.yamahata@gmail.com>, <kirill.shutemov@linux.intel.com>,
<suzuki.poulose@arm.com>, <steven.price@arm.com>,
<quic_eberman@quicinc.com>, <quic_mnalajal@quicinc.com>,
<quic_tsoni@quicinc.com>, <quic_svaddagi@quicinc.com>,
<quic_cvanscha@quicinc.com>, <quic_pderrin@quicinc.com>,
<quic_pheragu@quicinc.com>, <catalin.marinas@arm.com>,
<james.morse@arm.com>, <yuzenghui@huawei.com>,
<oliver.upton@linux.dev>, <maz@kernel.org>, <will@kernel.org>,
<qperret@google.com>, <keirf@google.com>, <shuah@kernel.org>,
<hch@infradead.org>, <jgg@nvidia.com>, <rientjes@google.com>,
<jhubbard@nvidia.com>, <fvdl@google.com>, <hughd@google.com>
Subject: Re: [RFC PATCH v2 09/10] KVM: arm64: arm64 has private memory support when config is enabled
Date: Thu, 15 Aug 2024 07:27:06 +0100 [thread overview]
Message-ID: <910085c1-c29c-4828-853c-70760b458086@amazon.co.uk> (raw)
In-Reply-To: <20240801090117.3841080-10-tabba@google.com>
Hi Fuad,
On Thu, 2024-08-01 at 10:01 +0100, Fuad Tabba wrote:
> Implement kvm_arch_has_private_mem() in arm64, making it
> dependent on the configuration option.
>
> Signed-off-by: Fuad Tabba <tabba@google.com>
> ---
> arch/arm64/include/asm/kvm_host.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h
> index 36b8e97bf49e..8f7d78ee9557 100644
> --- a/arch/arm64/include/asm/kvm_host.h
> +++ b/arch/arm64/include/asm/kvm_host.h
> @@ -1414,4 +1414,7 @@ bool kvm_arm_vcpu_stopped(struct kvm_vcpu *vcpu);
> (pa + pi + pa3) == 1; \
> })
>
> +#define kvm_arch_has_private_mem(kvm) \
> + (IS_ENABLED(CONFIG_KVM_PRIVATE_MEM) && is_protected_kvm_enabled())
> +
Would it make sense to have some ARM equivalent of
KVM_X86_SW_PROTECTED_VM here? Both for easier testing of guest_memfd on
ARM, as well as for future non-coco usecases.
> #endif /* __ARM64_KVM_HOST_H__ */
> --
> 2.46.0.rc1.232.g9752f9e123-goog
>
Best,
Patrick
next prev parent reply other threads:[~2024-08-15 6:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 9:01 [RFC PATCH v2 00/10] KVM: Restricted mapping of guest_memfd at the host and pKVM/arm64 support Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 01/10] KVM: Introduce kvm_gmem_get_pfn_locked(), which retains the folio lock Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 02/10] KVM: Add restricted support for mapping guestmem by the host Fuad Tabba
2024-08-05 17:14 ` Ackerley Tng
2024-08-05 18:08 ` Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 03/10] KVM: Implement kvm_(read|/write)_guest_page for private memory slots Fuad Tabba
2024-08-16 19:32 ` Sean Christopherson
2024-09-03 9:28 ` Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 04/10] KVM: Add KVM capability to check if guest_memfd can be mapped by the host Fuad Tabba
2024-08-05 17:19 ` Ackerley Tng
2024-08-05 18:12 ` Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 05/10] KVM: selftests: guest_memfd mmap() test when mapping is allowed Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 06/10] KVM: arm64: Skip VMA checks for slots without userspace address Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 07/10] KVM: arm64: Do not allow changes to private memory slots Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 08/10] KVM: arm64: Handle guest_memfd()-backed guest page faults Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 09/10] KVM: arm64: arm64 has private memory support when config is enabled Fuad Tabba
2024-08-15 6:27 ` Patrick Roy [this message]
2024-08-15 7:26 ` Fuad Tabba
2024-08-01 9:01 ` [RFC PATCH v2 10/10] KVM: arm64: Enable private memory kconfig for arm64 Fuad Tabba
2024-08-05 16:53 ` [RFC PATCH v2 00/10] KVM: Restricted mapping of guest_memfd at the host and pKVM/arm64 support Ackerley Tng
2024-08-05 18:13 ` Fuad Tabba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=910085c1-c29c-4828-853c-70760b458086@amazon.co.uk \
--to=roypat@amazon.co.uk \
--cc=ackerleytng@google.com \
--cc=akpm@linux-foundation.org \
--cc=amoorthy@google.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=brauner@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chao.p.peng@linux.intel.com \
--cc=chenhuacai@kernel.org \
--cc=david@redhat.com \
--cc=dmatlack@google.com \
--cc=fvdl@google.com \
--cc=hch@infradead.org \
--cc=hughd@google.com \
--cc=isaku.yamahata@gmail.com \
--cc=isaku.yamahata@intel.com \
--cc=james.morse@arm.com \
--cc=jarkko@kernel.org \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=keirf@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=liam.merwick@oracle.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mail@maciej.szmigiero.name \
--cc=maz@kernel.org \
--cc=mic@digikod.net \
--cc=michael.roth@amd.com \
--cc=mpe@ellerman.id.au \
--cc=oliver.upton@linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pbonzini@redhat.com \
--cc=qperret@google.com \
--cc=quic_cvanscha@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_mnalajal@quicinc.com \
--cc=quic_pderrin@quicinc.com \
--cc=quic_pheragu@quicinc.com \
--cc=quic_svaddagi@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rientjes@google.com \
--cc=seanjc@google.com \
--cc=shuah@kernel.org \
--cc=steven.price@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=vannapurve@google.com \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=wei.w.wang@intel.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=xiaoyao.li@intel.com \
--cc=yilun.xu@intel.com \
--cc=yu.c.zhang@linux.intel.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox