From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15E13C4345F for ; Sat, 20 Apr 2024 09:50:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75F126B0088; Sat, 20 Apr 2024 05:50:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70DF16B0089; Sat, 20 Apr 2024 05:50:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FD4A6B008A; Sat, 20 Apr 2024 05:50:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 439C66B0088 for ; Sat, 20 Apr 2024 05:50:30 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 876B0C163B for ; Sat, 20 Apr 2024 09:50:29 +0000 (UTC) X-FDA: 82029440178.06.A6FC356 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf09.hostedemail.com (Postfix) with ESMTP id 24309140014 for ; Sat, 20 Apr 2024 09:50:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713606627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WN2e57S0+y/r3C752wqBbZO6//48c4kCVEMvWlrOD5Q=; b=M5woMoGxA12sSo78+BGzlagSXqT94EtX19UF1ZAaY+NNPzcXkwvjtAq+S2eMJ4fQqLVyut mXtCGnuPSK5N89X95ZOJno+DBJfngMWIOd/GzwDieRXU9AOjpB1BIHsSk5qAafw08ovgNO 4S+S1fy/mxmbQApqknoy0c8jOUfXDk4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf09.hostedemail.com: domain of xiujianfeng@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xiujianfeng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713606627; a=rsa-sha256; cv=none; b=nW+r5JAWvKhAKjNdS7FCSt8165nuDVrMdFZI33LEGTq0YxQqzQNZTMSzDrKZi0XioHXrdy HYAWY3+0UltGng1EmnlkPuYxkP+o2oiC6CxpNCOZvUqVb2jC6BrYD1l2acSahWYkIviM4j DPSAXi8jllDIj0EJzKoKE7PtbuqQP3c= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4VM6DH626wzSjGK; Sat, 20 Apr 2024 17:49:19 +0800 (CST) Received: from dggpeml500023.china.huawei.com (unknown [7.185.36.114]) by mail.maildlp.com (Postfix) with ESMTPS id 8C833180A9C; Sat, 20 Apr 2024 17:50:22 +0800 (CST) Received: from [10.67.110.112] (10.67.110.112) by dggpeml500023.china.huawei.com (7.185.36.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sat, 20 Apr 2024 17:50:22 +0800 Message-ID: <90f306e2-dd37-4dea-d57e-7ddae22b1889@huawei.com> Date: Sat, 20 Apr 2024 17:50:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] cgroup: Introduce css_is_online() helper Content-Language: en-US From: xiujianfeng To: , , , , , , , , , , CC: , , , References: <20240420093837.1028410-1-xiujianfeng@huawei.com> In-Reply-To: <20240420093837.1028410-1-xiujianfeng@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.110.112] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500023.china.huawei.com (7.185.36.114) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 24309140014 X-Rspam-User: X-Stat-Signature: xg5577yjmkqqjuh8ax75krt4g73wyy8t X-HE-Tag: 1713606626-721451 X-HE-Meta: U2FsdGVkX18PpduBL4a9x2+zJfCd4QFKMsEi73ZT3ju5G6gdIMVE8drv9CEZx60nP6M88F8owWWOb1LstSxt3CGy5LsP/BhaAPnJdrolkQBCV2d0rG2ykwIO/+GPlNT5IviZXHEbyxRk8el3Kz/Xylu6AIr9GBe2e3yy2vKm9atgcWk05xI1eINNzjCg5KQz+QUyxV6RAvA29EtZ+pO/kdbjVvh6OmdYyIsPYovNVudddhOdLzxIu6XtB5tf1p5cnAQwwUSkeWq5jZHmXfVfibDqPBMrq888750CZzeEBSgUThrilgOZLfrGrHnN1/yGNv80zkg58shlcpFQBIkwuedv9gJ/cf78zfqqEKbsRaLpRBhY6C2HtsXZIidNekQQwfRp3HCBmt56K2udlHhRrjyyih3lqjapeHCftArfLR1iZUJ26hzyG3F+9bjMfhGhHWryBTBrhDd/qpN28+NlT9f6vC1UwyUh47uHBWp6Q9NvY04HbPN3/nF669iHOtQk9H1Xcl5Udw1xryt19+Siev/Wg5Lr9bdTKdPz9wcE129sh96P1/Uf5Gpmuax+Fgo3Ee1v901E8HgrZX2h22+XWJCKSXV0HHO4Gn5x9iIMXPfNmtC7tanb79CxIS7hdEq8Cx6fbhl/hKeK2V1psbFQKcmyDAhpkLN1OSLfuFRlQuPTe0wAarQhRKRpiFuzJbnnDQ1L9+Q1HGQ2rmoyHdPUNO1tRjKzGX38eEsWT5q2vXvMYQR3s2Bp3bBUNAHspVFLkpKXYudQXGR8cSkpJ0vcgo+YijgUtspC4PgtJS+eeEtVmsO3IBPQxdELjMNcsMjAOLQyJjhvTTJ4sVrbLyXzsAYBfu6eSRkR9xAnYDx8bnk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: sorry, ignore this one, the tag should be [PATCH -next] On 2024/4/20 17:38, Xiu Jianfeng wrote: > Introduce css_is_online() helper to test if whether the specified > css is online, avoid testing css.flags with CSS_ONLINE directly > outside of cgroup.c. > > Signed-off-by: Xiu Jianfeng > --- > fs/fs-writeback.c | 2 +- > include/linux/cgroup.h | 9 +++++++++ > include/linux/memcontrol.h | 2 +- > kernel/cgroup/cgroup-internal.h | 2 +- > mm/memcontrol.c | 2 +- > mm/page_owner.c | 2 +- > 6 files changed, 14 insertions(+), 5 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 92a5b8283528..bb84c6a2fa8e 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -916,7 +916,7 @@ void wbc_account_cgroup_owner(struct writeback_control *wbc, struct page *page, > folio = page_folio(page); > css = mem_cgroup_css_from_folio(folio); > /* dead cgroups shouldn't contribute to inode ownership arbitration */ > - if (!(css->flags & CSS_ONLINE)) > + if (!css_is_online(css)) > return; > > id = css->id; > diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h > index 2150ca60394b..e6b6f3418da8 100644 > --- a/include/linux/cgroup.h > +++ b/include/linux/cgroup.h > @@ -346,6 +346,15 @@ static inline bool css_is_dying(struct cgroup_subsys_state *css) > return !(css->flags & CSS_NO_REF) && percpu_ref_is_dying(&css->refcnt); > } > > +/* > + * css_is_online - test whether the specified css is online > + * @css: target css > + */ > +static inline bool css_is_online(struct cgroup_subsys_state *css) > +{ > + return !!(css->flags & CSS_ONLINE); > +} > + > static inline void cgroup_get(struct cgroup *cgrp) > { > css_get(&cgrp->self); > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 8f332b4ae84c..cd6b3bfd070f 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -939,7 +939,7 @@ static inline bool mem_cgroup_online(struct mem_cgroup *memcg) > { > if (mem_cgroup_disabled()) > return true; > - return !!(memcg->css.flags & CSS_ONLINE); > + return css_is_online(&memcg->css); > } > > void mem_cgroup_update_lru_size(struct lruvec *lruvec, enum lru_list lru, > diff --git a/kernel/cgroup/cgroup-internal.h b/kernel/cgroup/cgroup-internal.h > index 520b90dd97ec..feeaf172844d 100644 > --- a/kernel/cgroup/cgroup-internal.h > +++ b/kernel/cgroup/cgroup-internal.h > @@ -183,7 +183,7 @@ extern struct list_head cgroup_roots; > > static inline bool cgroup_is_dead(const struct cgroup *cgrp) > { > - return !(cgrp->self.flags & CSS_ONLINE); > + return !css_is_online(&cgrp->self); > } > > static inline bool notify_on_release(const struct cgroup *cgrp) > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7703ced535a3..e77e9e1911e6 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -405,7 +405,7 @@ ino_t page_cgroup_ino(struct page *page) > /* page_folio() is racy here, but the entire function is racy anyway */ > memcg = folio_memcg_check(page_folio(page)); > > - while (memcg && !(memcg->css.flags & CSS_ONLINE)) > + while (memcg && !css_is_online(&memcg->css)) > memcg = parent_mem_cgroup(memcg); > if (memcg) > ino = cgroup_ino(memcg->css.cgroup); > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 75c23302868a..7accb25e6fe6 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -523,7 +523,7 @@ static inline int print_page_owner_memcg(char *kbuf, size_t count, int ret, > if (!memcg) > goto out_unlock; > > - online = (memcg->css.flags & CSS_ONLINE); > + online = css_is_online(&memcg->css); > cgroup_name(memcg->css.cgroup, name, sizeof(name)); > ret += scnprintf(kbuf + ret, count - ret, > "Charged %sto %smemcg %s\n",