From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC07C678DB for ; Mon, 6 Mar 2023 02:09:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9CFD36B0072; Sun, 5 Mar 2023 21:09:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 97FFB6B0073; Sun, 5 Mar 2023 21:09:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86EC26B0074; Sun, 5 Mar 2023 21:09:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 76CC16B0072 for ; Sun, 5 Mar 2023 21:09:26 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 69214C0A31 for ; Mon, 6 Mar 2023 02:09:25 +0000 (UTC) X-FDA: 80536841490.16.88BBC39 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf04.hostedemail.com (Postfix) with ESMTP id AB18040004 for ; Mon, 6 Mar 2023 02:09:21 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678068563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cob3O07Ap6YuQk1i0OWnW/HXaprzcvOk678FtswZzq0=; b=Nskzc+G+A2b1ZBXhFTxZ849laLcQ3RYhaPSegLyZ5JWBcSDDx5GoL6XIieEgwtI8aHxFVg MV3GPyCS2vSPj0LA8+U91K/vTOEtAo8ckPDDSwga7cZt82q+qH6RjM6toepTUpjDmhGUvt WWGhCLs8pWqrBQ4iuUrS/fUZZAvnN9Q= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf04.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678068563; a=rsa-sha256; cv=none; b=rTBERPDsOd+q0i3d4HzPj2gnvDzvXsOO668CZhPUk4Kth5dBGTKqb4gi1ul+VeF635JQLf SL73s8bFkgRZCY5PigvBpJrMUvOSChXvTsU0ffa2u37hQkxGY6aCv0afFuBgNGTHFOTUQm gL28X+5ppTuIN3m+x/ML0kmJalP150A= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PVMQ00Gqxz16NjN; Mon, 6 Mar 2023 10:06:32 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 6 Mar 2023 10:09:16 +0800 Message-ID: <90d30f18-68e7-d295-7a42-c33554fd8b17@huawei.com> Date: Mon, 6 Mar 2023 10:09:16 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/2] mm/damon/paddr: fix folio_size() call after folio_put() in damon_pa_young() Content-Language: en-US To: SeongJae Park , Andrew Morton CC: , , , References: <20230304193949.296391-1-sj@kernel.org> <20230304193949.296391-2-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20230304193949.296391-2-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: AB18040004 X-Stat-Signature: r9byr7xpyekx6rp4ckxogpzheg9a1yyi X-Rspam-User: X-HE-Tag: 1678068561-444819 X-HE-Meta: U2FsdGVkX19ycpxh7AOOUevy+kRYfi5+EbYlYH95j5l3NAjW3bs9P1K24D1TU7xK3VfJPLgcitLzsUd47AHjG1IwjEBuaStdPQeeV4l3ZUpbgXcJwcJgYOpmgZvsgrGv7arFZrVHheB8kbH64ds1ovFOskRSOpXM7MMyTcwrqJTkf/eQ0C2vhKqw+saALcljRRU2bLCRi5RzFhW31ZiuTVGstWYXHQQrxwuaAtr/MazxIRuce7XCaBbImGnXk6du+9/fvUqUaBVMLoxrHf7NPO2kwWNlbMw5kY8dPQW/FZ/eyc+jSPTbk1Tb07uJv4SKLfrPz1tfjbwTObVE9cXVgAlk6Jp/QKxzb/dHjoM9DEs2xvkuzb2UyXVRIrFWSQMznFIXgQzgJuaUsyqAUJbcBU/FrI8c9Aqk11tew5tivNjm1V/wLafBaBsIy9k6XW5/bpSKToBCIHmhNDunWEMdKdkTX83VBnkPx4GMTqWyUTx9+DRCJUfLOHoq34hKqPTjuwPScy4WENXss+TujwFMuSZlu7YP1ZTe58rGzU6Z9Abm1awokTVWIKjS5iF4wByFo3gQFepPLeqSETpkq7Uu2va0pXluYmO6q5z1dqE5Uk34PT4wBdChO/+g4ff+UJ9s+ko6s/zeuPa7z09iiC9a+6spraHiUKeR9ehJYSmUz+g/F5QLBsN0P6Ex2cYXdxiHdPUp8ZIa40/CFGz5wEdN/jsm3DkJeEzFQ1zXezOt2/wFAA6wkM6OqOpLph2ahoPPsFhUR8GFHerF+P8ZJDv5x/EknV4uMiUClRR+I9elEVyRYtBt5d3+YQmzgrErmMKNjVyMm1xOi7Dlui2Myz8XG0ikjnql2OIefRH17qVrxfRSTCkNHtHLNRjybua5LuIeDxdAAahp3b7V4f871I5+Qgly1bitelDXEVHOgbeZ/75Swr4VAidkN5yN/zHinvsZBqUopDaQP2pDCQU8SJJ FN6VOcXe REMxJWYw1y6HCzCqkdUcepcA5+m+nIePvBqA6YVlQ9CLrZc9QFoENkKCssLK7t2Yq9+xqj5mxqIMlmxep7GH4iqC7wkDHNWW4e6Sa9Mpokj8B2XQqHgTqJprsxJp9i/D5WcLTma8uwJIDzghGh3GFNZvDnXCU5YoVB++UcQk59NSrYNosComxsErUfaCRjrwRU3VEYpc0r1JhpGAId5gbL5YRmZBX7XSH2FzhOckG6F8C0c7m58feHpBs4JIsX+RZ8sPro6C6bQhrmZUmV/jW5cB1ww== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/3/5 3:39, SeongJae Park wrote: > damon_pa_young() is accessing a folio via folio_size() after folio_put() > for the folio has invoked. Fix it. > Reviewed-by: Kefeng Wang > Fixes: 397b0c3a584b ("mm/damon/paddr: remove folio_sz field from damon_pa_access_chk_result") > Cc: # 6.3.x > Signed-off-by: SeongJae Park > --- > mm/damon/paddr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 3fda00a0f786..10f159b315ea 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -130,7 +130,6 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *folio_sz) > accessed = false; > else > accessed = true; > - folio_put(folio); > goto out; > } > > @@ -144,10 +143,10 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *folio_sz) > > if (need_lock) > folio_unlock(folio); > - folio_put(folio); > > out: > *folio_sz = folio_size(folio); > + folio_put(folio); > return accessed; > } >