From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B40FC4828F for ; Thu, 8 Feb 2024 23:50:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1C666B0082; Thu, 8 Feb 2024 18:50:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CCCC26B0085; Thu, 8 Feb 2024 18:50:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B94806B0088; Thu, 8 Feb 2024 18:50:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A9BE66B0082 for ; Thu, 8 Feb 2024 18:50:18 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 593FD1A0436 for ; Thu, 8 Feb 2024 23:50:18 +0000 (UTC) X-FDA: 81770282916.12.850F4DA Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf07.hostedemail.com (Postfix) with ESMTP id 687CB40006 for ; Thu, 8 Feb 2024 23:50:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="r/KHHIBf"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of brho@google.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=brho@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707436216; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bDa7AEoj173aQ+0nqq1TchEGoZbLfCamhjoFW8Psx6M=; b=XHkaXtHqRMIhHsdlf/KSF/sx9J31X/BnphckomVd2npgQXa+/ukgVbC0qvZLmZMOmv2wUm ooHLrVkTAfOvTLzcnSNAXSs+p2sM/uoqsHEnS1n8eRgvz7kGWcZ96ZM/6wwP/oZo6irbT4 oJ91kcC5YBRMxrkmSsqi8ZTMKcW7ZTA= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="r/KHHIBf"; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of brho@google.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=brho@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707436216; a=rsa-sha256; cv=none; b=LKMsiZgPEmPcIlbQ1nNZrNicxdov0V8e6nt/MCeH4yfHsJYMOz6X4i2ILuY8OWgSSsNtI6 kzsr/J5TlV3Eyv3Z2FNMA21Y2ox2iYZI4pekq1Z/knTxtqjVAktz9+gw+hXjvSoA/T3ian 4Lhx0CW8Tf6dQiLnl2XzKLBZ3mIK7co= Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-68ca3ab3358so2211116d6.2 for ; Thu, 08 Feb 2024 15:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707436215; x=1708041015; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=bDa7AEoj173aQ+0nqq1TchEGoZbLfCamhjoFW8Psx6M=; b=r/KHHIBf4kQvNkpmOyuf5jcr5cjCt6fS1LNK2373rPTWQCcY0RwCfYG/6ePHSxFh3J pQfnsBlXcoTtZbhwwErDP/C8acQJfCW/yEeZfF6nWosIYxTwxgxUFtB15CqM+KTFWVls HE31Cj8n4G/pJFkJI6QRH5mHDfzTfxFh2N2cNvIL67QQgIcAZY6TeGJJXrtE/X40ibKw lf8bhfnAVESMIZpM2JszQRmTnqYeBSlqUkUkToyj811JRjNzh21b12+72C5c19VoNIWn UObovbatr7ToREBtHg7yQNGBXIq7PJ1c5I7nL+BzFjLRpu5gc03MO7vquozKiWlJRt8m 8OQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707436215; x=1708041015; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bDa7AEoj173aQ+0nqq1TchEGoZbLfCamhjoFW8Psx6M=; b=wCq3rOjoPxV62LlfEm4rQ+w8SdfhxqNVpPf3VPGrhyK6GiXQKM1YGY4wZISgl5LVda fMv5UNI/R8swKdRrMLWoaH35oTaZmSB4fOKjFICbC4w1prdInBpYXOMDBk4zMym4Kuft 5a8WCohBRUYA2WbQ3fTjijTncr5SQ0wimrH0A6wLBK7YmIeo277baQsjlmAt4+8JRCaZ nsodHpA3hEhbbCoFtk7BFmbEEGTUV/i2Dl5I+kvyLNIA+VhirUtmOBJ0j6Kc4ih6k44Y jsR7VMNt9jfDZVwXggkZVaLF+ibHdKmrA9YDWMqMZJLlULYLLPEsbfzvKzGmaYxVuELz w+Vw== X-Gm-Message-State: AOJu0YyOGiko8Y2Z5FjHyBsWk/gBWA4dWm//cSrmMFF3VJRQnDSIeajV Gn1oUxjpYHw36MKjkUaa9gIcS0+pMmh6WEC1PhfTjtZbFv0zsSIICgy/aV7QXg== X-Google-Smtp-Source: AGHT+IHDgPxLeyIYAShMAOKyTQmwrRns3XsDqJA84Sx1OsvfowKBKc5OFJIg+veVeOK915RvEjuNmw== X-Received: by 2002:a05:6214:2aa6:b0:68c:c0bd:9bd1 with SMTP id js6-20020a0562142aa600b0068cc0bd9bd1mr817995qvb.16.1707436215507; Thu, 08 Feb 2024 15:50:15 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWkh5eROPj/tMsxYKWDUZ4JNsq6FGB5eqjbpYTO5x77d3PM0Jl3gYxtuth7kHjBOIfVoGKWDcHrt+t802Tny4IsTDJb7AGfqUo8SvuoIkVrYnZerC6lT8RLWUNgYj1K+WHkNqr/bUadyPhI/4VeZOy5YURcfmTDnGWK3i+j6sUMUpqV0IMYfIWR+zIaRRxyOXrOt+CWBgXFK8OUf765ravKIu5O5rxUi+le7gduFx2HM/kUmNDT4+Hun0Yolt8bj7aQ0S0hPd0ASN4gAIegPfVU/O+VEJIGXVswXS+MSMU= Received: from [192.168.1.31] (d-24-233-113-151.nh.cpe.atlanticbb.net. [24.233.113.151]) by smtp.gmail.com with ESMTPSA id e19-20020ad44433000000b006848cc2817esm275036qvt.33.2024.02.08.15.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Feb 2024 15:50:15 -0800 (PST) Message-ID: <90cbea27-8752-403f-9e0d-3aaa19100923@google.com> Date: Thu, 8 Feb 2024 18:50:14 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next 04/16] bpf: Introduce bpf_arena. Content-Language: en-US To: Alexei Starovoitov Cc: bpf , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Kumar Kartikeya Dwivedi , Eddy Z , Tejun Heo , Johannes Weiner , linux-mm , Kernel Team References: <20240206220441.38311-1-alexei.starovoitov@gmail.com> <20240206220441.38311-5-alexei.starovoitov@gmail.com> From: Barret Rhoden In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 687CB40006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wuep8k1575d371ety6jcmroywrsiem3p X-HE-Tag: 1707436216-727106 X-HE-Meta: U2FsdGVkX1/WuxQ6byZX0z8k8KmnI7As/X4IMB9ia7ah/vW0SjiyBruYa/de+gfMpTtSiDSg9VlVxbByFDLVo/i5nWubiez50V8FYdCrNzVJ+G1txhMalTQnNck69Nio5PQoSZoJAiyiWCbcOh0lqQBb8GA5pGp3aUK4cC2vu3nFABwpsDOjRih1/wmjDXR7YHukhBynNotzSF4i5H2NHWAAiDMta3vSfas7/bc8vOPJD9lq+SruE69AX3IciUxv403GuOnYW4ysyP2+W7vEAbT9jAnbCoriiKmgyWVCiEuKuiyuaKJkJ+4oBL7nBgTKuvSJCdnY0i0gEJW63SWMQoshj/Fu8dpTXhFqozoRhgEHDGYxPrV/dQyKkAmpWXVkYDkOAJGe0ykbVqfeyLRlzu9bJiBABbevuYDTXfNdNMgwJaWDF+okzEghcM64nkX5r9+xXPrtPm+dDS1zOcrachy1/9XtST8jbqP7LBSRNoSbt8fQTSsSqoH2Z6fy66QDcvsNXO0SZLIVnsCz6DduqqgPliXSzVk0Yip/ZiKJslGgWBAtcUpNPlwmu+VSJGcayNQJdVL1akHPUST/u2v7PPJJRz/QAmZrBpV+gr3UPuPd1u6QlsQ7n9O3Ab+1Z9uDO9ga2enpx5EGm56UYbldYvTJeCqTQCFQMR6tqp2DVjs9GIKQZV7FYWaqoHBrajaWHIHdu/14/Pqjz2VMvaOZsjalniJnvWvx5HlfMEd+u9fyZb9iukGRR/LJkE1B3ifvSbUM5g29VcKyhzRzwkx0OcO5kc/ElSTeVPVd865knns0FcOglYYeWOIfz3O768KqXCNVJuoYX6nEwpt8dwWJdfcCSqYGmm3o2r9UuUe91d7WNCWo2jqXd5nhGlEs9w0hNZkE5i7S96O/ZL37mRnwQrdT6Dv/Rga22p/vF1G8fgih84fpZWnbye7hKDujwf9Y4ebfvKOH+zu+cZRHJle VcMb6eei TCPsz7uG252vLdKe/lc90oC0tnY9gIassLl7LVuLYD6cZiP8rd7mOAScog2aF108fF8RgpaeNQipT5+QkOVtHwqe1k7YOR2nh4AN8wVnF5HmbuGWpvc/4svdSJ/nCKH/0H/CyX6nGEidy8Jw+DED520gDcKHJ6eyxQMvx9baMA6nrTVl2JWnEjgzS4VRvqcET8wuFdrnQn75z1oqlh8qVPTvpMLsmCfxXKCvzasH0qdcnK0z1MTe69UP68H69fNp2lqqOAons9Uus7Yae71mXZR3EOxLAL6x25fhZWj13iGGsb4iDuYW/CnfydmAkBjW30JVfGSzn/jUQEPohHp+qbYHE3rHYeqVmhOYPT2DmsugBN4GP75cvkcJGQDmvDQenXpjRI0N057sSv9tfugdQA7jUp8yneglrzAg2lHx1pO53jRMV6cI8hh/xCcgVA9Jdh/J7jRrH+R4SQNq89VOthHULlLz8pUH/XCyGy9z4jzBVNi4Lnfj5jutdntqYfa2gamT3Dtxz/DsGJ/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000364, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/8/24 18:36, Alexei Starovoitov wrote: > I'm inclined to tackle wrap32 issue differently and simply > disallow [user_vm_start, user_vm_end] combination > where lower 32-bit can wrap. > > In other words it would mean that mmap() of len=4Gb will be > aligned to 4Gb, > while mmap() of len=1M will be offsetted in such a way > that both addr and add+1M have the same upper 32-bit. > (It's not the same as 1M aligned). > > With that I will remove vmap_pages_range_wrap32() and > do single normal vmap_pages_range() without extra tricks. > > wdyt? SGTM. knowing that you can't wrap the lower 32 removes a lot of headaches. and the restriction of aligning a 4GB mapping to 4GB boundary is pretty sane. TBH doing it elsewhere is just asking for heartache. =) barret