From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03A7CC19F32 for ; Fri, 7 Mar 2025 08:13:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D70A280008; Fri, 7 Mar 2025 03:13:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 186D7280007; Fri, 7 Mar 2025 03:13:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00063280008; Fri, 7 Mar 2025 03:13:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D7907280007 for ; Fri, 7 Mar 2025 03:13:30 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9C538B69BA for ; Fri, 7 Mar 2025 08:13:32 +0000 (UTC) X-FDA: 83194040664.23.1AD7C52 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 0F1F1140011 for ; Fri, 7 Mar 2025 08:13:29 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jBYQKk87; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741335210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QO4aHW/EIqvVozmspxL85e+uicH6KLzd8n0qPmV6aaE=; b=tGQJi6z753ZUfNU8oT9LB8zrYeZ9PoRuWLkfjqc14iDFWnuQBn0S2vzWDGl97hEb4uLOMM 5SEVJfAP/MvDfY89OUb5ncpVEH4REg2ujb7nQzPZlGgwbxpm3IMh1blmpPJsidu1mHQaTK yYfcFsufF67Abm8g6kWRkTVt1xTPdmQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=jBYQKk87; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741335210; a=rsa-sha256; cv=none; b=ir5XL+Ak9r5qX5cbnCrk++8PknHzJ49rvvjiwbdUQZLRRs/FqIPoSv02Ec6fycjsESYvqr QW6ZWn+gT5knB1+pQuahkamOMQwQH3TVgeXemqvpLfH0BsJtwHGoQ8i5CDvFtVuc1L+paS WJDew2KVoDiNndyeKmfUaQjBZoctC6I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741335209; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=QO4aHW/EIqvVozmspxL85e+uicH6KLzd8n0qPmV6aaE=; b=jBYQKk8746Gor/ygTadJMH6m/wYsvnQbIWwzhjT07g/oWrsQw8mplIq2JAiORmQz+wQjVL z640vA287G8Jhk4ft6hWrlS96VqxzkasdH28BAOrZuRzX3C1AdL8jMs1JnU12VWEtW52DV sQmIksNmOmApXRZickW8vAGrATDCrTw= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-472-pwJn9HMVNq2Tu9qBcq8Msg-1; Fri, 07 Mar 2025 03:13:28 -0500 X-MC-Unique: pwJn9HMVNq2Tu9qBcq8Msg-1 X-Mimecast-MFC-AGG-ID: pwJn9HMVNq2Tu9qBcq8Msg_1741335207 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3912d9848a7so649485f8f.0 for ; Fri, 07 Mar 2025 00:13:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741335207; x=1741940007; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=QO4aHW/EIqvVozmspxL85e+uicH6KLzd8n0qPmV6aaE=; b=CxWLNpvABBdilYv4jr4UysbDFtQFZ9xQO05PyRsrn7zcp4tBZIFOWo6QAi9M3KxLME qja9WmxmwpJlcHqN2PmDVUt9ZTcSYkrBnu16zSH6FPVNM7wMah/lbLxw5zATP69lO4Od zbvvJVK2N96/ut8EA1uoUxPmcc1CvHKQF+tcGDAlj//qSTfyNGY6+4w1suzokfA5nakg ONleABWTNVrtJFkrn63dCgk+SRa8iAxmb1OeM5rlZG8NDcVROKmBx+6DJMpo26H/9+Gg hJGWb+envFhhC5y7HvFjLicTo7uhMvZyDQomqeanjctBsxnJ4ipWv6txEMGHNAV9TtkN rmOA== X-Forwarded-Encrypted: i=1; AJvYcCX0X4EJ/2XRE1mmcDT3TJ+CZ99kPdmpzhvZ3WvsuuC6LjS9vC/nU9gH/d1pEnzs1Fvvl4XxE0crNw==@kvack.org X-Gm-Message-State: AOJu0Yzd21Rpl/GFs5ZyAq7aAe5ZmSLVRQF559ALs3pftJJPvaFlulEv noD/3PA9F5w8q5MEUZLNN/Ux2D3EQxagR5YpE14lnCU27x/OylsV96QTguhKOGcNrQe1/bcej1q oHDrPKrtnbjm2z1gx9dkg8e/2lFHGsDvFthbMTzlEy3w2oJGw X-Gm-Gg: ASbGnctyMD51oxpm6xQ8bnbaK6uPI+XKuinfhK5dWxcozzdrCcP7b21oYBVaEp8ZhW0 bl00XzopXsYmhHMFuCofNB3b7TFqOteXUAQ22gUri99Rg4oSlFTFrxWbtvt4fR67+kf8lQo80FE tflArIRUiY5TY9nax4w2LbBZYgaMv1KF3401weNDM1nhHLGkZppE+yRQ7AOrY1hHFS5fQbgBgOv 6E1m/JqdKxIwRuSz7bmYs+zxfKhG2D1v9plbnH5u9FDcacz69zIWKWx9Byu3xJjWKNpfZeGVBn2 NSQT0XjlLYFiStN4AdlIE/G7z3FLtzuonYjBwB2d4iiHhdoswRCk/NtR7fHo/d3e2K3B631nDos UsHg3dyjtInBRLo26H3a2TNVwELlFCJrA9emMTw== X-Received: by 2002:a05:6000:144b:b0:38d:d166:d44 with SMTP id ffacd0b85a97d-3912985366amr5097587f8f.23.1741335207037; Fri, 07 Mar 2025 00:13:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbLoB9vEQuEUrUCb7OUKaNWOamOIwJBx/fzl0cgU09bEmozCG1yHUEdYjg+atR68mZx7vIeA== X-Received: by 2002:a05:6000:144b:b0:38d:d166:d44 with SMTP id ffacd0b85a97d-3912985366amr5097570f8f.23.1741335206665; Fri, 07 Mar 2025 00:13:26 -0800 (PST) Received: from ?IPV6:2003:cb:c721:7400:ab0b:9ceb:d2:6a17? (p200300cbc7217400ab0b9ceb00d26a17.dip0.t-ipconnect.de. [2003:cb:c721:7400:ab0b:9ceb:d2:6a17]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43bdd94913fsm42822315e9.37.2025.03.07.00.13.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Mar 2025 00:13:26 -0800 (PST) Message-ID: <90c8183e-d5bb-4460-8c93-ab9bbe977d66@redhat.com> Date: Fri, 7 Mar 2025 09:13:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] mm: page_owner: use new iteration API To: Luiz Capitulino , linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com, pasha.tatashin@soleen.com Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, muchun.song@linux.dev References: <93c80b040960fa2ebab4a9729073f77a30649862.1741301089.git.luizcap@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <93c80b040960fa2ebab4a9729073f77a30649862.1741301089.git.luizcap@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: x0D_YFKCcz9hsMzlBrkO_w-41rajtwvupRRLTtcDSAw_1741335207 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: dwfe4e3crj571tdcyq919n6oescwhfnw X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 0F1F1140011 X-Rspam-User: X-HE-Tag: 1741335209-44737 X-HE-Meta: U2FsdGVkX1+faSyu4/2Eob8THVmfgZ7IztGQ35BI9e0gy2leYFSIFcybFwGjr6uVQdPiC1B6Q/jOh0XU72xP1JrSdpAdW7/biQPBQfKUlmLx+NAMYsoOj1lSYWYz4yXrhR+aB1etjm6PcGGymmObx3oWZjMQLwd+R5vstseNobn8xO3Zy2R83jIe0TcfmughTSy9b2DCiWMQ2cKkFS2lOkhQYw23i0NCPwYYOQ4S8q7VUElfft1HYDobAIFud7EicWmsSRImv4uvxaga1k3m660FuWHKDBUFywDI5AfXyR7oMEwtcEqAj9DncunCStS9g2Y1vABjsdUqAsGsIxmkcbUEcDn7/SGQKNSrNg6bvrf1BATy3ff4QpFEOo8wInr2W4EN46Txqq1I5GOWaoubipKLTCatHStIHvOhY1vQ8H2Kg+hKE000tL7/6BGy1VlND71tAdbsPQSY8quKrgcvMRphXZlVSUlgjCNsrsSFXVwiVFw5Bv4Hhn7tXlX3Uedm5uBVjvm5Ce9YJdkt2BfkhAthuby8RqErwq2lrPEcKEM4+bWlR1nbb9lNkEYbIyPLd5DYRsW2zu8AgzhFJrkGH+aQkoQuW/IORucawK2BMGwe63cNPU1kBptGvzRGZzBGUhNiXkOixmxzwidTuZf4hlTX0s97HWPTlCbOSI5bHiO5C6n7q23IYoiCdmKfRcFc4XxXXVxw6xm1Ptj5gm9Yss/87G851QImq/jIfzbzOtJeZWSyHeSbZHFfDb0e70oxjXa2vDUqdkw5wU+Ah3Q/3IC7t0Djz2gQ8MMzWn3oH1hi6pmkD/gx8m14fOwVjwfYu4A/Lqk8llsjaX2qjhZ4Q/Ka9WGYrOS6RYJXMVEPSILHQrEAjvm/y24zH+0BYWRsI1Fu3TNsCbQqSuS7IAz7rtpTHgk1dMa5bVzcdvKEPWb57+54SWi8BjFYDmtMhuQ5C4XWETf3oZlSOYWUpf3 8pEW5bQC LbUKUitQeTG/Bo9Wc6yG+p190de/kG9qNbQZ1YbAUmmh6ZRDXyeSM1A8iD4V/H4CAE/i3/zCPRsWk0dEMUzlg/yuukiqJysQCaxlzZoEeoKFdqBwWeEV7iFplFZpBOer7qs49U8e/3e0AQKOULZPuE/OZ5dfGOQZ77w2qr8lg3FGeXenGFwHZ1wNt+An3DE2ovnIO3BAHrFPxjCrJ/iQ0NPe2FrRYjCSniVw9ODZWtL/8RRqBTwSKwGF9CfUg6L9VgAp0427FTALptygK0qiNMBKcHGmF8y32JPD3CD5V3/PmQa43WNaUg042yTLMH+oIuiC6tG9BF/G4HHHs/ga3HY/W2+OQu8pO6O+qK5ZJ4ABq2lRXTvVg9qG/D3H7mM5ms4ep/+6tk3LyXWWaqCzijHDOXq1Gw6wE2qcuKeSSaZ2QJ19DlK1CSHKS1Qv5OfbvcwXRl/t+NGISrBtvitvIGHXT1DuBq5KN5ST9Azne8R0VkbewR1kuVqdfwrs1odxtbxZX X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.03.25 23:44, Luiz Capitulino wrote: > The page_ext_next() function assumes that page extension objects for a > page order allocation always reside in the same memory section, which > may not be true and could lead to crashes. Use the new page_ext > iteration API instead. > > Fixes: cf54f310d0d3 ("mm/hugetlb: use __GFP_COMP for gigantic folios") > Signed-off-by: Luiz Capitulino > --- > mm/page_owner.c | 84 +++++++++++++++++++++++-------------------------- > 1 file changed, 39 insertions(+), 45 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 2d6360eaccbb6..65adc66582d82 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -229,17 +229,19 @@ static void dec_stack_record_count(depot_stack_handle_t handle, > handle); > } > > -static inline void __update_page_owner_handle(struct page_ext *page_ext, > +static inline void __update_page_owner_handle(struct page *page, > depot_stack_handle_t handle, > unsigned short order, > gfp_t gfp_mask, > short last_migrate_reason, u64 ts_nsec, > pid_t pid, pid_t tgid, char *comm) > { > - int i; > + struct page_ext_iter iter; > + struct page_ext *page_ext; > struct page_owner *page_owner; > > - for (i = 0; i < (1 << order); i++) { > + rcu_read_lock(); > + for_each_page_ext(page, 1 << order, page_ext, iter) { I realize that we could get rid of all the temporary page_ext variables and simply operate on iter.page_ext. If that makes sense, it could be done as a cleanup on top later. Thanks Luiz! Acked-by: David Hildenbrand -- Cheers, David / dhildenb