From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B988ACF9C6B for ; Tue, 24 Sep 2024 14:32:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B8956B00A3; Tue, 24 Sep 2024 10:32:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 369446B00A4; Tue, 24 Sep 2024 10:32:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 230D56B00A6; Tue, 24 Sep 2024 10:32:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 04F246B00A3 for ; Tue, 24 Sep 2024 10:32:29 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id AE25A1C710F for ; Tue, 24 Sep 2024 14:32:29 +0000 (UTC) X-FDA: 82599872418.22.D491430 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP id A47C0A000E for ; Tue, 24 Sep 2024 14:32:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727188260; a=rsa-sha256; cv=none; b=lwZ0um8AjQcE2jWjKaUADecx9vUN/DS8XOczX/oiiExH3Cp657yA84HGc4yTI/rT2DPPrl vXCYv9Ak1q6qS/TP8pgjqH6zkxoDF5YyzB+beLKUz20bbRVQY8gF9EVnaMWZ/or9vAN4m+ W3VznWgqNjq1AygXmvKzntslFvwDMUA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf25.hostedemail.com: domain of vincenzo.frascino@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=vincenzo.frascino@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727188260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kC2Jw7b3Mfp2zn3SUxCeDqvtNPDd5v1OU7RIA3iVK9E=; b=nOHvpDk5oKZgd2yVa+eUqFd+N4yM3fcaLKBBLuy1aumF7/AvfQjYr6mntjljt7i8+LS0VA X7BY6+xrATFIG7dJs60+7P6b5zCPdZ61/BsfimLxOedYCCxwBkSSD5HRcvVOJFQYnJHJrF 8ly4YptJEIoSRpZ6uFq1eSI5533jQnw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3FD93DA7; Tue, 24 Sep 2024 07:32:56 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1E4BC3F528; Tue, 24 Sep 2024 07:32:23 -0700 (PDT) Message-ID: <90be383e-8177-45fb-9fe1-bf8adfcf5088@arm.com> Date: Tue, 24 Sep 2024 15:32:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/8] vdso: Introduce vdso/page.h To: Christophe Leroy , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux-Arch , "linux-mm@kvack.org" Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Theodore Ts'o , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20240923141943.133551-1-vincenzo.frascino@arm.com> <20240923141943.133551-5-vincenzo.frascino@arm.com> <645e5f3f-debf-4f68-ad75-4fb749b07a5b@arm.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A47C0A000E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ayj8c4mqsokwq6tgsaodbg6xk7jenj9e X-HE-Tag: 1727188347-121268 X-HE-Meta: U2FsdGVkX1/QWxuGXOjB+GuIIkFJaOAASwPmkLVkHxSDiETa6INNHYNhavt4oU7V140i4+66+cwp9R+gRzJgjjinoAwfW1bfp3b+iX7Oz0Bj8RMo5MUp8IPcDI+baqa/Dlz/mLCxiQGs93wazdMlBwqjD0HysjRX+INvlfqvFZy5RbZgAKWznEFjZxxF3aPQLgG6k5BQWI+DaxoUsRa7wWP44gpoXlAXweSvmJk46CBEYqNbX4T2ePmAhhs53LPYH3cotTvMb2R01ovbUicohwqg2BBivMglf8oQN6PzxDVww+BfQrjYkvwyiY6tWbWxUyeQvjbfP5xqI9fyczXUjELRBDr+fzIlC+PMrA/rkHB8xzJIAUUmDpauQbKYPelbqUcUpE9fFq7mJ6WFwKkYpNUXL1aRKVcMbw7pTooOegR+2pBx8thy/MgOEuQ9exzKwLHNRCDUknPcq2UYwqpPYOA/yYl/F0dD/+ee+G5y4dCasAKJvbzc8+SulaFcF8SDEU3WwPFNdJBhVkHjLAcOTWFZ/LiYYTXTkoK6fdsp5hzSK3wwZqJsg5vQQronin29tatchrNn7HndgPKxMePRUh8IF44yiNjj7NeXNDaniGbodkRHwGnKigQiCHUaSYTjfLYCIJLysBowJxglnGXOKIq8QFfnUrCKPpL7DtkR2YsOacSQJRnjIPxgtrQifNEVsG4MdxZwLkXxmApMuN3ANoQThSj/kmF854uw1JhZb1xrCGxoKA7oeSNpHDCzV4KbKR9TQup2fJUjbmnK1jP3cxMJaNBo7WaYauktGSKneyuCw3PDe7htKt9mUoNkcH+y/GQSNCavpNQjXQ8mYsyI9HXb54f5hAD4nrhlc8Q6lcHbOwrtb0hwYv91KuRdBLz7ALVXeEKMibaZlm1f6nHUn4l+ZA3M9COAiNmk3yoI6TkUNVi909h9GdjCFPGK/Gav61KuJK1922ciArhWOrm nXqOhuYb H7pNiSjjWQ3b3vsw47kbJI/9iDq9ugzRlhB6STvzDW5R7NQg3y1QYXQS+jYN6OOfc4oP5pOXx9kh1oE95DNkq0xsvHZi4dXIovLzoPIGzOJTH6WnHmnWJ+KkVLocNEXlf/2HBS3lQ9ZFGRwq1ZwvnbWlTVUo3dcx7DqeJrMc9QjBioLMQtD+JeWiFpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/09/2024 15:28, Christophe Leroy wrote: > 'fault' is an 'u32' and 'mask' should be agnostic so the format should > be %x not %lx I think: > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c > b/drivers/gpu/drm/i915/gt/intel_gt.c > index a6c69a706fd7..352ef5e1c615 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt.c > @@ -308,7 +308,7 @@ static void gen6_check_faults(struct intel_gt *gt) > fault = GEN6_RING_FAULT_REG_READ(engine); > if (fault & RING_FAULT_VALID) { > gt_dbg(gt, "Unexpected fault\n" > - "\tAddr: 0x%08lx\n" > + "\tAddr: 0x%08x\n" > "\tAddress space: %s\n" > "\tSource ID: %d\n" > "\tType: %d\n", Good catch Christoph. It makes sense, I did not notice the "l". I will add it to my series. -- Regards, Vincenzo