From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
Arnd Bergmann <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Theodore Ts'o <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v2 4/8] vdso: Introduce vdso/page.h
Date: Tue, 24 Sep 2024 15:32:22 +0100 [thread overview]
Message-ID: <90be383e-8177-45fb-9fe1-bf8adfcf5088@arm.com> (raw)
In-Reply-To: <bfd5cc30-f5fd-465a-b2d8-f0b35c018cda@csgroup.eu>
On 24/09/2024 15:28, Christophe Leroy wrote:
> 'fault' is an 'u32' and 'mask' should be agnostic so the format should
> be %x not %lx I think:
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c
> b/drivers/gpu/drm/i915/gt/intel_gt.c
> index a6c69a706fd7..352ef5e1c615 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -308,7 +308,7 @@ static void gen6_check_faults(struct intel_gt *gt)
> fault = GEN6_RING_FAULT_REG_READ(engine);
> if (fault & RING_FAULT_VALID) {
> gt_dbg(gt, "Unexpected fault\n"
> - "\tAddr: 0x%08lx\n"
> + "\tAddr: 0x%08x\n"
> "\tAddress space: %s\n"
> "\tSource ID: %d\n"
> "\tType: %d\n",
Good catch Christoph. It makes sense, I did not notice the "l". I will add it to
my series.
--
Regards,
Vincenzo
next prev parent reply other threads:[~2024-09-24 14:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 14:19 [PATCH v2 0/8] vdso: Use only headers from the vdso/ namespace Vincenzo Frascino
2024-09-23 14:19 ` [PATCH v2 1/8] x86: vdso: Introduce asm/vdso/mman.h Vincenzo Frascino
2024-09-23 23:05 ` Jason A. Donenfeld
2024-09-24 15:10 ` Vincenzo Frascino
2024-09-25 6:51 ` Christophe Leroy
2024-09-25 21:23 ` Arnd Bergmann
2024-09-26 5:51 ` Christophe Leroy
2024-09-26 6:20 ` Arnd Bergmann
2024-09-27 13:09 ` Vincenzo Frascino
2024-09-23 14:19 ` [PATCH v2 2/8] arm64: " Vincenzo Frascino
2024-09-25 6:52 ` Christophe Leroy
2024-09-23 14:19 ` [PATCH v2 3/8] vdso: Introduce vdso/mman.h Vincenzo Frascino
2024-09-25 6:54 ` Christophe Leroy
2024-09-23 14:19 ` [PATCH v2 4/8] vdso: Introduce vdso/page.h Vincenzo Frascino
2024-09-23 16:54 ` Arnd Bergmann
2024-09-24 14:10 ` Vincenzo Frascino
2024-09-24 14:28 ` Christophe Leroy
2024-09-24 14:32 ` Vincenzo Frascino [this message]
2024-09-25 6:56 ` Christophe Leroy
2024-09-23 14:19 ` [PATCH v2 5/8] x86: vdso: Modify asm/vdso/getrandom.h to include datapage Vincenzo Frascino
2024-09-25 6:57 ` Christophe Leroy
2024-09-23 14:19 ` [PATCH v2 6/8] vdso: Modify vdso/getrandom.h to include the asm header Vincenzo Frascino
2024-09-25 6:58 ` Christophe Leroy
2024-09-23 14:19 ` [PATCH v2 7/8] vdso: Introduce uapi/vdso/random.h Vincenzo Frascino
2024-09-23 23:09 ` Jason A. Donenfeld
2024-09-24 15:14 ` Vincenzo Frascino
2024-09-25 7:00 ` Christophe Leroy
2024-09-23 14:19 ` [PATCH v2 8/8] vdso: Modify getrandom to include the correct namespace Vincenzo Frascino
2024-09-23 23:11 ` Jason A. Donenfeld
2024-09-25 7:09 ` Christophe Leroy
2024-09-25 6:39 ` [PATCH v2 0/8] vdso: Use only headers from the vdso/ namespace Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90be383e-8177-45fb-9fe1-bf8adfcf5088@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox