From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8147C7EE29 for ; Fri, 9 Jun 2023 14:34:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFF246B0072; Fri, 9 Jun 2023 10:34:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CAF6A6B0074; Fri, 9 Jun 2023 10:34:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B50068E0002; Fri, 9 Jun 2023 10:34:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A581B6B0072 for ; Fri, 9 Jun 2023 10:34:02 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 68DC312028D for ; Fri, 9 Jun 2023 14:34:02 +0000 (UTC) X-FDA: 80883453924.04.736F519 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf03.hostedemail.com (Postfix) with ESMTP id AD58520022 for ; Fri, 9 Jun 2023 14:33:58 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0x4PDx2W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iVjQ83RC; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686321239; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TQ5/N7tIpnehH7MNg1vCRZG6KJhrS3cnWdoR3DT75S0=; b=B2cAyR5QLDPIx3o9t4IAoCbynXirsmDniEgBh0g4yuN0mtqtM93StA8DXsyQsGtNin93vv FZ0ztJBNfLzd0IMyXXDLvmWqcvazB2NMTCOQ20q/xfi+fb+JCOu51L04gpSXOZkAitNtiK bQjLw9eSwEyDC2J60PQSBoyLf6+XAMA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686321239; a=rsa-sha256; cv=none; b=09cH7a16VzXPgQ0OPUuELMlQGNYzzMnrK7ABDm2McadU1r4TltzeN5dxi/JX8/6Eod4qL2 5K5by3D8Qf6WxqOSRN6IivgoHUufEpNsyEs7fTqRhkatWOiW679gUMn8VoPCXn/KngGTxR G7E24aQeDlGNiPncUVg6KaaTTu73BoY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0x4PDx2W; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iVjQ83RC; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1849B21A1C; Fri, 9 Jun 2023 14:33:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1686321237; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TQ5/N7tIpnehH7MNg1vCRZG6KJhrS3cnWdoR3DT75S0=; b=0x4PDx2WgWEEMtCNo0TUQk8emvr+6TCjcUkl/iYzM5SaUCuAW6CcpwnWUbxjChnbeINtfU DMIuNCS3djQAsKqf3O8xe/QKzPejV7Cd5G9uba4tgX7+ho3EQMwkwhKIvYVTw3Axmfry1T 7uMFJPrXsLnYamEahXpT4Xa75B0b20Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1686321237; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TQ5/N7tIpnehH7MNg1vCRZG6KJhrS3cnWdoR3DT75S0=; b=iVjQ83RC5Vfu9jY7+B+Iscc8r0IIsumksRx96GBNACPaLUsTuQtjmwglOEHowGwLN8/HFc 6exgN8sJteR9X8BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9D65013A47; Fri, 9 Jun 2023 14:33:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id liS3JFQ4g2QVcAAAMHmgww (envelope-from ); Fri, 09 Jun 2023 14:33:56 +0000 Message-ID: <90b845e6-c121-2e10-6750-c170b1fa8c7f@suse.cz> Date: Fri, 9 Jun 2023 16:33:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH v6 04/17] mm/slab: Limit kmalloc() minimum alignment to dma_get_cache_alignment() Content-Language: en-US To: Catalin Marinas , Linus Torvalds , Christoph Hellwig , Robin Murphy Cc: Arnd Bergmann , Greg Kroah-Hartman , Will Deacon , Marc Zyngier , Andrew Morton , Herbert Xu , Ard Biesheuvel , Isaac Manjarres , Saravana Kannan , Alasdair Kergon , Daniel Vetter , Joerg Roedel , Mark Brown , Mike Snitzer , "Rafael J. Wysocki" , Jonathan Cameron , linux-mm@kvack.org, iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Christoph Lameter , David Rientjes , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> References: <20230531154836.1366225-1-catalin.marinas@arm.com> <20230531154836.1366225-5-catalin.marinas@arm.com> From: Vlastimil Babka In-Reply-To: <20230531154836.1366225-5-catalin.marinas@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: zp745hdqocdn8xr64zj8u5x9apkhnwun X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AD58520022 X-Rspam-User: X-HE-Tag: 1686321238-23462 X-HE-Meta: U2FsdGVkX184MvC6LmZm2xwH5TyEox2CSN+9lmFiVVhmEfHf5QJ2307m0fJTeCkqE4ZFz2EMAhE6VUvQdnrolZaFGhH3Tfpf0/aWAoR98LawfvOkokpi7VES2BB3j67h2iJla2k4q68ZPZjmQTHVCV53el3Ih3zZg/I6pNhBl8ueSF1jg2dCnox1EPyoOidhC8XRvt8oHTWT8A4INPhTSLe8Um4mm4geNKOorJq2mCPCNpqQHtqroWIjRT4KfM1CNqxaZnwEine/z5ktkPuy2yJhNPbyhfF0jNd+zqEmuw74SPOpQFA4R2uO2E1BojuuEYxhp4ZDCO69EGA8DJRUCgNied9X8SzIsZMKdFoq9mNRHdV5tnmrDQEPEnQUCg4SbVYTHW55OqZS4QXCir7r98s3OEMn+wWpvOMvjQjWIbHY48B1xoVFWEYSfIfhvsj7W9Od49SHMQA+o8a+ahC9ifAgn482z6czCLQ459/d8H1Eaq9YXuHeaYgqXa37EyJWv1iIcRxUMWqOmCEhdM88DdcVrs7MU/3duPvJNJzHOa4VspfXiNozSzVWXfH5tmJPY2HDL9OyhDth5kAQG2xAEelLqeBPSurJQMq7qezwGJZe5svLw1asbkTNYhatZdBbDU9KHBXCxp1sUxcjWb+uSV+BFSYWkkLsBZBw/KDhMWjwWehGGqMuRyBqKbZDjijruZVUdFLSkx48Y5nOWz8gd8Jf7U6jWc2DeazfRtqZDrjgh+7Ia1rMpm5ySqwsJgrYFtmq6YuJxXOMaas5OKAVFXOV71OI1E6zJkDhJbPe6PyEUyCEW3mLIejxHxl7fVDF1HEDXKAWYWUOtCaYcJ6cfqiIeIsgmBS9b8IQasBBh4qjzoniGn/4VQR2rqq5s8VroCfP6QG/KsCxTUmsoBlLIYlKoNguSy2ApISs9u3lfW9A06EPWzBfTMrImSQdrlph2HLGUIJwefk6sRBYgMf h9qxWNuk bKpoPWKRGaEMlQvpXFNcRg9GoWSPbixw7XQxMopw0uM067W64e1qK/y2+ChBNM/DZBXhfYmM2cdd7rAL6blQyfTDarkbruAQTtpLOw66C/6fvU/3JMW8wLyKbQTMhXAYchofyIfDFF994maJb7Wp+Dbt5w5WoIrOeA9y3mM0iez7yxJIQAAn5vsFYA36Yt/gohRrvP7Y9/jX8I1W777uD29gZHCIBriWhBPgnZTuhOtXAFKOQNx6IIJ4rbHnGwFAxGGUvmAHpGuF853RleO62ePd20kkOkE8D3+89VgZLBHRNiDzKUDfoI/1fSgkBdNhcoIs8zAuOlopjmYRm5UWNI/qme8JinOTMHSiWUPD4ThLbZRq1fzKu/sSKjXwqtgVDTifIku2K283CeTpSR9m6Qp8u7FDanDI5lvnmbUb3qgYpJZYppp9RXrCWFQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/31/23 17:48, Catalin Marinas wrote: > Do not create kmalloc() caches which are not aligned to > dma_get_cache_alignment(). There is no functional change since for > current architectures defining ARCH_DMA_MINALIGN, ARCH_KMALLOC_MINALIGN > equals ARCH_DMA_MINALIGN (and dma_get_cache_alignment()). On > architectures without a specific ARCH_DMA_MINALIGN, > dma_get_cache_alignment() is 1, so no change to the kmalloc() caches. > > If an architecture selects ARCH_HAS_DMA_CACHE_LINE_SIZE (introduced > previously), the kmalloc() caches will be aligned to a cache line size. It this part leftover from a previous version? > Signed-off-by: Catalin Marinas > Cc: Andrew Morton > Cc: Christoph Hellwig > Cc: Robin Murphy Reviewed-by: Vlastimil Babka > --- > mm/slab_common.c | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 7f069159aee2..7c6475847fdf 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -862,9 +863,18 @@ void __init setup_kmalloc_cache_index_table(void) > } > } > > +static unsigned int __kmalloc_minalign(void) > +{ > + return dma_get_cache_alignment(); > +} > + > void __init > new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t flags) > { > + unsigned int minalign = __kmalloc_minalign(); > + unsigned int aligned_size = kmalloc_info[idx].size; > + int aligned_idx = idx; > + > if ((KMALLOC_RECLAIM != KMALLOC_NORMAL) && (type == KMALLOC_RECLAIM)) { > flags |= SLAB_RECLAIM_ACCOUNT; > } else if (IS_ENABLED(CONFIG_MEMCG_KMEM) && (type == KMALLOC_CGROUP)) { > @@ -877,9 +887,17 @@ new_kmalloc_cache(int idx, enum kmalloc_cache_type type, slab_flags_t flags) > flags |= SLAB_CACHE_DMA; > } > > - kmalloc_caches[type][idx] = create_kmalloc_cache( > - kmalloc_info[idx].name[type], > - kmalloc_info[idx].size, flags); > + if (minalign > ARCH_KMALLOC_MINALIGN) { > + aligned_size = ALIGN(aligned_size, minalign); > + aligned_idx = __kmalloc_index(aligned_size, false); > + } > + > + if (!kmalloc_caches[type][aligned_idx]) > + kmalloc_caches[type][aligned_idx] = create_kmalloc_cache( > + kmalloc_info[aligned_idx].name[type], > + aligned_size, flags); > + if (idx != aligned_idx) > + kmalloc_caches[type][idx] = kmalloc_caches[type][aligned_idx]; > > /* > * If CONFIG_MEMCG_KMEM is enabled, disable cache merging for >