From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 654D1EB64DC for ; Mon, 17 Jul 2023 15:42:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02DDD6B0074; Mon, 17 Jul 2023 11:42:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F218F8D0001; Mon, 17 Jul 2023 11:42:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC12C6B0078; Mon, 17 Jul 2023 11:42:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CD5B16B0074 for ; Mon, 17 Jul 2023 11:42:08 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 98A50A0411 for ; Mon, 17 Jul 2023 15:42:08 +0000 (UTC) X-FDA: 81021519936.08.8F3D430 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 35FE8140028 for ; Mon, 17 Jul 2023 15:42:05 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g8ZkUHcE; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689608526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3g9pjADKRhJ57FMX5gXYkm+ipevq0sMugfTwhHl2pPc=; b=NTc8jd4hK3yxf44Ai/MA18r5diTf70bXFcz3dHT4XecY1mcVpNjc5FpcEviCjPP8gQrb8W gP0hg8PJsaY/RT7fmxMp/qAtSvryf7qqn2ldo6Ri9tmqZP099giLCUQdqsjhbRBw72Z4f8 o9YwAPxmiV2q6Feys9IWD8P5Th+cdOY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689608526; a=rsa-sha256; cv=none; b=Bh0ZJlzonPC3BeOfyi887pj87HgT3locI2KVySpR42EZ/kVnOVgZDZ0mCVTGaI6M1iA7Z6 OJb/7B0zZCfS6M503oTIl6BBZoFryHUXehjDD3zXOWUsW7VCz4Wt2X246WO+y41XjMzpPV Qy0fUIHgGecm3UORsFouxCeI1qgSTso= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=g8ZkUHcE; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689608525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3g9pjADKRhJ57FMX5gXYkm+ipevq0sMugfTwhHl2pPc=; b=g8ZkUHcELTMiV78+qK8BIe2BC4DXhqORpPmDNXzgpJrNslGPozUWHHoMbiCPRbrnknUDaQ 7xLudT1uS7H22DfvmjubZVoqpKK7ShbUmfrd2dNNcxC4tPFMSY9LRhVDfyqrjq7Q7SBQEY wvLI2gY04fmJ+v19FjNyj2ZTpT07bzA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-9AXH5TofMU6UtfXpBLMrHw-1; Mon, 17 Jul 2023 11:42:04 -0400 X-MC-Unique: 9AXH5TofMU6UtfXpBLMrHw-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fc0627eafbso20359215e9.0 for ; Mon, 17 Jul 2023 08:42:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689608523; x=1692200523; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3g9pjADKRhJ57FMX5gXYkm+ipevq0sMugfTwhHl2pPc=; b=bhxFowP2gYCgfkCIMOR6LJSuIkeBTC3Xzz48SdinMILkXLwB+mmycVCduCE26veMsZ h/Fckj3Iqt6QYJzMM2R3WoCJFtVj/I1YB5aOTuyFwJam3BpPXB4fjt70RFnCmamiqrLe sPzonooxca7fE6wYfFihYYAEPjFjdZeD56UCTjOa2lSkAh3o5sp7aTGxLEAa/+huS7sP E7tYUz5pUy3I1d13OVkWy5gjpijJ+6Zif+fxP1Bpnlo2DyedG9CuqgVMSAZ9N/krwbuv ymhrAg1q/GhtrsJLk5yuzsaXNixf5Im6exCED5Q/VcqJIaI1JiofRrQK0CJLKFYUNsiP QBeg== X-Gm-Message-State: ABy/qLbiz/YQCnPAwG6gyMzfNWlWQUXe00PY+91jEdFj5A9PLq8OoWWw FjagS7+U8Xbq3OhDu/c6rIdX0O1fM6oe0bkyZct/PLGxWMMZJSFj1S+LgdYJAMbDYO022Leh4H1 U91ixojw9Xus= X-Received: by 2002:a05:600c:4509:b0:3fa:8c8b:716 with SMTP id t9-20020a05600c450900b003fa8c8b0716mr8464004wmo.1.1689608523142; Mon, 17 Jul 2023 08:42:03 -0700 (PDT) X-Google-Smtp-Source: APBJJlGgHpT8XonCi8k2gklP0NjV6dnu3l1DHiQ30N08iWXx3N+/R/nb3+dH8ujqqzommwbME591Jg== X-Received: by 2002:a05:600c:4509:b0:3fa:8c8b:716 with SMTP id t9-20020a05600c450900b003fa8c8b0716mr8463989wmo.1.1689608522771; Mon, 17 Jul 2023 08:42:02 -0700 (PDT) Received: from ?IPV6:2003:cb:c735:400:2501:5a2e:13c6:88da? (p200300cbc735040025015a2e13c688da.dip0.t-ipconnect.de. [2003:cb:c735:400:2501:5a2e:13c6:88da]) by smtp.gmail.com with ESMTPSA id m13-20020a7bce0d000000b003fbaa2903f4sm79979wmc.19.2023.07.17.08.42.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 08:42:02 -0700 (PDT) Message-ID: <90b406af-9db4-b668-a7a0-e574e104c84c@redhat.com> Date: Mon, 17 Jul 2023 17:42:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 1/3] mm: Allow deferred splitting of arbitrary large anon folios To: Ryan Roberts , Andrew Morton , Matthew Wilcox , Yin Fengwei , Yu Zhao , Yang Shi , "Huang, Ying" , Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230717143110.260162-1-ryan.roberts@arm.com> <20230717143110.260162-2-ryan.roberts@arm.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230717143110.260162-2-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 35FE8140028 X-Rspam-User: X-Stat-Signature: wekyessis1w64seeoabuycf7nurs9zjg X-Rspamd-Server: rspam03 X-HE-Tag: 1689608525-972157 X-HE-Meta: U2FsdGVkX1/6go2vD0W1wS5ZWbM+qgjtWMGrEw/iOVRycH9icR7A9P91aK+dNXrXDUVs3WTrD6bIYZg9s0OalAndoCArYlMR2ImgwyiAFFsikz9IzyHaOR7KeEuKGBfLURIhAWhGG+nbZeHxJVgO4g7s3K89rc1+FpEZUYQSXpPuhNyodpqPfFwrF3fnWQlyL1+dR5RZXNAQMNGowJ0cBCFB9jNSJZeKJ1oW18jaiNDovu1ywOjFif2n9yn89MommrQZqt4SEpUave4kyazLV1yT2n2/mYPgCzqGdKqRlcZCMMz0D1iPHCpE+VuWbS73w5Hwqz3Ge4V+FCEWQVXKMyc+YVQhJPES9kI4ndAdYSkJmtkBq2lwpPa8o77aIGo+5PUBXwVQt0O/Ygn+0V/HQvk25V1qkN5ES2WoMgRG7SqlP9clFRDZbDCSfGjWzeRzHmQ8FUT4T+32+9p0ENXrcZ31d4ECATcu/r6szRCsk8b7Hz5bD7uSOCI3mIB3F4VXvmyEpS4J7PvvDmvUgoKLiAfGpGAzU41Az0MH2Szmch8b+4sDGCRDMs0WOyBvUsX9jvJZCTEES6uuZc7tUS9pT+DLtd68BAnDoxvJHAnrAfoeHN33QGZ0KIfJMCrVPGnD84jLCLOtkYLO7K1iK/kem7QILSy50Za6AMp5iNNwsNcUV4+tFvFfC36AguPFVplTZ+H3PRdaOP6T0gcoMfTgLo0JCPcAjal83wREcjCpjOECen7JWFE0YAddKafG7Fb9YUBpEql9o0HrSxS6KE8GVEyTtuSmEYau+0uk2m173OHlWZKl9Le2/uXH40nNcrp1qlAIeOVE1DsdJW8znw//Pf0r99a6SHhYKnvdMzitFOuo8yAgkViBG8pXKlMKDpK9qqV6jmCN+7fzSCZAs85oWRyw9tta1GWIbaAPNLV/x/p6hE9PXrogxVBHWgjvgrcCPZR7b2Rwju7cg5lYYdm Q+SZSKcO g/pj7Ds8f4aXNqQNNnoq07vT47+jREiMOBtfni6toBuR9VmInOkEUabtm/vKSt5PVOzl83lJTChpXwLm8uVKSjtUfm+v0Cu12V/dTjSz+zlJCNDEvquZXAzMgrSiPY0qnBspBf1bXLINLBP8ajVtybelmWPQubzbb/VNJjXS7SSE9o4/Yv7e9khm9DOzWfyYZyY/enwTMsvyzHodZXwSkDcenN78Kc72qz3Bggj2YDBwfTcOsoeAsViheh0BnENqP6av9mpAsyvrBOUdGRBYaqE+UGHxn+KWLfcJKSW7gMOrX0P4snSmTc5c8k8yKMKspPfGVvNwCT7t37idqJbAVuAGBVxIePU5C+9nxlRRGyZn8RqZw/aYqwIuw1pPsy1NuedNixPBDjaA239vAj4dQ/JxHmHWiKosYHch9z/65I4Kwe/b7DkSwI/Mf3BlXsZ7yEueYoA41Bj+N0pGNZMiS/+/WhH+ZUZb7yq5OnbvOgnezOont+wFRijjoTm9oXLzLZZGh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 17.07.23 16:31, Ryan Roberts wrote: > In preparation for the introduction of large folios for anonymous > memory, we would like to be able to split them when they have unmapped > subpages, in order to free those unused pages under memory pressure. So > remove the artificial requirement that the large folio needed to be at > least PMD-sized. > > Signed-off-by: Ryan Roberts > Reviewed-by: Yu Zhao > Reviewed-by: Yin Fengwei > --- > mm/rmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index 0c0d8857dfce..2baf57d65c23 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1430,7 +1430,7 @@ void page_remove_rmap(struct page *page, struct vm_area_struct *vma, > * page of the folio is unmapped and at least one page > * is still mapped. > */ > - if (folio_test_pmd_mappable(folio) && folio_test_anon(folio)) > + if (folio_test_large(folio) && folio_test_anon(folio)) > if (!compound || nr < nr_pmdmapped) > deferred_split_folio(folio); !compound will always be true I guess, so nr_pmdmapped == 0 (which will always be the case) will be ignored. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb