From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB05C7EE2E for ; Fri, 9 Jun 2023 16:20:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B50FD6B0075; Fri, 9 Jun 2023 12:20:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD9D38E0003; Fri, 9 Jun 2023 12:20:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A28E8E0002; Fri, 9 Jun 2023 12:20:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8D6EF6B0075 for ; Fri, 9 Jun 2023 12:20:16 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 66D7E1602C0 for ; Fri, 9 Jun 2023 16:20:16 +0000 (UTC) X-FDA: 80883721632.28.AF54C31 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf27.hostedemail.com (Postfix) with ESMTP id 6528440020 for ; Fri, 9 Jun 2023 16:20:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ot7OR9FG; spf=pass (imf27.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.53 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1686327614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=usUa91lFTwm78ZcJqDITECIX6IQZqVVPZb/qreiSqx0=; b=KsQoVc/yvsUDItk6tHf7GKRHjW4UsmThs+cQ+3zUxvnCDTA4R3meKSVhS4FUvOiTOWG+6l qtIfc+O0jyMWUrDQRmLbEs9VoZfPMyI7omsNdJ39/sPeBm5aiaMD5UP1A19SXBqKGKZ1J5 t9aTcPEr0YfJn3DC9RK1HlLOWcw1cUk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1686327614; a=rsa-sha256; cv=none; b=Cu+LHYhNiASA/JKuJxzxVR4vH3TOZYfa36Mi28qfATj1254U9m/vQ8KNMekSKE56TcA5uQ om+BiOGZqn34Zum0zBD18qiJ3wWzdig4tuJujfuTgXSYeMzTtU4d6XbDpz0KPn9tjKyVj3 NVHZmWX7fH8EeeDqdMfIUn0Yu/QnCOA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=ot7OR9FG; spf=pass (imf27.hostedemail.com: domain of konrad.dybcio@linaro.org designates 209.85.167.53 as permitted sender) smtp.mailfrom=konrad.dybcio@linaro.org; dmarc=pass (policy=none) header.from=linaro.org Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4f6454a21a9so2493740e87.3 for ; Fri, 09 Jun 2023 09:20:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686327612; x=1688919612; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=usUa91lFTwm78ZcJqDITECIX6IQZqVVPZb/qreiSqx0=; b=ot7OR9FGvlcYcZD5e+cFOOoEF/WG2TryjkzKF7Y7nyRNcMhYN0MPV79TOo+C+dmXVR lvY31ZIut1OfKvPeIw1e4q0ma1wj7mAjXEFWSFt7BORxCehJmy+esFpQFKx8xRPe5RPa s4oATGJiDMXjJbGLGJxsRdaGE8LN2xwnUjHvb003d2AHf4bECiPk6MM3tIZC1gDgtqIo S8rUIbK2/DPKp88G24eIsWO5PYwE1Plm80C+bNKFkMHjM0r4iYDPMwaUxCptdVMLIqDT NdWzm185jBe4dLSFadFllbTJ1U8CNLjkqheJd96W2zGVd0ou9BREA0NHohLbIw/KL3G4 vHgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686327612; x=1688919612; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usUa91lFTwm78ZcJqDITECIX6IQZqVVPZb/qreiSqx0=; b=OEGhesBRE5CQ7b2gl5pwQzISTv4tQ2Wk7sXW5fmX9kDEu7/Ug9AgwQr8DRk5cJL3d0 FjBNDkla/gj9ppwEW+pJR6hJtn0j9b5jsH+bl3Rkg14oOmDrIYyGmhuT0dn0Q84eEyFu BIaHLvjd1jVez69bQLqvSduTue+qqIvKdwX4gFV56ZTObboOX59dEdBasafMafAJvZZS 2MJsfnIBhGlmTy8UMfkUvGo9jVL59sZpHUnPNhY0NwaOeqXvgM0vXbikYfbvptnLa9DE PJarsbHN5a9z8RqxIwxFIEpq4HNwV8efCQSuzCTyOE/SRtq9pkqzkrAXhfBYU3tLCVRJ IZ9g== X-Gm-Message-State: AC+VfDwrQZtDesv9fQi7k+oLTOG1Y0h4cd4aYa0jMkoRlwkWCe+Zb15J etr0M/cw6b1jPAlZecPLyTtPig== X-Google-Smtp-Source: ACHHUZ5JUKhb5xLWhhwfP9hIde5UuYkLpVxnT1k61JKzExG1On60bR+Hs2VUE0a/47NYIgSj/pTTUg== X-Received: by 2002:a19:5009:0:b0:4f3:b588:48d0 with SMTP id e9-20020a195009000000b004f3b58848d0mr1249482lfb.14.1686327612574; Fri, 09 Jun 2023 09:20:12 -0700 (PDT) Received: from [192.168.1.101] (abyj190.neoplus.adsl.tpnet.pl. [83.9.29.190]) by smtp.gmail.com with ESMTPSA id a1-20020a056512020100b004f138c4de81sm594947lfo.149.2023.06.09.09.20.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 09:20:12 -0700 (PDT) Message-ID: <90b04e1b-8f3b-982e-bab2-36c09cc1d53d@linaro.org> Date: Fri, 9 Jun 2023 18:20:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Nathan Chancellor Cc: Peter Zijlstra , corbet@lwn.net, will@kernel.org, boqun.feng@gmail.com, mark.rutland@arm.com, catalin.marinas@arm.com, dennis@kernel.org, tj@kernel.org, cl@linux.com, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, joro@8bytes.org, suravee.suthikulpanit@amd.com, robin.murphy@arm.com, dwmw2@infradead.org, baolu.lu@linux.intel.com, Arnd Bergmann , Herbert Xu , davem@davemloft.net, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Andrew Morton , vbabka@suse.cz, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-crypto@vger.kernel.org, sfr@canb.auug.org.au, mpe@ellerman.id.au, James.Bottomley@hansenpartnership.com, deller@gmx.de, linux-parisc@vger.kernel.org, llvm@lists.linux.dev References: <20230531132323.587480729@infradead.org> <20230609161340.GA4019185@dev-arch.thelio-3990X> From: Konrad Dybcio Subject: Re: [PATCH v2 5/12] percpu: Add {raw,this}_cpu_try_cmpxchg() In-Reply-To: <20230609161340.GA4019185@dev-arch.thelio-3990X> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6528440020 X-Rspam-User: X-Stat-Signature: mr64zxceo1btdj3s85gu89bg9w4ei78i X-Rspamd-Server: rspam03 X-HE-Tag: 1686327614-843446 X-HE-Meta: U2FsdGVkX1/EBlswB5hTwU61Dcx7ldH/J0MMXt1a82sJtZ/pVHQB4WguLl08+cxMJSNFUTy8PtbialoI8H5f3vYHezHGVIOq0NWHA3gTWIHB2f5p4Aatqe/Y+942oOD4LhpOtq7RitCL9BVzGzKsCPSATIm7KpB9BEBWYHyG1jJdeh9CBLtymPLqJIrh0n2DefGqxa4c0txa/Gm9roR6zJAzLMI7RzsnllXGaLaXGQAMPmf6Wy1JUcPyBImO9zNsFREOpQuKyrtIGU+sn0Yp0/AGNKxeaRuP5wRhOuTAwJcJ493xk9zCb+RRoqEBEKz0RMSLY2fk4Bv8lqN06gqjbPidyzRo6PP0TGGjvkXR+fyZb+i4PBW5+7iYVfqZA7DCb8n6da90t1bVf5FyZJch6a8Xp7VAVJ/9x1mikYurwjgzKuPKucG/PbMuIiFjV2FOTz+LZDYocMjYM6SmuUyFsB+QKsqrwF/SBo18F54kmlJ+P59vMOOcvBELINlzwc5afFGR5nr/0XjvJwEzE7YC2nSNnI/1mX/j2I0+NWZSqLrLcAYy0voBZc4UcSgPFydg7N47b230hxa1SIjOfHdX8GJGgYtE9fgJ8BteFDmU0KHOOpcHa4TyPT0Ei4HRs9zsQZ/TV5OduHazST0tmrk7VltZtMGXiCXLH0fwVxkwBYFTNKXP0wLJCZogKMDoR53n9S3exW1dG+oIuhlIpUIW66Ub07dRPOhFFAAVpYCXhtphl401dEaRS+AYyn41q7/kI/bFGe7H6vPmwsVrzuZcFuzUtYUwSN1PrnJv0IseJ99zcyEdhafpNDroawG16LuWA7YJx+ZmUn9gZjnHbiwBIhVba8BS/yD2PJYKEgswp1bLcKGFCTm7SZ0HiSGkfqN6nRUOI9DnABkVA4hMrlRpy0UF1byWb9NVs7BdBMe6Ad3qJZg0p1SLnre0re1X1xg6sPfjXCZaMnJIWnn9IIA xwkU3iDJ 2Zl+RJB59PKK6LMlplR0t8Sesjf/6mQieyVKuC8fkeq7Wj1vU1o8X7M1OVoG0Y3c3U7iwdqUGf+Zs/SL0U0tmdj/mwgmRVMUYlLTmz5lAtrPIk8HBC37MX9LvxN51bKD+Cz14HC+vJ+kqgqQdjQpdKNvYtXHQaSkZsl6bGNbAGncvgWsnaJUD9aXArIMWfGvpWcAkGjhgeaeJPrlhpmQJX3OhBdBT7bhNzRrMmqU+nlfJSuX/3VM0WAX70jzFClkhz4vyeemlEDSt6NjbVNCZvPoxzfzntPLIIxInusioMqBOyd1aHAKBdz/DklxoVh63K6zYeWTb3Fd5wIkUHMAMllA8FSITHBXzhXTH25W8k+kIRaDWurhMbkWzv5YpkBUfmknx7Wo7z4E4P5YPdYoLxo5mb/w0WGbDOyiG6oJ70BtahYuJSnzBpNURyn/lkqTKZJICcxS9nQlxVXAWyh94ky28/NVJ3kbVXFoOQ5wvZj4SFbJaNQuxhf5PD3BOMHrh9SdPqxbcJk6rpJGmR4zywbXoaqGKE4bY+Fv/MsL+hl9NNEXoGYptRRpzah3KRHiF9wGfTsgJdd6iNuQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9.06.2023 18:13, Nathan Chancellor wrote: > Hi Konrad, > > On Fri, Jun 09, 2023 at 06:10:38PM +0200, Konrad Dybcio wrote: >> >> >> On 31.05.2023 15:08, Peter Zijlstra wrote: >>> Add the try_cmpxchg() form to the per-cpu ops. >>> >>> Signed-off-by: Peter Zijlstra (Intel) >>> --- >> +CC Nathan, llvm list >> >> Hi all, this patch seems to break booting on Qualcomm ARM64 platforms >> when compiled with clang (GCC works fine) for some reason..: >> >> next-20230605 - works >> next-20230606 - doesn't >> >> grev -m 1 dc4e51fd9846 on next-20230606 - works again >> b4 shazam -P 1-4 - still works >> b4 shazam -P 5 - breaks >> >> Confirmed on at least Qualcomm QCM2290, SM8250. >> >> Checking the serial console, it hits a BUG_ON: >> >> [ 0.000000] ------------[ cut here ]------------ >> [ 0.000000] kernel BUG at mm/vmalloc.c:1638! >> [ 0.000000] Internal error: Oops - BUG: 00000000f2000800 [#1] SMP >> [ 0.000000] Modules linked in: >> [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted [snip] >> [ 0.000000] Hardware name: Qualcomm Technologies, Inc. Robotics RB1 (DT) >> [ 0.000000] pstate: 000000c5 (nzcv daIF -PAN -UAO -TCO -DIT -SSBS BTYPE=--) >> [ 0.000000] pc : alloc_vmap_area+0xafc/0xb08 >> [ 0.000000] lr : alloc_vmap_area+0x9e4/0xb08 >> [ 0.000000] sp : ffffa50137f53c20 >> [ 0.000000] x29: ffffa50137f53c60 x28: ffffa50137f30c18 x27: 0000000000000000 >> [ 0.000000] x26: 0000000000007fff x25: ffff800080000000 x24: 000000000000cfff >> [ 0.000000] x23: ffffffffffff8000 x22: ffffa50137fef970 x21: fffffbfff0000000 >> [ 0.000000] x20: ffff022982003208 x19: ffff0229820031f8 x18: ffffa50137f64f70 >> [ 0.000000] x17: ffffa50137fef980 x16: ffffa501375e6d08 x15: 0000000000000001 >> [ 0.000000] x14: ffffa5013831e1a0 x13: ffffa50137f30c18 x12: 0000000000402dc2 >> [ 0.000000] x11: 0000000000000000 x10: ffff022982003018 x9 : ffffa5013831e188 >> [ 0.000000] x8 : ffffcb55ff003228 x7 : 0000000000000000 x6 : 0000000000000048 >> [ 0.000000] x5 : 0000000000000000 x4 : ffffa50137f53bd0 x3 : ffffa50136490000 >> [ 0.000000] x2 : 0000000000000001 x1 : ffffa5013831e190 x0 : ffff022982003208 >> [ 0.000000] Call trace: >> [ 0.000000] alloc_vmap_area+0xafc/0xb08 >> [ 0.000000] __get_vm_area_node+0x108/0x1e8 >> [ 0.000000] __vmalloc_node_range+0x1fc/0x728 >> [ 0.000000] __vmalloc_node+0x5c/0x70 >> [ 0.000000] init_IRQ+0x90/0x11c >> [ 0.000000] start_kernel+0x1ac/0x3bc >> [ 0.000000] __primary_switched+0xc4/0xcc >> [ 0.000000] Code: f000e300 91062000 943bd9ba 17ffff8f (d4210000) >> [ 0.000000] ---[ end trace 0000000000000000 ]--- >> [ 0.000000] Kernel panic - not syncing: Attempted to kill the idle task! >> >> Compiled with clang 15.0.7 from Arch repos, with >> make ARCH=arm64 LLVM=1 > > Thanks a lot for testing with LLVM, submitting this report, and doing a > bisect. No, thank *you* for making it even possible ;) I sent a patch to fix this a couple of days ago and Peter pushed > it to -tip today, so it should be in the next -next release: > > https://git.kernel.org/tip/093d9b240a1fa261ff8aeb7c7cc484dedacfda53 Amazing, I can boot the most recent next-20230609 with it again! Konrad > > Cheers, > Nathan