From: Zi Yan <ziy@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Dan Carpenter <dan.carpenter@linaro.org>,
"\"Pankaj Raghav (Samsung)\"" <kernel@pankajraghav.com>,
"\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
"\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm/huge_memory: check new folio order when split a folio
Date: Thu, 07 Mar 2024 15:09:40 -0500 [thread overview]
Message-ID: <90B3461F-3A95-46F9-92F5-EA222A65D739@nvidia.com> (raw)
In-Reply-To: <20240307120224.0e627784a13cff1121048ae4@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On 7 Mar 2024, at 15:02, Andrew Morton wrote:
> On Thu, 7 Mar 2024 13:18:53 -0500 Zi Yan <zi.yan@sent.com> wrote:
>
>> From: Zi Yan <ziy@nvidia.com>
>>
>> A folio can only be split into lower orders. Check new_order to make sure
>> it is smaller than input folio order.
>
> It isn't clear what's being fixed here. Presumably something is
> passing in such folios, but what and where and why and what are the
> effects?
>
> Might it be that these folios are being caused by the debugfs
> interface? Or something else?
Since there is no new_order checks in debugfs before, any
new_order can be passed via debugfs into
split_huge_page_to_list_to_order().
I did not explicitly mention it here as the debugfs is added in
the commit after the Fixes one.
>
> So I'll add it, but I do think more information and context would
> improve the patch, please. Suitable Reported-by:, Closes: and Link:
> tags, perhaps.
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2024-03-07 20:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 18:18 Zi Yan
2024-03-07 18:18 ` [PATCH 2/2] mm/huge_memory: skip invalid debugfs new_order input for folio split Zi Yan
2024-03-07 20:02 ` [PATCH 1/2] mm/huge_memory: check new folio order when split a folio Andrew Morton
2024-03-07 20:09 ` Zi Yan [this message]
2024-03-07 20:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90B3461F-3A95-46F9-92F5-EA222A65D739@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@linaro.org \
--cc=david@redhat.com \
--cc=kernel@pankajraghav.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox