From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA87C61DA4 for ; Thu, 16 Feb 2023 10:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85BAB6B0071; Thu, 16 Feb 2023 05:56:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80BB26B0072; Thu, 16 Feb 2023 05:56:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D30C6B0073; Thu, 16 Feb 2023 05:56:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5DC226B0071 for ; Thu, 16 Feb 2023 05:56:22 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 385081A0B8A for ; Thu, 16 Feb 2023 10:56:22 +0000 (UTC) X-FDA: 80472851004.17.01CFA31 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 01B2D40009 for ; Thu, 16 Feb 2023 10:56:19 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cgTA8yeB; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676544980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uTgMQWhXxbdOB1s+iJ3y+3uVjK3VfEIrdExBYMmTzrk=; b=HujOoMzNpFM47LkKgrEsXmg1k79W+uYrS4oSiQMRaK/8effs+rLXL8eWNN2KnyKHA3BO1R 8HBC0oESr+TFfWzZkAN1FSsnnWbddOE+mvlizuM2darnR+Z8h7VdUsBjtvP7NfivtQpUai 1B9ZG0s+aynvSJribIE/0UhbdsQxY+Q= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cgTA8yeB; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676544980; a=rsa-sha256; cv=none; b=VT2mxhzbU6vrvw3mAgqOfX1D50a6ALf5GgTQ6u7djwiNEZO0hNeRHBCGHBcdB0PM9WXgK+ FwMWmP0WyOzu7r7+GkXmfwDI22owSRljoR+/csaon1edIDusv+l4wlgrsHcyE57rEdFUeI sZjE7lWILy7MbgQbuotWps8hpN1g8tk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676544979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uTgMQWhXxbdOB1s+iJ3y+3uVjK3VfEIrdExBYMmTzrk=; b=cgTA8yeBuLVrFQVUmlI+zpc+i1N1YJx/XupkVor1p/PDzbtkrCJaRFBHH5jm5w/+5d51X8 Bn2kkqyd8oZGSVLCtonsceAAevnNU5H26m5PiLePfMmuSxCWYBhVrrk1glN+9V+nsIJyVa 6qv75jzAEiTEOdI0A+bzz0LgINFEB2s= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-547-4lHcmlKZPQGr_oNPCACCKQ-1; Thu, 16 Feb 2023 05:56:18 -0500 X-MC-Unique: 4lHcmlKZPQGr_oNPCACCKQ-1 Received: by mail-wr1-f71.google.com with SMTP id v5-20020adf8b45000000b002bde0366b11so189517wra.7 for ; Thu, 16 Feb 2023 02:56:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uTgMQWhXxbdOB1s+iJ3y+3uVjK3VfEIrdExBYMmTzrk=; b=NmeFEmwc5EzjZ1KlhqGvYmT7LjfmHX8lV5jj3EAqCCsojwCB2Wgi3ioLZDEGBz5lx9 noUy+k6LdJC35v49TIiJZCMh1YV1C4/M45YHD/HAdeQukjyfdey6jNHrNxx9CRNOSeZa aL4j6ZFG+eewvE5cfQOxbttmMBnLiJBwqa+YYRqDHovM93o8ntbqGAm+0rSh3GhENANr 3iLSl6QkEbqS312kZguA4Ko/rMATRybhxqHVDYIGqokcYCQCnBXJBd3ex2/ApgF4lbdH tNjZlEhI6xQhiwusVbuZQ3snCJIU+rNtyEPWs2VQXBBHIQVJUsjIHK6IMMUnV6zOJIbx YwPQ== X-Gm-Message-State: AO0yUKULzHUD+4wFNnPobOh9VfXF6gEVRkEaMTgfRx/V+Zgb42H7zV6O 9M+8Cq6AxwNChN5c3irWW1MXCxdt4aVg9Pp2VeuLdf2H66H4KZLgGLsSHr+pxxhXW88Q3/ewH4f SPjtFlxSXx80= X-Received: by 2002:adf:e701:0:b0:2c5:5331:5516 with SMTP id c1-20020adfe701000000b002c553315516mr4351117wrm.51.1676544976934; Thu, 16 Feb 2023 02:56:16 -0800 (PST) X-Google-Smtp-Source: AK7set9ObTYOMWdJTcJUhFYm6zKW9Smmq8ZljjToRyJseQklHttx5j+GTfa92sWHSmEG8i4fOJ6xDQ== X-Received: by 2002:adf:e701:0:b0:2c5:5331:5516 with SMTP id c1-20020adfe701000000b002c553315516mr4351100wrm.51.1676544976599; Thu, 16 Feb 2023 02:56:16 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id h16-20020adffa90000000b002c5621263e3sm1221457wrr.19.2023.02.16.02.56.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 02:56:16 -0800 (PST) Message-ID: <909d3cd5-eb64-6901-4e12-00ac5c69f4aa@redhat.com> Date: Thu, 16 Feb 2023 11:56:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE" To: Konrad Dybcio , David Howells Cc: Alexander Viro , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , "Matthew Wilcox (Oracle)" , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-mm@kvack.org References: <20230215-topic-next-20230214-revert-v1-2-c58cd87b9086@linaro.org> <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> <3055589.1676466118@warthog.procyon.org.uk> <71078188-1443-d84e-658c-967991f3b590@linaro.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <71078188-1443-d84e-658c-967991f3b590@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: y5h8j4yg6qnwa8q4f5khetuzhs5buxkt X-Rspamd-Queue-Id: 01B2D40009 X-HE-Tag: 1676544979-946829 X-HE-Meta: U2FsdGVkX19zsCLcEep9OTkgO+gNnQYSRh9Glo6QiPTJz87gVwwt6sqAWYrxcywDhnPXmyxrbg6vOH5yHg3k6gQ8MyozyD1gx1bDHpqAOIe20sBdmM5LWeGPFbRCkH3h0W0Sk+Jc4LpdwGNsByU733eqCEv8pNvhozz2aCDH3YEhIJpsaT4DxpR0Q7/ISOPz2QRIIpy7ArWK4B2a9dROy3uCQuqEGTioJueyqZ6Rpmc+bNvT1MeKA+Bu4pChLY9a8VU6dke2MaNBnWGbAohnkBNqM1gm/I9Guy3PqlysFHSm2h9YdEcbfbt1h5J/3pN7lxEvaSpvCSAPO579doxvyVXCuA3rdG2doaKwYjLV7Ea7uw1ZmtMp0LEi97JG/haQBVe8xZ+3JGgI0WtUQvLVSdOLYJ1sV0lfkt9E+FUv6/Pw/hWCjISETqdhfLdaUhDww8y20gE93tVpCdHQ3OivqGQ4Wkq7VOw4MGgO0giwb1AMnyAmZ55XsE9Ocw/XbDueVuk0tdWuBeQginBtiReAXGHZgQZuSdFDwlp28c5vlfMQB/Kb2PeI1ZAGR0Ks5+/ZltgnNF7Wf1G3D0WjwJ+KjLDSCvNpP6Yngr1RQf9PG2XkZmxwV/iJcU46a6pDqJK5NwF/Vt3nd6IorImijv6PnLhK4BdMAwL8gHhmpSaWdM78J6ANBumjadgEbsoFiOHWEabEA7Jmc32vi5m2k/y56rKMoCJ7kLYdW5s1O/BKV3UuzYpZA0pLp0b8V1sWfVJunEtZXUxZRq+fWrJpFMqotJhVWoVsTf563RXYYP6QmC10JDcdwoflO8bCD/ibXKIqcJCg2Cj3TlKQ4w5FLrlrwVQ3XP4gQ97a1J4JFogXOYz6rLH+BbE2A/zHleLqWQYeksnLlz0BfKtJaU81ADBUAjctul1fHU2KwV+hP3rgQDHJdA94wYiOydIA07TmkFE+wjrmzuV6xd/ctD2bPe6 YuWCDwOY A+hFpir5H4QrX8GDEs5oGw9naSxl+fuwLK4tysMPrmpDJBw/8iWqAltwu+h4iVYS1IlysxUYkYm8PPKpqXHFkgq90lrYWZNnANj+MdePYWZiA3hdgn+JVwWE1TiUSs3/sNDap5OTmaZsBgEXHA3lps5R5E9RTdD1TcNcY/6lWSROKSJd+hRtfucyvTVTcunALX2FJO+s0zF3w51UquxDbZ0/atME3Ic2GrFeCWC3w9oJkKWTBjIeeYQxALaUcQHI3LyWcgUn5KgYjtmrR/vA1ifeJYYMchI7HwpNyo1E5YcD9D/wbGehnElEatrnzmaz35u/zEo8QgE/GEBjXYRsBXtBn8iqKYbY0Nn1ajzqFR/Rqj671/UHIRlOrXdRkQck/vtfhcqQ+kEiAUEKHKp29RkFyfK3T+6jFcbliixMRZ2OjsYdDf9t2jJ9w0LIMs5RtDLQ+vBy3oAsoggIe8PkszV+3iev2rm6KidUp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.02.23 10:10, Konrad Dybcio wrote: > > > On 15.02.2023 14:01, David Howells wrote: >> Konrad Dybcio wrote: >> >>> next-20230213 introduced commit d9722a475711 ("splice: Do splice read from >>> a buffered file without using ITER_PIPE") which broke booting on any >>> Qualcomm ARM64 device I grabbed, dereferencing a null pointer in >>> generic_filesplice_read+0xf8/x598. Revert it to make the devices >>> bootable again. >>> >>> This reverts commit d9722a47571104f7fa1eeb5ec59044d3607c6070. >>> Signed-off-by: Konrad Dybcio >> >> Commit d9722a47571104f7fa1eeb5ec59044d3607c6070 was part of v13 of my >> patches. This got replaced yesterday by a newer version which may or may not >> have made it into linux-next. >> >> This is probably a known bug fixed in the v14 by making shmem have its own >> splice-read function. >> >> Can you try this? >> >> https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-extract > next-20230216 boots fine again, thanks! > >> >> (Also, can you include me in the cc list as I'm the author of the patch you >> reverted?) > Ugh.. I thought b4 would have done that for me.. weird.. Right, and usually it's nicer to comment on the problematic patches, asking for a fix or a revert, instead of sending reverts. My 2 cents. -- Thanks, David / dhildenb