From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0955CCD1283 for ; Fri, 29 Mar 2024 19:32:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 403696B0083; Fri, 29 Mar 2024 15:32:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B3B56B0087; Fri, 29 Mar 2024 15:32:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27B566B0088; Fri, 29 Mar 2024 15:32:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 08C606B0083 for ; Fri, 29 Mar 2024 15:32:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1C4EE1C07A6 for ; Fri, 29 Mar 2024 19:32:44 +0000 (UTC) X-FDA: 81951073848.25.10B86C4 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf08.hostedemail.com (Postfix) with ESMTP id 436FE160004 for ; Fri, 29 Mar 2024 19:32:42 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="PkKa/jn1"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf08.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711740762; a=rsa-sha256; cv=none; b=E1mGyWEl6s+VvmLoAyVHrb08AULP0IpI4CWMya2CWvD6emLcqNnNbFWKp++4edPUOwac2A WvMOWqy45XQzNr3GztPFvLZYVBjr+RGihd07PDC4qXtESRdQNSAQCT+eqohv5m4rck3Dbl LlivOcyflF5iabjaOEngVqqOb4dGoXU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="PkKa/jn1"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf08.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711740762; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U0WlRAHC/svUOfvcVcapBuvlgrjV2NE5waLXnEOFdrY=; b=3NIuVRqsmedXG0gsgPY4IR00U15CjRMpRql7hzOlY2lT2xxyYeoWAvKw501IMxRcVULBi8 p+HtfDmnUxI7CP7V0pG18OZQzdXSKmI+ndcHRfn6tbMMiac6//EylnTyi2g+L+cnrIxol4 3m3+VGO8KXd5AVyNeJV3HkekHV02UUE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1711740760; bh=ABw+QBv24OmmzeZvXk5GjaZd8mv1dTdo+bCseQXgfLE=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=PkKa/jn1KWDEc+iH3q+Xazj6/Hji8DFGrvqM9t+M2HbjMYDX8Cgsiu4XuLNwNexrN v+LS5EpkY9YXB+uut4ctWXOVx3hLwTVkUvOouwf3flCyispTiwguVA/EIUjgMzd7pE m6ryqr7RHibXfsqpheOoMU4+B3Gi1Mpo+V2ETH8fbKKoOGA+jP46YAY0R/EQwguY+q QPtECq3OQ/o163img4RyQH3Hs7zHoDX8NNUJ2wJvMzzRcYWdNS5f6/HOghYI9FiZlW 5TbkbfanCHx2OJF6RBV98ob5rAD9bNp/H9jYmbiupDR8ne4y0iAiTn1xIiKONs1n6m kDSmnxE8jTVRQ== Received: from [100.113.15.66] (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 311623780C22; Fri, 29 Mar 2024 19:32:34 +0000 (UTC) Message-ID: <909806c1-a9c4-4f51-a807-46075efb8ab9@collabora.com> Date: Sat, 30 Mar 2024 00:33:05 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-mm@kvack.org, llvm@lists.linux.dev Subject: Re: [PATCH] selftests/mm: import strings.h for ffsl To: Edward Liaw , linux-kernel@vger.kernel.org, Andrew Morton , Shuah Khan , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Peter Xu , David Hildenbrand , "Mike Rapoport (IBM)" , Axel Rasmussen References: <20240329174236.2278217-1-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240329174236.2278217-1-edliaw@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 436FE160004 X-Stat-Signature: uyh498iw339oqd5xtkna59qm6w3ic8qj X-HE-Tag: 1711740762-269078 X-HE-Meta: U2FsdGVkX1+TT8V/S8kXS2OLoXmLRred0q+UlI7bwWQoej7qlNO4Br8bHHf+9iw4/BCY/d892RO7Of2CggQwC0xtwKLHju38dq/SB4ozOiDMEAhcMd1h+gXeui5aNMQpgFLZ+wBvdWhrF5BnBaLr3vyNBL8r5OGS/ImYXRfce279blSB3xFnYzM+gRMl+qTYnQN2QAnNdUzkPE+QOwE07WbWMQmRhgUZj87w9ecf7eAoJTMNHi2Sgfk6V3Gu+5pkFHY7HjvHNizBaX7KD5GrVbnBREu2AqPRJBMTo1y/oKyAKXG5QygBMk6mNa/kI2sc7Tm/gOVjq7rhL7RyFL6ClQ4WT4OzgWxCMMBq3ChnNRQIzNJ+Id8PflRjWYXIYnVL+LZwcqbnIgbNDH0t3tLsVHhHc9o2JnWHVTfOcKe5sQUYJ/rVHNCzebp7G8afukpGa7x2fB7U2PK232pj9mVXfUnPHC2nNPwh06hV8eEP5x/fnHWSQ8p5dvi9+db9Ppgr9jDWRItnCAO64UJejv86WBQUBWiEpAV4COEe0ThUoEiToVPo0RakAAjfVm9Ql+vor//DouLBg6NLMIQtqFTQiduj7NnHWCG+fMNtQvEcdPY2nGvDsZCT5WRomNGxueNMcfVqz+rr0jzh46ucxozXcfcC21xFKpbQP7YR5vmod6x21kb4K+dH2XYqF6BPWvYkrECA+CvMLoi8ZXaD5CfrJYuEXejX/y5RI9yrQ6qSGjjaYbtpQyOKOCvyIXSDE+XSPf9FNp7nbTKWmPokCgq8RXKlbzCFoDeSvUv9EG4VKwhNwc6W18cBu7IRvtG3k3QHP2c2587bBCq8XifOgr6FVcot8O7GC8x8fHujfM/iVAlsvIpqFCrCSICwKl7Q2D05qeeT0fKP+xJTJM3sNHUiUJ+sH8LFk+3TY5KoRPEqlMzOPmxOtOhRP4yFc37IUxfl5yBDvYDlmKNV5PmVc9f xaBAj27Q 0rkydRM2dvDgmEaF/jmc2qcsa9is8XU07674ZmJDTTUOwIL9xwPkYqqJxGBQlPwPdPrBG5TIYmI+yvrltUiOE0kYRvbJtztsU6pIlYF43cC8TQDhcmeetwZzz9LzN6qqex4QmMG6OqhkgqlWklHLDjU8O22WN+ZOU5/jAHtqmceCgLDc18MF0LsYQTU6UQ4N740z8Sq/GLJPDZsFF2VLp3hXdaG/2oMjgaU/IEAIxt5TBl5oK/MAMtiv5FDV+6b8zuh6sw3m+k3VIQt7VE23Ed/AiSqGeJAZBZaQ7Hqvhr8hI26cLGFFZFvIWF6Ia9alOHwnRBfdfTO1fGL7gayQ08YnUkfnf0UYTFuvOQChAR/ptEwCi4RmTJr+Lw47j9UfJsjABcVfaaKvPP/laKri4F+PC52DH8DE5ngXf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/29/24 10:42 PM, Edward Liaw wrote: > Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix > map_hugetlb failure on 64K page size systems") imported vm_util.h. > > Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h") Why do you think this Fixes tag is needed? This refers to a patch which is just moving code. It doesn't seem to have any thing related to strings.h. Other than that, LGTM Reviewed-by: Muhammad Usama Anjum > Signed-off-by: Edward Liaw > --- > tools/testing/selftests/mm/vm_util.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h > index c02990bbd56f..9007c420d52c 100644 > --- a/tools/testing/selftests/mm/vm_util.h > +++ b/tools/testing/selftests/mm/vm_util.h > @@ -3,7 +3,7 @@ > #include > #include > #include > -#include /* ffsl() */ > +#include /* ffsl() */ > #include /* _SC_PAGESIZE */ > > #define BIT_ULL(nr) (1ULL << (nr)) -- BR, Muhammad Usama Anjum