Re: [PATCH] selftests/mm: import strings.h for ffsl

[Muhammad Usama Anjum <usama.anjum@collabora.com>]

On 3/29/24 10:42 PM, Edward Liaw wrote:
> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix
> map_hugetlb failure on 64K page size systems") imported vm_util.h.
> 
> Fixes: af605d26a8f2 ("selftests/mm: merge util.h into vm_util.h")
Why do you think this Fixes tag is needed? This refers to a patch which is
just moving code. It doesn't seem to have any thing related to strings.h.

Other than that, LGTM
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>

> Signed-off-by: Edward Liaw <edliaw@google.com>
> ---
>  tools/testing/selftests/mm/vm_util.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/mm/vm_util.h b/tools/testing/selftests/mm/vm_util.h
> index c02990bbd56f..9007c420d52c 100644
> --- a/tools/testing/selftests/mm/vm_util.h
> +++ b/tools/testing/selftests/mm/vm_util.h
> @@ -3,7 +3,7 @@
>  #include <stdbool.h>
>  #include <sys/mman.h>
>  #include <err.h>
> -#include <string.h> /* ffsl() */
> +#include <strings.h> /* ffsl() */
>  #include <unistd.h> /* _SC_PAGESIZE */
>  
>  #define BIT_ULL(nr)                   (1ULL << (nr))

-- 
BR,
Muhammad Usama Anjum