From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5634CC4332F for ; Fri, 15 Dec 2023 07:56:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E99768D011F; Fri, 15 Dec 2023 02:56:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E232B8D0103; Fri, 15 Dec 2023 02:56:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC50B8D011F; Fri, 15 Dec 2023 02:56:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AD1D18D0103 for ; Fri, 15 Dec 2023 02:56:17 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 804371C16BD for ; Fri, 15 Dec 2023 07:56:17 +0000 (UTC) X-FDA: 81568294794.03.937F8B8 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf15.hostedemail.com (Postfix) with ESMTP id A16C9A0017 for ; Fri, 15 Dec 2023 07:56:15 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="HNR/1eHL"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf15.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702626975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A24O9hmrABMsr5U4vrRnTZke70do+PJq60a978UfGr8=; b=6pTPTWsrOfojH0sPVRDZJgQPIqH6yuoWlBYIBPqkEQrEXYLt/T60FBoRwkk5Zn0j3vEXls 2Oi6h+d0yUoE/ybeUevsNOmeQPf7gCj4lPHGQJuqLH0aTutK2IaIIc/ORq+9a6HEvhGH/Z ru3mnq3VlvjB/7X6KTT7a4MfC4AKe3s= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b="HNR/1eHL"; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf15.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702626975; a=rsa-sha256; cv=none; b=BJ9ABStBRLmvPg2ZbGpcnNaoIelxQ+aJVSXqZgRd08lKOaFnxGLeO8iPb3qKDZYNe6+DxN VveN9l07GwBDa/J26DuN1oKBskrPCSYKfHOfdoA7ANEeP8D5hlx/Pw6iVrAA0MKVWtNcKi ii047YmSBrU+XgGoHB1x5UGvmPqHo0M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702626974; bh=mAzpZ2f4BJM5eR5FSSU8TV6Mxhh8Z/aAMsRv8jD1bRc=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=HNR/1eHLnd0viOV+aHNDzc5a5U78Wf9gw9Icr/gmxIVPhttHLtgIvzp7opGestxOG e7mk87G1bvLJS+zRHnZnv0sB+u+hJ0XHbdwSU7jPqYGfouz4XYqJJhl5dAcCM5++vK 7hYPE1b25KDIovETWldP0/Mp8wFrumdO1uKfZnYVx5lA6CeIBmP746k7NmR9VYrOMc Z6hkSGq2LZTpncvoPdeYtIuqPeoS5tvGS5HGrFkvi+z3OiDDos90/H6hfPCGEaMl++ N66XufmXLvrvr9aB4IvUIQfzZRudt641+hmkvnsxWrV38wKksLp3tjnnGNGd4wOXfU A1nb09D5Hu2VQ== Received: from [100.96.234.34] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 6CE0C3781433; Fri, 15 Dec 2023 07:56:11 +0000 (UTC) Message-ID: <90939a1f-8519-4645-b869-5c1f8e701a3c@collabora.com> Date: Fri, 15 Dec 2023 12:56:08 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , Shuah Khan , Mike Rapoport , James Bottomley , kernel@collabora.com, "kernelci.org bot" , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: secretmem: Floor the memory size to the multiple of page_size To: Andrew Morton References: <20231214101931.1155586-1-usama.anjum@collabora.com> <20231214114056.ec687939a411961db10e73df@linux-foundation.org> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20231214114056.ec687939a411961db10e73df@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A16C9A0017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jk1h6hb5ktsgr7d5me3qtyc3uudiebru X-HE-Tag: 1702626975-987126 X-HE-Meta: U2FsdGVkX1/AYeo+u311v9aMR4xhL539Jv7N501ObTODWvjnjQW4mUHTRsrtrA7dhzwVLNIREZwCVBZW0LhD+bRKCyyHXTZt+zi35oG3z3yv9aEIUjvKzPaHF0y6dow43KOBy4lnh6n4YejLu5Rqr513ur6hJ6XvhJOwksgpGYBDZkJGAb4t6gcjX2ph0Cye8SvIba1CDSlGoQWDxaKwFK3NV9ZYIhj7x9/9piWVwMnKdA51m5OtSeBfNs9KxGQSbTtvcNGtU6NDvLz8wzaAJ+2js/7Pv4NB6IZ/+MXc5nZlmuYxePV5xHx7uMu1Ku4MHc0tPlqEdu9NHRWd0zRFplux80uDjhfgP98WP+QFCpwTIa0HVcKSigZ1xaCC1b55fnsHDr3PmFHZGXGrHtHXBHQcVhfRJWOfZSJC8qlOpgooPUxa4RYJMUrIIVBj/KvkU3GbTVWX+AdeDr2WU8f84KYNw1V+SlvcEX10ALtmTw2y7MN73ThrKMXtSuwW2tUw6NMu6yNFNA1N2OjLJZp4V7qHljGcY3NfAGUGPZg77WdoCKPVMcEMl+NiethwZJL+nPf3B+uZ1WMKNhseLREyzqfYQ/9B1gVqT+weoA+SjWScbKjkZy9/uCP/0EZGnoDBFcduIwnVhI1rq+sORILFvgqB030pm/tu8nxk/XmMVfUm4wM/ZKbuz6wZd1F0/xxt7CezUVkvKALTLccDMzhTrpbX417oH7ae5hMt3viEu6SuahBbladtgtMXpaBAS2IPE6J+6HYKF/+dv9+G5wAC+p2LVdWu8at0P/jnWzIa4b6KVuN64Pu7fE7Ro64CEJqn1j7RjmW+8IKkcNIlKDseB98FXd5kFoJDqjHeN6FlPpzWoVAsEv6y5Vow5mp2M9/s3StH0gPGH05kfMfjhHpGO6NDsjm2/sWPdD+Mtzab8NEcNU6hlLvhncaiS468ww8ySBNv/OptlouVQP4A0aE IxZQnPPr XQDZuF3lYjogXIb9Zg96SPSBTL0IG9TXFEHyBADN5Zz3eLNTGmXEFtaQOD3iOA9K0zEvv910hP9L34278OIptuQVzNvrcFWxEFaWAUaVkJqFsavvLNM9jyWf8zqr1N5HhaH4Fuss6viG7P8crEbZEPvUeg/c0DnB1vHqK8rvByum7vAzapybrsJv2BKPOMODa3OlEBgAko+iiaUc5UJ4MvVYvw6ixxopjpwmR8U9E7T9f1rQnzCrmZhL6MYVyOWxtHH2a8WVohb9L6Gozg2MYObPHyHcp7/jzjRYhRPU92K1dZ4IKEe1PfuqnYa3FvXF0pn8ymmr1r9Sodvg7gUOEemMEVNKRBQ00532y5qvcQz2FMfY0Ve/0A7S0zA2/p3WtumqRuniCPqIKgX8n6K+Nbadd6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Andrew, On 12/15/23 12:40 AM, Andrew Morton wrote: > On Thu, 14 Dec 2023 15:19:30 +0500 Muhammad Usama Anjum wrote: > >> The "locked-in-memory size" limit per process can be non-multiple of >> page_size. The mmap() fails if we try to allocate locked-in-memory >> with same size as the allowed limit if it isn't multiple of the >> page_size because mmap() rounds off the memory size to be allocated >> to next multiple of page_size. >> >> Fix this by flooring the length to be allocated with mmap() to the >> previous multiple of the page_size. > > I'd like to understand how this was noticed, what the ongoing effect > might be, etc. To help decide which kernel version(s) need the patch. This was getting triggered on KernelCI regularly because of different ulimit settings which wasn't multiple of the page_size. Find logs here: https://linux.kernelci.org/test/plan/id/657654bd8e81e654fae13532/ The bug in was present from the time test was first added. > >> Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)") >> Reported-by: "kernelci.org bot" > > Which is one of the reasons we're now placing a Closes: tag after a > Reported-by:. I was looking for email report from KernelCI. But I didn't find it. Not sure if we can do something like following: Closes: https://linux.kernelci.org/test/plan/id/657654bd8e81e654fae13532/ > > -- BR, Muhammad Usama Anjum