From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADF95C35FFF for ; Fri, 21 Mar 2025 11:27:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59492280008; Fri, 21 Mar 2025 07:27:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54552280001; Fri, 21 Mar 2025 07:27:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40D15280008; Fri, 21 Mar 2025 07:27:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2167B280001 for ; Fri, 21 Mar 2025 07:27:00 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 95A6C162326 for ; Fri, 21 Mar 2025 11:27:00 +0000 (UTC) X-FDA: 83245331400.05.A181971 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 1AFE540008 for ; Fri, 21 Mar 2025 11:26:57 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bKFcXzzO; spf=pass (imf07.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742556418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5t8CTXBvozjSkWsfr5HjhmrPtSRHXh5qZc7tXOfsijk=; b=ExXWzJ2b2vEknzi6pNyg0pncWahGlOlM2AHGxm9bwlQSlqpDJuCtI2KZTEZfvcAyjph2Tb CfUgEDMMxn0xPMO8JI4oD9+5X/KQFIOywaMPZuhfJCB/n1LBQBX5jfFiqhsa7Q+PKFSdJI T6jNNtO6lfm92UCcgci2IU6iZgmP8n8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742556418; a=rsa-sha256; cv=none; b=Buu4lpRmLvuDjYG5OOLiADw29T+QZDzvDUXhBaARDI9FYJsmLErdq2XqZqQy5ABX5ofYmW ovqF7ngft1btixkP6NSASgtcosIl8+h2RoWHF1JlDzlVf2WWUV4gLLoSbkBeNyScAYQFb8 7V/o7G1tZkM7mWHloWaAVAN7Ps8KydE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bKFcXzzO; spf=pass (imf07.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742556417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5t8CTXBvozjSkWsfr5HjhmrPtSRHXh5qZc7tXOfsijk=; b=bKFcXzzORekXSnIEzoa38sDPbWF+xk06bAofZUS6U1rK9wNI93A2h/m4SgX3KjDRNkjUQg sDC55kToYiGLaS3hcsnLbqOGwVgrXv8TQy+VTsOcBDl0rpkaqdWC4JuDVij/vR9CzAghFV Yu8XrLBQQCORZwno/Fj0oJPkS5JJy/E= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-539-GcG87FgMMwGBe0waT9pmHA-1; Fri, 21 Mar 2025 07:26:54 -0400 X-MC-Unique: GcG87FgMMwGBe0waT9pmHA-1 X-Mimecast-MFC-AGG-ID: GcG87FgMMwGBe0waT9pmHA_1742556413 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2254e500a73so22949055ad.0 for ; Fri, 21 Mar 2025 04:26:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742556413; x=1743161213; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5t8CTXBvozjSkWsfr5HjhmrPtSRHXh5qZc7tXOfsijk=; b=w9FOrteX+Culw5QIhyU2A+U1cqnbBuuax6Uj4F87Url0zNssOvsV4akzcp7Y+p7v5L PsN+d2O/n/0mYmZRC78sckRsftE/qVj741WmB7kUuc1RabVMBzZYBN+vDMniJ35vkcFd vHUiRDDjiIMpZ2LjWMMcyksITBXDUCbwdNRst6Wj1slmC/mc1u3hU4wkg4jJrcF5Pgv2 66OBXezJAY3CYOdtR+VTmTe6GXktjKRG3jRnRdZmGjUzB+WoSGMytsB6vsil/O1wFfck m2DLpmlpqk9KaVyUzdGGpO9Ap0rwcrK2G4nxETJml87WtHNGGB9eHOGq26rP19h3oykA 8K/A== X-Forwarded-Encrypted: i=1; AJvYcCU923KF1o639BdZAhGfakJtAe/jaDT1wi+vCyEUkiWEhb4jkRpYdxpPxlJlp5qaN1Svn2hyMtiAVA==@kvack.org X-Gm-Message-State: AOJu0YwYz9qSIeiY8qb/TpAEMEM4K+bIa0AOOYuLrYwxtfIrBfMyiuiG xp/Gf27zOoQ4vo1SK2CZa0aphKYyVEHWz6tg/G2JsWLWqQ73uPpkO1xA3iKhKgjpkvO69nAWxP3 vNeF4Ov5d7kd5yuERz6IVex24ivWMCdrCMTDm4Im45c+DtVGt X-Gm-Gg: ASbGncvJs3q5cP/0kkoJNjKEy1QXRuw+4OO6uxb72DMRXNBTagkrKxmSmggIW339oaQ XlYJkC/lNnzyMbjgfFego6oqEOaZ4epEVCt3U7aCi48avneAZfxup1q0yrVNRBGbnepi72Pliuv R8Q3+9BME5CDi8M/M2EMz9CIEijTvYLw947kqSUHxoLNEMAdD3M5apXJurALvMPan2zUV8y2nIn YIhMvxVdFCq7vZJNt1+Lq1KiZog4dm+3oE9LDo3yequaydp6PwDcVhKgAb1RyFS8jeaKo7hSg2O 2r/2cq9xvV39HZqmgw== X-Received: by 2002:a05:6a00:4fd1:b0:736:9e40:13b1 with SMTP id d2e1a72fcca58-73905a253aamr5091495b3a.23.1742556413124; Fri, 21 Mar 2025 04:26:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/Qqfyr6B8bsLxXxeQh/Wo7JYQY4tOPbEFYCnCV92lF5CSImpeVqV3WqCvsyiNvSwQwA8gIQ== X-Received: by 2002:a05:6a00:4fd1:b0:736:9e40:13b1 with SMTP id d2e1a72fcca58-73905a253aamr5091461b3a.23.1742556412745; Fri, 21 Mar 2025 04:26:52 -0700 (PDT) Received: from [192.168.68.55] ([180.233.125.167]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-739061592c4sm1582987b3a.154.2025.03.21.04.26.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Mar 2025 04:26:52 -0700 (PDT) Message-ID: <908c37d2-2da7-4892-bd07-4ec7ffb8fc3f@redhat.com> Date: Fri, 21 Mar 2025 21:26:47 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: Fix parameter passed to page_mapcount_is_type() To: David Hildenbrand , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, willy@infradead.org, vbabka@suse.cz, osalvador@suse.de, gehao@kylinos.cn, shan.gavin@gmail.com References: <20250321053148.1434076-1-gshan@redhat.com> <20250321053148.1434076-2-gshan@redhat.com> From: Gavin Shan In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ECnU-O0Kivr5T_JNzAqUt0FNAhsUN7HglNpHdP8lUy0_1742556413 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ahuwbq3c5wmyn1mfuynewe56wgq6qgnn X-Rspam-User: X-Rspamd-Queue-Id: 1AFE540008 X-Rspamd-Server: rspam08 X-HE-Tag: 1742556417-994008 X-HE-Meta: U2FsdGVkX1/+OlfQS6BtgVKQ3dAfmGKDkn0cW3SFR2fmOROlBuyD0EC2XCFSSLLZqoRAPT+JrlFc+XctZjThqsjvEeDQZS4cuvMM2/C038t+xzgYJG5q7BgpByXpLLDy9ItnDncDXG/Ien09nGJSHyY/yBVOWGg93kw+VC+thwt7rtli5JQYSNaXJjpM9+GEyprcC/FzGu81XbvA1KjOE8vpwhKVjrerVCDqipYi/9CtfuyCGLobMdUy/Ejn49r4bDh4WG2tS2y9ECvqsnTEf6/I4Hk1qRTHZgTwi4P2nMmie7YehhqTr6gkZSQT/D+7ym/mHfPA/AIFb6Nm7AwutRH1TVxj8uq7uZRL/edoXnFsNYFFe7n5HWVtprkzFy6NXWu12FTnnbCDZWDXqco41q5QH39g+TJnQPB0Rca+3tTVZVGztEiQZeHMIwYopjdyCSa4dspeRRmcKC9FFQ24kWmHmZLon78fxdXrCOU232o6vAqiU/te1vkfZRMY3iBZxGSb1Agk/pybP17G6yfEdls5p3Gz3tdDNmmg57krLFd1cVcl58fnQnxJ9JsFbiK1g/TfI6Y2CmdWNodoTMb87KVBTavDoHmv8m+YpLhnirc4QlXIhrK0bVhqicDkRvOAEkwYifFeNVevwiLINWwWs49WX0S/9BQANrVuJO/LxhFI2FVvkce5nhit4XVOP/gPwLFZ7Sy6Vrf/fwOV+gMEVMbjZOR1NiYcXAvORka9s2W3fL7Au0bu69wyZCnQgvqZmSsqFBhwddEZsqxw92pKK6mDwJshVXJnUXISkU2JHf7l0Vd+AcokRVccX5aGGDum+0Zjb3mBXSPIvu7RbFsHD6kk1bY+5RM3SuLWm1EelRQas7bJF/H+3vzlUjAlaRlao99BebUS6R6mBKxkrOwYxoA3JG9FqS3dxtyclU/VH716xmVeXnYVIw/Jp9Vj1YKYGZllGvjVp1ZcbHtEKUW 79c+tmU1 08/sMmQwCEAmA1OA3hDFBpKQGoPWKTV/bGgW9PLqAX68L1jKbVJxauR5PS/y/lJw0DRniQXzjQFUnfzy1BLEjnulxxcRtDMIdXDFJyAWvvAxd1BbGHrNQQxz5hIAmyPjXTxllVyS8aaRzXJ5x/y+462lEx9LB9wUBdKXoueTOHM8jYGSD5rshGyYQEVE5k7yWwRmGqo3qDO7MeDd/mWV8Z6bu+mFDAM39C/a8UODXi21a2o/Q6oPRvlpE0v3Z6gwXeNuvLT2OrA/WEv3g5265sgzvmoS1N/s2z8Jb5tGNslISLWrnrswKa+YpiL8N1Q3siuh0KG3RkOJnXhouCrtCZZbMK8jplN2CFHx9AQRr6txvEsGfsRkKJR2GQa2CDe7lLeu9HaSWSl0G8maTpKDnAIayF0CJDmIV9xJi/xBKSq71WiWHslu6JWxuXhZaqanJG7Qp6Dsgv38cF9orXrbPyUSWHoMnOZRESi/zpQdUWfjyQJqgmYxrJ/vSBgx3IBOXNUmvRSBVjvHSaqkBu+/m1/6eZy4lnqN+kNc+F4iHX+bmrZRz1IXq1CsPC6DA4FMzhf5b X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/21/25 8:13 PM, David Hildenbrand wrote: > On 21.03.25 06:31, Gavin Shan wrote: >> As the comments of page_mapcount_is_type() indicate, the parameter >> passed to the function should be one more than page->__mapcount. >> However, page->__mapcount (equivalent to page->page_type) is passed to >> the function by commit 4ffca5a96678 ("mm: support only one page_type per >> page") where page_type_has_type() is replaced by page_mapcount_is_type(), >> but the parameter isn't adjusted. >> >> Fix the parameter passed to page_mapcount_is_type() to be (page->__mapcount >> + 1). >> >> Fixes: 4ffca5a96678 ("mm: support only one page_type per page") >> Cc: stable@vger.kernel.org # v6.12+ >> Signed-off-by: Gavin Shan >> --- >>   include/linux/page-flags.h | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index 36d283552f80..ad87b4cf1f9a 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -950,7 +950,7 @@ static inline bool page_mapcount_is_type(unsigned int mapcount) >>   static inline bool page_has_type(const struct page *page) >>   { >> -    return page_mapcount_is_type(data_race(page->page_type)); >> +    return page_mapcount_is_type(data_race(page->page_type) + 1); > > Probably we should just call page_type_has_type() instead? > Yes, page_type_has_type() is better. It will be used in v2. Thanks, Gavin