From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A89CD68BE5 for ; Sat, 16 Nov 2024 10:23:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7E8E6B00CE; Sat, 16 Nov 2024 05:23:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E07A96B00CF; Sat, 16 Nov 2024 05:23:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C81C16B00D0; Sat, 16 Nov 2024 05:23:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A8FC06B00CE for ; Sat, 16 Nov 2024 05:23:40 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4014F417D8 for ; Sat, 16 Nov 2024 10:23:40 +0000 (UTC) X-FDA: 82791570414.22.FDE9B82 Received: from mout.web.de (mout.web.de [217.72.192.78]) by imf08.hostedemail.com (Postfix) with ESMTP id 0E1E2160018 for ; Sat, 16 Nov 2024 10:23:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=tnnl91YQ; spf=pass (imf08.hostedemail.com: domain of Markus.Elfring@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=quarantine) header.from=web.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731752528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eoB4Zba0oDILq/GyWjNIQLXHlVmq6QUNlZtjwtBqfrw=; b=H7jjhwHsPYmCwK/+D+OTfB8OIWqjYwtHPaVeeA4GJ8+g86cLq6qeYvHCvrRhJNDv+1TP/e oBT7IwZVYSgiaiwUhU0HQcxbFbPDq3gFlNkPyObY5xwgPGprFoo6/MHMLZWRecprg+v3I3 2SOr0zMFRysEJn39VFR6DCU8/+aWdEs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731752528; a=rsa-sha256; cv=none; b=z6o8aLUQ0d3RDNDgQlU7i5ptf3OY64TPGmT0FNXHXzL9Ry8qki39jbdP0Vxo8bDeKi90dq 9eceE+Kjyll2dPsV6l9td5ZIl/k3T33iNVioRvlHReyonSWIzH1oC2pQZHEgJoKv/4ZGeM dBjsnMR9fj6+geVK/C1xnCzFPvDEmB4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=web.de header.s=s29768273 header.b=tnnl91YQ; spf=pass (imf08.hostedemail.com: domain of Markus.Elfring@web.de designates 217.72.192.78 as permitted sender) smtp.mailfrom=Markus.Elfring@web.de; dmarc=pass (policy=quarantine) header.from=web.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1731752603; x=1732357403; i=markus.elfring@web.de; bh=eoB4Zba0oDILq/GyWjNIQLXHlVmq6QUNlZtjwtBqfrw=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:From:Cc:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=tnnl91YQA9DSUV2bdoeF4YOzfbARJimu/tmTDLNdMzul1FlQPw5QAAWt1drAk3Ad UaqUN1luEW9vrGmy5mWB1wRipPzGEoQ4902WuRX35XoQbOkOHx7N5kAyldxyp9LLl 1Vk/5239bUtdx8q/sqWvpw2IyfOhJfBK8McXtVpLEuSCNU5mE6cKsy0/6jClBDTUM m+oUTX9sbL6OWR2KY3c7lHUrA/8zzFHEyHN37tBZ9WKhIaGnQCYZaZ/dESL4qqWra HEE9nF1GNM2k2tc67GtBgE+9Wvrb9QIWtacHHbvnKxQVdIEh90Izoix70o+OBS4Mn VfNCU6GXLXJcQEmlEQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from [192.168.178.21] ([94.31.88.95]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M8kEV-1t87Dv2SuX-00FywX; Sat, 16 Nov 2024 11:23:22 +0100 Message-ID: <9088f9a2-c4ab-4098-a255-25120df5c497@web.de> Date: Sat, 16 Nov 2024 11:23:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [cocci] [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script To: Easwar Hariharan , cocci@inria.fr References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> Content-Language: en-GB From: Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan In-Reply-To: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:ozemPo5Q9OPy+/gWIfbNb/yTAwp7zpbaqzDjn4mcTmOYffBLZAH E0gCP/qnqze9l4Bx97cEhIN2OOovptOgRBkBUi+bKyV+a6ol7S4atoRxVmjqBCc2g41VI8a ROXhUKP5mlUoyzcJqOavJdVAoW8iKSPURqEhcga4JsnmJm/Pjl1vO+foxZw0grHWEblCrYI LJ17n1lYaEdE61JhX5uvg== UI-OutboundReport: notjunk:1;M01:P0:cqxyRecUHWI=;mdNOJxMPXJ1GyzF//eKGdLZ+Q8F gZOm7zXyKp5nkSwMIvY2D1Pf29OTgIQNnEk2sxWaloC9j5qlT3qQUm44Qe1eN8K2TrIb7Ylam rbOIjXCI16gwyjr6u6Tm4wzXx3QEqIRDJ6vPTxa1qCHZ5nXH9awzzielfDD+nIYBqn+NysMC0 QZsEszMBUB9IXfIsHktBfi8cBsv+k0746M1afH1AQnbUe7vbWDpvJQfebcg6n+Wz3fvdqxIZD kSPPyScjl7oMRh9gl8//4l2V7VzBO9LPR7x4sdROj+PLFL3oFRJx+0h1y9SyUqJ0GnPpxdEL0 PMzZq88Rt40rnD8qxMQHh7I/uNcMzG6WX18JYqJkBzSmPhgPNeCMeiVI23Ufs+Q4nUJ3qhDsK 0p5vEIj2tML+6DTh9sRN/Vkr1Nv2iQxQGIWmrKuhxE6H4MNkCnw+r/vzSC3EjHoSsbQuNjTP7 r+pzwFQBW5yKjimU/E0otnHQxITegw0hqubdGvkG7V+M9Xbvv+rLAmjIvBciAuyFg9KBmCLA8 CWrj3n83t/hiJIglwxY4Dk0jEZxvykwS9+BkMPoCtPW+iQ8gW/25w94Qj8e0xURq8TAcN0dXU AuweP7ynvWG484eB8hCbKDvioN+mlpMsRwjC2FQlrRm4HHD/6yeo6jL47sG63P4yysOuS2zfg IN1JwCXmYpKMSvSbVFw4XwyvjYvlKQDYKIw85OFcoZ0jKCnyiqcKt/8cDr+RhTK1EOdwwhDck OYb6KgYNVujGNSJD3nwWyFRxhnrOGI6zg/KUG07nQrZrZUdDjSpdUqLqFAptM+j5kRW2zaeV7 aAINj3gIMOnIF9IxH3vxoaq7UZVlr1ioWkWYi8cog6WCU27yEI6la8XQh2utvVDIt3r9tDYKA xoMAYChjmKcdRYrZMLRfSf6EiCXhz9YR9r6L9u2NSImvIGamFAFskjhIg X-Rspamd-Server: rspam10 X-Stat-Signature: wyag1ro1sjpku9hd5sunt3mdhzagsn5o X-Rspamd-Queue-Id: 0E1E2160018 X-Rspam-User: X-HE-Tag: 1731752586-314590 X-HE-Meta: U2FsdGVkX1/kGTwA3uK/whDC5/V1ekmqDO6hKMmpA71o6r/tKIK/qGkfheVrmrpb3luOVdjvcH5AO1peRRLq6w6lQYslhdYmLgtPrp8XSrNl7ZgOZOQc0FA0CRF0zu1Nwy6NEgNqpc3vjEAncKjYjVXZyiBI1d9EaKuUVHjYdSqg7buQtlVyHYCSaW+7SsVT020FEw8GSXrivPmrykWHdp2nVoKxkf01YOMJRxRwyjdXeyaDXPnO3AZ6BBBE91wDtzeFgy12cJaLj4PQ2CizDaSGBEKPS0fUbf0OumkmkARC+mUCcRxCG+72E1UQV2oob4to8EjC5EJZyTe6zQIE1bkPMOxwrgmA+8F00h4DtyJozT9NT8hOs5w9tMS+5F6AJZyaCj8oaSVCo3Q0ZAUWfM3g6KhmSqyqgo1BIP0162K/c83TFMpySZNGrrNwUPHitN9LbyOw/TAkdzRfxSXEEnrMvXT4lTAxkSwn4zhru4gDmOlbkGiJeGDuRp3NRgn6SlZakLWCm1xYqwm8LG9M+37gwqA5p4vawTq/+pveH1ZhPmyKphqYuQRNOLYlqwFW04PwVifj0LomfcdFo/qlgvoG8noss6TUPM2QFK6puWjSf+JWP9tW9wrRphT/b7qQt0ZPntLkiReFsceaIsX9xJZNW8xo4Zndy9VTMttvY++WlsZoS8gT4imstEd47QIzNn1VgI0OnaiokRGhQR7nevjQFRhPxRjIEaNBTzWQ5FcMEzPoEVz5GHFRIwk4g+yGl774HmuIn7ZDKDGbPIj+BPv2M3MAWX1OwTH/ByNGciGt0bagXtKHVSoO4bLsTYeekNY7TZSXA3+hUwzWGz1SbWnHxuJggVP8crhYM1BVcscnboI74FSb+y5Ecvj6BoO17nK0bsjDz/xUAByfzuS/DtAC9qg27sCm59k2GSl6LvkD2W9cQp/iRK9445q2BwnvYbnzIf6tya1q1KffUpd 7CP+5/DZ khHIIBVuArFbXrtJVNlBe11f6XXlTlMo+GXTjv1y03I/G6sYAf9FYxEdAI7IzI0eH/jMmGbdPSShfl1vwkS1qXZb7x1/5zJTHHjtaO641gRDlGQarDJkyXXTpw8C9FBJo1mjGiSkCpSzSMXun7rHKIPY1BwnDSI/icj+6kjOutsWDHXA/egVPh8EYrYW6kurRzTz/QEirGWhtbfnJFLxSOC3Dq4YfhcpPbuV//eIhOBYOsVADw6Y5ifk0jYQ19wCp6VaV/7FnhJJ7vIU6S2/KrsG8mdt/4fxNCRTBdzAecVCMnXTwRdnRbavy4gr9vTqC5C0FLubYvSIyegwRFWrlEmer3pYG67jb2Qj2xyPebzSNyAAlShPWebQxB9jmNMIya5Ian5izvl/gftJBNMA3yeDPNGVe+MwVBqeF0G3ocKuUBP41F+RNUYy/CQBj2X6yeQEXkc8uMxw1QpVkxyoFPjSIiSU27DmiGghA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Why is a change description missing here? =E2=80=A6 > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,21 @@ =E2=80=A6 > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) I suggest to take another look at corresponding development documentation. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Do= cumentation/dev-tools/coccinelle.rst?h=3Dv6.12-rc7#n71 Will the attention grow for the proper usage of operation modes according to the tool =E2=80=9Ccoccicheck=E2=80=9D? =E2=80=A6 > +// Copyright: (C) 2024 Easwar Hariharan Microsoft Should personal details and company names be better distinguished in such = information? > +// > +// Keywords: secs, seconds, jiffies May a (blank) comment line be omitted here? > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) I suggest to take a SmPL code variant (like the following) better into account. @depends on patch@ constant C; @@ -msecs_to_jiffies +secs_to_jiffies (C - * \( 1000 \| MSEC_PER_SEC \) ) Can any expressions become relevant besides =E2=80=9Cconstants=E2=80=9D? Regards, Markus