From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E19C54E58 for ; Sat, 23 Mar 2024 23:22:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C3B16B0082; Sat, 23 Mar 2024 19:22:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 772C16B0083; Sat, 23 Mar 2024 19:22:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EC6C6B0085; Sat, 23 Mar 2024 19:22:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4C19F6B0082 for ; Sat, 23 Mar 2024 19:22:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B96CA1A024B for ; Sat, 23 Mar 2024 23:22:22 +0000 (UTC) X-FDA: 81929879724.07.41AA5C3 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf14.hostedemail.com (Postfix) with ESMTP id A1CAD100005 for ; Sat, 23 Mar 2024 23:22:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AydO7gur; spf=pass (imf14.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711236140; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=numYesfytiCMENJq6OnJjqLqRHuG6hVWKsAhBliDRBI=; b=p4p/bzVRVOAA1ijkM7cqFMP4KJl2meiINCWDeD43y6gb28/k5O5DmAUzEdKRQT/Qpinjsf Oqst0ZCkRtERgSlaSrkk6z9eTJKNejpCAZqeSJChumXPMoJvUWgGKCOo39rUnjGz3BjDt3 Nc4kZ6pPxifd5JJU9x7QA2hyUFOUTJ4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711236140; a=rsa-sha256; cv=none; b=6vppn2Da7chAp5uMcod5gSUhPqRANREz8T2Uu3GV4c2osOT0DhS5hmixA9PIL9ZNqEt+5j MmVCOUnh9qqLid9QhKG1az6eiPXQqt4jXDgu55Zz7r+OkBgPfq3If65EBy8qL8ScpXwVyD 6fgmHB89Cjzyf3Sd0Zo5M3ORmNnA1tg= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=AydO7gur; spf=pass (imf14.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1e08512cd8dso19190995ad.2 for ; Sat, 23 Mar 2024 16:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711236139; x=1711840939; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=numYesfytiCMENJq6OnJjqLqRHuG6hVWKsAhBliDRBI=; b=AydO7gurovhK+bo9eYgY7WL8YbNx1J5RpH/QJJ8mmLfiCLU3DSaGJ6l0IVN4mbakSE PTR/WNCyWE/I7ujNPAO6waGoMMbusU3AAb4lv7SeIYZgUS4jG3SpJj30W+GiTNh/z40c o+5D5VPYgK6tG37MVArWFj02pAiIdZxXVjIR0Lc28Hq3hPzfCDraDpV9s6QSi4OnZWXF tXhzus53FJ0yWLUVoaJ+BfVekum1LpZt5HuDmhKq/OrpTdZ9c1Mr2BPSe0jdjk+maq+l lCMady/l4WOcKLdbWJdfz/o8wF0f4kqcitG5Yw4WN1gCapepDxdQ3S41djLl9v3luzVA RGuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711236139; x=1711840939; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=numYesfytiCMENJq6OnJjqLqRHuG6hVWKsAhBliDRBI=; b=pWMMmrh8qsUFN4Vo33ctyFjo1aVkHqnhLbYgoFmyjzTsLrqqYp4osCPyxCBNmXX1Ee JR4OKSiAaNEwmlouZnKbYUcxSK+4UgkrdQgzktV0L9qMOLMDYNYcI5iDopz/PWAiz0Cf hU8P62MAggcDDnvYmq3HcloM9w1koiC0bCfNmqTtEEs5lY56fDhUTqWWfKDX2+C1gZTP LhjO89ExN7Qt42TJaSj7WJmHUsNIubGyva83n2CSuE9OsXlSamCWFo3QZTtgRozLnbzK /sOeATvY5Vb4Me5kUV1f6LZsDNIxF5WYhDnX8fDOAXZQmbmfcWWrhe5Ksgzf9EUJRT0q rLyQ== X-Forwarded-Encrypted: i=1; AJvYcCVjhegdYs0jsxFQNU+/NLm3ouRKvC7UMHz+lJRoyCtSleA0BOsFEe4TvaaZ0ABDI5AEM6v9M3lWv4iq1AEHKGJVM2M= X-Gm-Message-State: AOJu0Yycj5J6x7iqY666dAe2SMuDBAhG1I+o27VbOr0DSvS+oQoSrOm7 6cuUSUbEKuwopo3Gvy4xSXSYCRoJMyEjDB6cWQ4NRCraiFgkJOKS X-Google-Smtp-Source: AGHT+IH7da+U373OlerZB2riMg4zTVvLs0rMSJ4B7kduDkb/wrETjP88PCq6XjGEpElQSc/CS/fU9w== X-Received: by 2002:a17:903:181:b0:1e0:b461:d10f with SMTP id z1-20020a170903018100b001e0b461d10fmr390484plg.59.1711236139274; Sat, 23 Mar 2024 16:22:19 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:329c:23ff:fee3:9d7c? ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id w22-20020a1709029a9600b001e00e17c4e0sm2073727plp.49.2024.03.23.16.22.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 16:22:18 -0700 (PDT) Message-ID: <90868fbd-8691-4d72-b211-9ecf2f6629f7@roeck-us.net> Date: Sat, 23 Mar 2024 16:22:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: vmalloc: Bail out early in find_vmap_area() if vmap is not init Content-Language: en-US To: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton Cc: LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , Dave Chinner , Oleksiy Avramchenko References: <20240323141544.4150-1-urezki@gmail.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20240323141544.4150-1-urezki@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A1CAD100005 X-Rspam-User: X-Stat-Signature: 6rxtum495kkqdwos5cj4di1kbs3okknj X-Rspamd-Server: rspam03 X-HE-Tag: 1711236140-726327 X-HE-Meta: U2FsdGVkX18OPkiVK8mazG7SmVgZt+FYy1kNL+E3y3qrl4OWXbT00Exx7iUY3MogyrBo/stz0X3LvgrBwnRFCC5f74aHcdBoPuBa3vxLrXV7X+D4U7jnCZYmI2B8T+LjTrnOHiuT83YruFGi0OX9QvKRTyn8XRBedO7FTf2KjFORlk0MaAkd7RYmLYLgoivzPpbEM4zENR3prC7ovbIKq/LhmfWpmhxGMGyL8ALrnZYa1Rv2xS2CmwO5zEo3R3nRSm0lFeC73mVKbJJLdsk2dSzEoCGkmTbzcV4GT9RqCh3LZoxMLWgkIlTeQK3vHeaLzy0e/Y5A9QjdagGdIkSM+pMEyya1INYDIwOwgC1njXDFJE5PlHQ/HxMTK3CZTR8rqG0EX3/IcnpQPn5na9o9SYhrJKJpSqdN+oWRe+2sgFDDEqU3fhx0lLMdx0L0GPB9xe4vxDZnHcdBKnqI4R6hx9294itWvv1dxNYtBIwKPhgSTFis98OmaNaYRfae+6Y3fmCwqpWDVG5rFobtBmOwg+vpfClEq5ZPQ5WPpoSs5tVqmNaxGLwgcYO3Ud5vvL9ANWg1sQ/BcWMtGSDT6dnr5t7fi+ByphvLUaMqWlX5A9/wG+MiG/HuJYjYNqbbqtMGqAlagVV2rfjadt+cG1J4VKewwc10K5lhNkqN7xf7ryVxFL2eMaCjMIfgV0IKD2zJd2SAg0mzLqQgScn/IL4nB3E8tYQFhdxA29Xae0T4efregdxpgB0xpg0aKXHY2w0zflk1mNYCcKglyhZhZALqm1MR8UGJSR4Ji4s6pJLyacI+ApYkjTLFvd4dhTPzI1V/Lgy2W8p6AAHp1AxZ3mVOKnYjM4HmbZuWVF+6tj0SAsClNckDXnCvXM2dAPvVlwqX2fAORHZxfNZUlGjmQQ2CZOvyoDP4gZu+/iYXtpekI9q+2ZtMVurYJwpltWKnu4Afbf1hcfl9+BJHJf84X6T t6WjZ7Ds uB+iieMaaMMa6/8g1in49Y3yhEyrtiiDvkFm4msqmVyXa4DXRvEOV+JcZl69fPjl7Pc9pdFz4Y45ff6jpxgBM8FhbAKuORE/eoZ7+Ko1HZXuI7+ilpH6FpEBICcsdI85knnR7eaHo56Sq/ZYbkN8NMwjFQcLfLmIwKi9IIKluX4RdkBBQKWLETSKYLGdDh7CWWkRBYwNGyJPYviJ0zdv1WGUIqCzmCqunHbAtOME1Kjneo5Rs/RIJOLAnMYVzZutJ7zWfnSAE5Dufq5mWecA51N7rk4m6Wb/K0hkZZSdHu/AcexexweagfHPegmW0iHdsH2nDggd1zkdMasLmJ/Oq2wjk0c2BTkP/ntHjq+YJmSU1cKdqbrG3Y8Xpy19/CCU69fETlMY5tR4CrLFoWoePzlYVK9buVwN+OhFya0E9lC4cBMkwIVvist2ksX8mJi4rhXMwstj14Mp+1b1l4Un7Y/pogEpz0XFPFHr2vySNcYfCDffaARuITmy80ldIzrTW7HhGKQ5ea2p1AiQcE6ZtTS58TGUTQGSZykMG2jkmupnC62uVkbHNaIraE2aywV0mI18Ifhyk+0DX2k+QeeIE9OJqIh5s/gaGHlSm8My83oKoi+kYo/Uo7bajwttyaTWmyO4Z X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/23/24 07:15, Uladzislau Rezki (Sony) wrote: > During the boot the s390 system triggers "spinlock bad magic" messages > if the spinlock debugging is enabled: > > [ 0.465445] BUG: spinlock bad magic on CPU#0, swapper/0 > [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 > [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) > [ 0.466270] Call Trace: > [ 0.466470] [<00000000011f26c8>] dump_stack_lvl+0x98/0xd8 > [ 0.466516] [<00000000001dcc6a>] do_raw_spin_lock+0x8a/0x108 > [ 0.466545] [<000000000042146c>] find_vmap_area+0x6c/0x108 > [ 0.466572] [<000000000042175a>] find_vm_area+0x22/0x40 > [ 0.466597] [<000000000012f152>] __set_memory+0x132/0x150 > [ 0.466624] [<0000000001cc0398>] vmem_map_init+0x40/0x118 > [ 0.466651] [<0000000001cc0092>] paging_init+0x22/0x68 > [ 0.466677] [<0000000001cbbed2>] setup_arch+0x52a/0x708 > [ 0.466702] [<0000000001cb6140>] start_kernel+0x80/0x5c8 > [ 0.466727] [<0000000000100036>] startup_continue+0x36/0x40 > > it happens because such system tries to access some vmap areas > whereas the vmalloc initialization is not even yet done: > > [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 > [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) > [ 0.466270] Call Trace: > [ 0.466470] dump_stack_lvl (lib/dump_stack.c:117) > [ 0.466516] do_raw_spin_lock (kernel/locking/spinlock_debug.c:87 kernel/locking/spinlock_debug.c:115) > [ 0.466545] find_vmap_area (mm/vmalloc.c:1059 mm/vmalloc.c:2364) > [ 0.466572] find_vm_area (mm/vmalloc.c:3150) > [ 0.466597] __set_memory (arch/s390/mm/pageattr.c:360 arch/s390/mm/pageattr.c:393) > [ 0.466624] vmem_map_init (./arch/s390/include/asm/set_memory.h:55 arch/s390/mm/vmem.c:660) > [ 0.466651] paging_init (arch/s390/mm/init.c:97) > [ 0.466677] setup_arch (arch/s390/kernel/setup.c:972) > [ 0.466702] start_kernel (init/main.c:899) > [ 0.466727] startup_continue (arch/s390/kernel/head64.S:35) > [ 0.466811] INFO: lockdep is turned off. > ... > [ 0.718250] vmalloc init - busy lock init 0000000002871860 > [ 0.718328] vmalloc init - busy lock init 00000000028731b8 > > Some background. It worked before because the lock that is in question > was statically defined and initialized. As of now, the locks and data > structures are initialized in the vmalloc_init() function. > > To address that issue add the check whether the "vmap_initialized" > variable is set, if not find_vmap_area() bails out on entry returning NULL. > > Fixes: 72210662c5a2 ("mm: vmalloc: offload free_vmap_area_lock lock") > Signed-off-by: Uladzislau Rezki (Sony) Tested-by: Guenter Roeck