From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D32D0C77B60 for ; Sun, 30 Apr 2023 22:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 651B96B0081; Sun, 30 Apr 2023 18:41:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 601D66B0082; Sun, 30 Apr 2023 18:41:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47B166B0083; Sun, 30 Apr 2023 18:41:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 37F8D6B0081 for ; Sun, 30 Apr 2023 18:41:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0D4EB1A069F for ; Sun, 30 Apr 2023 22:41:40 +0000 (UTC) X-FDA: 80739530760.20.57316B3 Received: from www.vigovproductions.net (www.vigovproductions.net [86.43.91.159]) by imf24.hostedemail.com (Postfix) with ESMTP id D7734180011 for ; Sun, 30 Apr 2023 22:41:37 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=vigovproductions.net header.s=mail header.b=iTkoFPC8; dmarc=pass (policy=reject) header.from=vigovproductions.net; spf=pass (imf24.hostedemail.com: domain of mgkeyes@vigovproductions.net designates 86.43.91.159 as permitted sender) smtp.mailfrom=mgkeyes@vigovproductions.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682894498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FEybQvaGKMeHDAqErffhG8NkPRgRAxsaIKiXseeaX6k=; b=hq5LvQ+D6AKVE1Dc2y7uZfgupE/gwFlV51ds/Fqaf9nwEgoat+i/Pre+WjP8v2GovCIoeW tssAwrAepBXVRt7XqEC+M1YNz57c8qLLr2HI37D5wSmUf/vm98CPI69W88DzBUXQpcSCY0 BdtMkpWodKgL8FgyperSuZaLqWED8zs= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=vigovproductions.net header.s=mail header.b=iTkoFPC8; dmarc=pass (policy=reject) header.from=vigovproductions.net; spf=pass (imf24.hostedemail.com: domain of mgkeyes@vigovproductions.net designates 86.43.91.159 as permitted sender) smtp.mailfrom=mgkeyes@vigovproductions.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682894498; a=rsa-sha256; cv=none; b=FDP5gn6M+Wc5aSf6ErDf6u86j/ytXZtjglJeSL9gzt8lp28OwGEQjPMekWG2zpZ8AzF8oN QBtXi96RmMSiLOv47ybxYZjA89eaVdZTUT5KOpofGRYZ7731tOmxZkF7tSSMXDWRBPxB1X PNyDZfYGueLRBAW1I0gwa4mqAhHazBM= Received: from vigov-webserver.vigovproductions.net (localhost [127.0.0.1]) by vigov-webserver.vigovproductions.net (OpenSMTPD) with ESMTP id be784070; Sun, 30 Apr 2023 23:41:35 +0100 (IST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=vigovproductions.net; h=to :cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=mail; bh= juXyoiof4ex/uZvf7aBY5+aQaAo=; b=iTkoFPC8xWMvBjg2WoxloPHwvnMZLdRb Lk/oxT1NmYgFohaeRK+G48wyYdD97pn7IgYUTd7VwChNvzdJYFz7BTKDxafbXKe+ gwWBWkzkBGoH+N1aD7D+XmmnND5WSnHl+kqRUkEhY43rqxqutfpokmeIKFbC5shl xofJt2MUSAS+mziW7c0uwhsvAqjwbxQJ5GzmMQ5oH9a+P9fIftTT6E7sAFpUH9AG vmQ2Cqw5mG3RrbnlBnwmVX2xYBEknV874hNR40TkwrkMx0+8LqdT6wbwU2f3//Ks rMrMbqE8PodPxLtbx/frQBazyvFnXIT30jObs0oVQ7zAuJvVasCXdQ== DomainKey-Signature: a=rsa-sha1; c=nofws; d=vigovproductions.net; h=to :cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; q=dns; s= mail; b=Li2USaB56wmXQTAb8AvXbMvISqCk2YHGynIPV6Bhr+ijkwUakwYc80/Z gFqOcLyWOXTiq0lJUctts0pC5VhY1/57NSRkl+hvLK0KSjt6sgSJl1Uy+kLwj1Kd 4Vu3DCGcchEzk/GRQ3dmWlO26M+/Jr0pcVlRNQyU+ZGPCCsmYvqJ4wC7GaoKlVVZ sHZjF7PLTxsWWTGF+oxJ+8FdLdLIA9iE6sQQcCbnfru4tFuGNbkTrKGdH8W1XfP4 7pZgCCfgwmXoxo30iy0UKU5LqroWBRjUl51U7a1/MwuS9PJWTHfown97jAD/xhWL NjCkhoXcEQszW1VqqijnfGvPe6HFPQ== Received: from [192.168.1.52] (www.vigovproductions.net [86.43.91.159]) by www.vigovproductions.net (OpenSMTPD) with ESMTPSA id 416617b0 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Sun, 30 Apr 2023 23:41:35 +0100 (IST) To: Tad , liam.howlett@oracle.com Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, rick.p.edgecombe@intel.com References: From: Michael Keyes Openpgp: preference=signencrypt Autocrypt: addr=mgkeyes@vigovproductions.net; prefer-encrypt=mutual; keydata= xsBNBFbRwEIBCACtizW7jkoD17g0VZFc+pBoevENZSJ6um8pNY1KEzmUOjHpz3hM+4qYp+/O XdmDOuh24n9yegOjy/29ILifLeAmYbzDI/a7+2HHtcOX6ekCWpEaS3tuED+4q0qPPBeN407C LVGh4aJqlphQxRcOVduJv1qmxFzuNjLbkL9JVcjQ7iuJgKr3yUp766gULp95z10GmlpogkEV 2av19L8nHOjMqS+cXZYuqnks+uNEduZNg9U8alVF4Z61DZZO/69XBN3y+fUDZkB7RNIWPkhh qbpWwR1wB8El+ZmQveLX64AKp7+y9ouwdlfYxQFFjWcJDnhYlBeFN+3FrFnvWGtrrO6vABEB AAHNLE1pY2hhZWwgS2V5ZXMgPG1na2V5ZXNAdmlnb3Zwcm9kdWN0aW9ucy5uZXQ+wsB3BBMB CAAhBQJW0cBCAhsDBQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEI0xE/fTb4M8SpoH/RGS 0SdDeE/FCFY51HNvRs/DfPT+lkpzOmvRz9VghTG1uAJ18XhGZyloj4Y45zvvfwuIZ4h4/Rs5 hUGZvUNdzqqTsKv1oVzvf7Jk/9Y8ycnfuXHO/QavpKCj5LnRIT0WUFU2tezDs4fwcqw3wXbu iz5sa+jTCSNkH6WryytkDx8CSq4KftgjB/uujvz3YMExvS7JjyPSnLsVYXws7HlHvl4u9oMD aCfci4bp/0i8oL499yUO7HC5jQwwkP9OZbAlgySPErEpahXG9Kx6MD82yy1JHdLmePyc74M8 U1k1FKABvjXEigoCRzjVtyiINCpNv6+kMS6M+fQMLuVM5gQKKLjOwE0EVtHAQgEIANgZcP6N Zy+jGkG4xp2Cs2E0SndXI4BV4HD6BZhsfQdrluhv058pdkz9Y081v6NzRTFuqeOCNzp1lftS qwA6UzpshTQB2SvUk1H/mwdEWhG8DDf4FFtde4m5nEvr0Sj/ZIzaynQIUHzQBnuuS1y4Btyi yQGFalRwQqcnuWJ+f+/zj9haXbdWPmZdSxIeO4C3v6+leh/cWdNjFt6xtWy546QkW9IZO++m 31+DdxlxwlwZQZrrV6orS60HWB4IYJBI0W5/z3EBlqJ026eLiWapYrNtrJyePI9pIP3diOd3 m6WiFSZELD3YSUHOSvcBoBfkl7LOUALLXKE3/CRucN7sH3MAEQEAAcLAXwQYAQgACQUCVtHA QgIbDAAKCRCNMRP302+DPM83CACTbzcLgrHEj5So0+FkSToc3pO5KOH0qLu9fA2TTY3jjM5U BproFhlDR3nrZBrtveN7B6ni7efOgZnFlSYfJBLnDg0joQLqM4DrdBJLsGo/eAomMJbLMWSm fSQ6VhIISNgPoh7db4HyACfr0SpBmK+OmkMB/yIhtqFjYJ7+Ms1IUd2TMlpDYaP98zsf4Hl5 A2ClhHpU+EB5AjCA+inVSwtj7NLJC30UOTJV9IbFwhPml/OdwZoSntWGY2OTIuBnt+3XbuHD zg9A46AXrTTLkqWrUI6IZtApqJd4sIXytnvf0W8MZ8pmP9wX7isvmychTrQ4JsEFxc3e1Sm9 m3gn/II+ Subject: Re: [PATCH v2] mm/mmap: Regression fix for unmapped_area{_topdown} Message-ID: <90777046-a420-b19f-1847-d353b9938131@vigovproductions.net> Date: Sun, 30 Apr 2023 23:41:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D7734180011 X-Stat-Signature: 8c9oj3q5wwip6fhb1nhyxcuoaz4y5chg X-HE-Tag: 1682894497-723845 X-HE-Meta: U2FsdGVkX1/Uq2xkGCAX1reIWeMdGUJ9W16xwAe3lPsj5I59AE/k9UZSWYN/bhL7y6bZn476CtZ4ecGSqYb+V3e8F8ZjJX/Qmhxngc65nXTCjx7vtuuPdW3swm8mI+k9aTHwPl37vIbss7HkFqEIn4cPgBstg7SBsQXEy5Mysep3l6ReoX/b8i551CF6Qo5bg3yeQuaRAJvEgzwclSmLnAIo60u9n5tR10jFLUn0NjHswc8SjWuIOAaGLk76bAsS35e/CSqpCQ7zWWGjFyUmRNwUkUsOvFGD37vwX90Oopn9ah85M5b2MXSrxEjT4GTN43lEFsunTZDoZBpSFnyV4nrNeitQiEBSNXDqwyvvwKfAw8P8JRboYit0tn8L/5sLagdxpk+3dCdUXy/h2DjsNibnwlklgWj9ArDwM/iYxWzUmbsDfccJPVQHqfFqxdN7Zp+WDuMegehhJbya8eie4rD8lURSE5eBx1wk6qH9UzzWoplZYiYB59DoSUsZzOp6llS7k/0WxsTIQ6uib60yHBWZQCrNlRJAkOhQqtbqmZbqmlr5DNk9TnVjeAaL9Ot7Urb7R4zWIPeSyaPccvXkGEhuip41z3BbuVMIMYVSRLV5wNY02uxD+gOrd4+Guzgubx1Z4LZ3K2Ui/CVdwJVpMBI/eLYP8G6DsQWs2FJ0yD5qXrjx/TonQDdTPvb9uqExvewCBPtmqwZ957mr8OVS78M2z8DeF6UAfOzblrQlioSuGpkcLm2LyXdvj9lX4kFF+kYdFR/VQdsd6aw9SiNmD/53HkIL6i1+X+Ouc6eyk7msiPxAN+oRmFgRXqxi5oPkOkiozqETkmUPff1rBNFL74gsrSyytNAzfHq6AzZzpOQRLXrD6leAOB4b63y21ZJWbKaHK2qilVv5owHHZf3af+QUV03v2UC47vK9X+cq5goYnUgyLxByw4MT2gOe3Vm5Pt4RzjhxIfPCk4M870V gP8LXxW+ tGseL/2WXbBtE6OggJiuuzvq3mzzwDCjdLB8hG/j0/y2Q4bibYWYXIfq/RWMpwqLNe276tVKejJZJhgJzrePRexRayCV9mGINdeQE4numjQbqX1RMIGqMAjK46mb/QZ1yjlnkNy/InVCKmW5vuAOCHltkP5CYFNON2IoCiBW2/lnvatTF8+9HSCcn1VPdTxJhSoWtou5HCKb5i1RrmelwPvtVhiJn3DsziyUAexBk6SCu+IAlcFqhF5tdtxRkFDxe5SC793E8VK3ni//FQ5RPPtTZEKo1nerB9IHMeGIqJsJAOQ9lB4siHGaC/BXdR9EvWIQ4mmP7VEdlD78z9o8wWW3mv5Z0Xu9n9g9XR3EZvbjYG1IHSo4opCakrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000030, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 29.04.23 15:32, Tad wrote: > This reintroduces the issue described in > https://lore.kernel.org/linux-mm/cb8dc31a-fef2-1d09-f133-e9f7b9f9e77a@s= ony.com/ Yes, I also ran into this (even though I'd somehow missed it the previous time). Apparently the issue arises at mm/mmap.c:1582, where low_limit is set to vm_end_gap(tmp). Occasionally, this returns a 64-bit address (e.g. 0x7fedea581000), which is obviously greater than high_limit for a 32-bit mmap, and causes the next call to mas_empty_area() to fail. I'm not sure why vm_end_gap(tmp) occasionally returns a 64-bit address, or if the best solution is to just check for this and skip the retry if it occurs=E2=80=A6 --=20 Michael