From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD785C433EF for ; Wed, 16 Feb 2022 03:02:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CE5D6B0078; Tue, 15 Feb 2022 22:02:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67DD36B007B; Tue, 15 Feb 2022 22:02:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D11E6B007D; Tue, 15 Feb 2022 22:02:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0156.hostedemail.com [216.40.44.156]) by kanga.kvack.org (Postfix) with ESMTP id 376766B0078 for ; Tue, 15 Feb 2022 22:02:32 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E8AE79274E for ; Wed, 16 Feb 2022 03:02:31 +0000 (UTC) X-FDA: 79147144902.15.9B47844 Received: from heian.cn.fujitsu.com (mail.cn.fujitsu.com [183.91.158.132]) by imf23.hostedemail.com (Postfix) with ESMTP id CA4E5140005 for ; Wed, 16 Feb 2022 03:02:30 +0000 (UTC) IronPort-Data: =?us-ascii?q?A9a23=3AVyhoJaxH54bFJIxjJOt6t+dIxyrEfRIJ4+MujC/?= =?us-ascii?q?XYbTApDhwhGNUyWAdWTrVPf+CYWugc9AkPd7lphwGusPUm9ZnHQtv/xmBbVoQ9?= =?us-ascii?q?5OdWo7xwmQcns+qBpSaChohtq3yU/GYRCwPZiKa9kfF3oTJ9yEmj/nSHuOkUYY?= =?us-ascii?q?oBwgqLeNaYHZ44f5cs75h6mJYqYDR7zKl4bsekeWGULOW82Ic3lYv1k62gEgHU?= =?us-ascii?q?MIeF98vlgdWifhj5DcynpSOZX4VDfnZw3DQGuG4EgMmLtsvwo1V/kuBl/ssIti?= =?us-ascii?q?j1LjmcEwWWaOUNg+L4pZUc/H6xEEc+WppieBmXBYfQR4/ZzGhhc14zs5c85K2U?= =?us-ascii?q?hsBMLDOmfgGTl9TFCQW0ahuoeWefCjl65PJp6HBWz62qxl0N2k6NJMZ9s55G2Z?= =?us-ascii?q?L8uYSKSxLZReG78q2y7KTS+9inM0vIcDneoQFtRlIwTjfS/RgXpHHR6TD4MRw3?= =?us-ascii?q?TEsi8QIFvHbD+IVayVoahvoYBBVPFoTTpUkk4+Agnj5bi0drVe9prQ+6GuVyxZ?= =?us-ascii?q?+uJDrLtbUf9miQcROgl3eomPA4nS/DhwEXPSfwjqt9mmwwOPC9Qv5UYQfUra46?= =?us-ascii?q?9ZtmlSYwmFVAxoTPXO/oP+kmguwQN5SNUEQ0jQhoLJ090GxSNT5GRqirxasuh8?= =?us-ascii?q?aRsoVEOAg7gyJ4rTb7hzfBWUeSDNFLts8u6ceQT0sy0/Mj93yLSJgvafTSn+H8?= =?us-ascii?q?LqQ6zSoNkAowcUqDcMfZVJdpYC9/8do1VSSJuuP2ZWd1rXdcQwcCRjQxMTmu4g?= =?us-ascii?q?usA=3D=3D?= IronPort-HdrOrdr: =?us-ascii?q?A9a23=3ATw3XBqNG1Rzw+sBcTv2jsMiBIKoaSvp037BL?= =?us-ascii?q?7TEUdfUxSKGlfq+V8sjzqiWftN98YhAdcLO7Scy9qBHnhP1ICOAqVN/MYOCMgh?= =?us-ascii?q?rLEGgN1+vf6gylMyj/28oY7q14bpV5YeeaMXFKyer8/ym0euxN/OW6?= X-IronPort-AV: E=Sophos;i="5.88,333,1635177600"; d="scan'208";a="121582272" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 16 Feb 2022 11:02:28 +0800 Received: from G08CNEXMBPEKD05.g08.fujitsu.local (unknown [10.167.33.204]) by cn.fujitsu.com (Postfix) with ESMTP id 2F6C64D169D8; Wed, 16 Feb 2022 11:02:27 +0800 (CST) Received: from G08CNEXCHPEKD09.g08.fujitsu.local (10.167.33.85) by G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Wed, 16 Feb 2022 11:02:26 +0800 Received: from [192.168.22.28] (10.167.225.141) by G08CNEXCHPEKD09.g08.fujitsu.local (10.167.33.209) with Microsoft SMTP Server id 15.0.1497.23 via Frontend Transport; Wed, 16 Feb 2022 11:02:26 +0800 Message-ID: <905fd72a-d551-4623-f448-89010b752d0e@fujitsu.com> Date: Wed, 16 Feb 2022 11:02:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v10 5/9] fsdax: Introduce dax_load_page() To: Dan Williams CC: Linux Kernel Mailing List , linux-xfs , Linux NVDIMM , Linux MM , linux-fsdevel , "Darrick J. Wong" , david , Christoph Hellwig , Jane Chu , Christoph Hellwig References: <20220127124058.1172422-1-ruansy.fnst@fujitsu.com> <20220127124058.1172422-6-ruansy.fnst@fujitsu.com> From: Shiyang Ruan In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed X-yoursite-MailScanner-ID: 2F6C64D169D8.A1823 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: ruansy.fnst@fujitsu.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: CA4E5140005 X-Rspam-User: Authentication-Results: imf23.hostedemail.com; dkim=none; spf=none (imf23.hostedemail.com: domain of ruansy.fnst@fujitsu.com has no SPF policy when checking 183.91.158.132) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=fujitsu.com (policy=none) X-Stat-Signature: 5jo49hhgfgunx63aug44ndz6z8nad6rn X-HE-Tag: 1644980550-957438 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.029287, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2022/2/16 9:34, Dan Williams =E5=86=99=E9=81=93: > On Thu, Jan 27, 2022 at 4:41 AM Shiyang Ruan = wrote: >> >> The current dax_lock_page() locks dax entry by obtaining mapping and >> index in page. To support 1-to-N RMAP in NVDIMM, we need a new functi= on >> to lock a specific dax entry >=20 > I do not see a call to dax_lock_entry() in this function, what keeps > this lookup valid after xas_unlock_irq()? I am not sure if I understood your advice correctly: You said=20 dax_lock_entry() is not necessary in v9[1]. So, I deleted it. [1]:=20 https://lore.kernel.org/linux-xfs/CAPcyv4jVDfpHb1DCW+NLXH2YBgLghCVy8o6wrc= 02CXx4g-Bv7Q@mail.gmail.com/ -- Thanks, Ruan.