From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30B0C3DA4A for ; Fri, 16 Aug 2024 10:21:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78AC68D0068; Fri, 16 Aug 2024 06:21:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 73B1E8D0066; Fri, 16 Aug 2024 06:21:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DBE28D0068; Fri, 16 Aug 2024 06:21:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4191B8D0066 for ; Fri, 16 Aug 2024 06:21:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id DC3B1A18CA for ; Fri, 16 Aug 2024 10:21:26 +0000 (UTC) X-FDA: 82457716572.26.C1DC1AE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 53ADF80025 for ; Fri, 16 Aug 2024 10:21:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YGEMQvfR; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723803586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dZeVJV1/flJkdL8JPpnGe9cmRQqqqzWPB1mzyyDgeQY=; b=R7t2CTAD835ZMd7uH06U9z6lrGTGyCYZaxxDcKiOm4Ceua0JSRXxyz9XLvbDVQNEQwZcWw 0qdqd4xFKn3oOeeKTqkkn5gqzBPX3Nj8Ufh0QmHLceq0UiR/XAygsPBCeOo3PX8g83nOL+ tCdzFC0dDG80GWU751lVXUb3QJddngw= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YGEMQvfR; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723803586; a=rsa-sha256; cv=none; b=SNO25XNneRmSECw1fXKkIBSq1/qDvG33nEJG9tsP9GskjLQwCQbBaUx+v1DXpmKAZU3dfd HdpnHbL//n2PpC5IdZEY0sBxBjjrUbH+dv5KsUo39Zq/aXUIOTZIal2ot5ZAn3J8MyPePn eHcOZt0UV9GDO0o6/clmkNowkNrJ5B8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1723803683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=dZeVJV1/flJkdL8JPpnGe9cmRQqqqzWPB1mzyyDgeQY=; b=YGEMQvfRXawjBDH8OrS+vxd7DdpuWeFp1A9rn6ZyRBIfOU1TIX1PoYMENRCjJnMkCuczHY VDScP/uFdERhOgfrpA4SQFE5lzJnAQ5aoVMqOOAbfThnZDmhBfUnzSSqsbkM/y5HTnEdFL 7CB3onGIywSPhc5h8mv0zvg9EojPrgk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-wuudhHDFMSy30A2rKGjD_A-1; Fri, 16 Aug 2024 06:21:22 -0400 X-MC-Unique: wuudhHDFMSy30A2rKGjD_A-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-428fc34f41bso12819315e9.3 for ; Fri, 16 Aug 2024 03:21:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723803681; x=1724408481; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dZeVJV1/flJkdL8JPpnGe9cmRQqqqzWPB1mzyyDgeQY=; b=Ilb27osgu9KbEIjKIr+euMF2ZvBvAA8H5Xag/9oRcSiqLAd9X2tOr1K68MO0uIQ/zr fQmO4TXEsIzHcZXqSnQNLDNodcUhfM6ZGbfJ5j2argXFHVCUz4GynMGiXK5At7A4xBnB qW1yz9+klrBUasMXw9OqQusSKf8XX6SACDeOEXjktuNyuyjV4mc5DUv16oXGoXjpN/M/ qwBbHiYJ5fAlS8i5jqs2dHyzIrLar02AEWxlvFTeujqzb+Cs3TLQ+cS5tH+z5gBDHcW4 YCdL/cMq6hnRr51rQTqHJ2eQh6FCXy7Da5gnvPxk0DmHubgo0odyHowd0gnCwc2qBjCc Zdsg== X-Gm-Message-State: AOJu0YwdF18yCWPAJGCDZFSjXBKqe0pDM6Vr+sjpGTzbj6PFWxSHjvNA ycQbeUsixgny8nTnGN/yy3hlDCdaGFosm+lCiWq21UDe1Q0kb4UJVhDQuTgdH8qiOL7g79sQykA 9Zx2X00QwpGRTfJ2MskGPr1epR9LytDqYwfKMkMN30h9aBKDK1jUJ4MXLx5E= X-Received: by 2002:a05:600c:4688:b0:426:6ed5:fd5 with SMTP id 5b1f17b1804b1-429ed7a5f5dmr15838205e9.6.1723803680985; Fri, 16 Aug 2024 03:21:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbTEEr3Iw1qrDKn60q1vYiJxeQxy92dQpVFN6gDXWHFSHPqexbut7JBDu9FRkvgSyTEIRruQ== X-Received: by 2002:a05:600c:4688:b0:426:6ed5:fd5 with SMTP id 5b1f17b1804b1-429ed7a5f5dmr15838005e9.6.1723803680427; Fri, 16 Aug 2024 03:21:20 -0700 (PDT) Received: from ?IPV6:2003:cb:c721:b900:4f34:b2b7:739d:a650? (p200300cbc721b9004f34b2b7739da650.dip0.t-ipconnect.de. [2003:cb:c721:b900:4f34:b2b7:739d:a650]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-429ed7841a1sm18783995e9.29.2024.08.16.03.21.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Aug 2024 03:21:19 -0700 (PDT) Message-ID: <905d6a3b-d0ac-4e5a-979b-40a49e345305@redhat.com> Date: Fri, 16 Aug 2024 12:21:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail From: David Hildenbrand To: gaoxu , Andrew Morton Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Suren Baghdasaryan , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh References: <883bf552-f339-474f-805b-4355ef49e526@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <883bf552-f339-474f-805b-4355ef49e526@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 53ADF80025 X-Stat-Signature: cunsch5ew9np6b6qjru3mchwgqfokw6o X-Rspam-User: X-HE-Tag: 1723803684-309551 X-HE-Meta: U2FsdGVkX18SsGt6kuHL3ueEGODwh4u7bhrxysmLKaOp9HPDLX1sWqV8hxOLiS4yyJiKJZYr8sq7UPkkaHQ1nmRPlPa5kPqGOvT3FrN/cgOYLXM95QR5sgJh+HCvghUyOgVHdkUaXWZ39pip5Vt82p/Ga+VgR/s5zaOImjrenQusDs/9t8MdIZK+OYGLrr2UFEwNwJRujBohFBqUeO6nK4nq1K2fMwaTCR1RPxZUugvBq2RahXSKigT1pMdlc+XurSY+kj/AxA4QwaT8Nc+dqEhPJ8RRm5m+w0R6s2HRISBPCXK9mSFVEosFAqZ2dmIsLUwQwi+CYJNgkrHbWdP8qancRwqsNbPCiA2+CA3WkQR3a3+SWTiuYSGM8Obz35qJ/RPlErhNCeiFQcHLCQZzkXASUVU28igPMKLeGFRlZlQLF/JzYpYtzJNcK98t0WBhuBSahrkah256e5bDMD7NPDa1jPiR3Rlkv3LU35hO5BVcG92GJMmsYzMBflyJMbhs7/PGCdenKSSeSzoAs6ok2+WWmliu0Qt6gsBYRZoR4NXsBH3NUktChrYLqI6cLBs5f2aI/NxpS0lhgqf4pjBFpmOsod4zohxsDV4t0+5B4dQRQ7PF4zglmPPAbna3z+gZAr0uA107XRfjIYv/KrtC1Uwy++IRbt65gcM0Um6p6VupAxqkPvcWD94S0INaS6V8JrbZvbegy61YgywTg8Jk3Zgb/rSzwuD3LESIjE1ti8rYbCrx21qo3vVWLAtRcbBm802Wb7gdjPeBbOODq0HR50m3Ja3tHgHUvAHeZTYjb3toQlBFuhMtqDIfB1wMdjA+y3nGMsNwIVw2YeLCn5zMegRjAJk7C9j8NgHpZmNbItXuexw8ZffH/cNxYubtplbQkD4ICpWH/Ksi4I8enuDAkSLR97K/EwpyVi31bi8ApnHfpTcP4Onblr7FT+1JFSdIIO0AMZPCI3cc/JE387T gq4NgVdZ 0SDm4ZihxqK6Pl2297nkmBv49xZS6lBAHm8ugLhqaCpBZ9dZooHYZrDKSTGA0a6gbWKsqto40kOPSp8RugOVPNWO6OmllhQae4OcsEiFmPr5FdpmIOb2IlufOZlXcMIwH1GaXPd+I83wDyDapF+LRKlH4IsymFrrT/SBzHD2abwCxs5PIakl7LiXjB1067jL+VyuONb3XqvmpzP7BvX+QhS6pbKHwA49PX72INqd0isDC4W7+xfQiHV1UBqHbM1FTKbjquD8M7K+jcms4yk3OmYKcl+iGX2oF6mEWfG4ffN0kBM0ZEHGS0CyiEEbn5E4vDo4EneuMoQADLVX4nTsnDDgRZH8icqZme0pCfw2GlqoflYVXhFN6NRFjbRE+fr+CNdi9FRn2i9jW+JltYzOt/bsukRRSo8VnoHO4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.08.24 12:19, David Hildenbrand wrote: > On 16.08.24 09:48, gaoxu wrote: >> Replace lruvec_add_folio with lruvec_add_folio_tail in the lru_lazyfree_fn: >> 1. The lazy-free folio is added to the LRU_INACTIVE_FILE list. If it's >> moved to the LRU tail, it allows for faster release lazy-free folio and >> reduces the impact on file refault. >> 2. When mglru is enabled, the lazy-free folio is reclaimabled and should be >> added using lru_gen_add_folio(lruvec, folio, true) instead of >> lru_gen_add_folio(lruvec, folio, false) for adding to gen. >> >> With the change in place, workingset_refault_file is reduced by 33% in the >> continuous startup testing of the applications in the Android system. >> > > The patch subject does not match what you do in the patch -- at all. > > "mm/swap: use lruvec_add_folio_tail() in lru_lazyfree()" ? Ah, sorry, I read it too fast. Yours does make sense :) (mm/swap might make sense, though) -- Cheers, David / dhildenb