From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 893DDC3ABA5 for ; Tue, 29 Apr 2025 17:25:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B87846B0010; Tue, 29 Apr 2025 13:25:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B37456B0011; Tue, 29 Apr 2025 13:25:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 912186B0012; Tue, 29 Apr 2025 13:25:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 65C856B0011 for ; Tue, 29 Apr 2025 13:25:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9F1F1BA1BC for ; Tue, 29 Apr 2025 17:25:04 +0000 (UTC) X-FDA: 83387756928.21.E931FA4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 2B2724000E for ; Tue, 29 Apr 2025 17:25:02 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tg1nYMSZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745947502; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e/bLyArrocjzIsxdJa7jG1qfjWAEQUi1ZPYPngioU1o=; b=dV8PU1L7WjoTF4HDIe0MC2ap1mm4JI+QrJP12Q2CQJtfzeJrcxOiC4vQwPw9exGIjc9krS s0+wmA5MFa2oz5hPxKVDG6AaAtrlkONLDBhQyhEED/7t9i2+7TGq7oNvmbJLElsHkbkw0O obO7QdmY5yljeiPWWKFh6S3mPJKQSvU= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Tg1nYMSZ; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745947502; a=rsa-sha256; cv=none; b=EKduyzG0wT2gscsqZyGlfiGX6jitf6iVC+MAckPhfoP8qCO2pvNyofU9YeXBd0D1fa56pv NA0eNwXNko4TDss1vswmLoMpxEKdBpImy46CYEGjOP31EdN4smEP/SguIb+n74Sg+n3z3D TgYOI7NldSuxoo6E/o3GWcTL964EDSU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745947501; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=e/bLyArrocjzIsxdJa7jG1qfjWAEQUi1ZPYPngioU1o=; b=Tg1nYMSZuNM/C89PtmT5chS1DqpxMSez69VDsAM9Cnvz4difkEAzFqA/7lyIlcQlnlIKW1 dG7JjgSzUQ0Uu6eACY78XMUZa+gTpm9fUfs7nY8U/AHbu301UC0bNIfrDZdGwtrRg3uo+D 1QbuNz2gt5b3nfG1/fNY/Ki3hfDU050= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-325-FrnbnN4SNNyMtpELJG7VBA-1; Tue, 29 Apr 2025 13:24:32 -0400 X-MC-Unique: FrnbnN4SNNyMtpELJG7VBA-1 X-Mimecast-MFC-AGG-ID: FrnbnN4SNNyMtpELJG7VBA_1745947471 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39135d31ca4so23925f8f.1 for ; Tue, 29 Apr 2025 10:24:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745947471; x=1746552271; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=e/bLyArrocjzIsxdJa7jG1qfjWAEQUi1ZPYPngioU1o=; b=vSOjR5P6YDF1+06xopfCgCwKRIdC9FnDIateGJ6CAcYR3A/suy5M85LzgHFDdJ6dkw 05CKXrhXzlZSxcwZ1Zd/6jkcweCKUNLks0UQ29WaFskB49jKBO4P5NnkcbXTWGCcMqbx laKJ6Nag7qGqRZO00xFjac1prVQR05sXvaQo1dM84W/uv9zQ9fW8eZfBriKx/SxTGXcZ OBTkJUv78ug4bmWLr4cGS7IkOPFehThSIpp3iBRoGh0ktNnQ6ddC+HiHr8b8rBKL8Gav 1X794o7yS74W0dfQKNzFbMnlG06DKlm8rJWS50g7v5dt/FU+g7WpY7rscTndJ70rsgHO KP6g== X-Forwarded-Encrypted: i=1; AJvYcCXOwkmIGwSPm0qiK0YmKVYLEoMSzZI40EIIrpeGowwSHzrgOz81stIarehWSyuvsEV5/xwoBQYPwA==@kvack.org X-Gm-Message-State: AOJu0Yw8HTV9lZyF1PmaMmZj+ZH/DL0ia6//3nNXm0eCRMvUs24c40iI KDVx+JqFQXksAN7SWnqzAFsvmbX96XSGNcyfPxyvCf5bzHrZpEFHzcQbAH5j4G8A1eqNcYvxXJl knmssjoUy3eUJlcpOw8OWLxMa+ItWQyHzZrXMstvX0CAnb7B3 X-Gm-Gg: ASbGnctKHuNOKkHt5cNSueiqevQVzPby91ouv7+9i6i7UYLrKFNMva8Y9G9422cYa/X TuHC91rt8aP7cqjL2drsZoMLpfdFRS1sEiNiP8JoqCe5c2emgdb2YfFHiNDccpKQj9na/weZYGI CShMDsEDsFs5HTCeWxEpVe7phTLbcm/Sw1ycjV47SUENFExMIH4ZywfKl08JPsOMnlUNW+vh59J KctwxOw1m22MLvr+w3TUfDN5fKBwuBR8ssX3+EEhVYilH6gkrE7GhyATtwRc1qDk1p1BoE4jcEm ovEJRl18JtjfFxQaif5NEI5HlZgNOwoyKMAJblaOrngd1oc+bJxKkh5/5r+hGuZKTEHGfSG9397 SaWrt6ywS9Vu3rw9D5YSN069mCxQdnewqfmjHbWs= X-Received: by 2002:a05:6000:144f:b0:3a0:88b8:276 with SMTP id ffacd0b85a97d-3a08a501c34mr3475544f8f.3.1745947471500; Tue, 29 Apr 2025 10:24:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGE7ui2XecAp7z+5YQCQ/G12l/zKaGk8AEgJ6wB0Jn+XqH6LadxEqe+Pn4apy1YfTj5fBzHZA== X-Received: by 2002:a05:6000:144f:b0:3a0:88b8:276 with SMTP id ffacd0b85a97d-3a08a501c34mr3475529f8f.3.1745947471138; Tue, 29 Apr 2025 10:24:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:fa00:8909:2d07:8909:6a5a? (p200300cbc73bfa0089092d0789096a5a.dip0.t-ipconnect.de. [2003:cb:c73b:fa00:8909:2d07:8909:6a5a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4409d2ac27dsm197171435e9.22.2025.04.29.10.24.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Apr 2025 10:24:30 -0700 (PDT) Message-ID: <905a7c96-a162-4dbc-8592-8d040b398cb0@redhat.com> Date: Tue, 29 Apr 2025 19:24:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 4/4] mm: perform VMA allocation, freeing, duplication in mm To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: diRdmWkScIdx0BA4BTEToeDVKAGKYLwmWFsiYf1hlKY_1745947471 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: zojemsooc4wpx651cf6aifw9njm89ymn X-Rspamd-Queue-Id: 2B2724000E X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745947502-821962 X-HE-Meta: U2FsdGVkX1/glch/EBSZA/vhgQXXth43J7xTzRnQ4FVGAuqsSd5IHIFQIoZVFsJHPWEK1/c0GSU0PSNjne+uPuQ5Tb7x4cn2DDpEHlWeAOHJHshAdYPWWiCcc23JhEIh+SREzHDKAoR1bjkNgKqy91/T25uBZIvWgpN1grbU7qdhH2HrBlmu1XJonBroFFHpVPJXw/FBaT/OEo4KywLVQhFOGwq8BcyUjJ8UQLTIq3k3G0d6oWwLu4AOD+aS6UDQFS72/86wxSc4x3clpjAmDVJ6K6HwLzRHtmAoavCgolYDnRY7TRMDKOAUSUygmXulcQ+vpuaXBAtcIIxXNHchED0zegPfYQMnL0/+CMR74e1mSzkKQwTpnXGkhtCUgAMAZRPUhimdVEd0RmYRKAAh5EATqMA8ceaaY63s9clYMyceh74YxR8D2eamEV+ehhp1fN06kQyoicYU9mLEg3rgxCaLN5EqBRfuVz01nPgdxG3dpO3PjHb05URWvOpHXen2HpRwoNpcUAF5RNjqgsFJjA7Bd2gvFBQgGhcwGj+CtsgdkCUnadwjjsLMeVZMsbKNI/gSDTOL+Ofb0mF5lgDKx4Z5TnAeFeMd5LDYe34MvLGSWCJdDlt5njFZnYtN42pOwQK+BYN1TX2NOPbzhF5C+PLbYjJGFUKirmQvxR+16ZiNVslu3VT2OsK4TD03iq0XAQEZgp1W64CVmYSlaAOapPtyNl/2HRgebsw8XtOkSGb72Dx0xlFzrkrLGSbfxwVH4IPv9vg8m91QbUbPEcc0wC/YD6uhm7esdgOcr2AZX54daiJWspzYOUPUD1QlGflzJI7x/AZ9J5HaSaMAYJNbJPu/KqM0armGyois3WK4mvVcLxAawUq3p7UGv6Q3YCyFaintqY7yqz+CLVVXDl9Udy0SSeRsWLsjU7W8g1QIJ0Uf4wwqcWUfWwZXtG4mxyLtaOGPhrWLRlY39g0//wK tHwvHHfZ h0gdjJ8X3QKLtBDHMAYWDopo/Apl2snddx19Bni3LRBU9fbshSESTGd/Ti75XFZQpo2Zc0fjCEDcNCpVKEnNT4T3rN9L6pfLeUinCNhJEtc7MQTITCgpjZIAQ0s3LsFZskq59JHcwngduknMrTXrB06r1LKcKRwTnDaautcc0dl9/k+LhoUSavM7hLCYp20SKh9UKB7smG+CZ6CUbk6EMAXtQIzOf+EE5six8lZZrovmPYqxjsDvfjDVIPVPZ+dG/7AzwSzCJ2s9jTV6DzU7xHZ7v0wTkIEy08+KkNjB5TAwNNynocHFiX1tW7P3rObMsFe0YiCRh1PA2jlwdBwxlGKr6JbtSw80JBjbQoBn5yvwNQmZ3YJBfdU/Fw1c/pQQoovANmhWPauK1zAjqM101g5Ju9bzu/RJs5tqeUK/dBsrJh9f9eXF3CUjyeSyTpLZfOGg1e/xgGxA+jrs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.25 17:28, Lorenzo Stoakes wrote: > Right now these are performed in kernel/fork.c which is odd and a violation > of separation of concerns, as well as preventing us from integrating this > and related logic into userland VMA testing going forward, and perhaps more > importantly - enabling us to, in a subsequent commit, make VMA > allocation/freeing a purely internal mm operation. > > There is a fly in the ointment - nommu - mmap.c is not compiled if > CONFIG_MMU not set, and neither is vma.c. > > To square the circle, let's add a new file - vma_init.c. This will be > compiled for both CONFIG_MMU and nommu builds, and will also form part of > the VMA userland testing. > > This allows us to de-duplicate code, while maintaining separation of > concerns and the ability for us to userland test this logic. > > Update the VMA userland tests accordingly, additionally adding a > detach_free_vma() helper function to correctly detach VMAs before freeing > them in test code, as this change was triggering the assert for this. > > Signed-off-by: Lorenzo Stoakes > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb