From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4699C4828F for ; Sun, 4 Feb 2024 01:52:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B6726B0074; Sat, 3 Feb 2024 20:52:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 265D16B0075; Sat, 3 Feb 2024 20:52:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12EB06B0078; Sat, 3 Feb 2024 20:52:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F18796B0074 for ; Sat, 3 Feb 2024 20:52:48 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5CA691C1002 for ; Sun, 4 Feb 2024 01:52:48 +0000 (UTC) X-FDA: 81752447616.10.9FDC962 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf30.hostedemail.com (Postfix) with ESMTP id 2260D80002 for ; Sun, 4 Feb 2024 01:52:44 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707011566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZUf8nyeaLrZCrfsK204Gc/Zf60Wn0W6E9wqVnaj2u+s=; b=AG8sQl+6gbrDeBnA30+L15MQkLb1BAweGfBZYW9hHXta9qPmaxSQJ5+OJsFHVdqtxVN5/o 46b24+BZ7vakA+9PNAsnFoLbnuHzYIuaxyp7lQhWVgM4RrU57W/iE/eiitzokEFjovNvRn akpHpmtLHkyONwLZ7UkV0hdyxc1Ncrc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707011566; a=rsa-sha256; cv=none; b=lkh9irK/csAVm7wpXi0wAuGT1DDra7ulCQUSWE8uAvyqU8wQtSAvPvnQDlSgD2A1RqxhL3 pRJPteaGb+PpiZzBXaqM3q0x3rcGwFvAFpHL+f3rD1EvQcad/zIh3IafcP8u/20OJZSOVu sx7laun7Sd+DIYIzESBnPLjQAgTiGsY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com Received: from mail.maildlp.com (unknown [172.19.88.105]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4TSCCt3V3Nz1Q8gk; Sun, 4 Feb 2024 09:51:22 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id 1D9D31404FE; Sun, 4 Feb 2024 09:52:39 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 4 Feb 2024 09:52:37 +0800 Message-ID: <90576a70-9ab3-dca7-f5cc-67e430dbe460@huawei.com> Date: Sun, 4 Feb 2024 09:52:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v4 2/3] x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC To: Borislav Petkov CC: "Luck, Tony" , Thomas Gleixner , Ingo Molnar , "wangkefeng.wang@huawei.com" , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-mm@kvack.org" , Guohanjun References: <3009aadd-69d6-c797-20b4-95cf926b6dd9@huawei.com> <20240201142016.GFZbuooG9CRoK90U2C@fat_crate.local> <39c1e4d2-b1d0-91ae-595e-1add4698dd7f@huawei.com> <20240202133911.GBZbzwf-M37M-J3EJX@fat_crate.local> <20240202194257.GFZb1FwcPPO8WXF86H@fat_crate.local> <20240202222220.GIZb1rHG3NiZKmdRXu@fat_crate.local> <4d974c1e-b3a8-8b21-88f4-e5f20b2fb654@huawei.com> <20240203094309.GDZb4KrS2GWa5XtGeZ@fat_crate.local> From: Tong Tiangen In-Reply-To: <20240203094309.GDZb4KrS2GWa5XtGeZ@fat_crate.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspamd-Queue-Id: 2260D80002 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kbm4a7944ukstfoj544ymhzq8tqje8pi X-HE-Tag: 1707011564-557757 X-HE-Meta: U2FsdGVkX18p6WuLCORwjdZpu05bTs3Q1NjaRnQzk6w+Od47KAMD4msWtzQAiSU8KWMbqPJpgomaHW2USqFKNLGfYCOJRhMlOOQtqTsdQoQQo/BfTBKusYmRBbOy849Ta+nBgYE0Y55lJt+6pO6jL5a6EHuCNofA67jSz8jT/4yq4BJduhEDPnlh7EXK8D9pdJrZZ9C12YKLhvsE6x5Lw7l87vhHGT61oHhhoGwzgeiZJKQCt96CabzVahUrfeoeaij8PkUzPPp7WdtEpGlrllCK8d24MtlftCJMdYcVAYzTsRmR65Au02PN0t0mRNVUQ/6lIT4qfRETPmbWNOt9BCpMhP+dsJZXRIB5zTQ6iCLVq+wAVpLhwmUfH+KtZxK9gOjc4Rx/M/J7BpkA7f1t3DW400/fu1+HMHN1TKfKF9gMcV80sHvojHWkr9NQ8l4vq9H6V6S4mzo/Rg32+NClABFUdClBohsHGkxZhUNYC/92AH86s24McMdzlFfMcuQRYLqc7H4ZGT+vz5HOirc9RAv4/Zqpq+ZwmljeCRLle4nQ9O0JtGSA1uM/ftNArxcnWqqXRi0uJYUt2cAU00AXH86n1dEQFoyN+heuhNRAy+YAxiVauRoBtKe3HwIXbl4qsP45fcXfhtIxw2kRgxz3MA6zqXMo6HvuFg0QJqGe15PaQq6cJWQIzqwZJDmte2V2iMFapAVlfBhIaE+Mx3zmj2YvhpDTS7VW0dn1RDd0OUCOQMom0pXAPkj+xkhtzPojJsz1NFF2GGe6qI+fSXdLUMefarpfT4+vlF3Psz66iL52zZjWb/MMFZZUI1UHOkUrz4GLJzJl2+nGnG7sQKDoQrQS0eSTYcwSFeLFD8AxJEYevY52GtrldogyDFWHcbH3d6t2G9OZPmIvf6CMQOLrl0xVmYwDxoT2l89blYTstCfaJ6s9xEkJDqP+kdVqrT0FJSTGx8eVLToAfTr5dLg GwifA3u3 YKrL87//0W+C3A6yub45OyeF6Gi/eoBZkovj4eozFH/hPJTcv2MIwipdrDgcpmMj7tY+tJrOcn1tR03+KS3jyTRXWeL5atGPLHdErPUGjPlNAIF4SBW0AjHAOXg+H1NltSgiinqyewotuREi/7dNU86NNpy54puz97szoGuGV2BjECH6X+LIhzbDCUMoS9/1dcM44FBEnuU69u1s/PMXie2tAKrXQSx4L3z0j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/2/3 17:43, Borislav Petkov 写道: > On Sat, Feb 03, 2024 at 03:56:04PM +0800, Tong Tiangen wrote: >> The goal of this patch: >> When #MC is triggered by copy_mc_user_highpage(), #MC is directly >> processed in the synchronously triggered do_machine_check() -> >> kill_me_never() -> memory_failure(). >> >> And the current handling is to call memory_failure_queue() -> >> schedule_work_on() in the execution context, I think that's what >> "scheduling someone else to handle it at some future point is risky." > > Ok, now take everything that was discussed on the thread and use it to > rewrite all your commit messages to explain *why* you're doing this, not > *what* you're doing - that is visible from the diff. > > A possible way to structure them is: > > 1. Prepare the context for the explanation briefly. > > 2. Explain the problem at hand. > > 3. "It happens because of <...>" > > 4. "Fix it by doing X" > > 5. "(Potentially do Y)." > > And some of those above are optional depending on the issue being > explained. > > For more detailed info, see > Documentation/process/submitting-patches.rst, > Section "2) Describe your changes". > > Also, to the tone, from Documentation/process/submitting-patches.rst: > > "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > to do frotz", as if you are giving orders to the codebase to change > its behaviour." > > Also, do not talk about what your patch does - that should (hopefully) be > visible from the diff itself. Rather, talk about *why* you're doing what > you're doing. OK, will improved next version. Thank. Tong. > > Thx. >