From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2413C52D7B for ; Tue, 13 Aug 2024 15:00:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 703DB6B0095; Tue, 13 Aug 2024 11:00:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 665196B0098; Tue, 13 Aug 2024 11:00:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F3EC6B009A; Tue, 13 Aug 2024 11:00:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1C06A6B0095 for ; Tue, 13 Aug 2024 11:00:00 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 91AFAA08B8 for ; Tue, 13 Aug 2024 14:59:59 +0000 (UTC) X-FDA: 82447532118.07.FD26AC0 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2059.outbound.protection.outlook.com [40.107.93.59]) by imf24.hostedemail.com (Postfix) with ESMTP id D0625180031 for ; Tue, 13 Aug 2024 14:59:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=jxPG9flg; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of ziy@nvidia.com designates 40.107.93.59 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1723561184; a=rsa-sha256; cv=pass; b=no7Z7TwfxqSy2wFn6g4pR6PAPS6NGEURwziNRqFJeLBz6/Iwr2ygf2X8iEKxx6xZ1Nqs1h f+wDeMfZUk7IR69XzUUcA5MM3pl7F5o/2Jrnp2pEgg/A0Mqf1udEJ/CcJkNH77UNqN7YvD sVNwPIRb5d7NnqyWh0/A++gclG9MERI= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=jxPG9flg; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of ziy@nvidia.com designates 40.107.93.59 as permitted sender) smtp.mailfrom=ziy@nvidia.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723561184; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gHrZ4Idpeb94AizlDxHvee/2qNpo+t7aAWfx9k15oBs=; b=H4A261HbPoruSojchV5AyPxj3GvXtB05H5BcVUGIGp1ezwGx2qex3spaup2YGQQSyxO+ZL 7vlt7RPk+AKVkmChgM0I3LrWxkfZprLlBqo1YQDDSNxmcXffLuKMtAfH52aidGWu/+/pxh u2ATFzYVNKOhpT0azlxNyG8cDNuq1vU= ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gZAHgLnRKG70hSCbbGYSq79sKO4LgmaB/vN2eh/12jYKh81eXxQHhAh0MMH9jNMKg2qFfUL9a3j1RjnS+dD+U8kGYHd9Jeq+e6BmoKGN5hcQlIYbaTb1rMtu5vKwRm77fIpj0cCL+1vlnPbLZzLuJ6vVihsvYiXe5xBWDsMMnPE561/MZ/gTa1KJqau0S6BXFnhBMO4s0kZ19OyWC9ODb/Iwu+3b20qjWwwKV36PvFJ+7N8goD+1Uj97WtaLC13Gc+WwdK8Rz9OaZP/yPJojWzJOdLwkVRLSzGqi0AQRMuuC00qAHvbCFfHB2VRgDvsfFfORH20luim7b2XdKe0n1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gHrZ4Idpeb94AizlDxHvee/2qNpo+t7aAWfx9k15oBs=; b=vptbDN82E9zMU9xdb9IzLCug8EySOsljtXry/arhgjc3QLdHZqubeRJg5Wz0vAbslDE6rZS9WUL8ExUo9C77sMtbVMZ2dHMJeXSNbUvSgwDlO/9mLN3kN70T9oNeI1J4hpkF4EYeIzfZi3mlnH+kkC8J1Ak20S8XhRKubwYc60XAJYqih0MtY8CAK68EEu4g7LkNqeyQxN/DcQHNOqdF/kqCMv8wDolPs85jd6VaPScM93z3h+uyKMuVEmq4q60QSJ99aA+8T7WIkiFkI10kDBLKQt3+cpsm9OKBihvphTHEEEs68NbrsdaHX2A6DucpM8W1WOCcQhdYbGPAopWLaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gHrZ4Idpeb94AizlDxHvee/2qNpo+t7aAWfx9k15oBs=; b=jxPG9flgr89SmgxYP2WUegh+bGRd4tV8UpIFnaVU8oTDEOxahZpqi9xEMsVzrpPDL8ID0zZtgRNBCip22k60+tes4CSB+1FW9jFSnWtZqqVBeWuFhIBDu4/d6pAlE/EriAfUHLfmJbsSSBrRiL0SYA2uK+GfRN9HsBNa2ZmHZOnrV/jDaRrslNed+VzP8Ti7fpEwGaetErmcuR4Bh6j5tfrKLhpbnYxcFBdVvczy3bXOV1vQhUvQQHWFBdEU2vRUEJUl5hAwpO/JTaQZ2nPVc0EmsLKqyO/9BeeswUgPRYFIiliuDjBMgJxZWQL18PuSdB9L/zNa2GHQRGuSDGeVfA== Received: from CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) by PH7PR12MB6444.namprd12.prod.outlook.com (2603:10b6:510:1f8::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7849.20; Tue, 13 Aug 2024 14:59:51 +0000 Received: from CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f]) by CYXPR12MB9320.namprd12.prod.outlook.com ([fe80::9347:9720:e1df:bb5f%3]) with mapi id 15.20.7849.021; Tue, 13 Aug 2024 14:59:51 +0000 From: Zi Yan To: Kefeng Wang Cc: Matthew Wilcox , Andrew Morton , David Hildenbrand , Oscar Salvador , linux-mm@kvack.org Subject: Re: [PATCH RFC] mm: skip gigantic pages in isolate_single_pageblock() when mem offline Date: Tue, 13 Aug 2024 10:59:48 -0400 X-Mailer: MailMate (1.14r6052) Message-ID: <905740F8-58C6-4333-8EA1-4A53C95CC1FE@nvidia.com> In-Reply-To: <92fedec5-62c9-4ec0-9d4c-a722b30aa63c@huawei.com> References: <20240813125226.1478800-1-wangkefeng.wang@huawei.com> <92fedec5-62c9-4ec0-9d4c-a722b30aa63c@huawei.com> Content-Type: multipart/signed; boundary="=_MailMate_2F304490-AF4A-4C4B-AF58-CD4A6986015F_="; micalg=pgp-sha512; protocol="application/pgp-signature" X-ClientProxiedBy: CH2PR07CA0029.namprd07.prod.outlook.com (2603:10b6:610:20::42) To CYXPR12MB9320.namprd12.prod.outlook.com (2603:10b6:930:e6::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CYXPR12MB9320:EE_|PH7PR12MB6444:EE_ X-MS-Office365-Filtering-Correlation-Id: 4ee6f9fc-cad8-4ae3-7b41-08dcbba894f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?69AkAhAng4An6ZYwoRmStF4MrUdKt4OOct/hO8dfx3EvT66gnG3VDqg8WhiZ?= =?us-ascii?Q?W79ggCorzgmO7TJlBWTaH3wvTaSdfcjd10Rg++ajqM4R6JJNp02upl4NCThY?= =?us-ascii?Q?PmvHuL9VWCkfPznGy1uICN8YS7E8l4JsvI0e9fGnQiJZIA4sE0XqwCAQcr0Q?= =?us-ascii?Q?X9PyVYzuBil7u1tltk5jKQF1HXoM2DB7RLULFYEopMhJe9VnWnf4pIGdtPjN?= =?us-ascii?Q?HqH7pKA3L+GgJaNpHEj9aCPGKcAcjSEA8wnRRV6h+Y201jyQn1MOcrhqJYRr?= =?us-ascii?Q?yZz2dWdzyqBdNBbTeHi/wZDPFYzzBgIJzrZt1klidQQ/iW34FezqNwPTb5VW?= =?us-ascii?Q?u9Mpqom3cjUTxSexVxY29mz9/CqoegnBqU7XJpRZAl+ZNqZ5OQM02FBGPkfJ?= =?us-ascii?Q?mF6BUe/sgKgTzlsRpMqLASzMjXMNl/1IHOOdpLSNCyjUEKTdlggxESETeTRi?= =?us-ascii?Q?qw4tA34+Fzk7f9vOVK3u7wrlK1gfyckOPhTk0iQUdqGk8jzpaT9SptG2ESvQ?= =?us-ascii?Q?N8XThh5cHCD2vE7qhkW4my9kuJ9S6I3FXGXyVHeOy3g0pnGU9RGvdBY+03s6?= =?us-ascii?Q?1q7bYsBJ5G4f9Ta5rB0tNDlRu+RspgSVVcqP5/kOuS7IF1FyiLMTLJft10A5?= =?us-ascii?Q?GpVYFPGboQzArdlR/ZOYYUxp221u/cLQyLXm9doo6J++p4h1s6nRWXvB1Uni?= =?us-ascii?Q?uxa9IHP7bL95EASIevstkhlExvk2OEPgIoV2fHJAonxd9HgdXPGl/pQ9NOq4?= =?us-ascii?Q?w4sd9ydW5EcK5eSHB1f6l7gZ3NBaMSeZ44rv3WYiB0srdKt6OOvLAAzwsjXo?= =?us-ascii?Q?chFmmuvT/JZWMPKgPwpxrZ0yCvmaYfC23POCDM5rPKWLdi8EBPJdFcDRAM+k?= =?us-ascii?Q?eJmVpzOCpPkNW3fG1gg5i15OQioThpmPCSAziZdcQadNWUlBUFSSoPRPAJt5?= =?us-ascii?Q?33nDASsY/KfDsGUl1CaegywQErcy7NZjONSjnagbhNgw5zovahnwlIxejR9a?= =?us-ascii?Q?YUD+DaNKD1xy6T6os4WGWXkio5kZbsbP8qmpeaKgWeYOmixMY6G/HZO+hkp5?= =?us-ascii?Q?Ew0yOj+2KMi9SkOVYJpyFbvbowTs3WpXvLBlFEkXqgFrXrNpFEqcRdx5IwiO?= =?us-ascii?Q?KRoAe6+fD0MGFuiwFCktcH2K0b6Lqr/5Yh//eqiO7DE5NDZL0D99n+K8w5LV?= =?us-ascii?Q?xoQ4IaWBP2zud0n5qxeW+FbmeDudmLCp1E+6h2yjDBMG/XUp2Uj0PEoHMKIB?= =?us-ascii?Q?IrFlAFfc2Eiw9ePz/IfTR2cPwnlooD9W4JQwH8GrxqQ6JSvwLC14TeHvrSZS?= =?us-ascii?Q?zWTYOarGshGTpA9hmPSQRgTNvPcoxAuPnPeQN0MOsjhiSO2Y4PqydIQfeM30?= =?us-ascii?Q?Ts5VnZc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CYXPR12MB9320.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yHgsNFa5klS2tzFLJPSX8Mld55BhciFompr9k2vOzutZzmkC6Zxu318N/XYG?= =?us-ascii?Q?gLmY4OKeeHiOslzkyXLDeJvep2bmDiy/RTWIC/qnifJS467cp6A+6UKm1hj/?= =?us-ascii?Q?9XkKVNobu6Usgny3lrI9tPAMEQqcr7AP1mE+MIoYZ31zlDpGjTo/PFsFd9TA?= =?us-ascii?Q?db/qQb7zoa45oV8hIV3/k8Rfb3aixfQNPAxVvfAHps4bYBvT2njDCeOdUhH8?= =?us-ascii?Q?lbbwCpT4F/hL7JfevZ0N84mKFQvfpXG1jvjpPcJsrw6mSnuYHezZYM7haVJZ?= =?us-ascii?Q?PqrfAWW5L5UJeK4Ebd+aYXq18oixqgDC9YBNwOtoSywEg6NSE6kAsXY4rPQk?= =?us-ascii?Q?TOXPOeMIj8WHEDg6XIWKiqCvSQ6EzdvvC1yhtNyEGuWPhstJj10Dz3D3bfmM?= =?us-ascii?Q?bAQXuJpLS2CSsonu5R+Lk9gOk2738QMbMKlVATrMos4dj/HD4bu++IP6NBrB?= =?us-ascii?Q?+t1VbAlQWdjQrLNZ3B+/5wDW/5i5mvElrpyHGG1E63wxX469S18AIZEUqx6S?= =?us-ascii?Q?DyiaX8Lxb868G9hR/0CjJkSdcrOSnD7qQpQXRS0q57liTxCUNM8QPYwHWIcz?= =?us-ascii?Q?0TY/T0LynqKErN4uaQ4fsS9jZgn8qoDVzs8e8kW41oIfjOrzHIcD0BVGQ0BA?= =?us-ascii?Q?XgOx/dx68mXSIhzR1vcGnEiPxcmmB8QKune71FMKmn1JmWx607Wb6CE7x+e2?= =?us-ascii?Q?AepMKSKCnsvE/5vWxMxISCrc7oIp4nqKWA3+Mu8KSMeAbY5bOqx3LIa6fXRq?= =?us-ascii?Q?fP0nRz1QHl3FSpX23uVjM5dTys2Ohk3JGiYEeVlxtGAGEbi0RaMaK9SaxMtQ?= =?us-ascii?Q?I6UlMAL8QoZ9q7I1gEiBjx/9iaZvoVyTvb74tSm32mOwSKMEbpjW+jPgDijV?= =?us-ascii?Q?odrGihXrSPR71ZlBH4dSRU5zL6okh/ka6DulbTpZfmZCykgNEIkuzPWcbQd8?= =?us-ascii?Q?RNlq/STUc5WBQh7kg1N0nCcNugmOHuNVPeMtPD4IP20mC6n0Y2R6yyvublUH?= =?us-ascii?Q?hLW4aqjr/pU8a76wRmEjt9qvc1m6DMp900XjT87Pc09dACCzOcB8QJXVs0EA?= =?us-ascii?Q?VVvHXdE3Hfkri4j0cM+tGa0ldp4oDRkje5N2BXVtuuNH1wOOjlKG88uYCCNI?= =?us-ascii?Q?40Dn+Sel22KVCARsBeO/lnmBxHBx8yQpkmpEBSBfN40s2xPfbCoV934nrvmw?= =?us-ascii?Q?aV0TJB1vTXn7YysPP+SDSp9rT6B4wLuPkWA0QB0JlkGW8PrDY3P4Hxsh3SNA?= =?us-ascii?Q?cLe1+WHI8imyFg+77fiGx/0Yz6owfJazt7D/2MHeYPdq2DZSVTHyLWLjA8aK?= =?us-ascii?Q?pL+8lD/VqmM34yxJKM0EwAvUzXSRLiGnC2xjstu9FDeQCSXimLL1zCFOz6Ta?= =?us-ascii?Q?mQOybdbxgk+sJL31lOMWl1exYNjPFT0m3G/VXyr/02IXETlgWco42GwBf6mc?= =?us-ascii?Q?Zx4DkkwxlqoULv8g1o8vnDNt7LuAICeAURgZp9+kF+R+hXbEdSvZpu+kcgst?= =?us-ascii?Q?QEcenB9KYDRHSlXPA+Z99a9I7jKllbbKfo6I579z90X7xrki1jFdM0uwU2fP?= =?us-ascii?Q?bjoqPdYciAd4Brp3pZr7SYICl/6wvMmZKZdKPFUZ?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ee6f9fc-cad8-4ae3-7b41-08dcbba894f7 X-MS-Exchange-CrossTenant-AuthSource: CYXPR12MB9320.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2024 14:59:50.9454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S3Yni9nZre/KD22v67nmtTTE13ndrjbD8ms/01mfbYehT9KNfMu+m/Rp4mpen1KE X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6444 X-Rspam-User: X-Rspamd-Queue-Id: D0625180031 X-Rspamd-Server: rspam01 X-Stat-Signature: y7gomn73yr75nqhe9tm7jiktfcc64hy5 X-HE-Tag: 1723561194-557798 X-HE-Meta: U2FsdGVkX1+l+41/v5SOmziZr8ZZZ9As+GzgxuHnMmXpG0hGfXQ83+oAsdvOXLJWRybFk2Nfm2MoMxBu1mqTQq4XEryISyLFbdPdy59s7HXW0yIay6Z79uEhtEw8BuYX3HJyRUSwGN+yC0JsezEbnuNXGLPpsaKfz0oG3GcJSZzY/iYSDmrKMyszzUQaxnnkxZScJk8aylCWw5roSaoEskG3nqrIETdhjmtmnpHIXyJJRhxbfwMXC9x6k8S5LldHyg/kqVCNU+oCfSSDcAMq5gXmJ0mxnlQ+tPN1bQc2be/TM6CqwspOuicBh6qDQaPnpBG7o70gHTGLfM7BOEM+oKR1y20bATZ9RNf0U0YoiVMTDjaTzZgWqFhp5LmPU3QNGzQhd3C1MDuxqde9EeJPGHT2Nf23llQXlAYz4QQKMZ7If2QgP44EcdpEoQinGlAKW55Qd7qviC3mbgLvikXUBohFXkH2J4o7wu1uZl9O4SdPNTKtL70NyNRF2sROi8Wf+47+lDL5fKpo08KIJntr9YerDZ4EiWQberloWDOIbcjKuNzI09fjz0ZHIQIiDhof8XaCDxViyfBd2jsR8hbNaGmB2cEIbzUuknabLkCramS1uc0AUd8vcOXsniavl2VES6p5nmgSA4cUaaupqYNERocESCmJWnqkFn17yPPZqQHu7XsZRMzfBuU+3Y5MHMS18lQJl2rL0ojGrHXL1LPYYQ4jCzFNFVu4vWJqQoAeketgZJmOPugMzdg3A8xaR75TIOA7PsxAtmFbQdo/ptlkyQt3C1ufPAvV0yzDX1l4r/IsdfG0WD5RzPBVjV1G3FRdYHB0ItQrGbtUU1+wHCd1f2UQna2YWmW0m8RS8gwZRCpwPIx4IfAbFAye1ZQzcsHWrD0gVQhLCoDzan3ZyoGjpg8G3OQoXzgPWEvRyhu8sPEC2DMy5uubewqfMlr1YqZi86sHUtjj48XNUEHbMJr xCT58zaP pVWIM32NYinx/hELkX+8REd68P0zuxzrGILczhHk+VbaAYcoela7cUGrv8sxY9JLLvhbF6C2KGi63Plmny/AoRojhEARifsW2XMLXc1aKLaWweMzmZUB9YIfHPt+u/5dXV+OtPoctrCm/jTs/nkgqh+fIT+6frNplB2SGsb+VHpE2BK+mC6fHgx39PxxIAPUWa/f5U+3bh1iTxyNn/pfd2fYvu487SUcLQLps/uNB3hpbVTm4khRJOD0BCDY3pX9OF/eSu65+nJSSZ8pIKaQAK0gpwN0vRokJXqInw/9GefuQJnGeIvCePe7kWZW8Z+3NGJcaOqG16b6GmY7hR1hNbOKvgtifeqFt2D6e032DDUfsh//yIjeo4nPA+YkgyNsFEKFq43mk3cazQ0AXBAsKL7lsQBKt7fhJmUaX9JZvuTPnJ7ZsIkV+AnYHt1mhQ7pGbowqJ4dwuKLk34tYyLsaUijVRxhxBQjnS/3XQ3LeOChDIgtxob7OALNYdDKEV1F3F0h8CTTBpq+Rk4mGnQsyzv/36jQcb3CbEgl7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --=_MailMate_2F304490-AF4A-4C4B-AF58-CD4A6986015F_= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On 13 Aug 2024, at 10:46, Kefeng Wang wrote: > On 2024/8/13 22:03, Matthew Wilcox wrote: >> On Tue, Aug 13, 2024 at 08:52:26PM +0800, Kefeng Wang wrote: >>> The gigantic page size may larger than memory block size, so memory >>> offline always fails in this case after commit b2c9e2fbba32 ("mm: mak= e >>> alloc_contig_range work at pageblock granularity"), >>> >>> offline_pages >>> start_isolate_page_range >>> start_isolate_page_range(isolate_before=3Dtrue) >>> isolate [isolate_start, isolate_start + pageblock_nr_pages) >>> start_isolate_page_range(isolate_before=3Dfalse) >>> isolate [isolate_end - pageblock_nr_pages, isolate_end) pagebl= ock >>> __alloc_contig_migrate_range >>> isolate_migratepages_range >>> isolate_migratepages_block >>> isolate_or_dissolve_huge_page >>> if (hstate_is_gigantic(h)) >>> return -ENOMEM; >>> >>> [ 15.815756] memory offlining [mem 0x3c0000000-0x3c7ffffff] failed = due to failure to isolate range >>> >>> Fix it by skipping the __alloc_contig_migrate_range() if met gigantic= >>> pages when memory offline, which return back to the original logic to= >>> handle the gigantic pages. >> >> This seems like the wrong way to fix this. The logic in the next >> PageHuge() section seems like it's specifically supposed to handle >> gigantic pages. So you've just made that dead code, but instead of >> removing it, you've left it there to confuse everyone? > > isolate_single_pageblock() in start_isolate_page_range() will be called= > from memory offline and contig allocation (alloc_contig_pages()), this > changes only restore the behavior from memory offline code, but we stil= l > fail in contig allocation. > > From memory offline, we has own path to isolate/migrate page or dissolv= e > free hugetlb folios, so I think we don't depends on the __alloc_contig_= migrate_range(). >> >> I admit to not understanding this code terribly well. >> > A quick search from [1], the isolate_single_pageblock() is added for > contig allocation, but it has negative effects on memory hotplug, > Zi Yan, could you give some comments? > > [1] https://lore.kernel.org/linux-mm/20220425143118.2850746-1-zi.yan@se= nt.com/ Probably we can isolate the hugetlb page and use migrate_page() instead o= f __alloc_contig_migrate_range() in the section below, since we are targeti= ng only hugetlb pages here. It should solve the issue. When I sent the original patchset, I over-thought about the situation and= included PageLRU and __PageMovable, so used __alloc_contig_migrate_range(= ). That was probably not the right approach. I am aware of that the current page isolation code is very complicated an= d planning to clean it up. My current plan is: 1. turn MIGRATE_ISOLATE a standalone bit instead of a migratetype (I have= a local patch) 2. refactor page isolation code, since after 1, migratetype is preserved across isolations 3. clean up alloc_contig_range(). Best Regards, Yan, Zi --=_MailMate_2F304490-AF4A-4C4B-AF58-CD4A6986015F_= Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQJDBAEBCgAtFiEEh7yFAW3gwjwQ4C9anbJR82th+ooFAma7dOQPHHppeUBudmlk aWEuY29tAAoJEJ2yUfNrYfqKO6MP/0yf0Y1aF71somIyX16IaSriHy7YxX5RBGSm IYI9kiuCXesSe4eeGpn1ZndqLz52W96Fxv53xQmWCPUEMpbFpYNtI5wS3gK65eun HTRxU+ze+nU+fcNuFzhjQ8K4q42AkEBi9aqsntNgMpvVqOyVyueLIgH2wG90HxvC oKDKC8HqlQ7Y3mgDsBq7xeYXan1vuO8RCow/pVfr7SDWvAnv07TkuvzfUwZsTUZt fbluMgyhsE8yy07NSts7G4AVKp31vNx3aRiOu1Dj43NEDLLtWK7evC6IEm1IkFIC P6oBHVdmVB8+lJTLI2lfhfyu1QHHbDZnBLpA8urMhkTrdCKxenc+elz6dW/8b4Gj DDjv9USOTCYHrax8DTCb7DU8RrZDJxRVOag7zdRCuJg3J071yGVJhNzAAFAa4B7B NZwQ15OFD/cu1KethBgSEsJHBxsJchZYIEGp87ZDUj9XPFnYBROKJ9/BleFQQabD M9oUGaddazbtA+Ve9aZpZAG/Pb5QMjF7F8jdLPKhSDoozWcyNIErM7pGwLdvpw9u A36V4TuT8NhQsovYFsS12h1zM9z77esZBwXm7FwP6hDsOPpofeKLcwI48cIffLE8 zrfGnmlobkGT16OSv7s1ZTbRint7ZYbHuc/QbcNgs7qoTEUx8iZU21scrfNNfhZf C3HPTv0R =KVhw -----END PGP SIGNATURE----- --=_MailMate_2F304490-AF4A-4C4B-AF58-CD4A6986015F_=--