From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 212E9C3DA6F for ; Fri, 25 Aug 2023 07:36:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AFD8280094; Fri, 25 Aug 2023 03:36:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 860878E0011; Fri, 25 Aug 2023 03:36:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 702EE280094; Fri, 25 Aug 2023 03:36:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5D01A8E0011 for ; Fri, 25 Aug 2023 03:36:10 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2F0E012050F for ; Fri, 25 Aug 2023 07:36:10 +0000 (UTC) X-FDA: 81161818500.08.7BAEC6D Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf14.hostedemail.com (Postfix) with ESMTP id 4BB8910001D for ; Fri, 25 Aug 2023 07:36:08 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=L3EiltqA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of haoxing990@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=haoxing990@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692948968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fmQXS7ZljRGETNucrUHW9C7e9E1jrlIlPOAPECVnU4o=; b=7QszlsXboI1EHWhGt/gCtTzMFl8SB0D1QXWiv36P/y13BP1fMJP9xLTU+zFfWb4/sOCbrb y0fJh26K4eDErZD4ZRCZQ3qrpIzXMvr4XSVOCO0A9idI7AJIR0zWMpUx7p0U9Lo9Dzq/Wd Vpv6eK+uBrTcJtQOLkMdpEEsLKgFvhQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=L3EiltqA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of haoxing990@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=haoxing990@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692948968; a=rsa-sha256; cv=none; b=e7rI8uqABPDarqFOtXFOK8PMvn1RTIT2E4OIQZ3XoMpl8GFIZHIEUz8C1gcf1vMgmjKO0U xtuTramfOIV8Clh2KNbxyfx2uwjd6/YjTGNTJLUnsHUpT2gfBQt7jgCXFDzVF8EouODQXN MCxOjLhhQ5VKC74NoBRC82dtHMVFkxM= Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-68a56401b9aso548901b3a.1 for ; Fri, 25 Aug 2023 00:36:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692948967; x=1693553767; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=fmQXS7ZljRGETNucrUHW9C7e9E1jrlIlPOAPECVnU4o=; b=L3EiltqAvipBCYB89ybi72qBxE87H58lYTfHNPfrgziksCQ+c76HutAnmOWWJHW8WI KOEkDzazuBirxMAvb1VtRUCmr/EMasK4+85E3WV4Mc9/wqZYDOyzxTst+CSTA3CRw5I2 nqy90/N36qQp7OI5baDF/ryNd4uxZKhEqB5w6BauiMmtFGJuEMIHSS0GCDYb58qOJjPO MF2OakVwTLvQmUYhEnFuvuBwb96eD2wMA062mMQpPrR6HC7lAcP3q+m4mCaCD2jPSXdt FSoUlD7DhNLy6CQCkEu6O7Y3E0yi4YYZkg3AKB5FobGDIWEx1JwIwaza4wTPY0FL/tFq HHoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692948967; x=1693553767; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fmQXS7ZljRGETNucrUHW9C7e9E1jrlIlPOAPECVnU4o=; b=KCj8Ax5ajWMLV7fcilj0ODKLDYoikpogHzSerZr9cT2Dor3YYWZXy0/4vhwclraD90 T4JC5UNZMuqzaRVeS6TghN5ZwMSLYGgfeYDM61kMVXwVdhHjVySVUvDQ7jVIszpKFZ7M f+MjkErx6zDadd/3naQsB9QqS6/Vyl+JLk0f3df/az5D7vALjwwAdXsk3F2psXWaKE/z 38Y6OVkpRStqLWw3mtotvN2y35qEVfP4bM2ECPS9KIuoRdlTap+6OgKnUfOej+pwOvGa b9cpAyccwAWaZ3dxkiC+ADG6r+UiJ1U30EDBx6JdxdFxgUK9dHhLR9oiXvco2eljhcAg 1fOw== X-Gm-Message-State: AOJu0YyPKm7qJqvEMZ/gIFn7Mc0edAgVEMpB9MVnMRA2dXCDpfFLwOYt eOb+lba85PZ3Tm3eFK9TaNQ= X-Google-Smtp-Source: AGHT+IFApIFHFPfhzlDLidf2FziQwvEK0ynti/yha+pP4Udf90W+JODZDSPEYGx+qcrjEmY6JnpFpA== X-Received: by 2002:a05:6a20:138f:b0:10c:7c72:bdf9 with SMTP id hn15-20020a056a20138f00b0010c7c72bdf9mr12929766pzc.29.1692948967087; Fri, 25 Aug 2023 00:36:07 -0700 (PDT) Received: from [192.168.255.10] ([103.7.29.31]) by smtp.gmail.com with ESMTPSA id c3-20020aa781c3000000b0068892c40253sm873672pfn.216.2023.08.25.00.36.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Aug 2023 00:36:06 -0700 (PDT) Message-ID: <90562ff0-9689-4d00-848e-87347cacdbae@gmail.com> Date: Fri, 25 Aug 2023 15:36:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: Use folio_migratetype() instead of get_pageblock_migratetype() To: David Hildenbrand , akpm@linux-foundation.org Cc: zhaoyang.huang@unisoc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vern Hao References: <20230825040848.1542-1-user@VERNHAO-MC1> <9d4d0643-6a7e-22bf-1f54-19646bb7231e@redhat.com> From: Vern Hao In-Reply-To: <9d4d0643-6a7e-22bf-1f54-19646bb7231e@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4BB8910001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 1ehgsbwo6hay3zd6u77ou438etsqxpps X-HE-Tag: 1692948968-379508 X-HE-Meta: U2FsdGVkX19mNyLZ45Vroc1b9sg3MPn9z9yXtNO6NlKiu75CI3Y95dkjDqB5jkZ9vqfxeLJ9Bf8WU/tc4B1wUihi1/OaejVXsP9+ivXBYGQZqTVkDpoB0ZAAhh3RxEFoIkTCqL5G2kq/FpjfLEWJiDPBWPHVbMXOJ8/4HgWwjziaGRQQxRD4ZRCLe0viR980XbAGnYRMvXZ9mhhOesruPnMYRu6cCpjb2Q0wVhsYT7OIp1AyM4HUIJCLuLzvptJLmGg71ZV2ismabS9+/ZJHxKHY6wNKFWwG+8PKQ+wZyWSGkIvyY3TOwEQehZu8QLy62njp00+xoiFY4wEy5KJyJnZxRi/tkUPHwNhurWWZNLl3ZU7ZeNZeXejpWmGjPZtj1Qw4Y90i4MqpZNWCsFyfx5xn9sSS5n6Rnca4ksB2b4C/T/5AUqefcsZYN2Q3d6As70sN3kXdSLljY7gbuw6ykx8RsnW9hNWYHkosH+p6EFgVLRO9fDa5T/N5gZvQVgkfmVK9DGoTVg2GJFAUCxBMaB8pVFheLmahwe9XckKHsNc803N9j+1gSvmnLRJtU0li+B0/g5/NUcwFmbPHhDcX4kZNMwrXzmT9Wuq76v6YowhGIfxAuu5ogBer4cTNHLdWLIyXM/GASat4kxc2BPXn7o0g+QgYkDFssjtyy9k1OkU8NcSqvF/sOi0ircyMlHIlDNhY4n1kBLlt1w09ClOCuxMnRlYnPI/HhY++VLiglW3X8HuSMQwlDcw1sw2pgroUs+mwYlD8AfXp7s39aExRWclZ0JX19gVaT1o7Co9pJ2rsb1gWF2I2pNlhJ8Vq90UxrpUUvxEoBsXIeVC5mtG0D2dJy8fflhH3JEZXrR4jXISZx4GWptGukXbIBTFmpNbaB+21o71tzp3iU685bdm8kSugSt5u5CFItWyDl382JwW88OMxiM+r/6aNL5ZylQFiFz0NJnHEI7z1illrWKn hv3i1tQw a1XZoMHAMoppcS5LYRG1+TXhFde91RpwSWEs72d/1qj6YxyQqhqMw4fOnsXbDIwlAfHdxs3vx1Uaj4P/goEjTR5PUrKR5G+UJprcpEyJUu4jGFcsEcEOjmMsTwZOnFOQnj9o51KpmyiisipG3GNMhDHUniAVA37/2X36QAOcEGDcXi7qSIG7mEn0O/PyY3i6N4/QeUmoRaUtGCbO0ITnAWCxqCoJq721f90X9dYlv/uezzut2/bQbYaNSnA4cQYD6EqsRVWguIZp7koN6JWDSmunS3ZpR23N1n/lnsdM/trLmA7XeRWxvnWDWeRLwrfMg7Jhaz+5imFH9QmTeFETTk2vhsnLkiLItnr69T3t8WB13KtCZH/GJqp67snQc9L3/9K2bCUlkuhzrx1m7rFh2+GyQWS9J3NSwzN8E8lhXUL/6mTxiaTTKDHtYeQFSVxkktTY0/d0ndj6R4rKqY6Ge//kMfhBOAhmgO3iVvf+KpbJuGl57y3zzB85LuQqCq4k0Wl7sW3bHTdkO6c/aD7imnVInqfdLwsgDtetzNSHYy4RPZGSrqysjeIkjCUKI69zyC5xK X-Bogosity: Ham, tests=bogofilter, spamicity=0.001343, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/8/25 15:34, David Hildenbrand 写道: > On 25.08.23 09:31, Vern Hao wrote: >> >> 在 2023/8/25 15:12, David Hildenbrand 写道: >>> On 25.08.23 06:08, Vern Hao wrote: >>>> From: Vern Hao >>>> >>>> In skip_cma(), we can use folio_migratetype() to replace >>>> get_pageblock_migratetype(). >>>> >>>> Fixes: 5da226dbfce3 ("mm: skip CMA pages when they are not available") >>> >>> Why did you think "Fixes" was a good idea? >>> >> The skip_cma() contains the folio argument, and the folio_migratetype() >> is already implemented in the kernel, so I think it's fine to keep it >> consistent. > > If this doesn't actually *fix a bug*, then please don't add fixes and > confuse people looking for actual bugfixes. > > See Documentation/process/submitting-patches.rst OK, my bad, i will remove it, thanks.