From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44A32C41535 for ; Sun, 17 Dec 2023 00:26:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA5DD6B007E; Sat, 16 Dec 2023 19:26:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B55C46B0080; Sat, 16 Dec 2023 19:26:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D526B0081; Sat, 16 Dec 2023 19:26:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8EAE16B007E for ; Sat, 16 Dec 2023 19:26:55 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6132512074B for ; Sun, 17 Dec 2023 00:26:55 +0000 (UTC) X-FDA: 81574419990.09.CBBF26B Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id B041018000D for ; Sun, 17 Dec 2023 00:26:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XAhLRpzB; spf=none (imf24.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702772813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UmhjuIC+i3niD7s22hOLxzfyohGKz2fOc8wk4Hhr30o=; b=GD/7JOlW+CGhD8r+FV/jhgBXakEOasr+Wf/o+ttOvEUh5DE1Y3BWYM711zLvkkhcbWX2IY 13x36bXpVol1MbFVblj+edJeb2+CUVJ1dBd++WlkyjLJplKeTFzo9VBlPfZN17qT/jq0eE FE3zjQ+UZ70L2rB7ejrkQeVblBC9tbE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=XAhLRpzB; spf=none (imf24.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702772813; a=rsa-sha256; cv=none; b=O15mHwDtNgZXfsA5qMLhEtiqAzc0vxzQvvxdpdhFZstRuPnOY4oKs393GB+9HhbwmQtxi2 I//EKFGVRSNtwmNFwuNUWvQUdtlo7SrOpaBV8qehGFurEsZutm68iZxCzjte7+qoRaMIUk p4WyxDO1Hm6PUfuXisqpYQ7Axp+Gids= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=UmhjuIC+i3niD7s22hOLxzfyohGKz2fOc8wk4Hhr30o=; b=XAhLRpzB623ksRVtLDlHFWBDbZ EtIZFtTiaEAe/aAGXYsnvPuxT2dfKCyqllfO1r7aioBpBREOnBdlTHSe7mgzHJjl+15eDYcrREtM6 t6NKdS1iFYmOMxz7cvLBi42OYGOW+Kjlc66SGaBAhCDgAArJ46ehcEnOiuUPsdN+E9KH61Bx8YnUc 14ZaSU371BZKcZAF6KzKp9VLPNGq5P5ESWtonHbxx+ADY6tXh5RWfHkVPpmPu+/3RSuUtaL8dey1I oOOk9HOLf6wryCKv09JFMD/IayYdoxsUVkvsymy97nMiUiOiM7kPudKtcyPbVekLdbb7MTThSUouL H+EB/Rrw==; Received: from [50.53.46.231] (helo=[192.168.254.15]) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1rEezZ-006ukF-1A; Sun, 17 Dec 2023 00:26:49 +0000 Message-ID: <90558702-2d94-4396-8e85-2ffa7777e87c@infradead.org> Date: Sat, 16 Dec 2023 16:26:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 46/50] preempt.h: Kill dependency on list.h Content-Language: en-US To: Kent Overstreet Cc: Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, tglx@linutronix.de, x86@kernel.org, tj@kernel.org, peterz@infradead.org, mathieu.desnoyers@efficios.com, paulmck@kernel.org, keescook@chromium.org, dave.hansen@linux.intel.com, mingo@redhat.com, will@kernel.org, longman@redhat.com, boqun.feng@gmail.com, brauner@kernel.org References: <20231216024834.3510073-1-kent.overstreet@linux.dev> <20231216033552.3553579-1-kent.overstreet@linux.dev> <20231216033552.3553579-3-kent.overstreet@linux.dev> <20231216223522.s4skrclervsskx32@moria.home.lan> <82ed43c2-2a9d-4c5e-8ccd-8078397b7953@infradead.org> <20231217001849.hmilfx63q44tv3vj@moria.home.lan> From: Randy Dunlap In-Reply-To: <20231217001849.hmilfx63q44tv3vj@moria.home.lan> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B041018000D X-Rspam-User: X-Stat-Signature: 5ujmbj3rh8igd3oizt8kko8nghkrh6mj X-Rspamd-Server: rspam01 X-HE-Tag: 1702772813-567045 X-HE-Meta: U2FsdGVkX1/g4myabxTx8FsA2FISP7CG8OCFUDfdJnP3suQGG//7swrvmEyCPQgyKMyzI8z9mliIwAG/574aSPtn56sxluOUmZt/pj+2rfgmME8Ge8QlTTpTsWHIkFAMEIw2p0GnDItkSm0Apu1UouGDEQqwvZGE5cK0b2I5gsZBQGcEgARYCYrsyv3jG0xa81dy62RnFC4BQdPby3PhZnbZZZpo77CyAVIe6gDM+IxTXDy9IFR9N2KfW9Fu2DoGdyy+avjqG8jT1cvTRJoIq5LRmwO6VugfCXOfm/djEN1066hNI1urputK8n+bmprbjB3LtjOucYAPHhgC+21N4T0JpnmcQDVzo5cjCagnY4WKhP2Z6EKdNKIgKQ/4+ehKk2HQESRmBIm/0nJ1kntUCHG8oPR8cpB0hndbxn1f8PEAoDx8POcsJa97AID/hxRn6ZHXVg2sO0cnQwboU9OCa2z2YE59lOrKTn5mprfCDMI9YYN5Ju2hJyyyQOZhfhBOMdGiBl+viIDEJug5EDJHhsFFAUX6MO0qXDtJvbPlsK5bH/JQuql68CVWaDFbxUcQoYkX1RP87j4E+o1Gbz8Uc2TPpT7Fl2C9uEfs4YYKhmkUa7RrEhqdkha2Vvgrr/4FkwB3OsvUl3Ftj/+5m0C62gK1NBJEXJ3P0+5PN0jobFsP0GdeXraDMVzQI3a80C+XNVDA6DyWtAf7f8qG5ETUym7ZGxhz9P/yr9z99oyzuvQj6W2z1qx0Ch3dLW0Pa0YnYq4ufVovnQm8awhKYu+UdJq3ga/7Mya7upizHYRwXOocgpapObGdceoU7AnXuBUdz+q+h8Qsh6YQqovscuUpNaAKnkuaWxENy/JR/mGHc8nkCeTxxgVV/VLQ68tBnG+naBboZbz0d+C6Geiyv5XDt00ycsS3/M+907gy7Pgk67dbrI2dZHgzrBLEzs2iO1RN1gSAPEBN7YjqorigW5U NkoEn4d4 4dWNkGJtLa5VfR//QkCUYnmdhB+xj1iTliKFW/18p3nYZC3g+neiLuR0a7nWMNkZ6+U+JdT4uz9B1ud/3YeyM3F3NLyiXo/1RWilmS08ekd/d5g4NaBzM6u6t2ez5eoppXOgWa6CzmEHTVF5G1hHoMxX0ZiJ1IZBQYG7sWXj1bqRbEST2tY6IZNOSdQxIcjNv0puNXlJ9e7w9qsb/aaluiHbyPMXOF2zmzYc2U6mWKa/ZySwhMVBy8yk7vLe8rPkSpHx2Qd6hY5m3PY+2uRsy/x1HG+NmvHlwhBSjdXun4ASWnURnCM+/d4Rd7PoUTADOPVHXLLVGl3CQzQ15/fejrkVQi7GU/OIGwSLQWtZStlHE808fCfyKJVd4GA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/16/23 16:18, Kent Overstreet wrote: > On Sat, Dec 16, 2023 at 04:04:43PM -0800, Randy Dunlap wrote: >> >> >> On 12/16/23 14:35, Kent Overstreet wrote: >>> On Sat, Dec 16, 2023 at 06:13:41AM +0000, Matthew Wilcox wrote: >>>> On Fri, Dec 15, 2023 at 10:35:47PM -0500, Kent Overstreet wrote: >>>>> - INIT_HLIST_NODE(¬ifier->link); >>>>> + /* INIT_HLIST_NODE() open coded, to avoid dependency on list.h */ >>>>> + notifier->link.next = NULL; >>>>> + notifier->link.pprev = NULL; >>>> >>>> Arguably INIT_HLIST_NODE() belongs in types.h -- we already have >>>> RCUREF_INIT() and ATOMIC_INIT() in there. >>> >>> I think I'd prefer to keep types.h as minimal as possible - as soon as >>> we start putting non type stuff in there people won't know what the >>> distinction is and it'll grow. >>> >>> preempt.h is a bit unusual too, normally we'd just split out a _types.h >>> header there but it's not so easy to split up usefully. >>> >> >> I don't feel like I have NAK power, but if I did, I would NAK >> open coding of INIT_HLIST_HEAD() or anything like it. >> I would expect some $maintainer to do likewise, but I could be >> surprised. > > It's INIT_HLIST_HEAD(), there's approximately zero chance of the > implementation changing, and there's a comment. s/_HEAD/_NODE/ for both of us. :) -- #Randy https://people.kernel.org/tglx/notes-about-netiquette https://subspace.kernel.org/etiquette.html