From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E041C3DA42 for ; Wed, 17 Jul 2024 08:03:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EFA006B008C; Wed, 17 Jul 2024 04:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED1D16B0096; Wed, 17 Jul 2024 04:03:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D68F56B009D; Wed, 17 Jul 2024 04:03:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5861B6B008C for ; Wed, 17 Jul 2024 04:02:59 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 13C3AA271E for ; Wed, 17 Jul 2024 08:02:59 +0000 (UTC) X-FDA: 82348503678.19.27189ED Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id B5ED640011 for ; Wed, 17 Jul 2024 08:02:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Dyp0m7b/"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721203357; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aac7mzpK+9VXNPOJ21/RuM77jIgKwx0OrsOzYAH/KZE=; b=g8RBjxTMSzk20sYVO+MvCZQPU559f+gBysz15JBFPzWIwpD8PvF7t959L+twVFfsGRAPNB u5lw06ftTwjWrPQdNf4Dru4mWRn6L+Xi7lupoWhVHftpzuQY3ZObH3T8HExoA+JggWMZBh dVqQhUaND12NtnzOSM0fjw2fNKHGZjA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Dyp0m7b/"; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721203357; a=rsa-sha256; cv=none; b=QSEM324Qo/MXZbuix/H130jcwD75GXg7GUJVyXwvNvvNF/HWHT9PdOfSiB0lsVrzayHNRf QuOJt9YKAsEvGCrXk4PN1rbXI1Ui3x7jUhLjGbep2CLrkT4nYwnSnXnv4oHN5hmGrOYEs1 SzDT5yJUgGVDZs2JjD/rl/DdXI082rg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721203375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aac7mzpK+9VXNPOJ21/RuM77jIgKwx0OrsOzYAH/KZE=; b=Dyp0m7b/SHiFhdjLV/Ava/aHhVUQMZ2vaeSfjiliut0LrZpmFH+8YJwnf0B0RaUkVXPv+J +fLsVvlJLdFGf1WmIYvIzbKXFz92W+itxwE/Gxm8aKjlixBnCSIyYy20YHjjMOaLg9tbCZ Yhxq3GZgSqf0r0epppPWJhpV6IevEsA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353-hIIMe4bfPIKW2D76hnvHbg-1; Wed, 17 Jul 2024 04:02:52 -0400 X-MC-Unique: hIIMe4bfPIKW2D76hnvHbg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4279c75c44dso41578665e9.2 for ; Wed, 17 Jul 2024 01:02:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721203371; x=1721808171; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aac7mzpK+9VXNPOJ21/RuM77jIgKwx0OrsOzYAH/KZE=; b=VeM+2WJ/VBSXwZk9cUOJFxtcF7B1r+5whG0BwfJGGBHcJHYWZQI63hWZYNMKtWXY54 tFBQj1W+k34zkFymArryIqwCGxBTSwrJoPk4mPy7+vJpBX1Mgu+QouqEtLpn2BPc4ZF1 BE9/0W4zujE6NN1FaO2nhzaTcRc5ZC4yXWVNx6kDraf5FkdY+rkjTNXh3ysHVB4OID6f bqOvqJUmZlyDbG9jYR0abqeOyf7a7sf2LSLSGGJUJ/4LP+NXwVWCfgt059Oi4WoflqEv LXuILUbwGdR28aCA5M49/RKMEEkdIl7QCFL+t0ym0Nh7GROi3vON6Mpok/N6qDHfVDQu f1zQ== X-Forwarded-Encrypted: i=1; AJvYcCXd7Tn9nQoXKW7jO/BjX5cxa3JllaJ8f3nKPoi6z460bDOE3rkjpD3zS2sCb87/W/DxODud121iOhB6J2Vp/mGQ5Xk= X-Gm-Message-State: AOJu0YxbosHQCHxN9etHtkzIliOUYWwgJj6ibAocLKhXHC3X+/jud2Hh cD47aLSkzNjyvuyE+zZAj1JWtXW7tw+/XxiDetFa9c6dP33sgPyCPTTCxWwJmULiqVWl57N1n32 +suioVrmQZiTqD4p1wq6bLTuMeargU9m82MEVVeR7/QKoigie X-Received: by 2002:a05:6000:18af:b0:367:f0d6:24e8 with SMTP id ffacd0b85a97d-368317376c4mr788189f8f.48.1721203371304; Wed, 17 Jul 2024 01:02:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEN5AtRZ4oICUJhKNgwLRtPqRrzAQGZwq+PhKjrttjnkY/yb3mUrW+vX7UqqlDhr8rd5hXdpg== X-Received: by 2002:a05:6000:18af:b0:367:f0d6:24e8 with SMTP id ffacd0b85a97d-368317376c4mr788167f8f.48.1721203370846; Wed, 17 Jul 2024 01:02:50 -0700 (PDT) Received: from [192.168.3.141] (p4ff23ef9.dip0.t-ipconnect.de. [79.242.62.249]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3683edc42ebsm182262f8f.90.2024.07.17.01.02.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jul 2024 01:02:50 -0700 (PDT) Message-ID: <9052f430-2c5a-4d9d-b54c-bd093b797702@redhat.com> Date: Wed, 17 Jul 2024 10:02:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm: mTHP stats for pagecache folio allocations To: Ryan Roberts , Lance Yang , Baolin Wang Cc: Andrew Morton , Hugh Dickins , Jonathan Corbet , "Matthew Wilcox (Oracle)" , Barry Song , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240711072929.3590000-1-ryan.roberts@arm.com> <20240711072929.3590000-3-ryan.roberts@arm.com> <9e0d84e5-2319-4425-9760-2c6bb23fc390@linux.alibaba.com> <756c359e-bb8f-481e-a33f-163c729afa31@redhat.com> <8c32a2fc-252d-406b-9fec-ce5bab0829df@arm.com> <5c58d9ea-8490-4ae6-b7bf-be816dab3356@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: B5ED640011 X-Stat-Signature: he31nuuyzukd6s87to7nk7r3jnccqbdp X-HE-Tag: 1721203376-444699 X-HE-Meta: U2FsdGVkX1/0TNpovcmK2m7TU1vnVbxIr3CpZM2AaNc3d9DxePFHnkyK1eHwHO2mQ6UZD4IcuzfnsFCNTjtV0w3Ov18JmjC+Uf9DtTUk5wVrtSpHrul/gH6zlIi/i32p9jwpNKeY5mlesYigFUcf/H/Yf4A9BnKeetgKXDIACYrRnb4OqrpTnKIof1r9plnra4aNLAm/EHOeYCvm0GiHUBKqCFYhS9B1XD20LniByq1ifrFy2eBWspbQ80yRMjl/Ey20WqLjvatUp0Mqfplg+3NaugO2hEXgjSj0LoSyO5++iA5m2Qh28rQ/yNARdb7qzM5X8gRYsmDCjO/gd4QVlqqla2gZ8bDXsqRpFu00gdk+Z/F7iBczvjFYE7y2oW8b4y5QJ29Wf4KDfMBCYQtVb0/r93HlPj9JeQY4dmZRTSnWFqG6Tc9C4mHepY3l9GYb8sJjsD3vKWvhpxWJc03q+LKDrHl9lHW23z6rLuBCEt65AqGNEwk8CLui3Fu+QRyeNuA7d+jXuWsGRtxNHKMZmg7r9axW/2iuF09Va2zJ75Jh1eKnBRHemuQ3JhRLZub9pF1MmFRsm5FYr6gq8trr9ij6MFwWKyEyW+4czeKUN8ruwLQm6RkYJICqRefRPA97Ep07gFeGR0659zXT5eOiVN0SKN72c1pJvinBTDPS3J3VL1m+AuWV/dYMnDS294I55VihrU2M3i3f5OjzvMvhf3HgqjsiTJ/30Dyu0bEBdUA2pdrgm0I1o0fLQ+ybCniQO+fduMxdXhA+yy7iKjFrpjM8qvA/CBECOuT0HZnD631BlGKXH22seRoAI/Nhg1KKrjQ4sbitcA2QKj13IdyEvyRSn3mrNrcAkmSuGq11iCezCrQZYera6eGISAC+OcLFnibGGmlOQnJ5cpToP1ZSlPe+xyM6emzxBor9x3q8aDgbFt5FRdUOQ9EhgAzLT4lGtKCyMRBK06DqCkdGD7o T8/3+mDT sjf99l5okvZRrHNfDCn1fOsOBPVwQm4u/uiaHJlbnpAO5DAEylzVWus10pggEAihjiNuxNWPA/X7Mjl874KI4YR0ZthabzE+Fx63cNEO92W0VwAuShvfS+Qxjd31DF6mXDsNS+RI5+77CMVOx16CXiB0dte+4UVzRR09jmPd/pSNS9M0fH/gdOUh0/IcIx8V+FBLAhdqnhHlqxvhA+Yp9QrhtoFYDgQEbWCAqPymzbwG9h0wXA3xXP9P6uEvAZjB2FTrlb79z4PM0Xor7qn8e2gq+Ztf13Np2d68mU9cyicDaQFeUWv2pTGL8E6G7rxHrwLSAiKezLnzgCqvlJR3p9OG97RAti6oa1I+8b3vLpoTxsBEGixwni3VcPZWcIVnj9KxFL/IsXwVIb7A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> Sorry, busy with other stuff. >> >> Indicating only what really exists sounds cleaner. But I wonder how we would >> want to handle in general orders that are effectively non-existant? > > I'm not following your distinction between orders that don't "really exist" and > orders that are "effectively non-existant". I'm questioning whether there should be a distinction at all. We should just hide what is either non-existant (not implemented) or non-functional. > > I guess the real supported orders are: > > anon: > min order: 2 > max order: PMD_ORDER > anon-shmem: > min order: 1 > max order: MAX_PAGECACHE_ORDER > tmpfs-shmem: > min order: PMD_ORDER <= 11 ? PMD_ORDER : NONE > max order: PMD_ORDER <= 11 ? PMD_ORDER : NONE > file: > min order: 1 > max order: MAX_PAGECACHE_ORDER That's my understanding. But not sure about anon-shmem really supporting order-1, maybe we do. > > But today, controls and stats are exposed for: > > anon: > min order: 2 > max order: PMD_ORDER > anon-shmem: > min order: 2 > max order: PMD_ORDER > tmpfs-shmem: > min order: PMD_ORDER > max order: PMD_ORDER > file: > min order: Nothing yet (this patch proposes 1) > max order: Nothing yet (this patch proposes MAX_PAGECACHE_ORDER) > > So I think there is definitely a bug for shmem where the minimum order control > should be order-1 but its currently order-2. Maybe, did not play with that yet. Likely order-1 will work. (although probably of questionable use :) ) > > I also wonder about PUD-order for DAX? We don't currently have a stat/control. > If we wanted to add it in future, if we take the "expose all stats/controls for > all orders" approach, we would end up extending all the way to PUD-order and all > the orders between PMD and PUD would be dummy for all memory types. That really > starts to feel odd, so I still favour only populating what's really supported. I would go further and say that calling the fsdax thing a THP is borderline wrong and we should not expose any new toggles for it that way. It really behaves much more like hugetlb folios that can be PTE-mapped ... we cannot split these things, and they are not allocated from the buddy. So I wouldn't worry about fsdax for now. fsdax support for compound pages (now large folios) probably never should have been glued to any THP toggle. > > I propose to fix shmem (extend down to 1, stop at MAX_PAGECACHE_ORDER) and > continue with the approach of "indicating only what really exists" for v2. > > Shout if you disagree. Makes sense. -- Cheers, David / dhildenb