From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37BB0C3DA64 for ; Thu, 1 Aug 2024 06:49:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DA9C6B00AD; Thu, 1 Aug 2024 02:49:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 98A636B00AF; Thu, 1 Aug 2024 02:49:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803C36B00B1; Thu, 1 Aug 2024 02:49:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 619896B00AD for ; Thu, 1 Aug 2024 02:49:39 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 050FE120932 for ; Thu, 1 Aug 2024 06:49:38 +0000 (UTC) X-FDA: 82402750878.05.4667BD2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id B20372002A for ; Thu, 1 Aug 2024 06:49:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ggB1Duj+; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722494971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S2NtmIp/4CuiXBD0LbwaFHmPzP6LgL2Oqy8LcjxKKkI=; b=uZRn+kHfIyOcx9It+o8y6i+RAyiaAV04NLQa2KJALLhMeAEnd9fjGZi4eWZVH+1DAfPxCb ANfz8RbWPpdGUsFnn8kqOEi1/2JxJYdUDbh7akfi1KldTU7/T21n4gjh+to07K2u37PlOC StXNqFkm+mY0Oj75Y4DbMz+C4c75/OI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ggB1Duj+; spf=pass (imf03.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722494971; a=rsa-sha256; cv=none; b=yU/ce8JOkBvKHNSMr9imbYkn/xeL3L3NDW85ylSS5TFJyIw8Z7QMFAB0Pv1jYKcAoCjOJ8 Q9n4x1DmclRNHmMpPgyDn2A4pClRtfxDYuMJ9Bhh6Y8jzhd09CpvHibcOapgBXPMw05+4N 5Mj7C4H9xl1UtCZCdhPuqq3/xt72i0I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722494975; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=S2NtmIp/4CuiXBD0LbwaFHmPzP6LgL2Oqy8LcjxKKkI=; b=ggB1Duj+ICE1r98CjpXaXypDCJg3W9Fr8eeny5FoyUGaBvJR9gHSwG2wmq2oETnNUoa/S9 aW54EtKWNEHHi/U0DmENcP21wYPkCA6mnZOBTS6EAv4A1RnFwRGMBX4QRnjuHM8ZV3MFUv Vpja4BnznQ7aTxRiISM4XojDsxKJQDE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-kf_kQn2FMJOQAttnV2U9OQ-1; Thu, 01 Aug 2024 02:49:34 -0400 X-MC-Unique: kf_kQn2FMJOQAttnV2U9OQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3686d709f6dso3476960f8f.0 for ; Wed, 31 Jul 2024 23:49:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722494970; x=1723099770; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=S2NtmIp/4CuiXBD0LbwaFHmPzP6LgL2Oqy8LcjxKKkI=; b=hYeyI96RCEyuCfC5c4m87PPauuPQjPIR9zs/w0IdbJmt5ttJRedCrK0rU9EaWLICCX dnJDbdUz+0rpn/nUMETIYZ/W3Jof8Yt0ZEEzDJTbiPT1jZDvX5ySpMVl4F2mQtJsrZxm W1AqAYkqxnhIHYFVjPIhZrbmxKv4/qlAKhybK9iqYMM2lbynia8//xSwn6LIOZBegkTC pmHCZsy1f7zUqjH06H7qP/geAn5W1FVQY6IerwS09aBddNufQvgvM6JEzC4NPg3IHKX/ cAxjvzBekb+h9dzYKkxYBJrqtHo68utDJlw+UZdaen81fi/8ZVX5BmSqoWS1rZro3OpX B0Ug== X-Forwarded-Encrypted: i=1; AJvYcCUZP9Id9ZNYuV882siVUOGhMqryWhEh3RJnY7LNSYri8szgbhr0gehoxV6wMUcWUZI75JrVRor9Jm1O4b6CHK+zNWA= X-Gm-Message-State: AOJu0YycUgwBI+nkNzsSgrpmzhkDvd2E2X5FvSsfivHQmUaNAtpc46eL rswDgxdbPjdhKChFKcDLsmgyBBas4BZI0/qqP9T/KT0ChwQpoVlQrOZtRtr96si1Rp2ruZR6sj/ Nom2ziC9ayQRWhBYgUbwr4+9i8k6UsbcM5tFn06sDqQYSUBkH X-Received: by 2002:a5d:4ad2:0:b0:367:f13b:ae8c with SMTP id ffacd0b85a97d-36baaf7587dmr760775f8f.47.1722494969938; Wed, 31 Jul 2024 23:49:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpzwZmizh4EyzTYJDbH8miZZukV/0//4Kl+vhqKeiXAb8XuDmeaEzSYjeYH9A66H0Me3EJhw== X-Received: by 2002:a5d:4ad2:0:b0:367:f13b:ae8c with SMTP id ffacd0b85a97d-36baaf7587dmr760763f8f.47.1722494969434; Wed, 31 Jul 2024 23:49:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:5c00:e650:bcd7:e2a0:54fe? (p200300cbc7075c00e650bcd7e2a054fe.dip0.t-ipconnect.de. [2003:cb:c707:5c00:e650:bcd7:e2a0:54fe]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b3686f73asm18531108f8f.113.2024.07.31.23.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Jul 2024 23:49:29 -0700 (PDT) Message-ID: <90477952-fde2-41d7-8ff4-2102c45e341d@redhat.com> Date: Thu, 1 Aug 2024 08:49:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] c0bff412e6: stress-ng.clone.ops_per_sec -2.9% regression To: "Yin, Fengwei" , kernel test robot , Peter Xu Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Huacai Chen , Jason Gunthorpe , Matthew Wilcox , Nathan Chancellor , Ryan Roberts , WANG Xuerui , linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com References: <202407301049.5051dc19-oliver.sang@intel.com> <193e302c-4401-4756-a552-9f1e07ecedcf@redhat.com> <439265d8-e71e-41db-8a46-55366fdd334e@intel.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <439265d8-e71e-41db-8a46-55366fdd334e@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: ncfnrfu4k866xujyggipciqg3dtzec16 X-Rspamd-Queue-Id: B20372002A X-Rspamd-Server: rspam11 X-HE-Tag: 1722494976-765725 X-HE-Meta: U2FsdGVkX1+Rsaw8lP8Lpoeq9AqO1BXvhId2b3NoTDk2dptOFdpm4gORdnruGCCxamfsStqmd2xFnr+EFk72qsTr99hkVeIEOn5ReQKkSVInakrKI0V5y4L6SrYLrj1zxBYtc69fNAcpycg0pYKyB/eTJvLvkBVSCJV1I5NK98qYTIDnUHZPcAmt9SdfApvzk2GwiEEsIcd+H+yxfdZM3OZAsILMsYyUmy22L9QsTGmQEwrpNU2AgE3ok1IZywmKcLpT0GpsVAJQ6cCnW68mJ6jNouZ8JWphfKafhs8nu3Da6h0M8DEDIdZlM2Rq5YbGF84WARO/DJ91n/ESFvKABJaARK63rRnSLpIUz/yYUSJ0UcbHgWNtlipV70S96o1bJbx3ZaYdHGKK1+x7VCY6oHOmDYU51oqV91akt8rmFgk2KIB1sLuIIL8sPIxUY2E4wNVaWcTc6IE/PZ/mi9/hfGVElx0anMeVJld4i+K2M2db0Tg/p6HBcctufPtId9XgL336YDcrAj2NYFaBD7hotRp375KuqPVvaeXw7yoMeBECLh/sJj6nWsLCLMl1mZJRhdK2xS0HEJI7TiDtKYQzUNzU6cN9nNVswBFnx8U2W7PGQw9/nD/OFV4AJHZ4X415I8uWrVkZEVgv5fm8oPYIGR7+xMYJxI6hfjEhTvTfcJe5A5qMRo3dL7KOzvueUjYYjp09conS+VZHX1u9E0q/bjW/PR3YC0z5Y6x1Wv8WyeUX+s+o/sX5sF9L+3/9rSXxu02fkEpUkgAZCfeQhYXK/urwEoO3He+YKe4a9h8pOtr5vqBa+Vk4M6JIg83o9x7UxgxnOkNT+H5rIvk87ufi4/v6j1BcjDull9h4JFTAJW7Fu/kiEekg9Nt+wsC2o5d+eXmqk+SCh2Yl0s7QHj6s6iF4b1prUrlioXafG9JI/i5nEJXGagQ9dy1N0095DgCwAJt4v4PZicdHQ0XfjoY Y4AyvpBD n4JRqp3MGsPa8pLf6i90hBi1n7WdVPE/MjpbphiBvnOh3/NTj1aIRMA3M32UiiQ01IkNBQMpcJ/1zzDp6+/q8a0lLSaF4Fb+0udnM1UkQIC4XXSjrocgNH3dERcn4cVv4lEj25SPRNAeMJCQPu/tlQxhjtizHgTq3Pk3PH/zeq57zPjCytkI6kp6FyPxTKVxYfIAyMrOlx3NepmtX4Ohr0p3fAOFyMk1OUvIdWQUIiVVJ2Ohr8JtS2eeKRrZuqvlQhj1E96Kt3JL/c0pAwx50Z/kdDAwhNeo+eMywPc49B08ynYRF6xfDR/dGSDEr1z9IEk+G1q9nN1OYYvxXghSfwmMwHiZm7huzX4di6ZcYbXi+iWCAQbCvYIlk9G4aFydPoU4O7iRF2JNskQBtFH9/xfubhpBCyzkMFlpiFYpdAre8BJsXd9thTkc9AezWDbsB2LHwbSWFDMrG21OK6D0fThJ7MMBklN1LJf4k6jXlToFYcYM6uvE37FHRutJxe1sSSbfoGCSuIbv5m9Z00vd9yK3nOB9n6X0DB4WsgpwuXeM96YvnaiL1kZnVpgzhoMEO/AkPdIvERiffqS8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 01.08.24 08:39, Yin, Fengwei wrote: > Hi David, > > On 7/30/2024 4:11 PM, David Hildenbrand wrote: >> On 30.07.24 07:00, kernel test robot wrote: >>> >>> >>> Hello, >>> >>> kernel test robot noticed a -2.9% regression of >>> stress-ng.clone.ops_per_sec on: >> >> Is that test even using hugetlb? Anyhow, this pretty much sounds like >> noise and can be ignored. >> > It's not about hugetlb. It looks like related with the change: Ah, that makes sense! > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 888353c209c03..7577fe7debafc 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -1095,7 +1095,12 @@ PAGEFLAG(Isolated, isolated, PF_ANY); > static __always_inline int PageAnonExclusive(const struct page *page) > { > VM_BUG_ON_PGFLAGS(!PageAnon(page), page); > - VM_BUG_ON_PGFLAGS(PageHuge(page) && !PageHead(page), page); > + /* > + * HugeTLB stores this information on the head page; THP keeps > it per > + * page > + */ > + if (PageHuge(page)) > + page = compound_head(page); > return test_bit(PG_anon_exclusive, &PF_ANY(page, 1)->flags); > > > The PageAnonExclusive() function is changed. And the profiling data > showed it: > > 0.00 +3.9 3.90 > perf-profile.calltrace.cycles-pp.folio_try_dup_anon_rmap_ptes.copy_present_ptes.copy_pte_range.copy_p4d_range.copy_page_range > > According > https://download.01.org/0day-ci/archive/20240730/202407301049.5051dc19-oliver.sang@intel.com/config-6.9.0-rc4-00197-gc0bff412e67b: > # CONFIG_DEBUG_VM is not set > So maybe such code change could bring difference? Yes indeed. fork() can be extremely sensitive to each added instruction. I even pointed out to Peter why I didn't add the PageHuge check in there originally [1]. "Well, and I didn't want to have runtime-hugetlb checks in PageAnonExclusive code called on certainly-not-hugetlb code paths." We now have to do a page_folio(page) and then test for hugetlb. return folio_test_hugetlb(page_folio(page)); Nowadays, folio_test_hugetlb() will be faster than at c0bff412e6 times, so maybe at least part of the overhead is gone. [1] https://lore.kernel.org/r/all/8b0b24bb-3c38-4f27-a2c9-f7d7adc4a115@redhat.com/ -- Cheers, David / dhildenb