From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99E5E77197 for ; Tue, 7 Jan 2025 12:34:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 42A986B00AA; Tue, 7 Jan 2025 07:34:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3D9BC6B00AC; Tue, 7 Jan 2025 07:34:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2531D6B00AD; Tue, 7 Jan 2025 07:34:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 048A96B00AA for ; Tue, 7 Jan 2025 07:34:44 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4FBCF1408EF for ; Tue, 7 Jan 2025 12:34:44 +0000 (UTC) X-FDA: 82980599688.19.3EA9455 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf13.hostedemail.com (Postfix) with ESMTP id 54DE720011 for ; Tue, 7 Jan 2025 12:34:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=SBE5Xjpn; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736253282; a=rsa-sha256; cv=none; b=kEEDU0pqLYSn3LNBTOH3/Pw7PKHGaR8pt0zOZvE6PvYmz8f4qecMAyq9tI/1qdW3lywvWN R2d2xhaZtcA/ffyQHnW15mjF0/PBoOQpm2r4T3ZMRER8Kyr8dK501pvtQnjtAi3zsFG+EJ S3zvvuXwAu88T1tdW0wOlIZ5qej80Nw= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=SBE5Xjpn; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf13.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.176 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736253282; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rBNgt4Pp+5r8EWFOkpTfSkW0RGZvpIi++k6cMXShG00=; b=waxzZfpmJtsMjYxpIW4PaNii+XHnkegFjhOr0WiX6RD34v5wsjKNkbSxBNfkak4TJG47tr nfhHkiCrO2C2y8wvoq1rH3450px2oWtN01py0iD5TICPmXBUb4ZuWuHj/hDWWjz01JAh33 1vMPJzrQ+Kcp4gowajrwF+SUSpUQ0/o= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2164b1f05caso220663565ad.3 for ; Tue, 07 Jan 2025 04:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1736253281; x=1736858081; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rBNgt4Pp+5r8EWFOkpTfSkW0RGZvpIi++k6cMXShG00=; b=SBE5Xjpn5CuV1pK/g9TsQRzWJnQVh/bXkO4drnr4ss9yhb10/mRVeYjt5o3lxX+68O ezjmX2Ibx+5BJAO4e6xiotAom9GDPN9R0N0s1KhvlN30qFpzgmofo/MbYiSMunRDudcJ EK7rKWksesR6mIxKH7e6gWPwiQ61tfanPmrpyIacq4l+UzyY3En5xE2t1ysQ2I8szh/C /g0liFFD9USh1We6XybHhkVKQUN0p4d9yKN5GoAR2j+gezjGu+jgqFsS2iXugO+CxIwT EWTlKChyhDvy0WN94Ca7qd7TrdWTELsoMxvSifABlu/bhkRSTOrdTGgRjZODkTmViaT7 5ccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736253281; x=1736858081; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rBNgt4Pp+5r8EWFOkpTfSkW0RGZvpIi++k6cMXShG00=; b=E6XF2up5iCTsVYgnQYkQI5U6C3QpT55+aahuH9i+KmsPK7U0L88imhpApGptc6i4+M Cev2VvmymzJ8ADDD/BhLhodtuUSS1p//Vga+iSk5c2yt6GnnoOvQafPQ2CoXevmUadVl vW4SSors/0bfWad10dPYSX/qfmhslzr0/eOdV97jBdtk4dGtKAHDJkgK5FtIFr6skG5M VS4Muc5oFCIHT+dhVKSQXFJlF2xFFu9WsOEN/87A6P97EPYpTVqlXg45X6EsFTo0SIlA rT9hB1cp0tecuf8FOKfUAsMy7+xK3pkIuJpV50ioHn7B9U+J+tHl6LkaOk1LndUB5ExF CmvQ== X-Forwarded-Encrypted: i=1; AJvYcCUIcAws7GaOp7Q9sGoI/t6KMglgFzEWf3CQ62Ys6l5h38TdXjorKxYprdBTAoOWBOrViU7QhkR3nw==@kvack.org X-Gm-Message-State: AOJu0YxTYflBHvJEUCRJwSi2bCi98OTS21mdeHBHNLBOaTWO5NvHrfm9 TsHv9XohYtaWUIlO1paG5DMyqzqKn/wkR77jTKQNxgRIfCDYbY4sAS7OqMz4H6g= X-Gm-Gg: ASbGnctkYuevJRJDLwPTWLw4pnEvBsPjIsJAPUJl2wh34KcnhNUCyK7Dh/HYR7QpgA5 UUqyaFaecS8bWRIAEO2sEm3woPwALmijHl7WpFoVKRHtjlpnbhe76mhfVVHsEF19ItkyeJVtY9o nAMKMhYun2lQfhD7SbAvEbgGiRecHxxGyH9TTnohY6OQVw+xkkHWaz+cAtkj+oZsu6F5gUHqD34 M9mP+falCr8xbn8Ol2vEr9hHS4hzDfXa61S8Z3usoUHPmKzvUTjHw15GZX5F4CFy2Dw4I48htxK +d2Y X-Google-Smtp-Source: AGHT+IE3yUUkb0m+aLP2spLDFrGsHc6y1BQTdsXYC7/WM0wTJqWEm80meD2oBwGaRCvgAk0D5TXwug== X-Received: by 2002:a17:902:e746:b0:215:8847:435c with SMTP id d9443c01a7336-219e6e8c595mr965146185ad.12.1736253280842; Tue, 07 Jan 2025 04:34:40 -0800 (PST) Received: from [10.4.33.153] ([139.177.225.247]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc962cddsm311379695ad.48.2025.01.07.04.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 04:34:40 -0800 (PST) Message-ID: <9040b9ee-88c9-4347-b8b6-5894b45e62b8@bytedance.com> Date: Tue, 7 Jan 2025 20:34:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/15] mm: pgtable: introduce generic __tlb_remove_table() Content-Language: en-US To: Andreas Larsson Cc: peterz@infradead.org, agordeev@linux.ibm.com, kevin.brodsky@arm.com, palmer@dabbelt.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, akpm@linux-foundation.org, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, rppt@kernel.org, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: <6e1aa2aa-a70d-4292-9c5e-21c8fea386f5@gaisler.com> From: Qi Zheng In-Reply-To: <6e1aa2aa-a70d-4292-9c5e-21c8fea386f5@gaisler.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 54DE720011 X-Stat-Signature: 13unbwoir6rr3rk13tknf8fmypa9nyne X-Rspam-User: X-HE-Tag: 1736253282-93615 X-HE-Meta: U2FsdGVkX1+RFHlYYjqx5FhI7vZpqE5TT+7RfIlXyrdACSxQxlPKWp39+KzwWqetRb5fr4p+fqrhY9GkprhyHpst8FqELrDEMmoOjjLLkYbFaIahAeHqzXPoqP944ZRuQ5pIgPk25joiivmAIXHM58x9vebbSeOJK95lGEzlb3jtnkgQt8ERooE0z76EJjfCZ6mGcjDLZVZlZlOBN0VPkCAsdxgk92MJN/HVzUu//XmcNENOWVQ6o9j9D/BFZpvayYLkSwKCHKJ5WYi5QUIQqKu4U8W9BFBGS/Jwm50BuMt2Ge5x3teIUZcA9HV1ISakLffe9FhjrrJFqdMW15tb9BI2vOUx+d6aUSAC6HUYAE6go7XhV19xr8LGtpwDDvbkF9bkW8LPhy6E/hMmVAVF7xCX/NRQCDm2td0icmVOdds/majmt0VvDfn9iJYaZkRwpz1b7TZ7qzYLw5Nj1fg6L1/FVgjs8usPSbe+qA2IywJVJGiI+bpub4sDRLBcu/8vF/NNMNInjXe064OfsGkzimeLWw9xChpCXkVRSzZN8/E2u3/tmFNvzuHrSFaLoUWrcmOEOJqGv5pZIQXjkwonVERri+enkqvYQhEH1SqqW+EmX/rSfg7hwjFvZ36rtQc8W/rtaomk2aM8jbgJg2/GvmzD47bzX9omVJz0X+u8JCsczamsOP75KVrOoiVd3oMnrfxz7JPCQ1q94Uy2Prh0AdReyJsenHitnmg5LW6HepG2qyaeDbisVHL1/aDAz9DKkWSyHIJq9b+3EpFvA/vkGSEwWFCbnXlir2P7q34/qz9K8DUMwMo8S5R5CIPGKQmuHLdjWrxzy1dRHGaeWyRvTH+D+VXcdvsBRgCyc/BXYqbangsAtOzR24RJcYv3juQrE+i3vHLlETRv/0LuiBNEv2n267Sd7REegD2SbTptRCONEfCtRdrkPGY0XrPHsCiX6TL83LyqNLXeWM0Ae3g d0GG6Lvx JTZ0oROC2Bma8Fi696ozRgfdrFbdYjTFzOz9fvFcX4SM5pQTOtgvMiRx3I1BAMy9DuF01Tk4g8iGie6AhKG76UAq20icA1GlKE0a56Jl6LWI2oyEkw8GWiUTy5ch5wJwdP7pSNgenpsaAMRE6vOgIcKz8BFTqnuU0PUFxo0KdkBsdIBa0ERa8zmDvs/AeEGLvghT4EyYfUkqkBEeJoGthN/PT+IeSeu0NjKerGgMm/mSO7HsW99Kzogb4VsBdzXXg03voVpXnojecAyA6uAvWvE5NGcMGYqAD3N06oEEMlvhVxyUby2GE9/wPJVAVREBEmYqheQZCIDJQnhP8YWVKynh79KBlIzE233nbSKPl0grEe5iobXQbtrNUWKzbzpUeMeATqV7A+8ScNfd/kyUNUUQZC0hxJj9S8lBI7PwoNXYR/8YUcBlaogaCU3fFkDb6zu4JkNDNO+EK53o5vsnyHaLh+wkNHo8wWHGZEE5xj9RkCCmj1VGq1VwvPK68f9RsnYX5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000024, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/1/7 20:32, Andreas Larsson wrote: > On 2024-12-30 10:07, Qi Zheng wrote: >> diff --git a/arch/sparc/include/asm/tlb_32.h b/arch/sparc/include/asm/tlb_32.h >> index 5cd28a8793e39..910254867dfbd 100644 >> --- a/arch/sparc/include/asm/tlb_32.h >> +++ b/arch/sparc/include/asm/tlb_32.h >> @@ -2,6 +2,7 @@ >> #ifndef _SPARC_TLB_H >> #define _SPARC_TLB_H >> >> +#define __HAVE_ARCH_TLB_REMOVE_TABLE > > sparc32 does not select MMU_GATHER_TABLE_FREE, and therefore does not > have (nor need) __tlb_remove_table, so this define should not be added. Got it. Will remove it in v5. > > >> #include >> >> #endif /* _SPARC_TLB_H */ >> diff --git a/arch/sparc/include/asm/tlb_64.h b/arch/sparc/include/asm/tlb_64.h >> index 3037187482db7..1a6e694418e39 100644 >> --- a/arch/sparc/include/asm/tlb_64.h >> +++ b/arch/sparc/include/asm/tlb_64.h >> @@ -33,6 +33,7 @@ void flush_tlb_pending(void); >> #define tlb_needs_table_invalidate() (false) >> #endif >> >> +#define __HAVE_ARCH_TLB_REMOVE_TABLE >> #include >> >> #endif /* _SPARC64_TLB_H */ > LGTM. > > > With the removal of the define for sparc32 in v5: > > Acked-by: Andreas Larsson # sparc Thanks! > > Thanks, > Andreas >