From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89BD6CDB465 for ; Thu, 19 Oct 2023 13:03:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 093E080099; Thu, 19 Oct 2023 09:03:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 01C9E8D019E; Thu, 19 Oct 2023 09:03:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0FB80099; Thu, 19 Oct 2023 09:03:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C469E8D019E for ; Thu, 19 Oct 2023 09:03:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id CA42AA0516 for ; Thu, 19 Oct 2023 13:03:47 +0000 (UTC) X-FDA: 81362228094.14.AE6E006 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id E3CA81C0042 for ; Thu, 19 Oct 2023 13:03:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=biY2pXpM; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697720618; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cOdqO2XoxuRzuqyPGyewOktUv4c1wTFsSVsSHrfwggg=; b=en90cGqvP4FIv5GjiougsHMIB3hsWo1Lg+U3nUqpuecp+jTRK3igQ5AoLydsFJzBJnLpm2 crBlIEU7B2myKNxBqopCF8xfpdCHzGXtkbmgG81vp/QyGrGPRAi0fiiiXFADnkR4W9Yabc XrkkO0sNzQemDAG7KtLh9oAN5gmIHY4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697720618; a=rsa-sha256; cv=none; b=p0VM4GWr2DYUxnMOT3xHbEMjz7xF8UuZK1beUe/1SX1O9iXhBLGch/6rFZinFxFjH4gf6U JEbOBcixfb6cukbkv3/OWKKpuOfpxBWrs4tbG3Nk4ZowSiuY5lvQYpQHn0FW9EghCHaxc+ dr40+Hm523EusJDsDqwJ2n3AFLNa3Wo= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=biY2pXpM; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697720617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=cOdqO2XoxuRzuqyPGyewOktUv4c1wTFsSVsSHrfwggg=; b=biY2pXpMAsvQlySfCBzrMK7/LYUpsenP0ya0B4EtAzjq3d6cmIBEdmPVh8685OKhyiLP9e 7Di1jfjxBu+/TjB83DWKHI//BqgZfiNMG9ksqyPHbUvyxOQ97XLB0jwFWvKmO+0zyqbQiU cr0q9yJSmqQk2w/ku17zq7Cwg91yolo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-uUhI1ZcGMQiFn0bYKf0WLg-1; Thu, 19 Oct 2023 09:03:35 -0400 X-MC-Unique: uUhI1ZcGMQiFn0bYKf0WLg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40570ccc497so60770945e9.3 for ; Thu, 19 Oct 2023 06:03:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697720614; x=1698325414; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cOdqO2XoxuRzuqyPGyewOktUv4c1wTFsSVsSHrfwggg=; b=EWA0Jg0SzneKRcs+l51ysbhhE3HxqtLoNYzWk3/+HsWG8oikmgiy4iwk1xcUOe6yJ9 EOSXrDZ/eRb69jSPWEsM10nJPAZdpfZqimJCYAFB/ygfhK9VRVc77QXV4iRjs4Y6mOfX KWWvz9Q69gbl//q/H9SI8uSBnvg4+gv0EebQnvSAqkZOQUe8SYZNQz/zuM03M1T6J7V9 7HdfzZPgqaOFAS/Twq584NwJRUk4v731xSBgAJU9nLdCl4YwKlPbDq+zYgfKe3TDd3Kn CbQMAWwuKD1mPuslyzZiylali7BIbUypSNNrQeZEVcpvZ2cSOgZrCNFC/CqpZL3ba3Wn Qy6Q== X-Gm-Message-State: AOJu0YxJQXsMqRB0G7mEgDPLaKXdIqs5vMUNmAdj6Pjd9CueODOFPYgO 7nd/pngEyjpfSTcAEC//84BhkTmzC/HUVkd2nFd0I6T/xHPKWtAmyua6+u1t2Rr8DlBM1zvPtp3 C9XPAJFbbiZI= X-Received: by 2002:a05:600c:1c93:b0:405:458d:d54 with SMTP id k19-20020a05600c1c9300b00405458d0d54mr1783650wms.33.1697720614478; Thu, 19 Oct 2023 06:03:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEniR6jtcNlcaZfheicelDCXWNJbEihe050M5J3eISf3Ms5mN5cNL5iDKMtru5WeI22XJDipg== X-Received: by 2002:a05:600c:1c93:b0:405:458d:d54 with SMTP id k19-20020a05600c1c9300b00405458d0d54mr1783626wms.33.1697720613985; Thu, 19 Oct 2023 06:03:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:500:6a06:17fc:810b:b054? (p200300cbc70b05006a0617fc810bb054.dip0.t-ipconnect.de. [2003:cb:c70b:500:6a06:17fc:810b:b054]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c1c1400b004065daba6casm4464578wms.46.2023.10.19.06.03.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Oct 2023 06:03:33 -0700 (PDT) Message-ID: <904094ce-e340-4bb7-b50d-6aedd816e569@redhat.com> Date: Thu, 19 Oct 2023 15:03:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: vmscan: the dirty folio unmap redundantly To: Zhiguo Jiang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: opensource.kernel@vivo.com References: <20231018013004.1569-1-justinjiang@vivo.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231018013004.1569-1-justinjiang@vivo.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 9mojddp1dn6wq3iczgtj4cseuqyfunx1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E3CA81C0042 X-Rspam-User: X-HE-Tag: 1697720617-100495 X-HE-Meta: U2FsdGVkX1+yFrfZ3eBEPt36/hbOAjXKbD95t1JzYeo3Oc4EAb+RPsTh0j++74Mq+WHjJQRhWFFFA7HNrVRquerZBFG0oS+2pPXn8Hsy7AMP4U7vAzeCqThlu5+SF4V9/mYpNAO/S86Ggi/jYtGcMmfjdzSbuaGVpZTRZ1dSUOxooQj9xM7Re0YsK/aR0AC6FSKrUUy9sSR0V+1I/GTmoTvDy037cLsTBtr8ZXuaUuPK4ouW11+xAqNqQ9z1sJOmJvZ7w39qcjy0kT7/nL2syZE9OvFCyDFF5u75kCYTDC9Xy9XNe72BVWaxZbMvi13KgJmXMHqr1XpTnNtOMA9n/Pi7OYVYiITg4fdE/hoRgFjwVC9rpX5dmCqGYDoJodPU6K2rF25/vKRBT19b+H4HJdEKdQf7ZlGjrVofrHVrmvMsZqTRSwrpWWn8IIBxCmdCo3+nGnNYpjo8fd8kvYJpNUyO90FWmLAeIIRpKK3XtI1bpEvM9biy5VbR7r6hZMH7rKWEwoh7z8xyETRVDq7Zb8UJXW1Y+xqhru1xi3kla8gC+vImHDNw5juapwFn4M/n47tPfpzGYBLe1RnMRqB/k+HkCLZ6KcdehTc/OH9Bf+WqJoZK7xL58qI6PiAA+xIocNQni0FWpMFiMxIjzhwsA1rMDJePACfLKyG4W6RLWqQQVRFzkLxm3GHufIJt9cyIcm5MK5+qJvDDivLkg1WYQ7OGSmib9Nx8JW8Yp9UoTnMHoQ5PZFRIblbCHqDCjUbPRKR8JUHk4hxukVloQ0S5VrIM/qBQ9o4xtydQSIq9HSgVBmJ4SEJruT9+NwtK+rgQYbInyuxL6cmJGwMp5ZhcYj/70YuDHvQ8z/yVO7iTvoF0rUVUEKkLMgaa06Mi6SxMuVpLQqZWbHtQ6H7tkeq/3tmMicSMBatWUt8mI1ctiPPn0GSeHVHGsGmOpKc3W8m1+pytiKmcM1e24HclQqI hIQygYke 8rC1SI/VSLdIehZCXEc8GZzNJ1PFmwZa5JFM88VdsbRjdMx3zcbMn1SxXsQQIAjoQgX7dsuaezfnI5+SLeIsWLIXXvO+U4TPEGlgMBqF4QV3h3SO17Ou4ThDQ+t+4JCLdEjbChhNPjtGWxmUelxnAqfntHyO17GpvSxV8cZevn3TKB13C75gu4uYbA/8yE4B7dBDKVDoDG+OMNVy56F8z86Pf7Ei818mnpyz+Wd0efNbNs+bKIXfZDYhLg17xqRN9RAAs3P/RcEX6A96ILq9ZQyIk+FS4SueIbPqYbrEhhb6JMqPdugCg61DmSm6KVIA0Zkzd/w67250zGdft2nNSnSoxUOwekvTacAuD0J5MRwJLp8YxqyDW4Y71j3Gy9Crc5GVGR/t6hIL8bJlLSEpLkXeUpfvRnrGE2j5aV0/TG+S7gAuUuO+JwCJ7NxCkGGSrQUhySyqisheMz6dTHP3ccxrqIC9JovpShrcc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.10.23 03:30, Zhiguo Jiang wrote: > If the dirty folio is not reclaimed in the shrink process, it do > not need to unmap, which can save shrinking time during traversaling > the dirty folio. Hi, I really cannot understand what you mean with "the dirty folio unmap redundantly". No clue what this patch is supposed to tackle by staring at the patch subject. This patch is supposed to improve performance. Can you provide some proof that it does and that we should even care about this change? > > Signed-off-by: Zhiguo Jiang > --- > mm/vmscan.c | 72 +++++++++++++++++++++++++++-------------------------- > 1 file changed, 37 insertions(+), 35 deletions(-) > mode change 100644 => 100755 mm/vmscan.c > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2cc0cb41fb32..cf555cdfcefc > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1261,6 +1261,43 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > enum ttu_flags flags = TTU_BATCH_FLUSH; > bool was_swapbacked = folio_test_swapbacked(folio); > > + if (folio_test_dirty(folio)) { > + /* > + * Only kswapd can writeback filesystem folios > + * to avoid risk of stack overflow. But avoid > + * injecting inefficient single-folio I/O into > + * flusher writeback as much as possible: only > + * write folios when we've encountered many > + * dirty folios, and when we've already scanned > + * the rest of the LRU for clean folios and see > + * the same dirty folios again (with the reclaim > + * flag set). > + */ > + if (folio_is_file_lru(folio) && > + (!current_is_kswapd() || > + !folio_test_reclaim(folio) || > + !test_bit(PGDAT_DIRTY, &pgdat->flags))) { > + /* > + * Immediately reclaim when written back. > + * Similar in principle to folio_deactivate() > + * except we already have the folio isolated > + * and know it's dirty > + */ > + node_stat_mod_folio(folio, NR_VMSCAN_IMMEDIATE, > + nr_pages); > + folio_set_reclaim(folio); > + > + goto activate_locked; > + } > + > + if (references == FOLIOREF_RECLAIM_CLEAN) > + goto keep_locked; > + if (!may_enter_fs(folio, sc->gfp_mask)) > + goto keep_locked; > + if (!sc->may_writepage) > + goto keep_locked; > + } > + > if (folio_test_pmd_mappable(folio)) > flags |= TTU_SPLIT_HUGE_PMD; > > @@ -1286,41 +1323,6 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > > mapping = folio_mapping(folio); > if (folio_test_dirty(folio)) { Can you elaborate why we want to remove below code? It would have made sense to me to duplicate the code in an early check before unmap, if the folio is already dirty before checking all PTEs. But why can we remove that post-unmap code? -- Cheers, David / dhildenb