From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE40CC36010 for ; Fri, 4 Apr 2025 21:00:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6665E6B002C; Fri, 4 Apr 2025 17:00:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 617596B002F; Fri, 4 Apr 2025 17:00:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48F816B0030; Fri, 4 Apr 2025 17:00:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2A1DE6B002C for ; Fri, 4 Apr 2025 17:00:08 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E3C70581E2 for ; Fri, 4 Apr 2025 21:00:08 +0000 (UTC) X-FDA: 83297578896.18.9753ABC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 90C3914000B for ; Fri, 4 Apr 2025 21:00:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CrzAq3aS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743800406; a=rsa-sha256; cv=none; b=1ra5C6nXA3FDTtWwM+RvxvO8mLBKpuc1cUctgxWmqnxVyKHaK1xY38eQ3IqAx5jTfWx2b1 o6jQVlvW4xctvJBQa8tiGxm1DvPcPeoKCjnhNwXWCarrJEmx807Y+aSSzyqqWDv3WvQRrY EV0Vp63zLkn+DTwaa3jV8vxX5KNQoI4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CrzAq3aS; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743800406; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YhsonaFCzIfa4nA3O3+Fv/1AXGJWz31w9SebUkiE5cI=; b=0VgsGRt2x5fxlKUKV6tw7/sWrA+HVJMvA8FFh/l/SW4Q4p2yYUfKmYhWgaLQ2k7QkMGOy8 1Ox36pTbT/fUFAPPPw0mhy6L2oEZxl0hUMFidfabZeqezbsxK6fZomcOYMV+6nof7nhmcM YSdXqM/EtKrKtuf7Ul0BNCiTqUNWgpI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743800406; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YhsonaFCzIfa4nA3O3+Fv/1AXGJWz31w9SebUkiE5cI=; b=CrzAq3aS5orEjmI6wQNJuRoyEvVj3lz6WU2UQl1fGLFJtiwJcEFTB8ODpG2XxNdITbiKbl g/tQOtmlprrmR7ABkrqi6LHpV7ArRafQIRJKrw6Vmaayapg986xvmXSS3pB2azkJYRs+Kb J5+M7u6RJgWBQW4YSM3UuwesSart1bg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-536-P1v6qiVKNI2lSR2_p6wu9A-1; Fri, 04 Apr 2025 17:00:04 -0400 X-MC-Unique: P1v6qiVKNI2lSR2_p6wu9A-1 X-Mimecast-MFC-AGG-ID: P1v6qiVKNI2lSR2_p6wu9A_1743800403 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-391345e3aa3so1422821f8f.0 for ; Fri, 04 Apr 2025 14:00:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743800403; x=1744405203; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=YhsonaFCzIfa4nA3O3+Fv/1AXGJWz31w9SebUkiE5cI=; b=jn1QaefvrM0i3geGYRUBUpB8iPNn7JzC6zbE5HDSlU/WEVOVpEWMOu8dRvklS9EXel G2LdxOwoSRGnNjDxSia8QLK0gfLgxswUCefzYKgUSyX9kQufO2PGtwXnn+43F3Etv7pV tMXo2+2A0GaLC6qjlJKlTQcXH704Mvy4ef+3I//VR7R96Q6yfOe7LZPfNuHTIQLR9fg/ vwpOFXYXAAuvMji3otVgsOuYobFjC1t3xrbTzLh4ME9Lpo4u4OyVU9K1Au5N5K9lqoVX h6phCov6jI+iPdV8ZUGQPnYqXXlDwI8oUD3J4W7kNd0hLfcjT34z0CAjizic06FRlg2y UZzQ== X-Gm-Message-State: AOJu0Yy3UioY90TgR89frpj+7fINR+zoBLcv2u7x4xX0w+rKuKSaYxRx pVcia9QFRcwRQEvBNrFK7HwodDR6Nv570y6T9NFyljCjESYWDMg32nJL526WWaRatTcYAP/t+mD aLlKsl7UgjGoKOQza/7+k4uJq++O7yxWvTP46OAmY1eSXiRyEmOtFjuw/LngjIQ== X-Gm-Gg: ASbGncvN4TNd5bvMbtwFoYWF2m8ZQ2JIKCD9hZmGK+6zf34rZzkEmntbAbzBL1CLIFY rBzWtOneTRwxh7sb2XLybMmM/KFS7t6zKSMrjz8kY/bKI8W0sDq8GhDUOpb7M40qLALgYBYo6FH VoVYqGiLwMt1gP/PHNvYkAXUOSnF0b0rZCRyPuu9d+IIMzZtgqjWbxurmlYW0lYXyT7M5iuRUl+ tEw7kJIKvcZUNNrTsmQ9nzJdf4+qXHcMImwoygGnwx8FN0oyna6I9Sa29hJBUicCOFg+WmnekjQ m6nqVQJOZPPouAkbpi+sqQ50r/UrWATnhKffiKiQu/32O3Bo9xLZOz5URAZtOqYv2ggw4uQSRXu G25nEueqqVa+hobLd+BmF+Tx980cENZEeVUTwOpkqjQo= X-Received: by 2002:a5d:5f42:0:b0:39c:e0e:bb48 with SMTP id ffacd0b85a97d-39d6fc0c1b2mr535835f8f.8.1743800403456; Fri, 04 Apr 2025 14:00:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHNzBLILDl3rt90I0MAcaLgMDWJ4unyzR6xSnv9sHaM/OKHBMCkSlm4xBYV7VcZ5d2IrpmePA== X-Received: by 2002:a5d:5f42:0:b0:39c:e0e:bb48 with SMTP id ffacd0b85a97d-39d6fc0c1b2mr535827f8f.8.1743800403150; Fri, 04 Apr 2025 14:00:03 -0700 (PDT) Received: from ?IPV6:2003:cb:c71b:7900:8752:fae3:f9c9:a07e? (p200300cbc71b79008752fae3f9c9a07e.dip0.t-ipconnect.de. [2003:cb:c71b:7900:8752:fae3:f9c9:a07e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c300968c4sm5260127f8f.9.2025.04.04.14.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Apr 2025 14:00:02 -0700 (PDT) Message-ID: <90309a63-c817-4b60-9b09-ff558a79d5af@redhat.com> Date: Fri, 4 Apr 2025 23:00:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] filemap: Remove readahead_page_batch() To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org References: <20250402210612.2444135-1-willy@infradead.org> <20250402210612.2444135-8-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250402210612.2444135-8-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JYvdQZ4DsUCJLKqzP3m_Z_apBhBWCrO_n6dEARiNupI_1743800403 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 90C3914000B X-Stat-Signature: 5sb3dtxjaf8exsypd1k7by76f1ahxg11 X-Rspam-User: X-HE-Tag: 1743800406-646998 X-HE-Meta: U2FsdGVkX1+E3bZUrlNnEP0BX3aFLZ8Nxdvs6PAOlLqDm/I96fGkKvpkFC0GAo5/OhmM2rsOcEjQBOWeeLUJ9omX1GpXjLS21c2o2BSQAQ3usHU/yOzCKD21VUV1Lht1DOF2zw5mI1/D3mpzlkzwoJaYWIVYyF2jwPxZnKf6vjkYKccQucV1xThfWAQ2RWimUyRZ6UktIt45dqtvzD9F9YLJ0L0DFBKjiwJHq7STnWileJVF53+3S9GwyvLX1nJLN9zdqz2nyegub22Pj08M83ujA8fDMmJJyLkcy3UAfnxEo3WAsRyenDVPZ8VJ1dQV/3zq3iM7niVBwSdK29rtgxK7I964RuOhRMQaUTIt1qZ+OJABHal9E4KwnHsG7lszngaPku3gjl217QS2GQNmUWEJG8DK2p1LTadao+tr2X3hqj4rC0Vpnnn3F+9Rngkg4L86NanHortx00A+rI3n/GK1neVDdJ8vvez/RYjk6etHwQgHP5aCEGP9ZlP5IenObBOgz6PpJmZi8iFoxtfumJ1bsG/7qvpfYKGrJ710NtjY1KxIjZWReUTY8ji+1vv49DzRJnraHrJL5h4YAp5cGLjnV7pjgIUx4W08c8EwqD2dee3uzAqP3i0dBmK1AroBdrvvA5u6Itlul0ahfdez4cf/Jkn/uYHm1sZil0Sl1RynEoL6OK4cukNythEf7AFHxRWL/9iNVHz2IXCm/rLT1hbafIrq/hJxvpDEN/bveq9Gl2JvcsldS15dCdRMS1l5KVvPlWqfn1ruODW7YH1xGdMw/FJ4Pg6XqmOcHGcLM01/P4tFuKwyBqfpUwsXrjlTqTu7jagMteGBT2D5cVPfbKA1KEPnQvOqKRZRoECfgEsDoncbKdM9iI6JHtDsQbZd8nCNI/MOFuEN+Kk7UeRuwVTeCZxBuUQDVWz9HLve7JTLjfBdF59WZLDeROBg3SVBlHLLeiv+fFbEmZEEaCa QykHtKOu SxuPMuyvM23TZOM4YAnJGTpFGj123Q1r2UJPAY9IZdhhN0fWiPbwLcPK/TzRmUhe7rfqoq6eMGMeETjnaKuAOYIqtmFQVbWaKZDqQl1jkgTTpknfAAw2CHJRVY9nlmxFZ8KqwjvEauyorqvHVlgMirChXttMOw/wLQN2OY8/MsgqGqRo8C2Hxudpr50MRFE0/3JhLrMZ+spl/gvNLgFHyhASp1sw1OxP4QMKoa2EVE7YejeF7rgqII/hb+/aJ0az28h0kNpFYXgW+MKCPq7F7uQlEVz1o7AgRmM0SQGfRyC9ehSqsZ8ZfRPejsxHZPYZC/cyPsUG7ThItkfI03S7mD8DPGweJNcZGUyviDkGNbsySPjKEuYWPaQAsn3xbikQoUKXYFmeHRfEKMXnp61CQRLBFolxDYlpyKi9PWXkjqR4XEDoYmye9+uQmZpAAfYRclA4CNfJh96BG+WKQHmLjF+dCTk9UN+UsHP22oynBslwtHxSUZnEptducXr0YZgfu9eEcbGmlku0waImxaB5Lwrbwlw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.25 23:06, Matthew Wilcox (Oracle) wrote: > This function has no more callers; delete it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pagemap.h | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h > index c5c9b3770d75..af25fb640463 100644 > --- a/include/linux/pagemap.h > +++ b/include/linux/pagemap.h > @@ -1447,20 +1447,6 @@ static inline unsigned int __readahead_batch(struct readahead_control *rac, > return i; > } > > -/** > - * readahead_page_batch - Get a batch of pages to read. > - * @rac: The current readahead request. > - * @array: An array of pointers to struct page. > - * > - * Context: The pages are locked and have an elevated refcount. The caller > - * should decreases the refcount once the page has been submitted for I/O > - * and unlock the page once all I/O to that page has completed. > - * Return: The number of pages placed in the array. 0 indicates the request > - * is complete. > - */ > -#define readahead_page_batch(rac, array) \ > - __readahead_batch(rac, array, ARRAY_SIZE(array)) > - > /** > * readahead_pos - The byte offset into the file of this readahead request. > * @rac: The readahead request. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb