From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54E1EC433F5 for ; Fri, 11 Mar 2022 04:51:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B12148D0002; Thu, 10 Mar 2022 23:51:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC13F8D0001; Thu, 10 Mar 2022 23:51:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B0228D0002; Thu, 10 Mar 2022 23:51:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 8798B8D0001 for ; Thu, 10 Mar 2022 23:51:38 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5126D24C74 for ; Fri, 11 Mar 2022 04:51:38 +0000 (UTC) X-FDA: 79230882276.05.000A950 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 97BE21C001F for ; Fri, 11 Mar 2022 04:51:37 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D93814BF; Thu, 10 Mar 2022 20:51:36 -0800 (PST) Received: from [10.163.34.78] (unknown [10.163.34.78]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD3C83F99C; Thu, 10 Mar 2022 20:51:34 -0800 (PST) Message-ID: <90246c21-94e9-e64e-dd83-fce45de89f72@arm.com> Date: Fri, 11 Mar 2022 10:21:34 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] mm/huge_memory: remove unneeded local variable follflags Content-Language: en-US To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220310131253.30970-1-linmiaohe@huawei.com> From: Anshuman Khandual In-Reply-To: <20220310131253.30970-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: g8pq48xtb965a84kbfatmg8d8q1rwefm Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-Rspam-User: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 97BE21C001F X-HE-Tag: 1646974297-500121 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Miaohe, On 3/10/22 18:42, Miaohe Lin wrote: > We can pass FOLL_GET | FOLL_DUMP to follow_page directly to simplify > the code a bit. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 3557aabe86fe..418d077da246 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2838,7 +2838,6 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, > */ > for (addr = vaddr_start; addr < vaddr_end; addr += PAGE_SIZE) { > struct vm_area_struct *vma = find_vma(mm, addr); > - unsigned int follflags; > struct page *page; > > if (!vma || addr < vma->vm_start) > @@ -2851,8 +2850,7 @@ static int split_huge_pages_pid(int pid, unsigned long vaddr_start, > } > > /* FOLL_DUMP to ignore special (like zero) pages */ > - follflags = FOLL_GET | FOLL_DUMP; > - page = follow_page(vma, addr, follflags); > + page = follow_page(vma, addr, FOLL_GET | FOLL_DUMP); > > if (IS_ERR(page)) > continue; LGTM, but there is another similar instance in add_page_for_migration() inside mm/migrate.c, requiring this exact clean up. Hence with that change in place. Reviewed-by: Anshuman Khandual