From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB90C61CE8 for ; Thu, 12 Jun 2025 07:54:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69FBD6B0089; Thu, 12 Jun 2025 03:54:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6507C6B008A; Thu, 12 Jun 2025 03:54:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 565906B008C; Thu, 12 Jun 2025 03:54:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 375C86B0089 for ; Thu, 12 Jun 2025 03:54:00 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E21F0140BB6 for ; Thu, 12 Jun 2025 07:53:59 +0000 (UTC) X-FDA: 83545984998.28.DEEF5A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 47EC5C000D for ; Thu, 12 Jun 2025 07:53:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Xq/kjhFA"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749714837; a=rsa-sha256; cv=none; b=wOxBhE9qp7yUtANuHQfWNWUIiI1anWQdvUtVGbZzwo3RWQTqfMlsTaeifbbwQYlxcxj+1m AA9tVfdL9GgifDw+FrnFyjbNXthGzxxyfGUyJ7r/RY1YjLDG8anEXQdvFzU4nyG6tL3VxW rBpnZmZ59+c0GU+kc3uCfF0rHGrl1TM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Xq/kjhFA"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749714837; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RH/H6EVFYHA1esphZzDQR2Ni+mAvwvUgy0mBlarrn6I=; b=xqQpAOcwZznNgvzOkl+ZBlc10Wj3CVrgvnAO3RdZHD+2g2zH/d0IVNYNAoTzb1oYoSXcMG Sul1j9WIwHjHCtF48nmasGUGiLJuwNAzcH0EoARkSFXVsTnfRULZkDh0zgomuN8b66Rn72 LmsUVXEqBS0woHfOvR0vvA1Ah08Uw+k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749714836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RH/H6EVFYHA1esphZzDQR2Ni+mAvwvUgy0mBlarrn6I=; b=Xq/kjhFACcOLcoIJURDL8odAlRYXn3z4TD43A1Fl9pt/vG4+5kpeTEGXbSlmUWPkl2yAq2 /fwHele0od8argbNAJvyZv0yVyrvp02XdQJLlJ3uNSQPi1ZzeoDuVpCyAZpSTNmK5+VQKh vdg4ohYV4dVK1n4LuFobLucEgL7fMOc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-ZvoE1y1nOuKf5katrwjKWA-1; Thu, 12 Jun 2025 03:53:55 -0400 X-MC-Unique: ZvoE1y1nOuKf5katrwjKWA-1 X-Mimecast-MFC-AGG-ID: ZvoE1y1nOuKf5katrwjKWA_1749714834 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43eed325461so3318925e9.3 for ; Thu, 12 Jun 2025 00:53:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749714834; x=1750319634; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RH/H6EVFYHA1esphZzDQR2Ni+mAvwvUgy0mBlarrn6I=; b=A/7H+ZwZqmgL4VEv6WLKg5cbz9cLi2Iey6j/fNOIng8QMjZRtfVMd2RS9wetgzGLdE c8S6rvoxyr7WD1bOBRlji/iMSB7w8r2mzrz3Lj5aijLycopS2ShIu2hPSF26Hp1H64Ep IWzGoZue5hgOy+1RD69vtguX/hLzuWg1UDCFPDdn4foeNVtPI710H+tK4Mw+yfFzjGXa PQB8zcbiY05XOhVVQfwCmj43TNZDEprdMKoQ143FHixrgElRmPCeU4l/t+a0DBAHf9KN dlAVj6bJ/8u9Zpd4o7y0gfA8+jVqV79B2x0WpBmd8LaRtedA9/d3uXcVYkLQXo3BSIzT d4lA== X-Forwarded-Encrypted: i=1; AJvYcCVsRqYGoLWfhU5KUGr7uQnz9GVtmhXL9qHRgMEAG1x5q88n6ZqyAtKoPxrSedoUWB6qSARBBtkGYA==@kvack.org X-Gm-Message-State: AOJu0YzJMMJuvDw5qQEv5XmwQC79hzX+CGQWaA0FoW125OJPbCSUKc2X fErDmiUP7paHxH9QyIGVoBPaDJcU6v/GK+bI8hHUByQsyKmRUNPwb7KAvd2QFS5sJnEaTtp9WzS lDCTlrhtRym9Xm2u6Me0DlqFfD9EgaChwCDl8/HKbw39yJiexqHeA X-Gm-Gg: ASbGncvrfC7w+GD++ifw84DLBMZrKZhGesl1+7Kh+CVH2jfuOMXFqZbWPzqP1NuROt7 fOpa3XTmDRoot+KzXSiFen8Vz/9ydCBA6wV+5s5A/UdWXq+GfWAHH6GqlZGmNK5zjp4e51J/Jtv GOJ8Q34sulUdCO64ciIj3VWLEGcgUEGYkQVou45wtdGDyQxcltNmWjEkCg2VkiFKvVexHP5JtvW 9sf7n2qcxcbrs+t/2IDTeUz/p7WuEnufPyrLtTd18Xn2Pfu9WCOJC2b6+sGQRPBsqyGZ67N7+1u MkHvqTkWMTL4swnPDdg6pBRXHUH8Harhu4e2b7vIjvEoUSalDOJOTK+fSoWYaq9C6FWEO4QE7cO iUn5nOTWV6DZ721Wh2cZTA9O1IyfUqFrZwEu1T6FKssEU0VfgzA== X-Received: by 2002:a05:600c:699a:b0:444:c28f:e81a with SMTP id 5b1f17b1804b1-4532b9298c5mr24403195e9.27.1749714834042; Thu, 12 Jun 2025 00:53:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsLC1gyEaaAhbwITsqYaFg+Rs7QaICk7BZoCo3p0/fRcL4bV/eQjvqizXigrX0h5RxQPFcbA== X-Received: by 2002:a05:600c:699a:b0:444:c28f:e81a with SMTP id 5b1f17b1804b1-4532b9298c5mr24402955e9.27.1749714833603; Thu, 12 Jun 2025 00:53:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:1e00:1e1e:7a32:e798:6457? (p200300d82f2c1e001e1e7a32e7986457.dip0.t-ipconnect.de. [2003:d8:2f2c:1e00:1e1e:7a32:e798:6457]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320580af6sm57902135e9.1.2025.06.12.00.53.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Jun 2025 00:53:53 -0700 (PDT) Message-ID: <90112dc7-8f00-45ec-b742-2f4e551023ca@redhat.com> Date: Thu, 12 Jun 2025 09:53:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list To: Zi Yan Cc: Jinjiang Tu , akpm@linux-foundation.org, linmiaohe@huawei.com, linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250611074643.250837-1-tujinjiang@huawei.com> <1f0c7d73-b7e2-4ee9-8050-f23c05e75e8b@redhat.com> <62e1f100-0e0e-40bc-9dc3-fcaf8f8d343f@redhat.com> <849e1901-82d3-4ba3-81ac-060fa16ed91e@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dMKKYzjMeFP1ruJQdOPnH23SF3ypCVyFhRgH7vDF_Ys_1749714834 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: my7i54rusdui81as4349ij79ea4xk5no X-Rspamd-Queue-Id: 47EC5C000D X-Rspam-User: X-HE-Tag: 1749714837-902943 X-HE-Meta: U2FsdGVkX1/tpQK62Ug/8EefquT4VludSzoib2SRWKWo6WWoeRU+PeRLdpJ0GQYjMWlBv9GSlxnSsMvXqyk5qOOVhWKGC4NTmAy2WDJKr5b8GYZ5a0fCP3s4BMJStjuRKiKibJ7694G5A0ZgG0jcq6WKM3/BQLBT4eoa9gMLeyuy3zmknNTUdWPo0IHEHvQlrxLcXSG4lV2ZvO/iuG1QO55EqtRwfK6hLRUv3n+a4y1suzIorvV9/dmmFt111OGc6z6572plZwPGE1iwoCb8CAzdct7Qgud/e6q4owrBGy1pexhq6weYTjzZ7MCbrWDtFloyFW0AzXYcImxeYfivdojG2VTRdyLWrn26rN1uS+Woiz3QzNKPl7m00w1be9PClRnkOEoEJ4pdy88+d1lRlXxTqsRCKKSBv68dEiLiDWTWLg7RFZVhDGCERkvigCqovzw9Io8+82YPJ/srVdONn6X1Hb0a+R2YVMq+LMqcPqxKcvdNKK+vCFcC8D5LIlr3OU79URyBDoc8wyaXs+HskCRIBSBa1hES4RmIXfJkMAB6UfeVYXC4hgGQzMdEPuci8O6A8FMjhjcFdGPer/143TVcI75gpaTWiSxnjUoIQbI3NxM0LUjyy203zUsREVdBgoADpuvTDRLuHb3DtiYx/7Qms14+eaSTbNWUbzdEj1BpZ63nCxEANJ4oAbOG5zPv3sECETfZLgejXflCNjG8Ya4PqvyMo45D91okrsgNUYTG/VkjNWPN/jKzVascLlqK8SYsZO4E3PU+CBPARo5dtrVtTRtadC5TfRNcXlpx+BtOXbIO/g7qOhECpOhTOIiSzrqaj1GY+R1ubuCDnut71yszNW9zvI3hlVnqXpEZQiQL35HzRtzTrGbTjAvfJPrCZdFr6bt1u5f/kDPXCHlEnpE7qM9QtmjchgIGiwQRjaFqwiV+Hr/JoRz7Jg56U+/eSOdo6BLLMbS5bT1z+Zn t2/H4jIF kMzbKV5NYJQRWDnHgYuJQTYeuDzrxZ3F+/jog+xF15YUOn0Tl6cJN4NyQScbqGK3Wz30qdN4A6tjBFSxGNlHcfWEFp/nBtgYT/x71skJK+KKmFirgfqZl7PkOI/IPoBLo7k7hmEGPyLGagfqFjJeOlD/uRxOyg8NqjvLWY1E3W8sQulsrexl4/zeIHUlpZcU8C1kAqP74Ex1dkljNEEwCBFI67ONm/yUCHledYGNTrUrW9RJ51T3Yk0UsBLQK+l+ApI8Gxm3lwp3Tz2botBGOSK+mzZ/Cz3ofzWDkSb9ThwtJP5pxZQki1tGqMy4PTXfcBEssDQ5kMiNMrNjt1gDPEC0pmIKBD1IxTv1uuPGIu+pCXzgz6GDTCThYwOMEXH2ieNoJSbXYT9QdOgqn+ENbpWtwHoV8zbPXtarXUjH5oBbU8TIf0vEoCzeSTdOTgqrAaFGM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.25 19:52, Zi Yan wrote: > On 11 Jun 2025, at 13:34, David Hildenbrand wrote: > >>> So __folio_split() has an implicit rule that: >>> 1. if the given list is not NULL, the folio cannot be on LRU; >>> 2. if the given list is NULL, the folio is on LRU. >>> >>> And the rule is buried deeply in lru_add_split_folio(). >>> >>> Should we add some checks in __folio_split()? >>> >>> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >>> index d3e66136e41a..8ce2734c9ca0 100644 >>> --- a/mm/huge_memory.c >>> +++ b/mm/huge_memory.c >>> @@ -3732,6 +3732,11 @@ static int __folio_split(struct folio *folio, unsigned int new_order, >>> VM_BUG_ON_FOLIO(!folio_test_locked(folio), folio); >>> VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); >>> >>> + if (list && folio_test_lru(folio)) >>> + return -EINVAL; >>> + if (!list && !folio_test_lru(folio)) >>> + return -EINVAL; >>> + >> >> I guess we currently don't run into that, because whenever a folio is otherwise isolated, there is an additional reference or a page table mapping, so it cannot get split either way (e.g., freezing the refcount fails). >> >> So maybe these checks would be too early and they should happen after we froze the refcount? > > But if the caller does the isolation, the additional refcount is OK and > can_split_folio() will return true. In addition, __folio_split() does not > change folio LRU state, so these two checks are orthogonal to refcount > check, right? The placement of them does not matter, but earlier the better > to avoid unnecessary work. I see these are sanity checks for callers. In light of the discussion in this thread, if you have someone that takes the folio off the LRU concurrently, I think we could still run into a race here. Because that could happen just after we passed the test in __folio_split(). That's why I think the test would have to happen when there are no such races possible anymore. But the real question is if it is okay to remove the folio from the LRU as done in the patch discussed here ... -- Cheers, David / dhildenb