From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B83C001E0 for ; Wed, 9 Aug 2023 08:49:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBD776B0074; Wed, 9 Aug 2023 04:49:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B443C6B0075; Wed, 9 Aug 2023 04:49:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E48D8E0001; Wed, 9 Aug 2023 04:49:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8A6E76B0074 for ; Wed, 9 Aug 2023 04:49:09 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 50BB4120E16 for ; Wed, 9 Aug 2023 08:49:09 +0000 (UTC) X-FDA: 81103941618.21.D4EF057 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.86.151]) by imf08.hostedemail.com (Postfix) with ESMTP id 5372016001F for ; Wed, 9 Aug 2023 08:49:05 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691570947; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rHucP+uSLAvJUIIkbPSdjoVqh8hzY5NZq+h0xCfEcWQ=; b=HNrsaSiLhS6gFnmfLMdURig5m56h/m7SI560OywaCZvXAox3/2EJmVLRl9h0knJ4S6836C t7I7sZXSWBQHXDtoBR0uwuSU4fCZfTMAXecZY36XuVNj+u4VKBF0475PpiENbacjxbtJW3 Grc8eiMALh7/OFcWcOpNWnD3VAEINKQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691570947; a=rsa-sha256; cv=none; b=zkBy1M0WSSqfbUqgP8fWBZ79ks77bIvKwlcE0EdA4LWKC/AlmX2pRi1VRvDsoNdRqgI2ED feLWpcij5vdZ+JKSSwATqZOSi7ufjWNAxWzJnqeA81uotwAH4cP9Ls3c/uxQg5o++G4DTc oBfE/DLAhezXKPByKjmQVgY7EF8F1dQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of david.laight@aculab.com designates 185.58.86.151 as permitted sender) smtp.mailfrom=david.laight@aculab.com; dmarc=pass (policy=none) header.from=aculab.com Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with both STARTTLS and AUTH (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-265-c5R6OnldN9G1uT9xX-Cmaw-1; Wed, 09 Aug 2023 09:48:57 +0100 X-MC-Unique: c5R6OnldN9G1uT9xX-Cmaw-1 Received: from AcuMS.Aculab.com (10.202.163.4) by AcuMS.aculab.com (10.202.163.4) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Wed, 9 Aug 2023 09:48:54 +0100 Received: from AcuMS.Aculab.com ([::1]) by AcuMS.aculab.com ([::1]) with mapi id 15.00.1497.048; Wed, 9 Aug 2023 09:48:54 +0100 From: David Laight To: 'Petr Mladek' , Andy Shevchenko CC: Marco Elver , "linux-kernel@vger.kernel.org" , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , Steven Rostedt , Rasmus Villemoes , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton Subject: RE: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Thread-Topic: [PATCH v2 2/3] lib/vsprintf: Split out sprintf() and friends Thread-Index: AQHZycNoqz0YrpkIvk2kVFpZOdRD+K/hpuug Date: Wed, 9 Aug 2023 08:48:54 +0000 Message-ID: <900a99a7c90241698c8a2622ca20fa96@AcuMS.aculab.com> References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-3-andriy.shevchenko@linux.intel.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Stat-Signature: z5t8qhd9zqs9s56t7titgctukc3mpw3n X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 5372016001F X-Rspam-User: X-HE-Tag: 1691570945-235005 X-HE-Meta: U2FsdGVkX19KT3xGhX00C38GgRlx/M6zG3UAhd15lkXuEOpqq400hiWjzrb0CQbfiR2WAhF/Fd+wW9Zk9d7XqRrdUjOnKdWmUJLD8/nRdjONM0IR5amSDDuqLn8zhEJmkwwc5EjSB/cm+qdmdgCbtgPVCIoLhs/ENYmv29A0iRa4zPjcOQH4Hb5C/iDNVoMGFaKiMdxRRHB2rFRL+ZzRkqW34cONOWqxnpA43+oV3RASULGJg+SH/ho6pDo4LLZLRVunR2XHp77QtzPqDbAIcJPNos4haj0YF6NiXA/BJS2L4dkXOS42x7V4IeAo3dc8TGn73R2/Maexo9ed6VnJUH9HUriagSlvl5XQi1se+KsTlamBkUXfgNPXANS8QZ/Y5uzKSmUZmEZr32MDnwjBtBVNNERTDj5Juxc8JfaRi1Eb0b9AEIJnctktZ3iuUyMW00cfo7WngIonX/oIvQLqj4Oldqk21cegkotseMwodOMKl8uscFhAvL2S+xg7X3LrrI5+f2GVcQVPN12nXdc6iNdE9oYVjHBLae2eiUj3+0fVt7b8anBkALMDSV87WVH4Ie18V42cEbnlVZd2TiVQAAhud9p1SqUA3/+LIb40Kw4pIRstwLL+GANcfxGGJN6YUKs51dcRRREa8w2O57OWtRJri18wxNEvz266JIQHxvGpObzmPMK/k2G7cY4sR+zAeXinhZQuQXOcio0UCxH1RNWG+/KGRBdAz/x/5zAmixV+hh1A83g5X9rX6bQJuTuLTo7eFf2yMlLTMrl6zSLadlufs+bpxMT+Y3hMFW7DaSVjeVqIXimVW5DU6UX7h6GKK5u5Ek4rbNC9R/GtZ5s7ivx+jmtoMH0wRgBfXIaFJms87/7Y3gigolHGl38N0p8DBaaLV4uFwbLWxz+uDWEAN6yN7J4pyXQJSOOnL+OYbhudxJXuZ4m6pomB5UT1ofCmc5jFEjs0NMkcf5ixNxU W3w/pi+9 2uXDxJ68CGU+GLuseb/sDGYQmvuwM5gw6gRNTUOfAVaO7W1nF5TfcqLOXnTnkjN1lGx8gAImFrLK1/If7d9OLPkQ5DsCpLYE6XLQMqXGEWU2U50SS9rpdg6GwAGBH5fhKqYpLnANiwWDpjZMFR27mlJvrQnqyxXi4ANeCJiumPFsxuYXLI3VunNmOWhwFf/WYC5EhUTgIAtUEi4QJddXaZjMNenVQd6yg3hHbZLCUjn+jyiU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: ... > If you split headers into so many small pieces then all > source files will start with 3 screens of includes. I do not see > how this helps with maintainability. You also slow down compilations. A few extra definitions in a 'leaf' header (one without any #includes) don't really matter. If a header includes other 'leaf' headers that doesn't matter much. But the deep include chains caused by a low level header including a main header are what causes pretty much every header to get included in every compilation. Breaking the deep chains is probably more useful than adding leaf headers for things that are in a header pretty much everything in going to include anyway. The is probably scope for counting the depth of header includes by looking at what each header includes. =09David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1= PT, UK Registration No: 1397386 (Wales)