From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69B2CC3ABBC for ; Fri, 9 May 2025 09:16:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D42E8E0003; Fri, 9 May 2025 05:16:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25E138E0001; Fri, 9 May 2025 05:16:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 088698E0003; Fri, 9 May 2025 05:16:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D3D1E8E0001 for ; Fri, 9 May 2025 05:16:16 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D2C78C034F for ; Fri, 9 May 2025 09:16:16 +0000 (UTC) X-FDA: 83422813152.14.B0D1913 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 59C19180017 for ; Fri, 9 May 2025 09:16:14 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fBy7xPol; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746782174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O50KC8poIn0AkdXO4SOPXeacSJBmsTouUfEw4SHP0HE=; b=orQ1+OG9FUGi/5sP6eIT9sdDyNFWmwtE6f1+pA0T1ruqiRQkqqb2ubFdrzVNdkQ8pBIoJR jLmUQjTWQtO+nx+C8AvrXQT3hE6I19SFSRlMWZ2EFGUc013BUBUGe+Er1gj4n0G/uuVq/o zlD+4T7hnJqtyhkKWWpVdcO/B9HMkYk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746782174; a=rsa-sha256; cv=none; b=C9wsqeGVIK9atvrZHk09MRS29sILm/xf7bXHJgYu9W5kL2cG+IhRpSaSEczSRQyaNIP1cV EgQ+PkL22ElEa+INKHLWllR93OcRklZFoeoFTHSH8tmUkD3EIjJdFq3TK+aCU4IJH917rm QSryr6b38UmEsWxbWD/ACJvnzONvHEg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fBy7xPol; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746782173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O50KC8poIn0AkdXO4SOPXeacSJBmsTouUfEw4SHP0HE=; b=fBy7xPolZno8BbXNkxM2v+0vhy7mOs1lN2PkMV6cfdT1SWUU6hynjsw3+a+RR/zepf4CWm xOZQjAAuItpayKV6rocckjf8Us4M3G6L7GqhnnZTnXTXIxFswHVklgKkWolF9D8TQ2gll1 IPQ3B4Qx7ep+rAN2gTuWphBb2Jo+D04= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-P3oagsRcPcq2UfS9naS4lQ-1; Fri, 09 May 2025 05:16:10 -0400 X-MC-Unique: P3oagsRcPcq2UfS9naS4lQ-1 X-Mimecast-MFC-AGG-ID: P3oagsRcPcq2UfS9naS4lQ_1746782169 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a1f6c5f54cso237084f8f.3 for ; Fri, 09 May 2025 02:16:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746782169; x=1747386969; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=O50KC8poIn0AkdXO4SOPXeacSJBmsTouUfEw4SHP0HE=; b=A2dadIDTe+gG+HLRvDBHRe973WJzVVliQHuduwYA5E+/uSc2/THkZxjXuHQ/k3FpYG /4i1CTeJ5gKTclRklHL90ttBGUY2HvV+rLHBxy9UPQCEiVJK/7mCuGHFT2sK/u0qNpW7 tyHc/bingMGDM2AkJy2q7eNMlogGO6ykSlBbnXVU8yvekKCdjfHBjWcfEEthSD7KTsAG 3nTxM5bWhvnvIFHdQ0etgYISbA1SdVz08Xhp/sFy8Gk1icnKdANAoNlVQXi93tC/Zc1t A6NnsrghDHvdQ2X24AgNFfY9FMiWub0OnjCS592xwwfK2e5KsRztNaL4cfW5Z+djSGGy Wcyg== X-Forwarded-Encrypted: i=1; AJvYcCUYKs3rDTy2IZdcbZKhtUkAKjYGmzBb1MW45cE8yS1du0gPaJ/C+GwT3fJX2B4pyNBI0xTZvS9/pg==@kvack.org X-Gm-Message-State: AOJu0YzphSwcXpvbC4ODPif/5vW6r9skjHnEe2xYryYf1U/z71Rw7ois IpSvR5kdGNYJgV0F+2NLC5HpdMGyUbXxRFfv1I662hSZRwA1ATHE+0MiR00UPpwGbovuvESm8t2 QwfSgeh3b90Yi2ckm2HOU+b4VwxNCnKoFP8HEjSK8QFo3b2+m X-Gm-Gg: ASbGncuH0o4RSx6GgtlH7gSmNedQPRGqYzcE2ULTxxJ64Pz3mj/TYhXDNMBqlU7yNDO anTzAbRbL62rzCc/2Ymwz8qWw9wyBSKXNZpyjrz7aJYBkdKais3OUxWGzItLqR/CLtfVamcyfWx ho5catueLfszMXc6ZgjL47aPW0qSoW9tLyoSujIwtGsxEtGrjFeTLadkBH1zbeRPDkFZoUjL/VO bP0kvBIVVwCxAkhrdezY3lM/eS4WdBlFuV+sLr9gUhU5ZWQ/J3HWPGeZDtRzMJXnkuxnu5dEwmo RgA1EqzrxUjvVrIc4W4sKj1WgYyfqlLLyD2p6i3MWRbBqfdfjCVlhJhHEyO7Q32eltog+hPk1aS o6AH3ubbLTG8C3aQieps4MgKxFuB8nOfHJ2Ismbo= X-Received: by 2002:a5d:59ac:0:b0:397:5de8:6937 with SMTP id ffacd0b85a97d-3a1f64a4b57mr2149462f8f.41.1746782169291; Fri, 09 May 2025 02:16:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpI1ETBmNUmD+2lZouKEgBiUCjLKGmWUAe31bT4cFadKl7DqoBsUiIB1JaibPip6PYQmoKmQ== X-Received: by 2002:a5d:59ac:0:b0:397:5de8:6937 with SMTP id ffacd0b85a97d-3a1f64a4b57mr2149430f8f.41.1746782168899; Fri, 09 May 2025 02:16:08 -0700 (PDT) Received: from ?IPV6:2003:d8:2f45:5500:8267:647f:4209:dedd? (p200300d82f4555008267647f4209dedd.dip0.t-ipconnect.de. [2003:d8:2f45:5500:8267:647f:4209:dedd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f5a4c5b9sm2644007f8f.91.2025.05.09.02.16.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 02:16:08 -0700 (PDT) Message-ID: <900a8898-0666-4639-9a0a-7e602eed275f@redhat.com> Date: Fri, 9 May 2025 11:16:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] mm: Add generic helper to hint a large folio To: Dev Jain , akpm@linux-foundation.org Cc: Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, pfalcato@suse.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org, peterx@redhat.com, ryan.roberts@arm.com, mingo@kernel.org, libang.li@antgroup.com, maobibo@loongson.cn, zhengqi.arch@bytedance.com, baohua@kernel.org, anshuman.khandual@arm.com, willy@infradead.org, ioworker0@gmail.com, yang@os.amperecomputing.com References: <20250506050056.59250-1-dev.jain@arm.com> <20250506050056.59250-3-dev.jain@arm.com> <887fb371-409e-4dad-b4ff-38b85bfddf95@redhat.com> <0979ce4e-d316-477c-872e-d3f9e47690e5@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7jLFKPlR-Xse20WdTulw5ANuftOeXEv_Pcl1lULvR1w_1746782169 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 59C19180017 X-Rspam-User: X-Stat-Signature: 16pa44nwcxosqif1rp4r4jr4xck7xr4m X-HE-Tag: 1746782174-14052 X-HE-Meta: U2FsdGVkX1+j+IWzYX4ikZiELfs32Bu4ni1u8/jg3M9fCKo/QV7dUwE/Mcf3BtMVhjDIj7oUKSWyT8HPmT3ZwBJ/1j7abwWaW8sd7t9embh1DWBAakf225hyp91+5Jua2DAdKsHh8L9pDeqZIJrDD2rQrkpcFOam8wDIrbdUmus7K8Uw3btHzfBfLJ+c3ATEt/OTT6WI+Iyw3OFIfdRG7gvAsFoTV59tHEvKXGmR97sDU/F8xh3iWuxXOUvWsKKsEm55L4oJBaYB+l3duLFX9Ok5jFKESErr3Zf9Ey47vKWAqNu2AGh9RHqYqupG7Cxrp+9X8hU2SS2mnmG72qfMsOQ/Rpn/NXjNlP+5+kUwNzPgZfb6a7kYQxKlF0/esd8xCzX9WOpn8dewaeh0QfND31eiqU4PrYrfEsWNUm08XgQSnr4bvcpiNJI0QEzVOB2iErfDmAE81VlCBLvc2F+UQI4z3Ow4ZskkBEUyL8kpUylTclqCkwAiO0Xbzr+awyl5MQEKkX7AddWpWFxqrZ8UmR9kjh8QnhhJj3+aY/1GnQMz1bQ++BUQIqCa1RGNeFz7SAH6pKQOwM8KCYsDPd3y8LWtcTY0en329hIAkq7ElwMLlFx401Motx459Jml/VGqDCOsTG4r2fwD2Mpgm2GTyEUdKRPOOTj+e89Ts9/bVhZ3DGz0vhfx5g2g5Lp2hqMwud35hUXmSNN+3/JO/r3jWsS+uoJ03w/VLDztaH0F4d4hGRQbbuFEiG3Xc0SxOXWbhwgZGdMOxPOFDzFDsuzdwAauls/Pg/JG22gF1sY8NZoyQOmXtTK8jbOESVVg0FM7iqvUccDK0Vnadxk5mRAaZRBsJS86YoCVn+8Lp62UjQK6JYb4thI3MTPdGmzoPjqflwJAcK0VV5K+sWr/0CtaREkW/p+7jhWGVa4qlIQrIIC+c8feTxxsfu82nzsYxtyHI4Ppdltz5/Jmn3czQxu 1xl24rcC puohK0+dGyiKKOzA4h3cOciLSdU5ASVtxoY8Gb1uTYfQ2zlY5Cuw4zpyAxUx7D7HyDSWZup0JDVI3+xear6/bIzHu/LhP8OT4Mcz5TOEwKM4y0xvyIjzrXdsNfLsqaj3vytL+OU8G+4pauFlk9MvnKkOb6dgW2b/yQDL/WQt+zzRtqpw8tVxdAFe1m6sEFZKf+emDiibs4fe6GRAQqAjoK+SkfQee6jSLHzPd81qD7GCofolS54J7kwHWLjAuXCQQ7eVB7CMze/zO8fbLQ+pryCY98tdyVoyOSkavCl3KRk887hRsSIzbiziILxxQQqsOyEbHn3f9LnDnv03ynKDQAFY4RvIiLeZcz0lxjRIzN3Y0gnwdlsxdRZBL47WnbTYQmrgL6kaECyaMNUdiXLGDDFgImDJpKN/cgd9lWAxZ+FrGhLs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.05.25 07:25, Dev Jain wrote: > > > On 08/05/25 4:25 pm, David Hildenbrand wrote: >> >>>> (2) Do we really need "must be part of the same folio", or could be just >>>> batch over present >>>> ptes that map consecutive PFNs? In that case, a helper that avoids >>>> folio_pte_batch() completely >>>> might be better. >>>> >>> I am not sure I get you here. folio_pte_batch() seems to be the simplest >>> thing we can do as being done around in the code elsewhere, I am not >>> aware of any alternate. >> >> If we don't need the folio, then we can have a batching function that >> doesn't require the folio. >> >> Likely, we could even factor that (non-folio batching) out from >> folio_pte_batch(). >> The recent fix [1] might make that easier. See below. >> >> >> So my question is: is something relying on all of these PTEs to point at >> the same folio? > > Hmm...get_and_clear_full_ptes, as you say in another mail, will require > that... > >> >> [1] https://lkml.kernel.org/r/20250502215019.822-2-arkamar@atlas.cz >> >> >> Something like this: (would need kerneldoc, probably remove "addr" >> parameter from folio_pte_batch(), >> and look into other related cleanups as discussed with Andrew) > > I like this refactoring! Can you tell the commit hash on which you make > the patch, I cannot apply it. Oh, it was just on top of my private version of [1]. It should now be in mm-new (or mm-unstable, did not check). But as raised in my other mail, get_and_clear_full_ptes() might be problematic across folios. -- Cheers, David / dhildenb