From: Usama Arif <usama.arif@linux.dev>
To: Balbir Singh <balbirs@nvidia.com>, Zi Yan <ziy@nvidia.com>
Cc: "Mika Penttilä" <mpenttil@redhat.com>,
"Kiryl Shutsemau" <kas@kernel.org>,
matthew.brost@intel.com, npache@redhat.com, david@kernel.org,
"Usama Arif" <usamaarif642@gmail.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, joshua.hahnjy@gmail.com, hannes@cmpxchg.org,
rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net,
ying.huang@linux.alibaba.com, apopple@nvidia.com,
riel@surriel.com, shakeel.butt@linux.dev,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] mm/migrate_device: fix folio refcount leak on folio_split_unmapped failure
Date: Fri, 6 Mar 2026 13:51:52 +0300 [thread overview]
Message-ID: <9008c7bb-f312-4a9f-a471-568575519d08@linux.dev> (raw)
In-Reply-To: <ee77cb18-3ca2-4f2b-a1f8-1083b1a9e879@nvidia.com>
>
> @Usama have you figured out where the original issue you are seeing stems from?
>
There was no issue or bug report. split_huge_pmd_address currently cannot fail.
I am making lazy page table allocation work [1], which would allow it to fail.
One of the review comments was if I need a folio_put if split_huge_pmd_address
fails. Its not needed if folio_split_unmapped fails, but is needed if
split_huge_pmd_address fails [2]. Actually it would be very nice if you could
review the patch in [1], as its modifying the code you wrote!
Thanks!
[1] https://lore.kernel.org/all/20260226113233.3987674-13-usama.arif@linux.dev/
[2] https://lore.kernel.org/all/6982e9fc-cc17-4d4f-b26e-83997c4bf070@linux.dev/
> Balbir
>
>
next prev parent reply other threads:[~2026-03-06 10:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 12:01 Usama Arif
2026-03-04 14:00 ` Kiryl Shutsemau
2026-03-04 15:17 ` Zi Yan
2026-03-04 21:48 ` Balbir Singh
2026-03-04 21:54 ` Zi Yan
2026-03-04 22:02 ` Matthew Brost
2026-03-04 22:09 ` Balbir Singh
2026-03-04 23:28 ` Usama Arif
2026-03-05 6:09 ` Mika Penttilä
2026-03-05 11:44 ` Usama Arif
2026-03-05 12:09 ` Mika Penttilä
2026-03-05 16:36 ` Usama Arif
2026-03-05 16:39 ` Zi Yan
2026-03-05 17:00 ` Usama Arif
2026-03-05 17:32 ` Zi Yan
2026-03-06 10:47 ` Usama Arif
2026-03-05 22:04 ` Balbir Singh
2026-03-06 10:51 ` Usama Arif [this message]
2026-03-04 15:25 ` Joshua Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9008c7bb-f312-4a9f-a471-568575519d08@linux.dev \
--to=usama.arif@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kas@kernel.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=mpenttil@redhat.com \
--cc=npache@redhat.com \
--cc=rakie.kim@sk.com \
--cc=riel@surriel.com \
--cc=shakeel.butt@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox