From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 733EFC54EBC for ; Thu, 12 Jan 2023 10:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF02A8E0002; Thu, 12 Jan 2023 05:38:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD1BE8E0001; Thu, 12 Jan 2023 05:38:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8E7E8E0002; Thu, 12 Jan 2023 05:38:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ADBAF8E0001 for ; Thu, 12 Jan 2023 05:38:48 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8089F404EC for ; Thu, 12 Jan 2023 10:38:48 +0000 (UTC) X-FDA: 80345798736.11.CBC7267 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf08.hostedemail.com (Postfix) with ESMTP id 92401160015 for ; Thu, 12 Jan 2023 10:38:46 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=e73uzU+b; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mNHJ2hvq; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1673519926; a=rsa-sha256; cv=none; b=gGH/qu3GkyyRYZpSYSeRSnJugXrjMuncx6jvYW6Abeu0IVrUcLih+krE3d+bqqFELG0kL5 AAFry9kTrzJvsXbjtoXcWNzBHY0PUi2g5w9+aJ9IDf73EcjPGl1TkgpO1gzLIgcHEcw6o7 tbDmMJRkZWU6bY1UoiUVx9W9J5OJsbQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=e73uzU+b; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=mNHJ2hvq; spf=pass (imf08.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1673519926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eiHbfAzoDiwycK23l3fHbtyWHUw9DB1Df3pT+ntfda8=; b=7GmVQ7lpf+lPef1cjeyEUmPFVTXakaYSFdciNuf0hA0EgcZjAP0ffYtzLOH/NuIVZHFuOX ejuYcHxRvrMEspTPOsXdB0NoME6WEqn25JDm5fPlamLLj7b9eoquXwH8FICUN7RTYSHy6T PMNRFzLeJq1oskiWOKF9NPfKwhha8GU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2A8FF3FC25; Thu, 12 Jan 2023 10:38:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1673519925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eiHbfAzoDiwycK23l3fHbtyWHUw9DB1Df3pT+ntfda8=; b=e73uzU+bnMqq9LFOQgGpNrgqdhEKQrmaXaUODm8nFeQrUi0xBZA1oXURiJCEjStvc0RwUi unweLn6ObU1xePCVHxI3uQelM3jo/9YaESDW02qxuIqCM3S10Crf2mhhsJKjqkMElSHnZB C//uMqmhK8vMYsMH6QHEVRKRAzW9e/M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1673519925; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eiHbfAzoDiwycK23l3fHbtyWHUw9DB1Df3pT+ntfda8=; b=mNHJ2hvqK/CEoOHSOX99Pd7CFVkbLz8ZzUVkHf+yeh7tYJcYVNzsR1uWf93RcnIsgOj3qL 3pOyxNUWO12mxvBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EB4AE13776; Thu, 12 Jan 2023 10:38:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vNelODTjv2MMKgAAMHmgww (envelope-from ); Thu, 12 Jan 2023 10:38:44 +0000 Message-ID: <9005c77f-c929-21f7-a735-3ab4e6d89832@suse.cz> Date: Thu, 12 Jan 2023 11:38:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v3 3/5] m68k/mm/motorola: specify pmd_page() type Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, Andrew Morton , linux-kernel@vger.kernel.org Cc: Matthew Wilcox , Hugh Dickins , Liam Howlett , William Kucharski , Christian Brauner , Jonathan Corbet , Mike Rapoport , Joel Fernandes , Geert Uytterhoeven References: <4b59f47ff4cd89ff76a5b6edbef6e8e0b37046f1.1672043615.git.lstoakes@gmail.com> From: Vlastimil Babka In-Reply-To: <4b59f47ff4cd89ff76a5b6edbef6e8e0b37046f1.1672043615.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 92401160015 X-Rspamd-Server: rspam01 X-Stat-Signature: 34yfmbc6kmhmxypc3a4d7s6x916rpzn4 X-HE-Tag: 1673519926-756070 X-HE-Meta: U2FsdGVkX186VW3yPcgsJFZXDkRP7YTI6ooIrq6Kqj6Ek28sHGW1oaJmVJS1mTS5YasuebSOsQt809oFlCK/pa2+EN7Gv0Rqg7v2lS0sA4EZvOCCoGfGW0ekdJHvYzzcYnsxymgzAUB6CKt8N0KnsmOiHAwG6v/6gEjd69/v+xWHERyY0wKROQ6BbFeVoQUp+akNFYKElgWnCU2MGprozKHvhJfwmvrdvWwtCqwlP96YlPBU6ZlPbiPz3ntBuSdE1Y6U551pOS7+nIlp+5Ssul40QPr6wkxT4EdJS1b2g8SeiUrz7EXhEwkc3w2GgqqOrPSfl5shGy4F2zUWecrq0utl2YNCShauQ0hn0T4WaxkT+TBVh0dtIE6EDvOuMZrlDwJV/u2g6W7+p0sPuceX82hTnldFAO27+6PUS7ygigeqVy0I6AlI+UkRnnBbKCEyCJ0KD2jSda/3SoWFj+eYVdPJD/lb7NNGaBFQvBtnaOfNQATO18PxVm9YKTRDz0mgR0Uotqf25sDjhXpMUqyEy7/qW6b3K/kf460oO+sc6MP8/m+3A3TPxw6lAjuW6AMsAY/mSDnwqWY+A1C62srZuPCvBxH3lCSs5nquutOixPFIr2GqjnMU3AviQ7cUpB305lW6YhHCay2I6NOGcEDUIbsY85OKxgntFBPXJzYkta/oT0RyjpdeMjJ7oSamL1H1dZtrOTzGLWOgJO0RbalL+k5QqoX3ns46hRT4ld3aG/l6St43SZQnh7hWBii/8onR/wPIYJ99IK7U20zesEIp4q9+w5Cy8pD4nVPu0+zaLOFSWDBU6fqenPb3ClWBa8In0950R79TGmL5NFPYFiJQl+VLN1Y878j4XvazT9Ws5jfKOH0CqGtjdN8WBjUcaOzcwtklXWTA1/H+hoHh9tXPa6oU8MXqVrEyLf7FdwPBaBjDJUlj9jNRfutB7OpNfrV2BxaovDqIbVju8gio8+B UPw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12/26/22 09:44, Lorenzo Stoakes wrote: > Failing to specify a specific type here breaks anything that relies on the type > being explicitly known, such as page_folio(). > > Make explicit the type of null pointer returned here. > > Signed-off-by: Lorenzo Stoakes Acked-by: Vlastimil Babka > --- > arch/m68k/include/asm/motorola_pgtable.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/m68k/include/asm/motorola_pgtable.h b/arch/m68k/include/asm/motorola_pgtable.h > index 7ac3d64c6b33..562b54e09850 100644 > --- a/arch/m68k/include/asm/motorola_pgtable.h > +++ b/arch/m68k/include/asm/motorola_pgtable.h > @@ -124,7 +124,7 @@ static inline void pud_set(pud_t *pudp, pmd_t *pmdp) > * expects pmd_page() to exists, only to then DCE it all. Provide a dummy to > * make the compiler happy. > */ > -#define pmd_page(pmd) NULL > +#define pmd_page(pmd) ((struct page *)NULL) > > > #define pud_none(pud) (!pud_val(pud))