From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 285ECC4828D for ; Wed, 7 Feb 2024 02:29:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE4166B0085; Tue, 6 Feb 2024 21:29:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A93316B0087; Tue, 6 Feb 2024 21:29:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95A9D6B0088; Tue, 6 Feb 2024 21:29:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 837E56B0085 for ; Tue, 6 Feb 2024 21:29:30 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 30FEC1C1367 for ; Wed, 7 Feb 2024 02:29:30 +0000 (UTC) X-FDA: 81763426500.21.6CF92CD Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf11.hostedemail.com (Postfix) with ESMTP id 8C9734000B for ; Wed, 7 Feb 2024 02:29:27 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707272967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jdD1MXDoMqo3V8A2lZViaqrEzxo+zYea4m07LqX6QLE=; b=VhHRJtQag+m4cSvJCKGR4Xo1zDDtqjqb4/wcVMAzgxynEW+/xxuoa0j37MVS9kWEREnKo9 t94nYkI9yYBFAJ1mr3hm+KCDMblLTd6OsMjiGwjLRKSvQ+1E0byR2JGcEknNvWH779pjpZ hBpCBsBE2oktAweK6LfCrvD+fDE9qHw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707272968; a=rsa-sha256; cv=none; b=RXrJVs7QCgz/vSYkwwBOu65oAodHJiVLUDHk5AEpGXzSo79FngR+x4BevsFujQMWT7QdVq UMPAIyrwy0JGzKp4rhrFZ3/KWFJZAHqnCmHpcTn1M1dwmpVzoWCDd5EvQCE80MipkLeNOQ VcIUF7rLo6NY0OyR8mwOS0zUJkVRxn0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B68BD1FB; Tue, 6 Feb 2024 18:30:08 -0800 (PST) Received: from [10.162.40.23] (a077893.blr.arm.com [10.162.40.23]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 709133F762; Tue, 6 Feb 2024 18:29:24 -0800 (PST) Message-ID: <8fff4340-368f-4e66-8839-1d54eea301f9@arm.com> Date: Wed, 7 Feb 2024 07:59:20 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/cma: Drop cma_get_name() Content-Language: en-US To: Andrew Morton Cc: linux-mm@kvack.org, Sumit Semwal , dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org References: <20240206041518.438801-1-anshuman.khandual@arm.com> <20240206142550.62bed7715692ddc0071da7d0@linux-foundation.org> From: Anshuman Khandual In-Reply-To: <20240206142550.62bed7715692ddc0071da7d0@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: mgra87ar4oiiisez5umsrkbendf716g3 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8C9734000B X-Rspam-User: X-HE-Tag: 1707272967-860762 X-HE-Meta: U2FsdGVkX18Uppt8XvuFtYxdEQCyC8qxwblA313/PhWQK1yu5QSc+DhyNrzig+lzw8VyaAynHyMYW0vZ7atXb9NnnlhSZ5NRCP9QpaOJiE2oltOJGcXzkfSNmFrByONkLteMg0fjn/YRsuyLZd2dzkStLgGxoiEiXUO4Rg6w1jumNzP7wZ8NTcggS+V5k1CwXmwX85yLNPwmLl4hqKbTSvOaljMuEpIHQuN6NqeeOPvFnypp9mY2JG3ibpt66D7MRIpf/F3lisyTNOzDujnYQ48s7EzXN4ToifwgVamDZCwjt/n5mlCitPXux2cjEIOuvrQO1340OytTZsAwxZ7ZWa7zF84niWt7PssIpq2+dSx1mJDJkAOLJ8E1EcGmd3Tb29ginRk5sgWe1aRNKbMIgx4Jb7HaLxcqLXx9kAI3R+R8tiJ7DDodEhlpOcu6lKFW6RT1pU2p3fgYtzlIc9jRnQM70xCIWDvra8+ix1Bkzb7izAZ3gseGsitt37UTfEzv2ocfcCl4vjdCW8rzocyCPoS4FnuIjzF97kQY6/XwwEQHw8Dbbx7FH80fw1aYdeznngpzFCXFZP80jR8BBIu6am8EvzplL5/vPc4n3nGCRdXjMM+IboQIHcMtLIOIybExqJBi1KIqWY+copPeBJMS+e5wewj/fqOH5bxoIBZ/0ZOxTRQXgO03uKtUdNJdbbHSnphGKlJn1vMd7br7ZqrZzMguXfVu1nA5BCGFZZZJhEEjr+2ORekvixPy+cj3i2QLV49fkO1bPFzkWc/6Gam6SBn1OmaSzw9oi4w9Ku8UH54NRgwQ08iL1u8XEgqcxoA94VrPQ3JYlKsvx8aNASFL1kBkZOxRLLJLOkgQuPvZpYNgTheVhsr85D9nVEocMFzh3Y3qs34gLbuwhDkKhLWdf6KaEoaCf3I6h/k4eTbcwAH4hNRLU+RMHfIA5XXOTtADXyVOprkLqxO89PW42Qg 4/o7Nzkh vMfV0LSMatRsZLV48tXyANVF2YjCQA2AGpnN7CsZEkiDqZ3SBDFTKhA5BrR5MXpxT8ukO3esdw/e4fPPbtAEkgnyuAEjd6fI/xsoCwVBNxMkooOLqO5lXJu5Cc+yHBMZOl2e+i+cgMOf/ReA9ZqwaZu5a9DhCNeCOIrYWxMSdkSQUXiIXXQsEEfGqMy6q4p3h+xmrBoLpIX+2Fon1XEntsPy6C1tenHOwQlaKWu9A9BrLvu9NxrDgzMrI0iqv+7a0JFzcLIJRjIP2/8uQGqDHA5ms2A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/7/24 03:55, Andrew Morton wrote: > On Tue, 6 Feb 2024 09:45:18 +0530 Anshuman Khandual wrote: > >> cma_get_name() just returns cma->name without any additional transformation >> unlike other helpers such as cma_get_base() and cma_get_size(). This helper >> is not worth the additional indirection, and can be dropped after replacing >> directly with cma->name in the sole caller __add_cma_heap(). > > drivers/dma-buf/heaps/cma_heap.c: In function '__add_cma_heap': > drivers/dma-buf/heaps/cma_heap.c:379:28: error: invalid use of undefined type 'struct cma' > 379 | exp_info.name = cma->name; > | ^~ > > Fixing this would require moving the `struct cma' definition into > cma.h. I don't think that's worthwhile. Existing forward declaration e.g 'struct cma' inside include/linux/cma.h does not seem to sufficient for cma->name to be de-referenced. Agreed - moving the definition for 'struct cma' into include/linux/cma.h is not worthwhile. Hence please drop this patch.