From: Mike Kravetz <mike.kravetz@oracle.com>
To: Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Michal Hocko <mhocko@kernel.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
David Hildenbrand <david@redhat.com>,
Oscar Salvador <osalvador@suse.de>,
Matthew Wilcox <willy@infradead.org>
Subject: Re: [External] [PATCH v2 2/5] hugetlb: convert page_huge_active() HPageMigratable flag
Date: Wed, 3 Feb 2021 16:44:01 -0800 [thread overview]
Message-ID: <8ffcaec2-6401-ee11-d71d-9f7a93a13309@oracle.com> (raw)
In-Reply-To: <CAMZfGtUda+KoAZscU0718TN61cSFwp4zy=y2oZ=+6Z2TAZZwng@mail.gmail.com>
On 2/2/21 11:42 PM, Muchun Song wrote:
> On Wed, Jan 20, 2021 at 9:33 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>>
>> Signed-off-by: Mike Kravetz <mike.kravetz@oracle.com>
>
> Hi Mike,
>
> I found that you may forget to remove set_page_huge_active()
> from include/linux/hugetlb.h.
>
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 37fd248ce271..6f680cf0eee6 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -852,7 +852,7 @@ static inline void
> huge_ptep_modify_prot_commit(struct vm_area_struct *vma,
> }
> #endif
>
> -void set_page_huge_active(struct page *page);
> +
>
> Thanks.
Thank you Muchun for finding this.
Thank you Andrew for fixing in your tree.
--
Mike Kravetz
next prev parent reply other threads:[~2021-02-04 0:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 1:30 [PATCH v2 0/5] create hugetlb flags to consolidate state Mike Kravetz
2021-01-20 1:30 ` [PATCH v2 1/5] hugetlb: use page.private for hugetlb specific page flags Mike Kravetz
2021-01-20 8:10 ` Miaohe Lin
2021-01-20 8:43 ` kernel test robot
2021-01-20 9:30 ` Oscar Salvador
2021-01-20 18:12 ` Mike Kravetz
2021-01-20 1:30 ` [PATCH v2 2/5] hugetlb: convert page_huge_active() HPageMigratable flag Mike Kravetz
2021-01-20 9:59 ` Oscar Salvador
2021-01-20 10:00 ` Oscar Salvador
2021-01-20 21:48 ` Mike Kravetz
2021-01-21 8:18 ` Oscar Salvador
2021-01-21 8:27 ` Oscar Salvador
2021-01-21 12:01 ` [External] " Muchun Song
2021-01-22 6:53 ` Miaohe Lin
2021-01-22 23:12 ` Mike Kravetz
2021-02-03 7:42 ` [External] " Muchun Song
2021-02-04 0:44 ` Mike Kravetz [this message]
2021-01-20 1:30 ` [PATCH v2 3/5] hugetlb: only set HPageMigratable for migratable hstates Mike Kravetz
2021-01-20 1:30 ` [PATCH v2 4/5] hugetlb: convert PageHugeTemporary() to HPageTemporary flag Mike Kravetz
2021-01-20 10:09 ` Oscar Salvador
2021-01-20 18:14 ` Mike Kravetz
2021-01-20 1:30 ` [PATCH v2 5/5] hugetlb: convert PageHugeFreed to HPageFreed flag Mike Kravetz
2021-01-20 10:10 ` Oscar Salvador
2021-01-20 10:44 ` [External] " Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ffcaec2-6401-ee11-d71d-9f7a93a13309@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox