From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 096F0C6FD1C for ; Thu, 23 Mar 2023 16:19:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D8076B007B; Thu, 23 Mar 2023 12:19:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8879B6B007D; Thu, 23 Mar 2023 12:19:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74FE66B007E; Thu, 23 Mar 2023 12:19:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6466B6B007B for ; Thu, 23 Mar 2023 12:19:20 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 205A312028B for ; Thu, 23 Mar 2023 16:19:20 +0000 (UTC) X-FDA: 80600672880.07.8F029F3 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf14.hostedemail.com (Postfix) with ESMTP id 060EE100014 for ; Thu, 23 Mar 2023 16:19:17 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WMWERatq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nfSFgFgZ; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679588358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b4ZejUgHNBoIjTb4eED8RR0YUHjbR+xKrnQmSeErxMw=; b=msKr/Mst2WHuTANoGDYnhynGIPvzLTVPZgl+dGebPf8twUEA0PgAZK5wfJuoZitEW4CFyo 8BNJKF4WunxmSBXD7OSUIw+Spx8tMVgStAftnXjZJwuq5LoFSGDUQVZRpIdsWpdOvdWq5h F/7gLPmHovTy5nws39PY11URdEJcRio= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=WMWERatq; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nfSFgFgZ; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679588358; a=rsa-sha256; cv=none; b=sBJd7b8h14sc3UDWP8Q25PO7kBBOLRNhr/SVRWORN0SFuQssC5ZUXJ7CNAptD+AlrczaJd AE0kqbTe3uwk7TgpKYsEpGcMVlYmfOqaDm9ii3cRm0r1kGhVDjavKhy7eRc575ygE3VyKZ pEPQER3siGyZXXticgPJ6aZql7jujmI= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5C9D6337DC; Thu, 23 Mar 2023 16:19:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679588356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b4ZejUgHNBoIjTb4eED8RR0YUHjbR+xKrnQmSeErxMw=; b=WMWERatqz41ixro5GhfGVr8b8iAVlTwVj5ezWdvfgYe3vGmxoOuZSiKTym9KewA+YFvUgf YWNt0Lca2jtbWL2XuSLOaNxixkgbwRGwtkaE4HGC496dIjiF/6lHuiBhig0uFSZNuJwEz1 +oxK7q7AFoThIPE8yPenkijzcJlKZ3I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679588356; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b4ZejUgHNBoIjTb4eED8RR0YUHjbR+xKrnQmSeErxMw=; b=nfSFgFgZsj6b1ReqqCKhiz2dmROFutClwCrf4Roga/gjUf5C+fdd7T4LLHgeGfDr+XffY+ mXszwF5vJUJ80BDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D66B132C2; Thu, 23 Mar 2023 16:19:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wWS2BQR8HGThQwAAMHmgww (envelope-from ); Thu, 23 Mar 2023 16:19:16 +0000 Message-ID: <8ff68064-3ec6-4aa2-2389-3568483a1bd4@suse.cz> Date: Thu, 23 Mar 2023 17:19:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file Content-Language: en-US To: Christoph Hellwig , ye.xingchen@zte.com.cn Cc: mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, linmiaohe@huawei.com, chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <202303221046286197958@zte.com.cn> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 060EE100014 X-Stat-Signature: f9ep6u5kjeme1oiizndj39383yega3tq X-HE-Tag: 1679588357-262443 X-HE-Meta: U2FsdGVkX1+WSIiPLZjS8B93heZuLAEFzFq3xez2xOaUuq4KEBCLnf3R+/7BRkA3EX6v0hiTStkVFOVgl/ygSd6uPJtEgwsILjaCjZjCXgjQiva9kCTflxhyFNAqeFVPERmkSiNNqDjIpXUPXkul/MkXHHjGixqPocWK9YDNHvLfpUEYl4vr9yOfnMs2dCzvsEGQaGYtR38BHOjDP0oEGR3AuxFaLmp6DoyMVM3Il16HKWrK7glrRm/w+hvoTwjbfDoP2Y7S4NIyGuEG6w48SvhZ6KfhDwOKlO+zfWTf4ZNn1+jRivm1OpHr9hnQxRfmTlaMrBUYjhhturyD+IjTqjzX7V48PWzheXbO0eCAsC2er+s903Kop0c3IjKWLrqbnzcWIM+bNlMvlMmR/rixGlS8Qklwt9zxQqI1EOvfwluxTJHWy1Vlx2rcYlhV6+rl6BCMa0Do2mz9G+Vdu3M9p9EwGmSYUwF60971OZC7Wpk/SmkSOryiRdX6jIM5K8qdqZWUYBW/B2DszCyaxCW9e6A+Kono7Ea2/xWgkseqVJxMbazV6UGme25CgiKf/w04jxFjIfKefpRzWBvMHzhVlvGWBelY3uh/Yg/9Hoo2TPiootB2bKO58I4Ccgqbr+0nwED7Bq465HYTWn3p6Znk01fhU7D3r/Mlq7w+oiaTeM7p69/xpwFTDfcb9FebLoF2KK/55UZbJEdsVbM2rOq33kVwZbWKNdYyjCL5ObBoJfHBunFf86FP+qjybzqjNvsB9MJGXc+diWwqXYm4HXLSwAeSb0ghnRMsSsGfCUyCBOUthxH8FO84haQhe2alF2MoTf/lcZqi1Rme/nNFJRvFJmUys8Z1MVVAOk2wtl20jFKoQwiuS5RTgAYkhT18rVjOcVoTuUjYcwAND/p6Fh24vZaQowuwhRSvGrlRaKyCh8Tz46YUEiuj+D7JszF/EAi0YvKcMKBykWhZQBotpjq 37aBGocC ASgh+coaFYQ+AProPtvQErc5xMQZ6yJuNfqgfYRQ+zHVuxKa4JodmtFsm6v7gMqK7RdwG+cE3mwRJovAHkKX1Sfb7yzPCUfjZ9m6ztBb1BO/BJoXK6TFVKOaWoCdTOqqbtv7HcwuaFkcFdMkvL+x4cwB+RUta1UasmP5HLM5W3kvkq0zXwv3iB7Y80giaio7Y2QNb9zMEZbeHGmWp4M3Plu8VUWKQbEulMS9bv0T3YAIJDdmNazk9b1VTu9Pfvm0BtxrUgbDv3hspQqepWHclxlfrbg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/22/23 09:35, Christoph Hellwig wrote: > On Wed, Mar 22, 2023 at 10:46:28AM +0800, ye.xingchen@zte.com.cn wrote: >> From: Minghao Chi >> >> This moves all compaction sysctls to its own file. > > So there's a whole lot of these 'move sysctrls to their own file' > patches, but no actual explanation of why that is desirable. Please I think Luis started this initiative, maybe he can provide the canonical reasoning :) > explain why we'd want to split code that is closely related, and now > requires marking symbols non-static just to create a new tiny source > file. Hmm? I can see the opposite, at least in the compaction patch here. Related code and variables are moved closer together, made static, declarations removed from headers. It looks like an improvement to me.