From: Vlastimil Babka <vbabka@suse.cz>
To: Christoph Hellwig <hch@infradead.org>, ye.xingchen@zte.com.cn
Cc: mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com,
akpm@linux-foundation.org, linmiaohe@huawei.com,
chi.minghao@zte.com.cn, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH V5 1/2] mm: compaction: move compaction sysctl to its own file
Date: Thu, 23 Mar 2023 17:19:15 +0100 [thread overview]
Message-ID: <8ff68064-3ec6-4aa2-2389-3568483a1bd4@suse.cz> (raw)
In-Reply-To: <ZBq9uO6wLI1fX1x/@infradead.org>
On 3/22/23 09:35, Christoph Hellwig wrote:
> On Wed, Mar 22, 2023 at 10:46:28AM +0800, ye.xingchen@zte.com.cn wrote:
>> From: Minghao Chi <chi.minghao@zte.com.cn>
>>
>> This moves all compaction sysctls to its own file.
>
> So there's a whole lot of these 'move sysctrls to their own file'
> patches, but no actual explanation of why that is desirable. Please
I think Luis started this initiative, maybe he can provide the canonical
reasoning :)
> explain why we'd want to split code that is closely related, and now
> requires marking symbols non-static just to create a new tiny source
> file.
Hmm? I can see the opposite, at least in the compaction patch here. Related
code and variables are moved closer together, made static, declarations
removed from headers. It looks like an improvement to me.
next prev parent reply other threads:[~2023-03-23 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 2:46 ye.xingchen
2023-03-22 8:35 ` Christoph Hellwig
2023-03-23 16:19 ` Vlastimil Babka [this message]
2023-03-23 19:39 ` Luis Chamberlain
2023-03-24 6:24 ` ye xingchen
2023-03-24 18:11 ` Luis Chamberlain
2023-03-27 2:49 ` ye xingchen
2023-03-27 10:27 ` Vlastimil Babka
2023-03-27 3:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff68064-3ec6-4aa2-2389-3568483a1bd4@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=chi.minghao@zte.com.cn \
--cc=hch@infradead.org \
--cc=keescook@chromium.org \
--cc=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox