From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 937CEC369D5 for ; Thu, 24 Apr 2025 21:22:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 393D96B00BF; Thu, 24 Apr 2025 17:22:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31B4C6B00C1; Thu, 24 Apr 2025 17:22:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0FAAA6B00C3; Thu, 24 Apr 2025 17:22:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E1A4A6B00BF for ; Thu, 24 Apr 2025 17:22:32 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5AC3116197F for ; Thu, 24 Apr 2025 21:22:34 +0000 (UTC) X-FDA: 83370211428.15.E4BF516 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf17.hostedemail.com (Postfix) with ESMTP id CF65740003 for ; Thu, 24 Apr 2025 21:22:31 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eTmcujpt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745529752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d9YviV4Z/8/bRYnSiKAoF3XUKGpSI2ebxPC5ZsuRIKs=; b=44RsH9XEeoTvaZt7elPvHZBP0fJzOw2QxGzhfn3qyoRW+MBC6x1dKM7nXGz/s05CXvJvN1 pcX869+bvAkm69sHT7eae7K2aha9CCYwdCvKyZN5VaggwWZSgdZM+4O2+pbVvpVbLZ7EnU cU8+pl7pkKGgzdx5IdkaA7LQAlhLw94= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745529752; a=rsa-sha256; cv=none; b=qpJ25c6kxiT0Nq2F3ciig1JlsurzTceCoNiOltEVFbrKHYHBTqRTr/NX3QtN8jgRwSRrr1 Ekkw0sWQiaOtXIbew2/ia6C7lzslHkAve5ONFd4V5SV9rG86V7GOuAQcgIQbGi03zcx95C 7k3FzQ9nkl3Q5f8yUuXWAask2u08t6c= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eTmcujpt; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745529751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=d9YviV4Z/8/bRYnSiKAoF3XUKGpSI2ebxPC5ZsuRIKs=; b=eTmcujptD4XQIg0k7ebdCugpwrSugdOPFr9dQX/FefE7z/6NpOxkK0kOYhWrs4O9rZAnsn dVMYndJODZp9kw02l1GkyYY3stvltwMwkwov7utMqlQaxo7lQKEgcMtbzVeq5WhB/QX9LV /Bc93RRpDUcK3MTiw/+QxKl36iVZ7Bc= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-141-3UAMLiIrMhyR4PMj1GHDYA-1; Thu, 24 Apr 2025 17:22:29 -0400 X-MC-Unique: 3UAMLiIrMhyR4PMj1GHDYA-1 X-Mimecast-MFC-AGG-ID: 3UAMLiIrMhyR4PMj1GHDYA_1745529749 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43ceb011ea5so9114035e9.2 for ; Thu, 24 Apr 2025 14:22:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745529749; x=1746134549; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=d9YviV4Z/8/bRYnSiKAoF3XUKGpSI2ebxPC5ZsuRIKs=; b=T0bw2gKAAbD3t9FryHWQVRahEpP115qxgzWxlqJ29c1SO9ipy8FYlYSNeMJ674SEOP CKeiO/qfYfXj3BATN0AgBuwL0O54JjgNAxuC0+EHCPIkvytoYWlxSX+a4UNZlWgkXKXb QDgtyyJcbV8Fm+XVs1HIWwUUEHot6R+JA9y3luIaqapmtsf4JBWnmLcxy/WhLSgzZwzr 1NPCnBAwr6YR1DNdrPWjLxrD1463AbO1s5kSun4NZ2OOn0ucVuvMdshTVfxVRTxHuBaQ SkCXaK6MxU+ow+moVfQCe5C1nOyaGXqLxMgnDVoVH9XyxJMCvXVxv/47eCw/tpbia0p+ dqww== X-Forwarded-Encrypted: i=1; AJvYcCWPMFKnHZBmXx8XUAjOXRmZ0/OJiJDQGWFop7lRqNcn0tARERa7eJe70BTUMiwhIq8iG0D+Q1YgrQ==@kvack.org X-Gm-Message-State: AOJu0YzfHNyLca8bjeFV6tNb5E7v7UJwuVZZzm3M7yTBru3z4uF6oqh0 yOwOFO0y+mmzBZMHqRVb7cF+2/rulexFXqcv5S8QlY+qxKVqk8Cfc5MCs/1BBGWnag3Qlnt9M1D jtw04/Q7+0tAxohWAsN6IDWYXqIP+BAqTT+S4twgt8YwzDFH4 X-Gm-Gg: ASbGncteoeYh8FckYTNxT7Hf01AOjG6xaQOE2O00+GyOBHDgbAuLH0CDnK8HIOqGcpb 2eEHqhR586CJL5JJZFVjQkVrEq0cG/2ib5nGkO/s9xEmU3gAOXsANKmEzoNWMW0pVwRyGRbQysx kgRzjyH0laIN9mKlH08E4fnQicHjVmUtWkJtrtmHWBIhSKvFQsyTJvVf6lfETK+kheFOKdF3NG0 kbB01B26Z/bW61QP5e1UsCBGI9E8hZXoOTNrNLpgoQgHH9CB9Bd92GxK/1yhhWydmvzRXFzWvWz VIM+rCM5XVnyWQV5UOqGx4JBCaea9zSV2+eqUlx0rPgX4vefRmHWF0v57eoyhP35c+gWRVsBOeq V/EsUoxfoV0gkL7Jd/CYfsczWyNSZ8GF7fzIL X-Received: by 2002:a05:600c:350e:b0:43c:efed:732c with SMTP id 5b1f17b1804b1-440a31bf0damr5091325e9.28.1745529748758; Thu, 24 Apr 2025 14:22:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHlWPsh8zoKaShSLYXX86IuGQxpDTTvCW3Irk3N6jV77sYjou8SjQL624Zhmy+ZfO4KrX7qCQ== X-Received: by 2002:a05:600c:350e:b0:43c:efed:732c with SMTP id 5b1f17b1804b1-440a31bf0damr5091195e9.28.1745529748356; Thu, 24 Apr 2025 14:22:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c74e:ff00:f734:227:6936:cdab? (p200300cbc74eff00f73402276936cdab.dip0.t-ipconnect.de. [2003:cb:c74e:ff00:f734:227:6936:cdab]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-440a5311403sm2029595e9.23.2025.04.24.14.22.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Apr 2025 14:22:27 -0700 (PDT) Message-ID: <8ff17bd8-5cdd-49cd-ba71-b60abc1c99f6@redhat.com> Date: Thu, 24 Apr 2025 23:22:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/4] mm: perform VMA allocation, freeing, duplication in mm To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Kees Cook , Alexander Viro , Christian Brauner , Jan Kara , Suren Baghdasaryan , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <0f848d59f3eea3dd0c0cdc3920644222c40cffe6.1745528282.git.lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <0f848d59f3eea3dd0c0cdc3920644222c40cffe6.1745528282.git.lorenzo.stoakes@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7aZ4gHhfxPlbdlm5vl3xmzfrZc6k59MLX452QmXG0Tw_1745529749 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF65740003 X-Rspam-User: X-Stat-Signature: jpky5e64to9i74mowt7guzktr4xe7ffb X-HE-Tag: 1745529751-998313 X-HE-Meta: U2FsdGVkX18mNtGXrBPqMXY+hl9otlPReTWPfU+usCIYvMSwRWrPp3CpL/+wQKfgJz3sX1uPYBct+4smvAYoNztn3Hd9cGJ9gnKSHVjqYjOz/iKM1FMkeQ6MCV/39i/qpZkOWG7M6wNT59xJVYK+1Tfx2amgkV2tGwRi8AGNdsPudfKG+SM+vDK5fDGVkYkM0ZgDEK/f42UMQwfrC95sq7H776CPFvY2VWiqUEOPRJ33AUNOnRj2bbgOwDEofYSm+rZB/GoVDSrCaeY+Qqi3Kc9ia5tGArqi4wgsGgsBSCrAjmLVDMlZjeLUiW7/XZKfdjPm+pDIvKitifhGVHYmUMl5vnsBmnPu1jzZQ3iQlknECVUKYsunUxX6eODAi1OGA+i5hDjoq7i3uV683XUcmRIrvJWtwjZdAWMKXfwsgIZf84y+OxME5GOhkaZlJw38VfntmpuchlnyY452soeHaO7roE7z+i89nTxpPvjSvgMR14/pZzlu4pl+u6isCJ4YV9YkoWMcgNM1yh58JRygakKnv2uHCO4U5qU5/sXP3ZeODr0Cwn4Sb+sqVUjgA292fqEbEQDk1mqNfLe03HxvPdqFhB4H0RceL9fX9PM/gN/jdEDAR7DUdrGlQx0F8r47c2owy69+nHIxmv4gSwSbwl6vqKAGcSezjyvmvMjtyjAOGfrjoUXHAjIGFJCFLCL6HR0NegJLfoRm3NgrcHpFGwFAJDRRdSOTrHv1gcyLUm/Yk+jzIel822aYHTslsRnkdyHyb3G5UyCqfXdbRi9TaeoAbnTfJTdpj95F4RNq/RGYwiNUQN076UWGFf5a7Ea5e8JFRd/ydJyRLXZK8rgBIg0dnwdTRAKgo6jWHNRLRx/6gGxxu7uXCTmNSNTHqm6h8ghJNccpI0xQpbN8JoQPbgY4GgJtkfosUsHQow415QnICk/I2j9SE9Bq3CchQQRnGBi6/ZEd9zLEVJcCI08 RCT40etw +4Wb/4rvnrxkZo9egngR6CX9YQsEJoZip4w7AQW618eFadnoJVoIjd/CsfCszhP2FQRyJVke9yvKO5O9TT/xQaoBM2vJ/OZvWUQf/pyDB1BIZnHZUmmd0hGlqQZXU0xzVweazkO+LngATJQwX6+Rb77/S1SicWrN/pEAIhTHXgAoZ34CKWmVgT46VEq0QhI9audg8yWI81F9UzqEj8/b5HlekW2eIxs5LlK8D+oZVgPRGIX6P+JC6y9+T0vqph2gtZaDj4Z3XjFd9Zh7y7TcoAwT8CofgjyUb8hqXx1p7f0iOH7Amew1YgS0ik1AVZv+6carES3Bs+CElrJMkxGSz/PmCfdfREy5VjkQkj4aa8FkSNGuBK4aoXe8rDnVJFMh56tMpo1WQAh7gsIgGAW6a4wHepw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.25 23:15, Lorenzo Stoakes wrote: > Right now these are performed in kernel/fork.c which is odd and a violation > of separation of concerns, as well as preventing us from integrating this > and related logic into userland VMA testing going forward, and perhaps more > importantly - enabling us to, in a subsequent commit, make VMA > allocation/freeing a purely internal mm operation. > > There is a fly in the ointment - nommu - mmap.c is not compiled if > CONFIG_MMU is not set, and there is no sensible place to put these outside > of that, so we are put in the position of having to duplication some logic > here. > > This isn't ideal, but since nommu is a niche use-case, already duplicates a > great deal of mmu logic by its nature and we can eliminate code that is not > applicable to nommu, it seems a worthwhile trade-off. > > The intent is to move all this logic to vma.c in a subsequent commit, > rendering VMA allocation, freeing and duplication mm-internal-only and > userland testable. I'm pretty sure you tried it, but what's the big blocker to have patch #3 first, so we can avoid the temporary move of the code to mmap.c ? -- Cheers, David / dhildenb