From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40E4C369C2 for ; Fri, 25 Apr 2025 20:12:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A3D06B0007; Fri, 25 Apr 2025 16:12:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9555F6B0008; Fri, 25 Apr 2025 16:12:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7A58A6B000C; Fri, 25 Apr 2025 16:12:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 603606B0007 for ; Fri, 25 Apr 2025 16:12:57 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 74A9B1CC7E8 for ; Fri, 25 Apr 2025 20:12:57 +0000 (UTC) X-FDA: 83373664794.01.3051843 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id EB8B280011 for ; Fri, 25 Apr 2025 20:12:54 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KbRwRHSl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745611975; a=rsa-sha256; cv=none; b=aM6ctl2zIR3DRfkmyCsxzN1DLiYZ5RYBltjPAqeK7i9kViVwss4y3BDX1EBq4Av+xIseSm VFh8Q6R9FE+Vdxw4byawk1AkrvlHCz4SISKJ8lPwtZM3/o/zlpgTUIj06TNSQHiNXswf0s ykp2A9fUl805xmP7YvOJqRila7RumEA= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KbRwRHSl; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745611975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DP2vwiic8e2s/R5GDgOi0xr/8SGBP9j4xTLdbOHVads=; b=PrwJLMJ9VKjMaqCdfWQLdI/W+AabiJXfjgTW8GRXIc2DlBtgYCm0/DX+3FQ3u+ozwGsFDw aBmapP+z0PaiOfWNyeMaHkQoStSF0dGMCfw66Gx807yDJq/vqaQ95MOwjnOsKxP8rNj6as 9bPHK3QGKUbPeFqTPb7eykQtW0MgMD8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745611974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DP2vwiic8e2s/R5GDgOi0xr/8SGBP9j4xTLdbOHVads=; b=KbRwRHSl+oc63pBW4sO46vB35W/oSVvvD1/2U4EkGItUhdZlBnJiK3kXVYascbMANFBpUD 8mZOndI9RRUH7fdgG0rdZD4BvY+BkzgUOJCKEWM4/QifX3YD3zxPN3PO2QlRoNUTmRvrfN 09kNFwrIS097RZL4qnXZg4vljSIwzYc= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-pnGpAvRQP6uf8MIoVA9xxA-1; Fri, 25 Apr 2025 16:12:53 -0400 X-MC-Unique: pnGpAvRQP6uf8MIoVA9xxA-1 X-Mimecast-MFC-AGG-ID: pnGpAvRQP6uf8MIoVA9xxA_1745611972 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-39d8e5ca9c2so1484708f8f.0 for ; Fri, 25 Apr 2025 13:12:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745611972; x=1746216772; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=DP2vwiic8e2s/R5GDgOi0xr/8SGBP9j4xTLdbOHVads=; b=LscWUasRnx3qcc2hd4miXZbLbQEuQLbMp2NPvKnDw6EsrdAUQ6wnNRdpF6+DdfKF/o 880SbGUyBDTyTJ0/oe5Tt7nO61/1vf4re1KCZUnb5ohjkvb0VBLvUEu9Q/zdcsOrirf5 RpziKXcVwzw5TIRi4ksMogoF6YjrNxnEU4an0xBni9kEAyU9G2PUvaRl9Tyo3wM0mXbf 5vJ3+VP0kx4FJOCnSSxChr7Qw+Y/P2PlX3mgBy7AR+2zbebLQwnpQL3hnqs7CS4cvvaD jqM8OxOA08EoA8GtWByLXesQ37922+HyvSL8xTRBfRSc6hTaJ0Edt1kZ8LAiUTpHP71c KA+w== X-Forwarded-Encrypted: i=1; AJvYcCWG03f/8W91yPK9J4fyldjrE8CM/0gJ6YLsSKI/qakxKr2/0wCtL/nds0yEK0z8IuRwuAk9QlhQPA==@kvack.org X-Gm-Message-State: AOJu0YyxWB5Q1g1hS+pD7SJWlrmuEmc7EaWdtO3TBL19tQ5TEe37HAzJ l3pgI6I3MiCXz6dpRiumHo3b8nXy9rNvoMVcC5GADwMDVywd7sf1cRXfCi/3bTEXyrSIg6hNt9r ey3evZEFV/qrPdUuTigF1MuMRhawozRs/+oXWc7mgaR1/2ZSs X-Gm-Gg: ASbGncua88ZFXjKnDVLP/XCdxJJQ0Ng9ErU1SUi/4AthJX7CJEYB1CFbK15hHt5F3b3 qXDrXMjGcJfsgSrRM3l4dd/y8XDLvZ2jexeExRtZWhl3n2NEbTLLbx2DtwP54IORg8LM5hKoQ69 KUIwg78M+IIpKemRHUyDxp7hh/nmNEE1VcFM+FL4FcflkZcP1M0xUnDc8Ggw70PheW4UAZYXo8D 9MQzx9m1osvk0kIRKn+ySlZn56fw1m6d5uMU1OSQQW7f6Sle6m6oQiw7IRTPVc0+ffXXa/roFcs mUmH8fIawQsfqi9fcTEXCuvfuakjC9lsAIO4zZhcON5hj/9oElMveYgHexQ9WH7uZldgmBKBLJF /KkxKqrimYgrRrnbP1kSf0OYRPh1NfgA0GotJ X-Received: by 2002:a05:6000:1786:b0:391:2d61:4561 with SMTP id ffacd0b85a97d-3a074e14820mr2921268f8f.6.1745611971830; Fri, 25 Apr 2025 13:12:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEFVn9H//z0k1CtrVOQbHYlOLGF8iqTCK5yC0ChSELN1MCMaffah5JZTgjMkK35gLUoNPkjKw== X-Received: by 2002:a05:6000:1786:b0:391:2d61:4561 with SMTP id ffacd0b85a97d-3a074e14820mr2921248f8f.6.1745611971452; Fri, 25 Apr 2025 13:12:51 -0700 (PDT) Received: from ?IPV6:2003:cb:c70f:6900:6c56:80f8:c14:6d2a? (p200300cbc70f69006c5680f80c146d2a.dip0.t-ipconnect.de. [2003:cb:c70f:6900:6c56:80f8:c14:6d2a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a073c8cc74sm3339530f8f.11.2025.04.25.13.12.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Apr 2025 13:12:51 -0700 (PDT) Message-ID: <8fd728cf-bc54-433d-8701-234a67933a97@redhat.com> Date: Fri, 25 Apr 2025 22:12:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] mm/mm_init: Use for_each_valid_pfn() in init_unavailable_range() To: David Woodhouse , Mike Rapoport Cc: Andrew Morton , "Sauerwein, David" , Anshuman Khandual , Ard Biesheuvel , Catalin Marinas , Marc Zyngier , Mark Rutland , Mike Rapoport , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ruihan Li References: <20250423133821.789413-1-dwmw2@infradead.org> <20250423133821.789413-8-dwmw2@infradead.org> <91CA8854-2E86-4AF3-BAD0-8C47833F59D4@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <91CA8854-2E86-4AF3-BAD0-8C47833F59D4@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UnuYc9bntmOBXAMETvyN75z_LBvwbqCf1r0MS5IPgmk_1745611972 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: EB8B280011 X-Rspamd-Server: rspam04 X-Stat-Signature: brht17ih8usko4td1n5jn4dmmcwz9936 X-HE-Tag: 1745611974-622330 X-HE-Meta: U2FsdGVkX1/fqnKOTM7WYvoSGf3bOiyQSSj9hI6aWJb7DVkcyFHgDbNHB6b4KjuZlym8GbEy80DhFsjP1Omg3DutnmQ9acpcq9rctiz1svQ4OHXM0XKTrtONVpNSBhd0SYpNP9FK+6OM8yhcK4OkAx5o4BKba0g9dd+lS7q/72ci9USEPBBhxlmiXrFs4zEZg9xAcGFXk1GxcEf15LPkWrOHCOghHz01PimkiRysBDuPs0Uihfz2Qh4W8XjamWLWhTYba0WHG5jk4Q7zEPb6jU2mRyDzlpHYlCgv5Ku26/Uhu9/Ekx3VO+OvYySicwmYZP9x03NOM9mhcgIuN+S+kIPQk6aDtXOrDos+slj9yDWlRnFsPHMoxzxxaHpQOkpm/eYIVpWCYtk2J9y/LKKxvFz0udf/LLG+kdlYZVStp0SPFJZSk5t6c64fKEkf83WNo1F8h5ALcw0fBPOGHobWQO1FOlt3hm9RXcCMbp3IJesk2eQMVa8D/UeKCvRfkpjdYDqp7Y73psDJ33o9u6RyIHVQ3imtHlbKyiCShM1wjHHQ9Z/9+pW74XjvytVX4gr5NdtKhYA8tQpdANMKv/1lTqRzS2Ek8dEokGPfirJs5D+lfk8+1eOIyuUaIVMiZilhAufkRVQ9KHfBcNY5DtPuRoRVK8f8NS3Phwd247/5TyHBFdFwfhcbn1gNPwgovMLqil5/VXgzj2fkCaxK2OrSKPwI4Jfcoy0ey5ECuhfJEcZBFtMqIw2GZUscoodjQ1hX7JUBDWjNLgVzET3OJtAVdosWSc/4NkNPErNfHJlNqQFQcXiRT773638t/RhbX88koKgzpBh++wG74s7D6vpcxI8bXDAkvb4q5rmV4hHMsHgXCj2mO9yLmRWFoc4RWvMhyR7HkHR6hko4TfuaKWRhsEedsXOR40Oaoj8XHAk/r3Z3zYARHYZNGNWE0NPRsGGuW9EWLbk4b4xJriPcsgc vc0deUYe ELecVMHSDvtfv721a5pslxEOubQefQioO6q0YWHckr0h+OnNKX2lvuDdCfqATXOiJnGTz6LmaWdMIrQ00f119AFmAYzh2WTcq6MtI905Jyy/IeR+Io6YHaifdE4PQTBMp447z4725DkefgmwwycPd6VkBPGTd18Rh1wwzyxKLGEaD+ORENGgysIR5sJdDi3yBDh9LVFDZ/hAWUpvGpcHOytq6avwda52n2jmgy8s0ql1Zw6mR+dZ1VEwB6BkyrV7t/2ZosW9A0qshhAF4kKFKxQV4YVE8lflgoE7YGLmpqS4W3YeLmtxxXhZsI3nw5IQDoPGpuwbRCrUada1LKRamvNW9A6CMNW1MeUiNvktchZc0X3BYGPQ+xGFH7a5g9JI1QENBgWRxvYYGllvVzsHxw70OQ/qyoO3K4V0wSmbMoaoV9W1psS/46LPpAR9+lQJTtknCjKJWQTHgMOUxIHat4aAEJeWXJUBYJf6nMYG5W7hvoZTcrqttuS2KwBW1/yW+Zy5ukbkQnR2Ge8w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.04.25 21:08, David Woodhouse wrote: > On 25 April 2025 17:17:25 BST, David Hildenbrand wrote: >> On 23.04.25 15:33, David Woodhouse wrote: >>> From: David Woodhouse >>> >>> Currently, memmap_init initializes pfn_hole with 0 instead of >>> ARCH_PFN_OFFSET. Then init_unavailable_range will start iterating each >>> page from the page at address zero to the first available page, but it >>> won't do anything for pages below ARCH_PFN_OFFSET because pfn_valid >>> won't pass. >>> >>> If ARCH_PFN_OFFSET is very large (e.g., something like 2^64-2GiB if the >>> kernel is used as a library and loaded at a very high address), the >>> pointless iteration for pages below ARCH_PFN_OFFSET will take a very >>> long time, and the kernel will look stuck at boot time. >>> >>> Use for_each_valid_pfn() to skip the pointless iterations. >>> >>> Reported-by: Ruihan Li >>> Suggested-by: Mike Rapoport >>> Signed-off-by: David Woodhouse >>> Reviewed-by: Mike Rapoport (Microsoft) >>> Tested-by: Ruihan Li >>> --- >>> mm/mm_init.c | 6 +----- >>> 1 file changed, 1 insertion(+), 5 deletions(-) >>> >>> diff --git a/mm/mm_init.c b/mm/mm_init.c >>> index 41884f2155c4..0d1a4546825c 100644 >>> --- a/mm/mm_init.c >>> +++ b/mm/mm_init.c >>> @@ -845,11 +845,7 @@ static void __init init_unavailable_range(unsigned long spfn, >>> unsigned long pfn; >>> u64 pgcnt = 0; >>> - for (pfn = spfn; pfn < epfn; pfn++) { >>> - if (!pfn_valid(pageblock_start_pfn(pfn))) { >>> - pfn = pageblock_end_pfn(pfn) - 1; >>> - continue; >>> - } >> >> So, if the first pfn in a pageblock is not valid, we skip the whole pageblock ... >> >>> + for_each_valid_pfn(pfn, spfn, epfn) { >>> __init_single_page(pfn_to_page(pfn), pfn, zone, node); >>> __SetPageReserved(pfn_to_page(pfn)); >>> pgcnt++; >> >> but here, we would process further pfns inside such a pageblock? >> > > Is it not the case that either *all*, or *none*, of the PFNs within a given pageblock will be valid? Hmm, good point. I was thinking about sub-sections, but all early sections are fully valid. (Also, at least on x86, the subsection size should match the pageblock size; might not be the case on other architectures, like arm64 with 64K base pages ...) > > I assumed that was *why* it had that skip, as an attempt at the kind of optimisation that for_each_valid_pfn() now gives us? But it's interesting in this code that we didn't optimize for "if the first pfn is valid, all the remaining ones are valid". We would still check each PFN. In any case, trying to figure out why Lorenzo ran into an issue ... if it's nit because of the pageblock, maybe something in for_each_valid_pfn with sparsemem is still shaky. -- Cheers, David / dhildenb