From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6473C433EF for ; Fri, 22 Jul 2022 14:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D5AA6B0075; Fri, 22 Jul 2022 10:00:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 585E76B0078; Fri, 22 Jul 2022 10:00:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 426F78E0001; Fri, 22 Jul 2022 10:00:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 336F66B0075 for ; Fri, 22 Jul 2022 10:00:29 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ECD0FA0C81 for ; Fri, 22 Jul 2022 14:00:28 +0000 (UTC) X-FDA: 79714895736.12.20E4047 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 387201C00B4 for ; Fri, 22 Jul 2022 14:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658498426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EYLb6RY2ueWnVYybTZA3yk/81e2BTNzZgl+I9HRbCgI=; b=F10RZK34KlPjrsJ6UBFjLZwREGf5IqLw6Bg2M/h8Rh6zh7MuqeHXnWQvd4nloqKnvCXrHt k3tZr7M87OmZufy/MalIm/v9AeGY6wKg1p8qtJN1FoXlgyW7YegF9sMVbQp9GjVa9+vEag H8w80EUzY5/1FVjZbEfUCEbvugMBJXo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-362-mcxfl-tfNNWDs8NlsqANcA-1; Fri, 22 Jul 2022 10:00:25 -0400 X-MC-Unique: mcxfl-tfNNWDs8NlsqANcA-1 Received: by mail-wm1-f70.google.com with SMTP id n19-20020a05600c3b9300b003a314062cf4so3895338wms.0 for ; Fri, 22 Jul 2022 07:00:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=EYLb6RY2ueWnVYybTZA3yk/81e2BTNzZgl+I9HRbCgI=; b=HSn55stFZbLcJdyBTG46RxkVs/W4FUc7Da0SIHRl7LJBcHA+KC9PyHDsd0Gp7D0f/j Fzmy4S5L/VGAPb93axJU3S+dI0m0DMrduOrakthtLinpW4LrmZA9DCZi4rWsp2+1iJo9 uReyUwUMxobHQINLmWJGhm1f03sPCdJwF9uF4AdwF6/31qVMCGsd9rnSqIqczhv84Vzf XKc2sei2BkqY1AiObdB/EfY3A8pEMMcY9IWX3qY/bnAZ+P/yg7imW8iIcML+1S7Hg47Y 9dQz+LIH6Mzr9xpfC5BLmd13IiGcsKTAaEmEndZHPW8Fjgkqhs/6wQMDSu3aH6nYV9lX D+7g== X-Gm-Message-State: AJIora+4H2xymU7IwKEUP7RZSyFf1Y5CnNV5O3NEl9fDmQWoNPLDKWoH kIe2necUoKJD96OMjYzkavSonyxQ7TtMxnjHO3PRIpyvJx/s9SBAAQ7OCIEs2Xf0bfuFwmseXCg U+mFQvMf5G74= X-Received: by 2002:a05:600c:1f0a:b0:3a3:15a8:a8e1 with SMTP id bd10-20020a05600c1f0a00b003a315a8a8e1mr595211wmb.167.1658498424198; Fri, 22 Jul 2022 07:00:24 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s8ZOURDBaUw+YZ7e4WCDD2+8cifIOmHl8p0TJdZ6Na8HH6aIEI8WrytCsO1vPoqo/9EqL/og== X-Received: by 2002:a05:600c:1f0a:b0:3a3:15a8:a8e1 with SMTP id bd10-20020a05600c1f0a00b003a315a8a8e1mr595180wmb.167.1658498423796; Fri, 22 Jul 2022 07:00:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:cb00:cd6b:7964:cc7d:b0e6? (p200300cbc707cb00cd6b7964cc7db0e6.dip0.t-ipconnect.de. [2003:cb:c707:cb00:cd6b:7964:cc7d:b0e6]) by smtp.gmail.com with ESMTPSA id l10-20020a7bc34a000000b003a30f84a9aasm5040435wmj.26.2022.07.22.07.00.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 07:00:23 -0700 (PDT) Message-ID: <8fd4d9fa-7370-3d97-20d0-a4dfed914600@redhat.com> Date: Fri, 22 Jul 2022 16:00:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/3] selftests: soft-dirty: Add test for mprotect To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Nadav Amit , Andrew Morton , Andrea Arcangeli References: <20220721183338.27871-1-peterx@redhat.com> <20220721183338.27871-3-peterx@redhat.com> <8fbbd68f-267c-1e0d-a578-7da4551c4c19@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658498427; a=rsa-sha256; cv=none; b=XOnY7BzVxRiTyGkY81xX97UmfmeVkZfCdXrfOfa6Ek5oYy2seR860Ie8dT3P/SgRW69nQJ I11noR7CjjvQaqoboDMppvn9gMCU0WEsFSMHcTGZldfi6eAKySmpeeLdFicKGpdD6x2L+Q 7FFWzvu/IIf/Z06aoqjP96+c2Yqlp60= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F10RZK34; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658498427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EYLb6RY2ueWnVYybTZA3yk/81e2BTNzZgl+I9HRbCgI=; b=eywVZ0wDw2NBvYSa1XCNBPjoIB0N70XKEpp+LMcDABnS8Z9+Kmy2trY4h7dwOy0UCetlUF yd9SiMk8dWpPevB0t5mEt+vudBNTiSbfxKmdE9b4XQQE4ppmdOxsldzI1C+PcXCfMduKkE jvi+67r0Ak/Zl1zixCT8y6Ij5Dvbvio= X-Rspamd-Queue-Id: 387201C00B4 Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=F10RZK34; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf21.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: fbrdb87ow6smn7p47bo38ycdkwf8eb7o X-HE-Tag: 1658498427-616769 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.07.22 15:44, Peter Xu wrote: > On Fri, Jul 22, 2022 at 09:17:34AM +0200, David Hildenbrand wrote: >> On 21.07.22 20:33, Peter Xu wrote: >>> Add two soft-diryt test cases for mprotect() on both anon or file. >> >> s/soft-diryt/soft-dirty/ > > Fixed. > >> >>> >>> Signed-off-by: Peter Xu >>> --- >>> tools/testing/selftests/vm/soft-dirty.c | 69 ++++++++++++++++++++++++- >>> 1 file changed, 68 insertions(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/vm/soft-dirty.c b/tools/testing/selftests/vm/soft-dirty.c >>> index 08ab62a4a9d0..7d93906aa43f 100644 >>> --- a/tools/testing/selftests/vm/soft-dirty.c >>> +++ b/tools/testing/selftests/vm/soft-dirty.c >>> @@ -121,13 +121,78 @@ static void test_hugepage(int pagemap_fd, int pagesize) >>> free(map); >>> } >>> >>> +static void test_mprotect(int pagemap_fd, int pagesize, bool anon) >>> +{ >>> + const char *type[] = {"file", "anon"}; >>> + const char *fname = "./soft-dirty-test-file"; >>> + int test_fd; >>> + char *map; >> >> Instead of fname, unlink, open, close, unlink you can use a tmpfile >> >> FILE *file; >> >> file = tmpfile(); >> if (!file) { >> ksft_test_result_fail("tmpfile() failed\n"); >> return; >> } >> test_fd = fileno(file); > > Note that tmpfile() should by default fetch from /tmp which is very > possibly a tmpfs afaict. It's tricky in this special test case since I > don't think tmpfs can trigger this bug (shmem doesn't define page_mkwrite). > I don't think we need that? SOFTDIRTY tracking enabled should be sufficient, or what am I missing? -- Thanks, David / dhildenb