From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 738ADCCA47C for ; Tue, 7 Jun 2022 14:32:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D80FC6B0072; Tue, 7 Jun 2022 10:32:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2F936B0074; Tue, 7 Jun 2022 10:32:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1F576B0075; Tue, 7 Jun 2022 10:32:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B2F1B6B0072 for ; Tue, 7 Jun 2022 10:32:32 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 87E0760E9E for ; Tue, 7 Jun 2022 14:32:32 +0000 (UTC) X-FDA: 79551680544.06.0DCE568 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf01.hostedemail.com (Postfix) with ESMTP id 7EF774000D for ; Tue, 7 Jun 2022 14:32:21 +0000 (UTC) Received: by mail-pj1-f46.google.com with SMTP id a10so15792282pju.3 for ; Tue, 07 Jun 2022 07:32:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=VPOLce4T8uKTl8bDuvP4aIArWmHTCA4t119LiXZasqg=; b=BdkETQXDehKm3RcVOVc9IQ+5+eLDKcr/JN6J0vfmovydms+JFO5qQflU50SLT2xkjL CGp03OfGGatm2GSbk90GTyq4BHJi3G9gZJFLU+L2misnEd2asnYJ+67b7RUAAhXziIqR FHN09RKAdBe/DQ/fup4DHjPtQTdxgrbRDNf065bei0nE414/z1Oh4ThLAKz0hMUHhMuy x9cn0jeuE18MYnd4KogDFU3Q+zDpnoCSn0C308ksuyAOyhxrinC0f+7bDJKqCtCMqjaZ QmQZQOsMz6ky+yVMTgILZSpT9lOiptwPU4tj5plX7Rh4C5+Qbi/bxLvPM8mdmgAYHEJC yVnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=VPOLce4T8uKTl8bDuvP4aIArWmHTCA4t119LiXZasqg=; b=1p5LbDK1LeC+XdOO1HPOxl35hupTZkoEZmUut5izT6zvA8rnMvBBYO/UuOiSpd1kz8 XZ66Sg1FD20/7qn1TMZ8el86cG4N9GIC6AzA+fTHgbnJaoSu9bfavOwtd7ZqQC+Wx8m4 F4G2aH+crIUN7f24f+4xhvqnRe2nEu4T6P7pot3LfrXN4zbICJP43gEZZbFYnVZgktYt YaISkYcSrEWjiLCMgKEprcr/JVA1QfFDfY7QrqLu6cd0Egcci/3mS5booEuN1Dt/4jmK pwCT6rQSG/1EAy+zHiy68TrdQcku3xXQejMNbDPvOEC9goasoC4KfuysdvAVNW/6smyK Lrpg== X-Gm-Message-State: AOAM532vgmzfRCSfmnYGMCWjmg5D1JBC6vP2AwUoszgkJgjRNb8Phrws cTfKY9AWr17zeR6nEMWKUbePlpgVSjPYcA== X-Google-Smtp-Source: ABdhPJyv9HnBgv55K19xenISwxECGP7eD7YX/uyVGu+CijT7ncOI+nSmLo2B8LGbyhrDTSeymhVBCQ== X-Received: by 2002:a17:903:1c5:b0:167:71bd:462f with SMTP id e5-20020a17090301c500b0016771bd462fmr13880919plh.65.1654612350883; Tue, 07 Jun 2022 07:32:30 -0700 (PDT) Received: from [192.168.1.104] ([101.86.206.159]) by smtp.gmail.com with ESMTPSA id jb15-20020a170903258f00b001688f2ff292sm243875plb.222.2022.06.07.07.32.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jun 2022 07:32:30 -0700 (PDT) Message-ID: <8fc24ba3-1467-b845-a70e-7ed77750e6cd@gmail.com> Date: Tue, 7 Jun 2022 22:32:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/4] mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical address Content-Language: en-US To: Catalin Marinas Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com References: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> <20220603035415.1243913-2-patrick.wang.shcn@gmail.com> From: Patrick Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BdkETQXD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of patrick.wang.shcn@gmail.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=patrick.wang.shcn@gmail.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 7EF774000D X-Stat-Signature: cirm3p6da78wyupjxn53efgt3inxmygr X-HE-Tag: 1654612341-53854 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/6/6 19:55, Catalin Marinas wrote: > On Fri, Jun 03, 2022 at 11:54:12AM +0800, Patrick Wang wrote: >> diff --git a/mm/kmemleak.c b/mm/kmemleak.c >> index a182f5ddaf68..1e9e0aa93ae5 100644 >> --- a/mm/kmemleak.c >> +++ b/mm/kmemleak.c >> @@ -172,6 +172,8 @@ struct kmemleak_object { >> #define OBJECT_NO_SCAN (1 << 2) >> /* flag set to fully scan the object when scan_area allocation failed */ >> #define OBJECT_FULL_SCAN (1 << 3) >> +/* flag set for object allocated with physical address */ >> +#define OBJECT_PHYS (1 << 4) >> >> #define HEX_PREFIX " " >> /* number of bytes to print per line; must be 16 or 32 */ >> @@ -575,7 +577,8 @@ static int __save_stack_trace(unsigned long *trace) >> * memory block and add it to the object_list and object_tree_root. >> */ >> static struct kmemleak_object *create_object(unsigned long ptr, size_t size, >> - int min_count, gfp_t gfp) >> + int min_count, gfp_t gfp, >> + bool is_phys) > > The patch looks fine but I wonder whether we should have different > functions for is_phys true/false, we may end up fewer changes overall > since most places simply pass is_phys == false: This should be better. Will do. > > static struct kmemleak_object *__create_object(unsigned long ptr, size_t size, > int min_count, gfp_t gfp, > bool is_phys); > > static struct kmemleak_object *create_object(unsigned long ptr, size_t size, > int min_count, gfp_t gfp) > { > return __create_object(ptr, size, min_count, gfp, false); > } > > static struct kmemleak_object *create_object_phys(unsigned long ptr, size_t size, > int min_count, gfp_t gfp) > { > return __create_object(ptr, size, min_count, gfp, true); > } > > Same for the other patches that change a few more functions. Since the physical objects are only used as gray objects. Changes on irrelevant places will be removed. The leak check could be taken on physical objects. Conversion of block address from virtual to physical before lookup should make this work (this is useless currently). I think we'd better know about this. Thanks, Patrick