From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92884CD13CF for ; Mon, 2 Sep 2024 14:42:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 27F2C8D00E6; Mon, 2 Sep 2024 10:42:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 208398D0065; Mon, 2 Sep 2024 10:42:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 033368D00E6; Mon, 2 Sep 2024 10:42:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D9A2A8D0065 for ; Mon, 2 Sep 2024 10:42:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 974601C5956 for ; Mon, 2 Sep 2024 14:42:32 +0000 (UTC) X-FDA: 82520064144.25.E905FC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 4BC17160014 for ; Mon, 2 Sep 2024 14:42:29 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iRt1wHGm; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725288055; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2MFYfuHNL3RyOhKmQdM5Y+z9WH6X5FHEktceTsR2UCc=; b=wUHt2pvlsOiJ4DnA4kZGn7LGFWjFF6LamDQIYESbK9O1fZ9UbK0NYujQBeyWhGiTqIHpat Nle9ag44DnCVL41Qeq9JNMvt+2fbRL/+j/BvuRGIMtW6SXNcdsJqNFc6J9Uiilz/rTl58u corPDaZyTnpV7lYXMXOuEA04TkgsUyE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725288055; a=rsa-sha256; cv=none; b=nQ0mLG5TvEHdUfglSeqDr26KvS1MEuzzzV3bBkw6Gj2AQWp5DOfM+mnitOpKmY0BmnP1RU U3WtP13dmv0of4/AVoICIm4sKKRZUMvGTz4UPDzGNj49nQN0lIxrkE/Nmizr5Frm8MxRfJ n4+oeTHsOX/Et+v8hkyPrEfV33YVWfw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iRt1wHGm; spf=pass (imf08.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725288148; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=2MFYfuHNL3RyOhKmQdM5Y+z9WH6X5FHEktceTsR2UCc=; b=iRt1wHGmUI0GmHzlSBU/w0db1GaWszgYbg87LLVgsiDixLGJozH7kYXuvdbsQdIjFxVmvl 03OOl9S5dRLicr2OEF//gtFAmv7Ur0pwSF5ySzPEERxbSDeMXSzimyBXqJ1FYxTzMOK5cC Ngavm5eeanHP4klDoaczYlxUdoeNyYM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-5kSiLDUsOqCdohMyWmtFZg-1; Mon, 02 Sep 2024 10:42:26 -0400 X-MC-Unique: 5kSiLDUsOqCdohMyWmtFZg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42bb6f7e7adso40443655e9.0 for ; Mon, 02 Sep 2024 07:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725288145; x=1725892945; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=2MFYfuHNL3RyOhKmQdM5Y+z9WH6X5FHEktceTsR2UCc=; b=LSWpguXXBsxtSZ9AlNK5S/ReytnitDCrA58wb8ZhGIyLLRCWoguGGBPQQAMYYvw/vU OvNBPExnf0ph/OTrVWC1jkHOEUzuaAFTBdbZ9LA2NK71SFcKtPrPTzDBkHbMe/vpjJbD OqZM7Nc1J9sfx6Q62VfzAFamGsUGyS3HKktgcVqj6tDT62NBFfT3nwXNDiQ6laXp/fpf zt4xejQOfCIIyUrbHR69nlt11fxDRKLwdfwCgT9Esi25VV9A0RmyGY7Y27MwqhVLa/zY WneIhJaOcFCX8JvDUrpZyquVPec/0ItcEI02d/UL+qcX6OS6t64ylqEkf8oY7NzpL1z2 1mww== X-Forwarded-Encrypted: i=1; AJvYcCUOJB0DtJG+gIFtVSB94oDn2tLfta9OTFWYplQZjN8yLrCCMcK9PVYVVk0cuA98k74wtltbXQBj/A==@kvack.org X-Gm-Message-State: AOJu0YxQE/N8yWH5tfYhLGKaQZ9Ah+CbOwa8wAIBNU1KFa3KXlLnUsWe QnF38IwqAhE731Kt3n6JFXA672woEBwxbRZROXB5xB6Pk3GqDAZQsSc9Q+ibdsZNxQkuG4cU6Gk uqA4FWRGgAd0/4bcptJ3PX0fc13HypJ9UT/guuoGoqHxD2SmPprVLtK23ifM= X-Received: by 2002:a05:600c:1d98:b0:42b:a9bb:924a with SMTP id 5b1f17b1804b1-42c7b5d902cmr43481975e9.23.1725288145365; Mon, 02 Sep 2024 07:42:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGcdksUugss8NQ3p2NoFd69SVnFW2DOpdbvsLEwvqYT0MzW+uMFtVXyRqwyU2COwN3zbYBjvA== X-Received: by 2002:a05:600c:1d98:b0:42b:a9bb:924a with SMTP id 5b1f17b1804b1-42c7b5d902cmr43481655e9.23.1725288144487; Mon, 02 Sep 2024 07:42:24 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42bb6df92f1sm141005245e9.25.2024.09.02.07.42.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Sep 2024 07:42:23 -0700 (PDT) Message-ID: <8f9f16e9-4d89-44ba-a244-9389233b5325@redhat.com> Date: Mon, 2 Sep 2024 16:42:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/4] mm/page_isolation: remove migratetype from move_freepages_block_isolate() To: Zi Yan , linux-mm@kvack.org Cc: Oscar Salvador , Vlastimil Babka , Johannes Weiner , Baolin Wang , "Kirill A. Shutemov" , Mel Gorman , linux-kernel@vger.kernel.org References: <20240828202240.2809740-1-ziy@nvidia.com> <20240828202240.2809740-3-ziy@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240828202240.2809740-3-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: stsq1pcpcd7x5udeokbxquq1xy6xuhmg X-Rspamd-Queue-Id: 4BC17160014 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725288149-792786 X-HE-Meta: U2FsdGVkX1/p2Saej5zUeBZEPtmaFAwozntxhdrRciTWRYU9H7FOQhxWLTnZMT1LvzMjxgWnu+MHA7bkEwvbXo9GSRNLHFFFGOLWo+D3VRu3ncoHrWoxyHmNNSXn+V32hlI/weiV8c7UkQHs8QWyjRZc/zbuXC1YK/4aM7DbdEKxgkqc/TIx8ROnJJMzTzaJWHY5hrYNzuGbkA9HAEL9tQ37xp9QemqeBGyOdC+eZill2NQZ0ujl7kW3ulVpgs52Kl+3J8aE4JrCwbtWPfJVbW0QmKbMDnDkBhLbMdHuTZWhxvwFmonVFeqBU1IJsjEkZ1UvN6HpakzvLP4Jf2EnQlf/xeYPshEMD/575Gxx6uUD1U2+kij3z/6m+m6DxsTrv+wtLU70dUAogYffau4kdwkKVQ5Z3h5IIIWbOiQiysZ8dBxOcv1sVidmx3KYXQEpnvb4oZRgLeBLl1bgeX5ylIf6pcIEAe5BnhqjtaCEeaG+UN0g6TJ+mIMCydGzQPFAHGVJes/i8wXXG/O0K6Cd7Yo878pk3szHo3TgmTH7gY4eGzyekKN/CNr5DiBtZ4oZQH2RMjYsDDyWPj9Df9azooyyIxDpUzzKD+WfzFjuBwjjoOTl/GbTBEG4DL5CEa1RvF5caMuKWvpoA/9oN9yUqsaZz69Nocbyrb2fEAYRpfyDOxvFAMhqpMJtD6bWvwG64p1LXKr8zzjW91yrZg2zY21TkXSBdGAKQrfx4Y7QXcowfi2reDnqcCbNVMMtiZEE0y/nE0D1Nnks8XlppY7uJ0XS3UqWNMN5opwBYz4E/rN+QpT7cj4pVBnOcGlwU6BSMLxWEMrqjtfWSPXcOd2o26OLk2Xli3vJGLj0LOe1QLzmyN7lgmVflXouIJL6UFwuf923OxlgGDy54yxr0UkXbEA2pJS1wQAjUvrUJJU8bcl353UTbkFX4iRvOmbbCYt2Pr1Lwn6QjT1fwpYmPzC Ab8ZYloA L2F+oWTQOcj1Sp3H3wW1md9dcan6+f15QlowDkPS3LChhirLk6zf4M9wlYAt3GGvqVxTcqRs2DMtlJQil3a3xAobEICh5OIrQZdE6wJOmdwALKUW5BtEuyZMZolvwIoXxVFGEjwIRZ3+h7ncYhO9PZDe0tOS8uCT6bULzeqxs0+2AlliTioH+ZUZ3R6018uGZhDGpYPMwOu0lSnVsnSt23dhdik3DVHdVmWkezY52cMVBhZHS99eOsquku9g2ZRdsWBXxxcLYeTAPGOWP+fI6l6npmVXzL12Ae9/1VFydX4to5kfOgYwKSXxY5MfvrxRR0X9Jrc6dtbPk8U9UlkHeBYrGlFyA3m8ojNEB6TsWdR7A94/AabxFcxUHpRxndHrhZ99pueJMYuNGodccbzzAy7ZWBl4uWSzl0c8rKSLlSAYuHRXx2N6dIHJf+4HBMCwSaUEDnoBDo1NnZXTMLwg3v0WIQj7dTyuaLa9V0V1xYIUWgiTibEGlCO9ZAz82ySrbM13kqF+3MVfwek0wZ5foIuftJPDuzil8eP+XJWPSV9R/qMKfF8vSdP3dPSYYWi+wp5Hz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.08.24 22:22, Zi Yan wrote: > Since migratetype is no longer overwritten during pageblock isolation, > moving pageblocks to and from MIGRATE_ISOLATE do not need migratetype. > > Signed-off-by: Zi Yan > --- > include/linux/page-isolation.h | 3 +-- > mm/page_alloc.c | 27 +++++++++++++++++++++------ > mm/page_isolation.c | 19 +++++++++---------- > 3 files changed, 31 insertions(+), 18 deletions(-) > > diff --git a/include/linux/page-isolation.h b/include/linux/page-isolation.h > index 11b8695115ea..6a62401410c3 100644 > --- a/include/linux/page-isolation.h > +++ b/include/linux/page-isolation.h > @@ -35,8 +35,7 @@ static inline bool is_migrate_isolate(int migratetype) > > void set_pageblock_migratetype(struct page *page, int migratetype); > > -bool move_freepages_block_isolate(struct zone *zone, struct page *page, > - int migratetype); > +bool move_freepages_block_isolate(struct zone *zone, struct page *page); > > int start_isolate_page_range(unsigned long start_pfn, unsigned long end_pfn, > int migratetype, int flags, gfp_t gfp_flags); > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 4ea5cd1a07e2..dc7c36461953 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1764,10 +1764,12 @@ static unsigned long find_large_buddy(unsigned long start_pfn) > * > * Returns %true if pages could be moved, %false otherwise. > */ > -bool move_freepages_block_isolate(struct zone *zone, struct page *page, > - int migratetype) > +bool move_freepages_block_isolate(struct zone *zone, struct page *page) > { > unsigned long start_pfn, pfn; > + bool is_block_isolated = get_pageblock_isolate(page); > + int from_mt; I think we should have two functions, one that isolates, another one that un-isolates. Or at least make the semantics not depend on the current state of the pageblock. bool pageblock_set_isolated_and_move_free_pages(struct zone *zone, struct page *page, bool isolated); vs. pageblock_isolate_and_move_free_pages() pageblock_unisolate_and_move_free_pages() -- Cheers, David / dhildenb