From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E8E9EB64DC for ; Mon, 26 Jun 2023 01:40:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A27218D0002; Sun, 25 Jun 2023 21:40:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D6D98D0001; Sun, 25 Jun 2023 21:40:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EC718D0002; Sun, 25 Jun 2023 21:40:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8098F8D0001 for ; Sun, 25 Jun 2023 21:40:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 171ED1A032D for ; Mon, 26 Jun 2023 01:40:58 +0000 (UTC) X-FDA: 80943195396.19.4F84D66 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf30.hostedemail.com (Postfix) with ESMTP id 998F480009 for ; Mon, 26 Jun 2023 01:40:53 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687743654; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XC8IUMY5QAXsQWsV1ypx/MZL/PwrIsU72QdRYjgON8E=; b=RHgTbEsfOrOxPTLUMrfy44I1E8Hpqkc+rpPz/C3WvVGi/lXlQa5jnl7/qk7brI+Qz+/Ml1 Xz1SqdqNlOmRLGBWsI+MCYGgKyFvNB2hDLClQQATXLpDpm5J1PbgXKVqFVE8y0iFzjISx0 hbXY3rZpinhngrhEjgW5jJkQE1O8B50= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf30.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687743654; a=rsa-sha256; cv=none; b=MsZvsH8Mj9qVLxlVvRiD/kE3rn3gaiBZuihy/Wo577OMkNZPaa+wSuwMZqv85/AJS7eDJX VmSmZ8M6Tvm84qjJIZtsQFSU1wxw2OrJ2QuBxj7XafcQrf8hYAR3QG1pNC5W2JNFXgu9hU CQXVwGI5ixwr3H94PnxkNromNdpclVg= Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qq9Sy4pb4zMpZD; Mon, 26 Jun 2023 09:37:38 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 26 Jun 2023 09:40:48 +0800 Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page() To: Matthew Wilcox CC: , , , References: <20230625113430.2310385-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <8f8f7622-9bea-c344-4e54-ef902129de67@huawei.com> Date: Mon, 26 Jun 2023 09:40:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 998F480009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mbb1dkkfecu3xraw9mrf6y319ok5btrz X-HE-Tag: 1687743653-999657 X-HE-Meta: U2FsdGVkX1+zsi4OR0lTRjfxbNJeNJDJXcye/saQzKpM+XxJaOFlPCAoAgu/QbYTdQb+asOs79fvS3q9yIQwG2M6X8wXxRWm8Ka9S15/XiMyO6iRIMecr/rqS7Xew5aKKYr0PVtEY28PFBJ8wxznGCEeOdB5azzWCtTkpin+7qsvpfc81nXB+PhBRXbPWHYjDu5MieVDrkeF2+UF8xrLY0E5VxYM1qW1cUL1K6M1Ek5yThEhLYe1hHcNaXbc7WE3T7VpDa5mxkzVTAIXmnW+82KI9OJyMV9YP5vA1FrnLZfcoEdJXiPKk2ghb1l0J6/OR/Ab8MUnEfUjscAssd2GDVlNw8Oo6CuWpMSV2t/3IRh2hdmMAhE7qGrzRSJDBrsvVaw52Ddr1OVxFnjdlAaoTq8CPSnddHriAod0jy3Ye8FaxqY6sqxVypsnucqqnzckb8HqEp64k+CX6pI7r3GkviUAabYy/g4I5HdpXOoKDoPod86CIbTfN7E1C02PHVbnEZK0Wzml8mB+7XJlU3VUj54OmVioEWz5sC4jd0/jMa/dU7iXg4kDQpk8sErTeOZOmZ9gnB1GPbDG7OohOqeFP9e4YKvSnxobRKWpBvG1stJoHsuyzO5RfFAWfXNJaVXeOANuissL1eXd4SWsuj5XSTA9Tpzd9TFauQXu5WbfMxnoNyyzKnSXQUgMd89eyqYEItx6MPnORTGoFZwazSeonNdPiQ0V/rmuvIJ4FERHAyqXfU6am21ugJESqOJkqLY6RFrV7XCARog0UcitSn+QSdgeIdQq98LBiyZDJxbeU28A6KoPDn51Lcgl3/SePCSdq/GJB8jLsK4Rn45gRNcBeW6Y1CqViRy149nYfZADDfzV1jVCWprTfki2VUjxOYdnO0Vx4xzEX0svw8cJosHPZhnlXtlAJtIV/9Ut5JLNfojvGlk8SMmgpaD6QsLnUSN+B0OxYzjdn7nsmVqkSqg Sn6d6vfU 94PACkimp3LNyj2VuPynw7HvfEuzTdKwctHULcwCyoilxMDhw6GB8ETTfRnc+nPOjhH/5ia5EoDHyaW5dlRqKw1rdQkYC3lLessV5FXYoEmlxR4860R0WwGTwuOgIGq9iCquUKcafwl9RUQ56M1OsBREDT2v7TkMqbLZ/NLikMK7hGo9xZWcagqgYiw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/26 3:50, Matthew Wilcox wrote: > On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote: >> Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches >> are not shrunk now. This check can be added back when a lightweight range >> based shrinker is available. > > On further review, I think you've misunderstood the entire situation > here and no patch should be applied. Thanks for your review. I think you might misunderstood the patch. What I want to do here is remove the unneeded if block: if (PageLRU(p) || is_free_buddy_page(p)) return; Because nothing is done after the check. So this check is useless and should be removed. Thanks.