From: Miaohe Lin <linmiaohe@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <naoya.horiguchi@nec.com>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memory-failure: remove unneeded page state check in shake_page()
Date: Mon, 26 Jun 2023 09:40:48 +0800 [thread overview]
Message-ID: <8f8f7622-9bea-c344-4e54-ef902129de67@huawei.com> (raw)
In-Reply-To: <ZJiacZIkvIv1P3AK@casper.infradead.org>
On 2023/6/26 3:50, Matthew Wilcox wrote:
> On Sun, Jun 25, 2023 at 07:34:30PM +0800, Miaohe Lin wrote:
>> Remove unneeded PageLRU(p) and is_free_buddy_page(p) check as slab caches
>> are not shrunk now. This check can be added back when a lightweight range
>> based shrinker is available.
>
> On further review, I think you've misunderstood the entire situation
> here and no patch should be applied.
Thanks for your review. I think you might misunderstood the patch. What I want
to do here is remove the unneeded if block:
if (PageLRU(p) || is_free_buddy_page(p))
return;
Because nothing is done after the check. So this check is useless and should be removed.
Thanks.
next prev parent reply other threads:[~2023-06-26 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 11:34 Miaohe Lin
2023-06-25 13:32 ` Matthew Wilcox
2023-06-25 19:50 ` Matthew Wilcox
2023-06-26 1:40 ` Miaohe Lin [this message]
2023-06-26 0:52 ` Naoya Horiguchi
2023-06-26 1:43 ` Miaohe Lin
2023-06-28 0:04 ` Naoya Horiguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f8f7622-9bea-c344-4e54-ef902129de67@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox