From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A54C48297 for ; Mon, 12 Feb 2024 15:26:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B8DF6B0082; Mon, 12 Feb 2024 10:26:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 968FE6B0083; Mon, 12 Feb 2024 10:26:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80A8C6B0085; Mon, 12 Feb 2024 10:26:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6E1566B0082 for ; Mon, 12 Feb 2024 10:26:52 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 43296A1D6C for ; Mon, 12 Feb 2024 15:26:52 +0000 (UTC) X-FDA: 81783529464.01.9D9BBCF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 7516D160012 for ; Mon, 12 Feb 2024 15:26:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mll8fNJO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707751610; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ylaC1wxOtmdVELv0CHaAgYwG4Tklp3Nu9mzaIJ8MpfQ=; b=lnBREe2dnqzyylkfbNN3WKMuoE27Y/DsKUw/cpO07Vw5sBriFK7W7JIc81dvvOR24Y3ROk 99/uY5Vlx/Sk+2C/UHc5qGltIc5aByCobH4nr63XqF9bzrBP9wffEO73Ec96U9M/V1rFMU xc1jJQ0Jm1r58np1id1lG7bmWsz+TLE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mll8fNJO; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of longman@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=longman@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707751610; a=rsa-sha256; cv=none; b=QcdwjV93k3sSp0+Fi4DeYx77GUrLid4CCUyaqsUAEJTqUwntcbvOGr9MjYQN8wIISlTBQQ 3uq1rs5ODh/oGew65mU2Zyl9lUdTQfvvtwXp7lU6McUV1DPeK1/L2OrvLJOoxflPX0ZJ2e 1qJBmo+B+TA4XkKbsRD1dxks22sCBcE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707751609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ylaC1wxOtmdVELv0CHaAgYwG4Tklp3Nu9mzaIJ8MpfQ=; b=Mll8fNJOOpNGPdmh146fLEcnMp+IPp6tFssfeVWIEjSFD5HkJobB+KS7A+kkmLXGTxqDZS dZh2c4oVI449B71Zhsy2QGGylZu1DDrzYKHMHmiNgEBiIMfHwQVdibjAPzhP8OXUJr+iBf UC0v78eaxkbJqzd/h+iGcOymC5CWigw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455--AT9ag3PPyGuW6Mt9zfYVg-1; Mon, 12 Feb 2024 10:26:46 -0500 X-MC-Unique: -AT9ag3PPyGuW6Mt9zfYVg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F1E9A108BE69; Mon, 12 Feb 2024 15:26:42 +0000 (UTC) Received: from [10.22.33.62] (unknown [10.22.33.62]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F192112B5; Mon, 12 Feb 2024 15:26:42 +0000 (UTC) Message-ID: <8f8d5a2d-dde3-42e5-9988-fab042666f40@redhat.com> Date: Mon, 12 Feb 2024 10:26:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] Port hierarchical_{memory,swap}_limit cgroup1->cgroup2 Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=C3=BD?= , "Jan Kratochvil (Azul)" Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: From: Waiman Long In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Rspam-User: X-Stat-Signature: 5gfhek85pj4u71drnzbzfo68n8ccysyz X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7516D160012 X-HE-Tag: 1707751610-446625 X-HE-Meta: U2FsdGVkX18vGOakWRWwzV8TSCS/ww9hLcrxUuclHPyvev5UmJUmOm/N2hWDknBMByk1rRHvjySzETiCoRBOCGi693qOu0lz0dLAkgCxM25gh0a+dUVHIZYDqsTy39r+PpTz0ZKw+28BhwQUx6LlfpB5w+wxareXU2aYE2NDR+4KAQ8t+BzdW/irqE+WHXtmAwUTyErB8OKVl7GyZdMkgnOg6r1QWlz+7ObDFSwmH4jS9pTHKP4ZHjgXV2HE42vJecEAQef8/8ZBY5dXRTRRavX6/m6sdwYZyuaoE3hzTjh/iKTzWA4QvBeRnE0iQD4BlyLhVHwEMr+Lgkctr5kNG+oSfMva3lnS8bjcVQ3GFGWOgm6RocF5I6YwyAMpyMLtbk+ZpBd9ce50VRzEVP1wSh4F3/6N/7zWiGKUWaBRkcJss6haGOAzlcO95T1f8UYg9JMbUuz5FHMwGGrDJU0Q1QLv0xRPK7k1kdVIhdSzdIin+mYLappu97byftzBPUMLP7qOOMWmK5duyKui4XUiMHmecROUGAeeiBaBYoyNjUYoog9Ku0/qS0P79yb6sUKqkLQipVgu0scgwirMKrmbLZwrebF3B5Dr/0TaZwnEPQN/d71mbRodOpgB0pXdc6BOgmewd7SpthOjP8ztJcXrDXqesfFvQwE7LBMFRh7HxbH0zNslmCaLP4JehMldcPBzVVjnC3MwgZn1a8CXP9hyl19eG9eC0BORmfCMRba7OplVdFECCB0Fqa8P+xReLm90tPou+y834xwM/q17POAqN7mS6sF7xW5P1I3VqCFtqTsVJapZ2447omK+VJQPGiHNjrHRTCALsx8ngOGkoDmB+J/WRvP269KlIxVCgZdNTcjs4+frXUTH4cZizN8RJfkt7fnf3b/1UWwVdDLUh2a8mYqL3dQ0i00bQvMWju7ynvTfciPSpt3ZkmFj7YR8XfVJpsMhTGUPuD8jk1+wQYr 2bdCPXHR /4A5HABFp5uqlj6Xynp7/gyKRvAg92M9lNGwXhtCXUOdVFVZGzLbm0KlDfJxg5gRVspRNvZqy/WgkpKO73M4w8xvl6NcR4FOWq4gkQNlnIYP+AdMAzKsTARw5rGiHMX80IRq7A8Nju+RdsVyVlU7EhQUh5ltQIfNXU+C9UaPHxuBOBGQFkj8k1fPba9Aiip1pqNfAoqU+a5+Naar3RPoMeTF8C32U4wak7b2uL7pAaeT2FgPe5FdFcT+DnsVD+AvgGGAKk0ewHiqW7L1WMK26e5c8RKXCTzgPSw3UqxbnyZOIidv7OpUDc466LldoRXkeYd/6k6wsGEJY268= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/12/24 10:00, Michal Koutný wrote: > Hello. > > Something like this would come quite handy. > > On Mon, Feb 12, 2024 at 12:10:38PM +0800, "Jan Kratochvil (Azul)" wrote: >> which are useful for userland to easily and performance-wise find out the >> effective cgroup limits being applied. > And the only way to figure out inside cgroupns. > >> But for cgroup2 it has been missing so far, this is just a copy-paste of the >> cgroup1 code while changing s/memsw/swap/ as that is what cgroup1 vs. cgroup2 >> tracks. I have added it to the end of "memory.stat" to prevent possible >> compatibility problems with existing code parsing that file. > I was thinking of memory.max.effective (and others). > > - no need to (possibly flush) stats when reading memory.stat > - can be generalized also for pids controller (and other "limiting" controllers) > - analogous to precedent of cpuset.cpus.effective > > Whereas, using v1 approach in v2: > - memory.stat mixes true stats and limits, > - memmory.stat is hierarchical by default, no need for the prefix. > > What do you think of the separate .effective file(s)? This is certainly a good alternative. Cheers, Longman