From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FAC6C0015E for ; Thu, 27 Jul 2023 09:16:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7556C8D0002; Thu, 27 Jul 2023 05:16:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 72BCA6B0074; Thu, 27 Jul 2023 05:16:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F45E8D0002; Thu, 27 Jul 2023 05:16:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 511B76B0072 for ; Thu, 27 Jul 2023 05:16:02 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2DE92A051A for ; Thu, 27 Jul 2023 09:16:02 +0000 (UTC) X-FDA: 81056834964.16.62CEE93 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf28.hostedemail.com (Postfix) with ESMTP id 365CAC0006 for ; Thu, 27 Jul 2023 09:15:59 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="gs/PU4tG"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf28.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449360; a=rsa-sha256; cv=none; b=2p31b1mPk6W0B1NgLIDTXqKqb1wJP9kNZeNmFAFMIS8/5bEZ1Q26BIxw4H7SQK6R9sTBtv SFapFNrMNA/v0NqX34Qu15EkBLU5bP97SLhpJ/LgPWSdaLSz2aRBUfgqJZWt8RM2YzJWSL uzdR5XyKbcib8TNoEEejrlDj6Szr5Ww= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b="gs/PU4tG"; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf28.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.215.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449360; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pSf6nVkdhsvxhtXxVh7cgsa4dxLg7VE+dk8AIIS4uIA=; b=h7kXlrWOOXsiOveBgjg8ASSDC3tlZb8KWCqbt4bTtZlYsREUG4t6lKuZ2yVD3fdwpq8po3 kxhz9fBXH2d6Ohpg+9kPgoeQl4LPGuhqXzssUJEWsE+oSbSMVNDMAV3Q+p2OuWuXq6jpoO CjhBjVOd3BzsoUs5PNhqV4bo/RUmTU4= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5576ad1b7e7so73451a12.1 for ; Thu, 27 Jul 2023 02:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690449359; x=1691054159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pSf6nVkdhsvxhtXxVh7cgsa4dxLg7VE+dk8AIIS4uIA=; b=gs/PU4tG46kQg+lGivKEpQm67BWRBr/3B5K5J0ZjcDJiH4VmN/xAYLr567/KvCeKyO Sxv9KoDe1Fgjt2T5xGL5ntjIo2URj6N4iyAFFdnIg9R3abku7q3pHpjtx5uyfVGaAvYO XtiYYOqXBfNiFu1rjUbVMMYVt5QxVT4/F43UKIFaCuAs9bCstLLngxCL3ODWliEci9Sz ElL4V2hOOxLgo9+060cMLFPSS0lDlqR1ZhVgYCnGDkIpUHSxXftLLIhthhd9SgFzYboG fvp5YOTqEFeGRzV75GGLb7yIHnFGlXJ5ArnypIHw3PlhSwR6sQo5O1DaMDPfX3YeBn9C fAww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690449359; x=1691054159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pSf6nVkdhsvxhtXxVh7cgsa4dxLg7VE+dk8AIIS4uIA=; b=CcVsCNfx7sHOCjf3WRRHkiYsYcDnqB0pr5vo/Lrl9dKmeXajxqG3NmJ1dWX/zdrt3H XxgC5hemtdlZ7kUy3Cs4buF/Ot4B6k/MLwFE+wKjaBELo8jALImAeo8PVKrkfXExCvBC 8khVz0ZaA0mVefggqrzPmsK+z9T+J/lcD+GiVx1E+EjLUtxjQTzYqbmgJ89SWt23YcML bYGx23kZk3MVEIwLHsLNfGceoJwi79qo3MbygeUv9jdFKDJBAM5q5AqaxPY+yDQOI0CK loiaoiOgEfq9gOlPh5Nnp/W9bAd80VKGq2IXgxDGSmpvcw1Ra4PvcvgiFCJocR3H5YD/ Bijg== X-Gm-Message-State: ABy/qLZhDIIBwj/Y9UKjzsZ30b45zV5GVZQQjkObzEWJZR9bKKSOvcNf P9Q+0Jq1dmA/MvmCUU75gqQKwA== X-Google-Smtp-Source: APBJJlFWNasuQyGNPy0hcIGkgu46yCpujoddgwDeBo2nmYNJTDqcdO/STO03uju2nKSJGm9+FY3b7g== X-Received: by 2002:a17:90a:7c48:b0:268:38a7:842e with SMTP id e8-20020a17090a7c4800b0026838a7842emr4155117pjl.2.1690449358970; Thu, 27 Jul 2023 02:15:58 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id bv21-20020a17090af19500b0026596b8f33asm2403500pjb.40.2023.07.27.02.15.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:15:58 -0700 (PDT) Message-ID: <8f8aa0d6-8f5c-958d-096d-d4c6d3e71e7a@bytedance.com> Date: Thu, 27 Jul 2023 17:15:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 29/49] md/raid5: dynamically allocate the md-raid5 shrinker Content-Language: en-US To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-30-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230727080502.77895-30-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 365CAC0006 X-Stat-Signature: tkphnyoawpze4b4gof8s86q6rhxi5q77 X-HE-Tag: 1690449359-799366 X-HE-Meta: U2FsdGVkX1+/qmhzGWNj642WhB0XJKefpEybBVpslD7w7mysI30/SaePc2j/qj6AZ/0Wf2ohkEgXR9iCis7ZNHidTssmqsJee4HYG3N7Z/3ezqN+EHtwEL1SXA4f9Vt+fJq2Wfe0kvm4frykq2+jQEWFCEfQJREnCeQfcrX0K7UEjFosZRPE2tyeMkN9+O4LQA62xz9ptm/cQlontXnc3Tgy5TbOa8yDEeMQ4TDLSDq3fJTFDay22uxDcFgBc26X16OXrEfcIkHiXy62QvDLAET9vSW2I6SHH+aiRaooC9BCpEtf2PHKQeZqk5kSlGu2lC9DR5p1yPU2ri8x3kd8nWUUjPbJI9UAi/Z0PCN30C6epOOBrwXpKiHbXWIDjsUZx6HVsh3glDPjf4KRejsfLj+IqQ83tMYwFOzltV3RL8YNR0SQ7uuDo55LoFckZR26n6ZZklyMNayJThE2hN0xcBqhWy+fVn6scJ04JP0b6H+pNPzYqgW8QzrhngljzMI7F6kszU0WLvMr1AOZDBuJHkmcmtRd4+Ycu/UrDRqNMPgcKhJvo7zeoAQkiqNrCJuS6FTczz3bffVyFSbixRMTvKkZ5MQvtTH4pRxFfCiNeyVcGTKD5iTx/lF66+YghDXh3RK8+EXgpS47PzakusNnKp8siuf7V+Z3qoukZosK6kONkasnwugSjbqHeipXQClNBgRdE+SB4QK9wWIFSjlAeuaRVC9vUMCv3kiqtLZJvWh3KgIGhpDASOvB7MXaSIVRbJ/S0UhY+vPlE36jQ2FxWt6Md6cOtvg7Lf1qQfMHS5+sFsJySiB+dSCbd7RAVqPyWOw8BumWUvx5kcitwCJmq46y4clmRYswPCX/NfOFR+GKFnFcKlmtrCrDQHtJDy/Hgj1tFuZsZ+johCsXAxAtUHqXhcKIZTmaZo6hMoXCWG3PWUi9F/agG3Gdvk5OWD0lSSI93JpvSmvWf6kpV0M EQS5IuGH 4DXOhC+AkUpjI+GgRfWWpxYSNIC/w/JR/hKlY9NVTHDZBQSfdu3K7OBoetjrlwyrFc71XSCrUm8qVSdFthN6VEx3yxK4XSeuEJFGJjf3stMAUH8cGoO5SLSa5F6ccct33egadzfqwqCCXHQClowo6LsDR/XQ9qoQRzDMIWLV9oN+aFfpZzfpIu+2CgucybAuyIi/VAaJvzrLzn7XT6BiQyK++ALnKotm7y6tPs2xyTQAcbAdSz8j0vxsL2xhuxAy7+CPpTrMnOP4JstjiB+yJYo9ndveIPtI1MewVIOsPRgOxjAPutzozhy3nvULPynv7Yfjgjc922XeMEN204JP0VfiWpfj+PuIg8PJ1KDf0ot7bDJMZ8ui6hQrSdAPMF/cx/ENQS4Qpz9CtD94vFy7wnBQ9irmb+s5NSWLyAzge9YK5GHI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 16:04, Qi Zheng wrote: > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the md-raid5 shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section when releasing the struct r5conf. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > drivers/md/raid5.c | 25 ++++++++++++++----------- > drivers/md/raid5.h | 2 +- > 2 files changed, 15 insertions(+), 12 deletions(-) > > diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c > index 85b3004594e0..fbb4e6f5ff43 100644 > --- a/drivers/md/raid5.c > +++ b/drivers/md/raid5.c > @@ -7414,7 +7414,7 @@ static void free_conf(struct r5conf *conf) > > log_exit(conf); > > - unregister_shrinker(&conf->shrinker); > + shrinker_free(conf->shrinker); > free_thread_groups(conf); > shrink_stripes(conf); > raid5_free_percpu(conf); > @@ -7462,7 +7462,7 @@ static int raid5_alloc_percpu(struct r5conf *conf) > static unsigned long raid5_cache_scan(struct shrinker *shrink, > struct shrink_control *sc) > { > - struct r5conf *conf = container_of(shrink, struct r5conf, shrinker); > + struct r5conf *conf = shrink->private_data; > unsigned long ret = SHRINK_STOP; > > if (mutex_trylock(&conf->cache_size_mutex)) { > @@ -7483,7 +7483,7 @@ static unsigned long raid5_cache_scan(struct shrinker *shrink, > static unsigned long raid5_cache_count(struct shrinker *shrink, > struct shrink_control *sc) > { > - struct r5conf *conf = container_of(shrink, struct r5conf, shrinker); > + struct r5conf *conf = shrink->private_data; > > if (conf->max_nr_stripes < conf->min_nr_stripes) > /* unlikely, but not impossible */ > @@ -7718,18 +7718,21 @@ static struct r5conf *setup_conf(struct mddev *mddev) > * it reduces the queue depth and so can hurt throughput. > * So set it rather large, scaled by number of devices. > */ > - conf->shrinker.seeks = DEFAULT_SEEKS * conf->raid_disks * 4; > - conf->shrinker.scan_objects = raid5_cache_scan; > - conf->shrinker.count_objects = raid5_cache_count; > - conf->shrinker.batch = 128; > - conf->shrinker.flags = 0; > - ret = register_shrinker(&conf->shrinker, "md-raid5:%s", mdname(mddev)); > - if (ret) { > - pr_warn("md/raid:%s: couldn't register shrinker.\n", > + conf->shrinker = shrinker_alloc(0, "md-raid5:%s", mdname(mddev)); > + if (!conf->shrinker) { Here should set ret to -ENOMEM, will fix. > + pr_warn("md/raid:%s: couldn't allocate shrinker.\n", > mdname(mddev)); > goto abort; > } > > + conf->shrinker->seeks = DEFAULT_SEEKS * conf->raid_disks * 4; > + conf->shrinker->scan_objects = raid5_cache_scan; > + conf->shrinker->count_objects = raid5_cache_count; > + conf->shrinker->batch = 128; > + conf->shrinker->private_data = conf; > + > + shrinker_register(conf->shrinker); > + > sprintf(pers_name, "raid%d", mddev->new_level); > rcu_assign_pointer(conf->thread, > md_register_thread(raid5d, mddev, pers_name)); > diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h > index 97a795979a35..22bea20eccbd 100644 > --- a/drivers/md/raid5.h > +++ b/drivers/md/raid5.h > @@ -670,7 +670,7 @@ struct r5conf { > wait_queue_head_t wait_for_stripe; > wait_queue_head_t wait_for_overlap; > unsigned long cache_state; > - struct shrinker shrinker; > + struct shrinker *shrinker; > int pool_size; /* number of disks in stripeheads in pool */ > spinlock_t device_lock; > struct disk_info *disks;